[FIX] web: NO SQUASH, position and scrolling issue

[FIX] html_editor (position and scrolling issue)

DO NOT SQUASH: very specific fix for overlay_buttons_plugin move on scroll

Author: abd-msyukyu-odoo

addons/html_editor/static/src/core/overlay_plugin.js

@@ -2,7 +2,7 @@ import { markRaw, EventBus } from "@odoo/owl";
 import { Plugin } from "../plugin";
 import { EditorOverlay } from "./overlay";
 import { throttleForAnimation } from "@web/core/utils/timing";
-import { findUpTo } from "@html_editor/utils/dom_traversal";
+import { closestScrollableY } from "@web/core/utils/scrolling";
 
 /**
  * @typedef { Object } OverlayShared
@@ -56,14 +56,7 @@ export class OverlayPlugin extends Plugin {
     }
 
     getScrollContainer() {
-        const isScrollable = (element) =>
-            element.scrollHeight > element.clientHeight &&
-            ["auto", "scroll"].includes(getComputedStyle(element).overflowY);
-
-        return (
-            findUpTo(this.iframe || this.editable, null, isScrollable) ||
-            this.topDocument.documentElement
-        );
+        return closestScrollableY(this.iframe || this.editable) || this.topDocument.documentElement;
     }
 }
 

addons/web/static/src/core/position/position_hook.js

@@ -97,10 +97,15 @@ export function usePosition(refName, getTarget, options = {}) {
             const targetDocument = getTarget()?.ownerDocument;
             targetDocument?.addEventListener("scroll", scrollListener, { capture: true });
             targetDocument?.addEventListener("load", throttledUpdate, { capture: true });
+            const containerDocument = options.container?.()?.ownerDocument;
+            containerDocument?.addEventListener("scroll", scrollListener, { capture: true });
+            containerDocument?.addEventListener("load", throttledUpdate, { capture: true });
             window.addEventListener("resize", throttledUpdate);
             return () => {
                 targetDocument?.removeEventListener("scroll", scrollListener, { capture: true });
                 targetDocument?.removeEventListener("load", throttledUpdate, { capture: true });
+                containerDocument?.removeEventListener("scroll", scrollListener, { capture: true });
+                containerDocument?.removeEventListener("load", throttledUpdate, { capture: true });
                 window.removeEventListener("resize", throttledUpdate);
             };
         }