[IMP] estate: model constraints

Author: lkerroum

estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare
 
 
 class Property(models.Model):
@@ -41,6 +42,7 @@ class Property(models.Model):
     offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offers")
     best_price = fields.Float(compute="_compute_best_price")
 
+    # Functions
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
         for record in self:
@@ -76,3 +78,13 @@ def action_cancel_property(self):
                 raise UserError("Sold properties cannot be cancelled.")
             record.state = 'cancelled'
         return True
+
+    # Constraints
+    _check_expected_price = models.Constraint('CHECK (expected_price > 0)', "A property expected price must be strictly positive")
+    _check_selling_price = models.Constraint('CHECK (selling_price >= 0)', "A property selling price must be positive")
+
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price_percentage(self):
+        for record in self:
+            if record.state == 'offer accepted' and float_compare(record.selling_price, 0.9*record.expected_price, precision_digits=9) == -1:
+                raise ValidationError("The selling price cannot be lower than 90% of the expected price")

estate/models/estate_property_offer.py

@@ -16,6 +16,7 @@ class PropertyOffer(models.Model):
     validity = fields.Integer(string="Validity (days)", default=7)
     date_deadline = fields.Date(string="Deadline", compute="_compute_date_deadline", inverse="_inverse_date_deadline")
 
+    # Functions
     @api.depends('create_date', 'validity')
     def _compute_date_deadline(self):
         for record in self:
@@ -34,13 +35,14 @@ def action_accept(self):
                 raise UserError("An offer has already been accepted for this property!")
             record.status = 'accepted'
             record.property_id.state = 'offer accepted'
-            self.property_id.buyer_id = self.partner_id
-            self.property_id.selling_price = self.price
+            record.property_id.buyer_id = self.partner_id
+            record.property_id.selling_price = self.price
         return True
 
     def action_refuse(self):
         for record in self:
             record.status = 'refused'
-            self.property_id.buyer_id = ''
-            self.property_id.selling_price = 0
         return True
+
+    # Constraints
+    _check_offer_price = models.Constraint('CHECK (price > 0)', "An offer price must be strictly positive")

estate/models/estate_property_tag.py

@@ -6,3 +6,6 @@ class PropertyTag(models.Model):
     _description = "Real Estate Property Tag"
 
     name = fields.Char(name="Name", required=True)
+
+    # Constraints
+    _check_unique_name = models.Constraint("UNIQUE(name)", "A property tag name must be unique")

estate/models/estate_property_type.py

@@ -6,3 +6,6 @@ class PropertyType(models.Model):
     _description = "Real Estate Property Type"
 
     name = fields.Char(name="Name", required=True)
+
+    # Constraints
+    _check_unique_name = models.Constraint("UNIQUE(name)", "A property type name must be unique")