[FIX] estate: replace invalid models.Constraint with _sql_constraints

The models.Constraint syntax does not exist in Odoo's ORM.
SQL constraints must be defined using the _sql_constraints class attribute.

Author: raibr

estate/models/estate_property.py

@@ -1,18 +1,27 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Real Estate Property"
+    _check_expected_price = models.Constraint(
+        "Check(expected_price > 0)", "The expected price must be strictly positive."
+    )
+    _check_selling_price = models.Constraint(
+        "Check(selling_price >= 0)", "The selling price must be positive."
+    )
+
+   
 
     name = fields.Char(required=True)
     description = fields.Text()
     postcode = fields.Char()
     date_availability = fields.Date()
-    expected_price = fields.Float()
+    expected_price = fields.Float(required=True)
     selling_price = fields.Float()
     bedrooms = fields.Integer()
     living_area = fields.Integer()
@@ -22,62 +31,78 @@ class EstateProperty(models.Model):
     garden_area = fields.Integer()
     garden_orientation = fields.Selection(
         selection=[
-            ('north', 'North'),
-            ('south', 'South'),
-            ('east', 'East'),
-            ('west', 'West')
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
         ]
     )
     state = fields.Selection(
         selection=[
-            ('new', 'New'),
-            ('offer_received', 'Offer Received'),
-            ('offer_accepted', 'Offer Accepted'),
-            ('sold', 'Sold'),
-            ('cancelled', 'Cancelled')
+            ("new", "New"),
+            ("offer_received", "Offer Received"),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
         ],
-        default='new',
-        required=True
+        default="new",
+        required=True,
     )
-    buyer_id = fields.Many2one('res.partner', string='Buyer')
+    buyer_id = fields.Many2one("res.partner", string="Buyer")
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
     total_area = fields.Integer(compute="_compute_total_area")
     best_price = fields.Float(compute="_compute_best_price", string="Best Offer Price")
 
-    @api.depends('living_area', 'garden_area')
+    @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
-    @api.depends('offer_ids.price')
+    @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for record in self:
             if record.offer_ids:
-                record.best_price = max(record.offer_ids.mapped('price'))
+                record.best_price = max(record.offer_ids.mapped("price"))
             else:
                 record.best_price = 0.0
 
-    @api.onchange('garden')
+    @api.onchange("garden")
     def _onchange_garden(self):
         if self.garden:
             self.garden_area = 10
-            self.garden_orientation = 'north'
+            self.garden_orientation = "north"
         else:
             self.garden_area = 0
             self.garden_orientation = False
 
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for record in self:
+            if not float_is_zero(record.selling_price, precision_digits=2):
+                if (
+                    float_compare(
+                        record.selling_price,
+                        record.expected_price * 0.9,
+                        precision_digits=2,
+                    )
+                    < 0
+                ):
+                    raise ValidationError(
+                        "The selling price cannot be lower than 90% of the expected price."
+                    )
+
     def action_sold(self):
         for record in self:
-            if record.state == 'cancelled':
+            if record.state == "cancelled":
                 raise UserError("Cancelled property cannot be sold.")
-            record.state = 'sold'
+            record.state = "sold"
         return True
 
     def action_cancel(self):
         for record in self:
-            if record.state == 'sold':
+            if record.state == "sold":
                 raise UserError("Sold property cannot be cancelled.")
-            record.state = 'cancelled'
+            record.state = "cancelled"
         return True

estate/models/estate_property_offer.py

@@ -11,14 +11,13 @@ class EstatePropertyOffer(models.Model):
     _order = "price desc"
 
     price = fields.Float(required=True)
+    _check_price = models.Constraint(
+        "Check(price > 0)", "The offer price must be strictly positive."
+    )
     status = fields.Selection(
-        selection=[
-            ('accepted', 'Accepted'),
-            ('refused', 'Refused')
-        ],
-        copy=False
+        selection=[("accepted", "Accepted"), ("refused", "Refused")], copy=False
     )
-    partner_id = fields.Many2one('res.partner', string='Partner', required=True)
+    partner_id = fields.Many2one("res.partner", string="Partner", required=True)
     property_id = fields.Many2one("estate.property", string="Property", required=True)
     validity = fields.Integer(default=7, string="Validity (days)")
     date_deadline = fields.Date(
@@ -40,14 +39,16 @@ def _inverse_date_deadline(self):
 
     def action_accept(self):
         for record in self:
-            if record.property_id.offer_ids.filtered(lambda o: o.status == 'accepted' and o.id != record.id):
+            if record.property_id.offer_ids.filtered(
+                lambda o: o.status == "accepted" and o.id != record.id
+            ):
                 raise UserError("Only one offer can be accepted per property.")
-            record.status = 'accepted'
+            record.status = "accepted"
             record.property_id.buyer_id = record.partner_id
             record.property_id.selling_price = record.price
         return True
 
     def action_refuse(self):
         for record in self:
-            record.status = 'refused'
+            record.status = "refused"
         return True

estate/models/estate_property_tag.py

@@ -8,4 +8,8 @@ class EstatePropertyTag(models.Model):
     _description = "Real Estate Property Tag"
     _order = "name"
 
+    _check_unique_name = models.Constraint(
+        "UNIQUE(name)", "The tag name must be unique."
+    )
+
     name = fields.Char(required=True)

estate/models/estate_property_type.py

@@ -7,5 +7,8 @@ class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Real Estate Property Type"
     _order = "name"
+    _check_unique_name = models.Constraint(
+        "UNIQUE(name)", "The type name must be unique."
+    )
 
     name = fields.Char(required=True)