[CLN] Module: Estate, Estate_accounting

Description:
1. cleaning code to follow odoo's convention
2. addressing nit left by the PR reviewer

Author: OmarKhalil2001

estate/models/building.py

@@ -1,11 +1,11 @@
-from odoo import models, fields, api
-from odoo.exceptions import UserError
 from datetime import timedelta
 
+from odoo import models, fields, api
+from odoo.exceptions import UserError
 
 class Building(models.Model):
-    _name = "estate.buildings"
-    _description = "Buildings"
+    _name = 'estate.building'
+    _description = 'Buildings'
     _order = "id desc"
 
     name = fields.Char()
@@ -39,7 +39,7 @@ class Building(models.Model):
         "res.users", string="Salesperson", default=lambda self: self.env.user
     )
     tag_ids = fields.Many2many("estate.building_tags", string="Tags")
-    offer_ids = fields.One2many("estate.offers", "building_id", string="Offers")
+    offer_ids = fields.One2many("estate.offer", "building_id", string="Offers")
 
     total_area = fields.Integer(string="Total Area", compute="_compute_total_area")
 

estate/models/building_type.py

@@ -2,15 +2,15 @@
 
 
 class BuildingType(models.Model):
-    _name = "estate.building_type"
-    _description = "Building Type"
+    _name = 'estate.building_type'
+    _description = 'Building Type'
     _order = "sequence, name"
 
     name = fields.Char(required=True)
     building_ids = fields.One2many(
-        "estate.buildings", "building_type_id", string="Buildings"
+        "estate.building", "building_type_id", string="Buildings"
     )
-    offer_ids = fields.One2many("estate.offers", "property_type_id", string="Offers")
+    offer_ids = fields.One2many("estate.offer", "property_type_id", string="Offers")
     offers_count = fields.Integer(
         string="Offers Count",
         compute="_compute_offers_count",
@@ -27,6 +27,6 @@ class BuildingType(models.Model):
 
     def _compute_offers_count(self):
         for record in self:
-            record.offers_count = self.env["estate.offers"].search_count(
+            record.offers_count = self.env["estate.offer"].search_count(
                 [("property_type_id", "=", record.id)]
             )

estate/models/offer.py

@@ -1,12 +1,13 @@
+from datetime import timedelta
+
 from odoo import models, fields, api
 from odoo.exceptions import UserError
-from datetime import timedelta
 from odoo.tools.float_utils import float_compare
 
 
 class Offer(models.Model):
-    _name = "estate.offers"
-    _description = "Offers"
+    _name = 'estate.offer'
+    _description = 'Offers'
     _order = "price desc"
 
     price = fields.Integer(required=True)
@@ -15,7 +16,7 @@ class Offer(models.Model):
         string="Status",
         required=False,
     )
-    building_id = fields.Many2one("estate.buildings", string="Building")
+    building_id = fields.Many2one("estate.building", string="Building")
     partner_id = fields.Many2one("res.partner", string="Partner")
     validity = fields.Integer(string="Validity (days)", default=7)
     date_deadline = fields.Date(
@@ -42,10 +43,7 @@ def _inverse_date_deadline(self):
 
     def action_accept_offer(self):
         for record in self:
-            if record.status != "accepted" and record.building_id.state not in [
-                "sold",
-                "canceled",
-            ]:
+            if record.status != "accepted" and record.building_id.state not in ["sold", "canceled"]:
                 record.status = "accepted"
                 record.building_id.state = "offer_accepted"
                 record.building_id.buyer_id = record.partner_id
@@ -58,9 +56,7 @@ def action_accept_offer(self):
                 )
                 other_offers.write({"status": "refused"})
             elif record.building_id.state in ["sold", "canceled"]:
-                raise UserError(
-                    self.env._("Cannot accept offers for sold or canceled buildings.")
-                )
+                raise UserError(self.env._("Cannot accept offers for sold or canceled buildings."))
             else:
                 raise UserError(self.env._("Offer is already accepted."))
 
@@ -76,22 +72,13 @@ def action_refuse_offer(self):
     @api.constrains("building_id", "price")
     def _check_price(self):
         for record in self:
-            if (
-                float_compare(
-                    0.9 * record.building_id.value, record.price, precision_digits=2
-                )
-                == 1
-            ):
-                raise UserError(
-                    self.env._(
-                        "Offer price must be at least 90% of the building's value."
-                    )
-                )
+            if float_compare(0.9 * record.building_id.value, record.price, precision_digits=2) > 0:
+                raise UserError(self.env._("Offer price must be at least 90% of the building's value."))
 
     @api.model
     def create(self, vals):
         for val in vals:
-            self.env["estate.buildings"].browse(
+            self.env["estate.building"].browse(
                 val["building_id"]
             ).state = "offer_received"
         return super().create(vals)

estate/models/salesperson.py

@@ -2,6 +2,7 @@
 
 
 class ResUsers(models.Model):
-    _inherit = ["res.users"]
+    _name = 'res.users'
+    _inherit = ['res.users']
 
-    building = fields.One2many("estate.buildings", "salesperson_id", string="Listings")
+    building = fields.One2many("estate.building", "salesperson_id", string="Listings")

estate/models/tag.py

@@ -2,8 +2,8 @@
 
 
 class BuildingTag(models.Model):
-    _name = "estate.building_tags"
-    _description = "Building Tags"
+    _name = 'estate.building_tags'
+    _description = 'Building Tags'
     _order = "name"
 
     name = fields.Char(required=True)

estate/security/ir.model.access.csv

@@ -1,5 +1,5 @@
 id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
-access_first_model,access_first_model,model_estate_buildings,base.group_user,1,1,1,1
+access_first_model,access_first_model,model_estate_building,base.group_user,1,1,1,1
 access_building_type_model,access_building_type_model,model_estate_building_type,base.group_user,1,1,1,1
 access_building_tags_model,access_building_tags_model,model_estate_building_tags,base.group_user,1,1,1,1
-access_offers_model,access_offers_model,model_estate_offers,base.group_user,1,1,1,1
+access_offers_model,access_offers_model,model_estate_offer,base.group_user,1,1,1,1

estate/views/views.xml

@@ -2,7 +2,7 @@
 <odoo>
     <record id="some_model_action_1" model="ir.actions.act_window">
         <field name="name">Buildings</field>
-        <field name="res_model">estate.buildings</field>
+        <field name="res_model">estate.building</field>
         <field name="view_mode">list,form,kanban</field>
         <field name="context">{'search_default_Available': True}</field>
     </record>
@@ -15,14 +15,14 @@
 
     <record id="some_model_action_3" model="ir.actions.act_window">
         <field name="name">Offers</field>
-        <field name="res_model">estate.offers</field>
+        <field name="res_model">estate.offer</field>
         <field name="view_mode">list</field>
         <field name="domain">[('property_type_id', '=', active_id)]</field>
     </record>
 
     <record id="list_view_" model="ir.ui.view">
-        <field name="name">estate.buildings.list</field>
-        <field name="model">estate.buildings</field>
+        <field name="name">estate.building.list</field>
+        <field name="model">estate.building</field>
         <field name="arch" type="xml">
             <list string="test_list" decoration-success="state in ('offer_received', 'offer_accepted')" decoration-bf="state=='offer_accepted'" decoration-muted="state=='sold'">
                 <field name="name"/>
@@ -36,8 +36,8 @@
     </record>
 
     <record id="first_form_view" model="ir.ui.view">
-        <field name="name">estate.buildings.form</field>
-        <field name="model">estate.buildings</field>
+        <field name="name">estate.building.form</field>
+        <field name="model">estate.building</field>
         <field name="arch" type="xml">
             <form string="Test">
                 <header>
@@ -98,8 +98,8 @@
     </record>
 
     <record id="first_search_view" model="ir.ui.view">
-        <field name="name">estate.buildings.search</field>
-        <field name="model">estate.buildings</field>
+        <field name="name">estate.building.search</field>
+        <field name="model">estate.building</field>
         <field name="arch" type="xml">
             <search string="test_search">
                 <field name="name"/>
@@ -170,8 +170,8 @@
         </field>
     </record>
     <record id="kanban_1" model="ir.ui.view">
-        <field name="name">estate.buildings.kanban</field>
-        <field name="model">estate.buildings</field>
+        <field name="name">estate.building.kanban</field>
+        <field name="model">estate.building</field>
         <field name="arch" type="xml">
             <kanban default_group_by="building_type_id">
                 <template>

estate_accounting/models/estate_account.py

@@ -2,11 +2,10 @@
 
 
 class estateAccount(models.Model):
-    _inherit = "estate.buildings"
+    _inherit = "estate.building"
 
     def action_set_sold(self):
-        print("\n\n\n", self.buyer_id.id, "\n\n\n")
-        account_move = self.env["account.move"].create(
+        self.env["account.move"].create(
             {
                 "partner_id": self.buyer_id.id,
                 "move_type": "out_invoice",