From d1535030d2e65b61cc1797c51555ca220eeaec13 Mon Sep 17 00:00:00 2001 From: Zac Turner Date: Fri, 27 Mar 2026 09:57:24 +1100 Subject: [PATCH] ap-7798 # Removed `uploadPDFConversion` fn --- CHANGELOG.md | 4 ++++ src/OneBlinkUploader.ts | 43 ++--------------------------------------- src/types.ts | 2 +- 3 files changed, 7 insertions(+), 42 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb9494e..dc13c6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +### Removed + +- **[BREAKING]** `OneBlinkUploader.uploadPDFConversion()` + ### Added - `pdfConversionId` and `pdfConversionJobId` to `OneBlinkUploader.uploadPDFConversion()` result diff --git a/src/OneBlinkUploader.ts b/src/OneBlinkUploader.ts index 0ae932e..684925f 100644 --- a/src/OneBlinkUploader.ts +++ b/src/OneBlinkUploader.ts @@ -6,7 +6,7 @@ import { UploadFormSubmissionOptions, UploadOptions, UploadEmailAttachmentOptions, - UploadPDFConversionOptions, + UploadCustomPDFOptions, UploadAiBuilderAttachmentOptions, } from './types.js' import { SubmissionTypes } from '@oneblink/types' @@ -506,45 +506,6 @@ export default class OneBlinkUploader { }) } - /** - * Upload a PDF for conversion. PDF Conversions are always private. - * - * #### Example - * - * ```ts - * const abortController = new AbortController() - * const result = await uploader.uploadPDFConversion({ - * onProgress: (progress) => { - * // ... - * }, - * data: pdfData, - * formId: 1, - * abortSignal: abortController.signal, - * }) - * ``` - * - * @param data The PDF data and options - * @returns The upload result - */ - async uploadPDFConversion({ - onProgress, - abortSignal, - data, - formId, - }: UploadPDFConversionOptions) { - return await uploadToS3<{ - pdfConversionId: string - pdfConversionJobId: number - }>({ - ...this, - contentType: 'application/pdf', - body: data, - key: `forms/${formId}/pdf-conversion`, - abortSignal, - onProgress, - }) - } - /** * Upload an attachment for use with the AI builder. * @@ -612,7 +573,7 @@ export default class OneBlinkUploader { abortSignal, data, formId, - }: UploadPDFConversionOptions) { + }: UploadCustomPDFOptions) { return await uploadToS3({ ...this, contentType: 'application/pdf', diff --git a/src/types.ts b/src/types.ts index 23d5b43..dc0f96d 100644 --- a/src/types.ts +++ b/src/types.ts @@ -70,7 +70,7 @@ export type UploadAssetOptions = UploadOptions & { fileName: string } -export type UploadPDFConversionOptions = UploadOptions & { +export type UploadCustomPDFOptions = UploadOptions & { /** The PDF File to upload */ data: AttachmentUploadData /** The id of the Form that the PDF Conversion is occurring on */