From 5d0096ba5e9855fbe04033f5850fdf978941ad45 Mon Sep 17 00:00:00 2001 From: Dominik Helm Date: Tue, 21 Oct 2025 15:36:03 +0200 Subject: [PATCH] Remove BugPicker --- .../InvokedynamicRewritingExecutionTest.scala | 1 - ...ormInvocationsWithRecursionDetection.scala | 3 - TOOLS/bp/build.sbt | 1 - ...gImmediatelyUnboxedToPerformCoercion.scala | 122 ---- .../src/TODO/CloneDoesNotCallSuperClone.scala | 91 --- TOOLS/bp/src/TODO/DoInsideDoPrivileged.scala | 66 -- .../bp/src/TODO/EqualsHashCodeContract.scala | 78 --- TOOLS/bp/src/TODO/InefficientToArray.scala | 101 --- .../TODO/LongBitsToDoubleInvokedOnInt.scala | 73 --- ...zableClassHasASerializableInnerClass.scala | 70 -- .../SwingMethodInvokedInSwingThread.scala | 80 --- TOOLS/bp/src/TODO/SyncSetUnsyncGet.scala | 89 --- ...UninitReadCalledFromSuperConstructor.scala | 216 ------- TOOLS/bp/src/main/resources/application.conf | 34 - .../org/opalj/bugpicker/core/html.css | 117 ---- .../org/opalj/bugpicker/core/html.js | 2 - .../org/opalj/bugpicker/core/report.css | 123 ---- .../org/opalj/bugpicker/core/report.js | 399 ------------ .../org/opalj/bugpicker/core/search.js | 92 --- TOOLS/bp/src/main/resources/reference.conf | 3 - .../org/opalj/bugpicker/core/Console.scala | 330 ---------- .../core/analyses/AnalysisParameters.scala | 27 - .../AnonymousInnerClassShouldBeStatic.scala | 187 ------ .../core/analyses/BugPickerAnalysis.scala | 605 ------------------ .../analyses/BugPickerAnalysisDomain.scala | 274 -------- .../core/analyses/CollectionsUsage.scala | 159 ----- .../core/analyses/CovariantEquals.scala | 114 ---- .../core/analyses/DeadEdgesAnalysis.scala | 362 ----------- .../GuardedAndUnguardedAccessAnalysis.scala | 193 ------ .../analyses/ManualGarbageCollection.scala | 67 -- .../analyses/ThrowsExceptionAnalysis.scala | 130 ---- .../core/analyses/UnusedFields.scala | 119 ---- .../core/analyses/UnusedLocalVariables.scala | 288 --------- .../core/analyses/UnusedMethodsAnalysis.scala | 167 ----- .../UselessComputationsAnalysis.scala | 174 ----- .../UselessReComputationsAnalysis.scala | 103 --- .../bugpicker/core/analyses/package.scala | 28 - .../org/opalj/bugpicker/core/package.scala | 30 - .../AnonymousInnerClassShouldBeStatic.jar | Bin 7303 -> 0 bytes .../analyses/BadlyOverriddenAdapter.jar | Bin 4219 -> 0 bytes .../resources/classfiles/analyses/BitNops.jar | Bin 3294 -> 0 bytes ...ingImmediatelyUnboxedToPerformCoercion.jar | Bin 1402 -> 0 bytes .../CatchesIllegalMonitorStateException.jar | Bin 4606 -> 0 bytes .../analyses/CloneDoesNotCallSuperClone.jar | Bin 1869 -> 0 bytes .../CnImplementsCloneButNotCloneable.jar | Bin 1731 -> 0 bytes .../analyses/CovariantCompareTo.jar | Bin 10104 -> 0 bytes .../classfiles/analyses/CovariantEquals.jar | Bin 2018 -> 0 bytes .../analyses/DmRunFinalizersOnExit.jar | Bin 1183 -> 0 bytes .../analyses/DoInsideDoPrivileged.jar | Bin 3418 -> 0 bytes .../analyses/EqualsHashCodeContract.jar | Bin 1652 -> 0 bytes .../FieldIsntImmutableInImmutableClass.jar | Bin 12105 -> 0 bytes .../analyses/FieldShouldBeFinal.jar | Bin 1382 -> 0 bytes .../FieldShouldBePackageProtected.jar | Bin 1404 -> 0 bytes .../classfiles/analyses/FinalizeUseless.jar | Bin 1893 -> 0 bytes .../ImmutableClassInheritsMutableClass.jar | Bin 2771 -> 0 bytes .../ImplementsCloneableButNotClone.jar | Bin 1685 -> 0 bytes .../analyses/InefficientToArray.jar | Bin 1319 -> 0 bytes .../analyses/JCIPAnnotations-license.txt | 15 - .../classfiles/analyses/JCIPAnnotations.jar | Bin 1888 -> 0 bytes .../analyses/JSR305Annotations-license.txt | 6 - .../classfiles/analyses/JSR305Annotations.jar | Bin 1935 -> 0 bytes .../analyses/LongBitsToDoubleInvokedOnInt.jar | Bin 1358 -> 0 bytes .../analyses/ManualGarbageCollection.jar | Bin 2010 -> 0 bytes .../analyses/NativeMethodInImmutableClass.jar | Bin 1917 -> 0 bytes ...lizableClassHasASerializableInnerClass.jar | Bin 5808 -> 0 bytes .../classfiles/analyses/OwnAnnotations.jar | Bin 571 -> 0 bytes .../analyses/ProtectedFieldInFinalClass.jar | Bin 1502 -> 0 bytes .../PublicFinalizeMethodShouldBeProtected.jar | Bin 1209 -> 0 bytes .../resources/classfiles/analyses/Readme.txt | 7 - .../SerializableNoSuitableConstructor.jar | Bin 1232 -> 0 bytes .../SwingMethodInvokedInSwingThread.jar | Bin 3143 -> 0 bytes .../classfiles/analyses/SyncSetUnsyncGet.jar | Bin 908 -> 0 bytes ...dFieldAccessDuringStaticInitialization.jar | Bin 11295 -> 0 bytes .../analyses/UnusedPrivateFields.jar | Bin 5031 -> 0 bytes ...UrUninitReadCalledFromSuperConstructor.jar | Bin 1909 -> 0 bytes .../analyses/UselessIncrementInReturn.jar | Bin 1884 -> 0 bytes TOOLS/bp/src/test/resources/empty.properties | 0 .../test/resources/invalid-value-1.properties | 1 - .../test/resources/invalid-value-2.properties | 1 - .../test/resources/not-a-property-file.gif | Bin 600 -> 0 bytes .../AnonymousInnerClass.java | 22 - ...nonymousInnerClassAccessingOuterClass.java | 51 -- .../StaticInnerClass.java | 22 - .../BadlyOverriddenKeyAdapter.java | 17 - ...BadlyOverriddenKeyAdapterWithOverload.java | 18 - .../BadlyOverriddenMouseInputAdapter.java | 17 - .../CorrectlyOverriddenKeyAdapter.java | 17 - .../CorrectlyOverriddenMouseInputAdapter.java | 18 - .../BadlyOverriddenAdapter/NotAnAdapter.java | 15 - ...Overload1CorrectlyOverridesKeyAdapter.java | 18 - ...Overload2CorrectlyOverridesKeyAdapter.java | 18 - .../sourcefiles/analyses/BitNops/And.java | 42 -- .../analyses/BitNops/FlagCollectionLoop.java | 22 - .../BitNops/InvolvingPrivateField.java | 19 - .../BitNops/InvolvingPublicField.java | 18 - .../sourcefiles/analyses/BitNops/Or.java | 42 -- .../BitNops/UninterpretedInstructions.java | 21 - .../NewIntegerToDoubleValue.java | 13 - .../UnrelatedClass.java | 14 - .../MissingSynchronized.java | 63 -- .../ProperSynchronized.java | 51 -- .../UnrelatedClass.java | 15 - .../CloneWithoutCallToSuperClone.java | 16 - .../CorrectlyImplementedClone.java | 24 - .../SomeClassWithoutClone.java | 14 - .../ImplementsCloneAndCloneable.java | 16 - .../ImplementsCloneButNotCloneable.java | 16 - .../SomeClassWithoutClone.java | 14 - ...tractComparableWithCovariantCompareTo.java | 23 - ...stractComparableWithMultipleCompareTo.java | 23 - ...AbstractComparableWithProperCompareTo.java | 17 - ...nericComparableWithCovariantCompareTo.java | 23 - ...enericComparableWithMultipleCompareTo.java | 24 - ...tGenericComparableWithProperCompareTo.java | 19 - ...tSelfComparableWithCovariantCompareTo.java | 22 - ...ctSelfComparableWithMultipleCompareTo.java | 23 - ...ractSelfComparableWithProperCompareTo.java | 17 - .../ComparableWithMultipleCompareTo.java | 24 - .../ComparableWithProperCompareTo.java | 18 - .../ExtendsProperComparableAndOverrides.java | 17 - ...roperComparableWithCovariantCompareTo.java | 20 - ...endsProperComparableWithoutOverriding.java | 14 - ...enericComparableWithMultipleCompareTo.java | 23 - .../GenericComparableWithProperCompareTo.java | 17 - .../SelfComparableWithMultipleCompareTo.java | 23 - .../SelfComparableWithProperCompareTo.java | 17 - ...tlyOverriddenAndCovariantEqualsMethod.java | 21 - .../CorrectlyOverriddenEqualsMethod.java | 17 - .../CovariantEqualsMethod.java | 16 - .../CovariantEquals/NoEqualsMethod.java | 12 - .../CallsRunFinalizersOnExit.java | 15 - .../SomeUnrelatedClass.java | 15 - .../CallsSetAccessibleInsideDoPrivileged.java | 28 - ...CallsSetAccessibleOutsideDoPrivileged.java | 20 - .../DoInsideDoPrivileged/ClassWithAField.java | 13 - .../DoInsideDoPrivileged/UnrelatedClass.java | 14 - .../ClassWithNeitherEqualsNorHashCode.java | 14 - .../EqualsWithoutHashCode.java | 16 - .../HashCodeWithoutEquals.java | 16 - .../CustomAnnotatedWithTrivialMutable.java | 17 - .../JCIPAnnotatedWithCyclicFields.java | 21 - ...otatedWithDefensiveCopyOfUnknownClass.java | 22 - .../JCIPAnnotatedWithDirectPublicSetter.java | 22 - ...JCIPAnnotatedWithIndirectPublicSetter.java | 28 - ...PAnnotatedWithMutablePublicFinalArray.java | 18 - ...PAnnotatedWithMutablePublicFinalField.java | 17 - ...PAnnotatedWithTooShallowDefensiveCopy.java | 37 -- .../JCIPAnnotatedWithTrivialMutable.java | 17 - .../JCIPAnnotatedWithoutDefensiveCopy.java | 22 - ...PAnnotatedWithoutDefensiveCopyAtInput.java | 26 - ...CIPCorrectlyImplementedImmutableClass.java | 95 --- ...rrectyImplementationWithFactoryMethod.java | 37 -- .../JSR305AnnotatedWithTrivialMutable.java | 16 - .../MutableClassWithCyclicFieldsA.java | 14 - .../MutableClassWithCyclicFieldsB.java | 14 - .../MutableClassWithUnknownField.java | 19 - .../NotImmutableWithPublicFields.java | 26 - .../SomeClassWithoutFields.java | 14 - .../FieldShouldBeFinal/VariousFields.java | 39 -- .../SomeClassWithoutFields.java | 14 - .../VariousFields.java | 28 - .../ClassWithoutExplicitFinalize.java | 18 - .../FinalizeUseless/UsefulFinalize.java | 20 - .../FinalizeUseless/UselessFinalize.java | 17 - .../JCIPAnnotatedImmutable.java | 14 - .../JCIPAnnotatedInheritingFromMutable.java | 16 - ...PAnnotatedInheritsFromDirectImmutable.java | 14 - .../JCIPAnnotatedWithoutInheritance.java | 15 - .../MutableClass.java | 26 - .../ImplementsCloneAndCloneable.java | 15 - .../ImplementsCloneableButNotClone.java | 10 - .../SomeClassWithoutClone.java | 14 - .../InefficientToArray/EfficientToArray.java | 28 - .../InefficientToArray.java | 22 - .../IntBitsToDouble.java | 18 - .../LongBitsToDouble.java | 17 - .../ManualGarbageCollection/RuntimeGc.java | 14 - .../RuntimeGcIntentional.java | 15 - .../ManualGarbageCollection/SystemGc.java | 14 - .../SystemGcIntentional.java | 15 - .../JCIPAnnotatedWithNativeMethod.java | 28 - .../JCIPAnnotatedWithoutNativeMethod.java | 16 - .../NotImmutableWithPublicFields.java | 26 - .../NonSerializableOuterClass.java | 26 - .../SerializableOuterClass.java | 24 - .../analyses/OwnAnnotations/Immutable.java | 20 - .../PrivateInFinal.java | 11 - .../ProtectedInFinal.java | 11 - .../ProtectedInNonFinal.java | 10 - .../ProtectedFinalizeMethod.java | 16 - .../PublicFinalizeMethod.java | 17 - ...ableInheritsFromNoSuitableConstructor.java | 20 - .../SerializableNoSuitableConstructor.java | 15 - .../BadSwingImplementation.java | 31 - .../GoodSwingImplementation.java | 43 -- .../NoSwingUsed.java | 23 - .../VariousSettersAndGetters.java | 80 --- .../A.java | 155 ----- .../B.java | 82 --- .../C.java | 31 - .../ClassUsesItself.java | 17 - .../CodePaths.java | 106 --- .../EmptyStaticInitializer.java | 12 - .../EnumUsesItself.java | 22 - .../Recursion.java | 34 - .../StaticNativeMethod.java | 28 - .../UnrelatedControlClassA.java | 18 - .../UnrelatedControlClassB.java | 20 - .../analyses/UnusedPrivateFields/Unused.java | 23 - .../UnusedSerialVersionUID.java | 14 - .../analyses/UnusedPrivateFields/Used.java | 102 --- .../UnusedPrivateFields/UsedInInnerClass.java | 35 - .../UsedSerialVersionUID.java | 13 - ...ubclassAccessedBySuperclassBeforeInit.java | 25 - ...erclassWithAccessToSubclassDuringInit.java | 17 - .../UnrelatedClass.java | 15 - .../IntFieldIncrementInReturn.java | 37 -- .../IntParameterIncrementInReturn.java | 33 - .../UnrelatedClass.java | 14 - .../annotation/concurrent/GuardedBy.java | 38 -- .../annotation/concurrent/Immutable.java | 35 - .../annotation/concurrent/NotThreadSafe.java | 30 - .../annotation/concurrent/ThreadSafe.java | 22 - .../net/jcip/annotations/GuardedBy.java | 64 -- .../net/jcip/annotations/Immutable.java | 49 -- .../net/jcip/annotations/NotThreadSafe.java | 37 -- .../net/jcip/annotations/ThreadSafe.java | 37 -- TOOLS/bp/src/test/resources/valid.properties | 4 - build.sbt | 15 - src/site/UsingOPAL.md | 5 - src/site/index.md | 6 - 231 files changed, 8879 deletions(-) delete mode 100644 TOOLS/bp/build.sbt delete mode 100644 TOOLS/bp/src/TODO/BoxingImmediatelyUnboxedToPerformCoercion.scala delete mode 100644 TOOLS/bp/src/TODO/CloneDoesNotCallSuperClone.scala delete mode 100644 TOOLS/bp/src/TODO/DoInsideDoPrivileged.scala delete mode 100644 TOOLS/bp/src/TODO/EqualsHashCodeContract.scala delete mode 100644 TOOLS/bp/src/TODO/InefficientToArray.scala delete mode 100644 TOOLS/bp/src/TODO/LongBitsToDoubleInvokedOnInt.scala delete mode 100644 TOOLS/bp/src/TODO/NonSerializableClassHasASerializableInnerClass.scala delete mode 100644 TOOLS/bp/src/TODO/SwingMethodInvokedInSwingThread.scala delete mode 100644 TOOLS/bp/src/TODO/SyncSetUnsyncGet.scala delete mode 100644 TOOLS/bp/src/TODO/UrUninitReadCalledFromSuperConstructor.scala delete mode 100644 TOOLS/bp/src/main/resources/application.conf delete mode 100644 TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.css delete mode 100644 TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.js delete mode 100644 TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.css delete mode 100644 TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.js delete mode 100644 TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/search.js delete mode 100644 TOOLS/bp/src/main/resources/reference.conf delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/Console.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnalysisParameters.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnonymousInnerClassShouldBeStatic.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysisDomain.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CollectionsUsage.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CovariantEquals.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/DeadEdgesAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/GuardedAndUnguardedAccessAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ManualGarbageCollection.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ThrowsExceptionAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedFields.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedLocalVariables.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedMethodsAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessComputationsAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessReComputationsAnalysis.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/package.scala delete mode 100644 TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/package.scala delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/AnonymousInnerClassShouldBeStatic.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/BadlyOverriddenAdapter.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/BitNops.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/BoxingImmediatelyUnboxedToPerformCoercion.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/CatchesIllegalMonitorStateException.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/CloneDoesNotCallSuperClone.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/CnImplementsCloneButNotCloneable.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/CovariantCompareTo.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/CovariantEquals.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/DmRunFinalizersOnExit.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/DoInsideDoPrivileged.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/EqualsHashCodeContract.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/FieldIsntImmutableInImmutableClass.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBeFinal.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBePackageProtected.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/FinalizeUseless.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/ImmutableClassInheritsMutableClass.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/ImplementsCloneableButNotClone.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/InefficientToArray.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/JCIPAnnotations-license.txt delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/JCIPAnnotations.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations-license.txt delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/LongBitsToDoubleInvokedOnInt.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/ManualGarbageCollection.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/NativeMethodInImmutableClass.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/NonSerializableClassHasASerializableInnerClass.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/OwnAnnotations.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/ProtectedFieldInFinalClass.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/PublicFinalizeMethodShouldBeProtected.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/Readme.txt delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/SerializableNoSuitableConstructor.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/SwingMethodInvokedInSwingThread.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/SyncSetUnsyncGet.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/UninitializedFieldAccessDuringStaticInitialization.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/UnusedPrivateFields.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/UrUninitReadCalledFromSuperConstructor.jar delete mode 100644 TOOLS/bp/src/test/resources/classfiles/analyses/UselessIncrementInReturn.jar delete mode 100644 TOOLS/bp/src/test/resources/empty.properties delete mode 100644 TOOLS/bp/src/test/resources/invalid-value-1.properties delete mode 100644 TOOLS/bp/src/test/resources/invalid-value-2.properties delete mode 100644 TOOLS/bp/src/test/resources/not-a-property-file.gif delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/AnonymousInnerClassShouldBeStatic/AnonymousInnerClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/AnonymousInnerClassShouldBeStatic/AnonymousInnerClassAccessingOuterClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/AnonymousInnerClassShouldBeStatic/StaticInnerClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/BadlyOverriddenKeyAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/BadlyOverriddenKeyAdapterWithOverload.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/BadlyOverriddenMouseInputAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/CorrectlyOverriddenKeyAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/CorrectlyOverriddenMouseInputAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/NotAnAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/Overload1CorrectlyOverridesKeyAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BadlyOverriddenAdapter/Overload2CorrectlyOverridesKeyAdapter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/And.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/FlagCollectionLoop.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/InvolvingPrivateField.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/InvolvingPublicField.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/Or.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BitNops/UninterpretedInstructions.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BoxingImmediatelyUnboxedToPerformCoercion/NewIntegerToDoubleValue.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/BoxingImmediatelyUnboxedToPerformCoercion/UnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CatchesIllegalMonitorStateException/MissingSynchronized.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CatchesIllegalMonitorStateException/ProperSynchronized.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CatchesIllegalMonitorStateException/UnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/CloneWithoutCallToSuperClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/CorrectlyImplementedClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/SomeClassWithoutClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneAndCloneable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneButNotCloneable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/SomeClassWithoutClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithCovariantCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithCovariantCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithCovariantCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableAndOverrides.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithCovariantCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithoutOverriding.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithMultipleCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithProperCompareTo.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenAndCovariantEqualsMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenEqualsMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CovariantEqualsMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/NoEqualsMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/CallsRunFinalizersOnExit.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/SomeUnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleInsideDoPrivileged.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleOutsideDoPrivileged.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/ClassWithAField.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/UnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/ClassWithNeitherEqualsNorHashCode.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/EqualsWithoutHashCode.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/HashCodeWithoutEquals.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/CustomAnnotatedWithTrivialMutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithCyclicFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDefensiveCopyOfUnknownClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDirectPublicSetter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithIndirectPublicSetter.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalArray.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalField.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTooShallowDefensiveCopy.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTrivialMutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopy.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopyAtInput.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectlyImplementedImmutableClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectyImplementationWithFactoryMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JSR305AnnotatedWithTrivialMutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsA.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsB.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithUnknownField.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/NotImmutableWithPublicFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/SomeClassWithoutFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/VariousFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/SomeClassWithoutFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/VariousFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/ClassWithoutExplicitFinalize.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UsefulFinalize.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UselessFinalize.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedImmutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritingFromMutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritsFromDirectImmutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedWithoutInheritance.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/MutableClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneAndCloneable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneableButNotClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/SomeClassWithoutClone.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/EfficientToArray.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/InefficientToArray.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/IntBitsToDouble.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/LongBitsToDouble.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGc.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGcIntentional.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGc.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGcIntentional.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithNativeMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithoutNativeMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/NotImmutableWithPublicFields.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/NonSerializableOuterClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/SerializableOuterClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/OwnAnnotations/Immutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/PrivateInFinal.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInFinal.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInNonFinal.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/ProtectedFinalizeMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/PublicFinalizeMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableInheritsFromNoSuitableConstructor.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableNoSuitableConstructor.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/BadSwingImplementation.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/GoodSwingImplementation.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/NoSwingUsed.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/SyncSetUnsyncGet/VariousSettersAndGetters.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/A.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/B.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/C.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/ClassUsesItself.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/CodePaths.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EmptyStaticInitializer.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EnumUsesItself.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/Recursion.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/StaticNativeMethod.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassA.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassB.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Unused.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UnusedSerialVersionUID.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Used.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedInInnerClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedSerialVersionUID.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SubclassAccessedBySuperclassBeforeInit.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SuperclassWithAccessToSubclassDuringInit.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/UnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntFieldIncrementInReturn.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntParameterIncrementInReturn.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/UnrelatedClass.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/GuardedBy.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/Immutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/NotThreadSafe.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/ThreadSafe.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/GuardedBy.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/Immutable.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/NotThreadSafe.java delete mode 100644 TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/ThreadSafe.java delete mode 100644 TOOLS/bp/src/test/resources/valid.properties diff --git a/DEVELOPING_OPAL/validate/src/it/scala/org/opalj/br/InvokedynamicRewritingExecutionTest.scala b/DEVELOPING_OPAL/validate/src/it/scala/org/opalj/br/InvokedynamicRewritingExecutionTest.scala index 925352173c..90919141a3 100644 --- a/DEVELOPING_OPAL/validate/src/it/scala/org/opalj/br/InvokedynamicRewritingExecutionTest.scala +++ b/DEVELOPING_OPAL/validate/src/it/scala/org/opalj/br/InvokedynamicRewritingExecutionTest.scala @@ -379,7 +379,6 @@ class InvokedynamicRewritingExecutionTest extends AnyFunSpec with Matchers { new File("OPAL/ai/src/main/resources/").toURI.toURL, new File("OPAL/ba/src/main/resources/").toURI.toURL, new File("OPAL/bi/src/main/resources/").toURI.toURL, - new File("OPAL/bp/src/main/resources/").toURI.toURL, new File("OPAL/br/src/main/resources/").toURI.toURL, new File("OPAL/common/src/main/resources/").toURI.toURL ) ++ opalDependencies diff --git a/OPAL/ai/src/main/scala/org/opalj/ai/domain/l2/PerformInvocationsWithRecursionDetection.scala b/OPAL/ai/src/main/scala/org/opalj/ai/domain/l2/PerformInvocationsWithRecursionDetection.scala index bfd763dc23..6eed5cd1b0 100644 --- a/OPAL/ai/src/main/scala/org/opalj/ai/domain/l2/PerformInvocationsWithRecursionDetection.scala +++ b/OPAL/ai/src/main/scala/org/opalj/ai/domain/l2/PerformInvocationsWithRecursionDetection.scala @@ -9,9 +9,6 @@ import org.opalj.br.Method /** * Enables to perform invocations. * - * ==Example== - * (PerformInvocationsWithRecursionDetection is in particular used by BugPicker's domain.) - * * @author Michael Eichberg */ trait PerformInvocationsWithRecursionDetection extends PerformInvocations with TheMemoryLayout { diff --git a/TOOLS/bp/build.sbt b/TOOLS/bp/build.sbt deleted file mode 100644 index b511e98651..0000000000 --- a/TOOLS/bp/build.sbt +++ /dev/null @@ -1 +0,0 @@ -// build settings reside in the opal root build.sbt file diff --git a/TOOLS/bp/src/TODO/BoxingImmediatelyUnboxedToPerformCoercion.scala b/TOOLS/bp/src/TODO/BoxingImmediatelyUnboxedToPerformCoercion.scala deleted file mode 100644 index f8a322c7c2..0000000000 --- a/TOOLS/bp/src/TODO/BoxingImmediatelyUnboxedToPerformCoercion.scala +++ /dev/null @@ -1,122 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports code such as this: - * {{{ - * new Integer(1).doubleValue() - * }}} - * where a literal value is boxed into an object and then immediately unboxed. This means - * that the object creation was useless. - * - * IMPROVE to also detect code like this: {{{Integer.valueOf(1).doubleValue()}}} - * - * @author Ralf Mitschke - * @author Daniel Klauer - * @author Michael Eichberg - */ -object BoxingImmediatelyUnboxedToPerformCoercion { - - override def description: String = - "Reports sections of code that box a value but then immediately unbox it." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: SomeProject, - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[LineAndColumnBasedReport[Source]] = { - - // For each method doing INVOKESPECIAL followed by INVOKEVIRTUAL on the same - // java.lang class, where the called method's name ends in "Value"... - val theTypes = scala.collection.mutable.HashSet( - ClassType.Boolean, - ClassType.Byte, - ClassType.Character, - ClassType.Short, - ClassType.Integer, - ClassType.Long, - ClassType.Float, - ClassType.Double - ) - val theMethods = scala.collection.mutable.HashSet( - "booleanValue", - "byteValue", - "charValue", - "shortValue", - "intValue", - "longValue", - "floatValue", - "doubleValue" - ) - - var result: List[LineAndColumnBasedReport[Source]] = List.empty - for { - classFile <- project.allProjectClassFiles - if classFile.majorVersion >= 49 - if !project.isLibraryType(classFile) - method @ MethodWithBody(body) <- classFile.methods - } { - val instructions = body.instructions - val max_pc = body.instructions.length - - var pc = 0 - var next_pc = body.pcOfNextInstruction(pc) - - while (next_pc < max_pc) { - if (pc + 3 == next_pc) { - instructions(pc) match { - case INVOKESPECIAL(receiver1, _, TheArgument(parameterType: BaseType)) => - instructions(next_pc) match { - case INVOKEVIRTUAL( - `receiver1`, - name, - NoArgumentMethodDescriptor(returnType: BaseType) - ) - if ((returnType ne parameterType) && (theTypes.contains( - receiver1 - ) && theMethods.contains(name))) => { - result = - LineAndColumnBasedReport( - project.source(classFile.thisType), - Severity.Info, - classFile.thisType, - method.descriptor, - method.name, - body.lineNumber(pc), - None, - "Value boxed and immediately unboxed" - ) :: result - // we have matched the sequence - pc = body.pcOfNextInstruction(next_pc) - } - case _ => - pc = next_pc - next_pc = body.pcOfNextInstruction(pc) - - } - case _ => - pc = next_pc - next_pc = body.pcOfNextInstruction(pc) - } - } else { - pc = next_pc - next_pc = body.pcOfNextInstruction(pc) - } - } - } - result - } -} diff --git a/TOOLS/bp/src/TODO/CloneDoesNotCallSuperClone.scala b/TOOLS/bp/src/TODO/CloneDoesNotCallSuperClone.scala deleted file mode 100644 index 687df7ceda..0000000000 --- a/TOOLS/bp/src/TODO/CloneDoesNotCallSuperClone.scala +++ /dev/null @@ -1,91 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import org.opalj.br.MethodDescriptor.JustReturnsObject - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports `clone()` methods that do not contain a call to `super.clone`. - * Such `clone()` methods are probably (but not necessarily) implemented incorrectly. - * - * In order to satisfy the standard `clone()` contract, `clone()` must return an object of - * the same class it was called on. If every `clone()` method in an inheritance hierarchy - * calls `super.clone()`, then `Object.clone()` will eventually be called and create an - * object of the proper type. - * - * If a clone() method does not rely on `Object.clone()` to create the new object, but - * instead invokes a constructor of some class, it will always return an object of that - * class, regardless of whether it was actually called on an object of that type. - * - * This can cause problems if this `clone()` is inherited by a subclass, because then - * calling `clone()` on the subclass returns an instance of the superclass, instead of - * an instance of the subclass as it should. This violates the `clone()` contract. If the - * `clone()` method would call `super.clone()` instead of a constructor, then this issue - * would not happen, because `Object.clone()` would have created an object of the proper - * type. - * - * Of course, if the subclass implements `clone()` by creating the proper object itself, - * or the superclass with the suspicious `clone()` is `final` so that there cannot be any - * subclasses, then the mentioned problem can never occur. - * - * TODO: Ideas to improve this analysis: - * - It currently only checks whether a call to `super.clone()` exists inside `clone()`, - * but not whether it is actually reached/executed on all possible code paths. - * - It produces false-positives when super.clone() is called indirectly through a helper - * method. - * - It produces false-positives in cases where super.clone() doesn't need to be called: - * - if there are no subclasses, - * - or if the class is `final` so that there can be no subclasses, - * - or if all subclasses implement clone() themselves without calling super.clone(), - * i.e. the subclasses themselves take care of creating the proper object, so the - * superclass' clone() doesn't need to make sure to eventually call Object.clone() by - * calling super.clone(). - * - * @author Ralf Mitschke - * @author Daniel Klauer - */ -class CloneDoesNotCallSuperClone[Source] extends FindRealBugsAnalysis[Source] { - - override def description: String = - "Reports clone() methods that do not contain a call to super.clone()." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[MethodBasedReport[Source]] = { - - // For each clone() methods that doesn't contain a call to super.clone()... - for { - classFile <- project.allProjectClassFiles - if !classFile.isInterfaceDeclaration && !classFile.isAnnotationDeclaration - superClass <- classFile.superclassType.toSeq - method @ Method(_, "clone", JustReturnsObject) <- classFile.methods - if method.body.isDefined - if !method.body.get.instructions.exists { - case INVOKESPECIAL(`superClass`, "clone", JustReturnsObject) => true - case _ => false - } - } yield { - MethodBasedReport( - project.source(classFile.thisType), - Severity.Warning, - classFile.thisType, - method, - "Missing call to super.clone()" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/DoInsideDoPrivileged.scala b/TOOLS/bp/src/TODO/DoInsideDoPrivileged.scala deleted file mode 100644 index d2f27f1674..0000000000 --- a/TOOLS/bp/src/TODO/DoInsideDoPrivileged.scala +++ /dev/null @@ -1,66 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports invocations of `java.lang.reflect.Field|Method.setAccessible()` - * outside of doPrivileged blocks. - * - * @author Ralf Mitschke - * @author Roberts Kolosovs - */ -class DoInsideDoPrivileged[Source] extends FindRealBugsAnalysis[Source] { - - /** - * Returns a description text for this analysis. - * @return analysis description - */ - override def description: String = - "Detects calls to setAccessible() outside of doPrivileged blocks." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[MethodBasedReport[Source]] = { - - // For all classes referencing neither privilegedAction nor - // privilegedExceptionAction, look for methods that call setAccessible() on - // java/lang/reflect/{Field|Method}. - for { - classFile <- project.allProjectClassFiles - if !classFile.interfaceTypes.contains(ClassType.PrivilegedAction) && - !classFile.interfaceTypes.contains(ClassType.PrivilegedExceptionAction) - method @ MethodWithBody(body) <- classFile.methods - ( - _, - INVOKEVIRTUAL( - ClassType.Field | ClassType.Method, - "setAccessible", - _ - ) - ) <- body.associateWithIndex - } yield { - MethodBasedReport( - project.source(classFile.thisType), - Severity.Warning, - classFile.thisType, - method, - "Calls java.lang.reflect.Field|Method.setAccessible() outside of " + - "doPrivileged block" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/EqualsHashCodeContract.scala b/TOOLS/bp/src/TODO/EqualsHashCodeContract.scala deleted file mode 100644 index d7584384b2..0000000000 --- a/TOOLS/bp/src/TODO/EqualsHashCodeContract.scala +++ /dev/null @@ -1,78 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* - -/** - * This analysis reports violations of the contract defined in `java.lang.Object` w.r.t. - * the methods `equals` and `hashcode`. - * - * @author Michael Eichberg - */ -class EqualsHashCodeContract[Source] extends FindRealBugsAnalysis[Source] { - - /** - * Returns a description text for this analysis. - * @return analysis description - */ - override def description: String = "Finds violations of the equals-hashCode contract." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[ClassBasedReport[Source]] = { - - val mutex = new Object - var reports = List[ClassBasedReport[Source]]() - - for (classFile <- project.allProjectClassFiles) { - var definesEqualsMethod = false - var definesHashCodeMethod = false - for (method <- classFile.methods) method match { - case Method( - _, - "equals", - MethodDescriptor( - Seq(ClassType.Object), - BooleanType - ) - ) => - definesEqualsMethod = true - case Method( - _, - "hashCode", - MethodDescriptor( - Seq(), - IntegerType - ) - ) => - definesHashCodeMethod = true - case _ => - } - - if (definesEqualsMethod != definesHashCodeMethod) { - mutex.synchronized { - reports = ClassBasedReport( - project.source(classFile.thisType), - Severity.Error, - classFile.thisType, - "Does not satisfy java.lang.Object's equals-hashCode " + - "contract." - ) :: reports - } - } - } - reports - } -} diff --git a/TOOLS/bp/src/TODO/InefficientToArray.scala b/TOOLS/bp/src/TODO/InefficientToArray.scala deleted file mode 100644 index f395346eca..0000000000 --- a/TOOLS/bp/src/TODO/InefficientToArray.scala +++ /dev/null @@ -1,101 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports code that calls `SomeCollectionClassObject.toArray(T[])` with - * zero-length array argument, for example: - * {{{ - * myList.toArray(new T[0]) - * }}} - * This is bad because this `toArray()` call will never optimize for speed by re-using the - * array passed in as argument for returning the result. Such code should do something - * like this instead: - * {{{ - * myList.toArray(new T[myList.size()]) - * }}} - * - * @author Ralf Mitschke - * @author Daniel Klauer - */ -class InefficientToArray[Source] extends FindRealBugsAnalysis[Source] { - - /** - * Returns a description text for this analysis. - * @return analysis description - */ - override def description: String = "Reports inefficient toArray(T[]) calls" - - private val objectArrayType = ArrayType(ClassType.Object) - private val toArrayDescriptor = MethodDescriptor( - IndexedSeq(objectArrayType), - objectArrayType - ) - - /** - * Checks whether a type inherits from java/util/Collection or is java/util/List. - * @param classHierarchy class hierarchy to search in - * @param checkedType type, that is checked if it's a collection or list - * @return true, if checkedType is a collection or list, false otherwise - */ - private def isCollectionType( - classHierarchy: ClassHierarchy - )(checkedType: ReferenceType): Boolean = { - checkedType.isClassType && - (classHierarchy.isSubtypeOf( - checkedType.asClassType, - ClassType.Collection - ).isNoOrUnknown || checkedType == ClassType.List) - // TODO needs more heuristic or more analysis - } - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[LineAndColumnBasedReport[Source]] = { - - val classHierarchy: ClassHierarchy = project.classHierarchy - val isCollectionType = this.isCollectionType(classHierarchy) _ - - // In all method bodies, look for calls to "toArray()" with "new ...[0]" argument, - // on objects derived from the Collection classes. - for { - classFile <- project.allProjectClassFiles - method @ MethodWithBody(body) <- classFile.methods - pc <- body.matchTriple { - case ( - ICONST_0, - _: ANEWARRAY, - VirtualMethodInvocationInstruction(targetType, "toArray", `toArrayDescriptor`) - ) => - isCollectionType(targetType) - case _ => false - } - } yield { - LineAndColumnBasedReport( - project.source(classFile.thisType), - Severity.Info, - classFile.thisType, - method.descriptor, - method.name, - body.lineNumber(pc), - None, - "Calling x.toArray(new T[0]) is inefficient, should be " + - "x.toArray(new T[x.size()])" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/LongBitsToDoubleInvokedOnInt.scala b/TOOLS/bp/src/TODO/LongBitsToDoubleInvokedOnInt.scala deleted file mode 100644 index 52cdb142af..0000000000 --- a/TOOLS/bp/src/TODO/LongBitsToDoubleInvokedOnInt.scala +++ /dev/null @@ -1,73 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports code that passes a 32bit `int` to `Double.longBitsToDouble()`, - * which takes a 64bit `long`. Such code is broken, because an `int` is too small to hold - * a `double`'s bit pattern. - * - * The conversion from `int` to `long` may change the bit pattern (sign extension), and - * even if that doesn't happen the outcome won't necessarily be intended/expected. Perhaps - * `float` should have been used, instead of `double` - or `long` instead of `int`. - * - * @author Ralf Mitschke - * @author Daniel Klauer - */ -class LongBitsToDoubleInvokedOnInt[Source] extends FindRealBugsAnalysis[Source] { - - /** - * Returns a description text for this analysis. - * @return analysis description - */ - override def description: String = - "Reports code passing ints to Double.longBitsToDouble(long)" - - private val longBitsToDoubleDescriptor = - MethodDescriptor(IndexedSeq(LongType), ClassType.Double) - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[LineAndColumnBasedReport[Source]] = { - - // In all method bodies, look for occurrences of (I2L, INVOKESTATIC) instruction - // sequences, where the INVOKESTATIC is a call to - // java.lang.Double.longBitsToDouble(). - for { - classFile <- project.allProjectClassFiles - method @ MethodWithBody(body) <- classFile.methods - pc <- body.matchPair { - case ( - I2L, - INVOKESTATIC(`ClassType.Double`, "longBitsToDouble", `longBitsToDoubleDescriptor`) - ) => true - case _ => false - } - } yield { - LineAndColumnBasedReport( - project.source(classFile.thisType), - Severity.Error, - classFile.thisType, - method.descriptor, - method.name, - body.lineNumber(pc), - None, - "Passing int to Double.longBitsToDouble(long)" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/NonSerializableClassHasASerializableInnerClass.scala b/TOOLS/bp/src/TODO/NonSerializableClassHasASerializableInnerClass.scala deleted file mode 100644 index caef1c444a..0000000000 --- a/TOOLS/bp/src/TODO/NonSerializableClassHasASerializableInnerClass.scala +++ /dev/null @@ -1,70 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import bi.AccessFlagsMatcher -import br.* -import br.analyses.* - -/** - * This analysis reports outer classes that have (non-`static`) inner `Serializable` - * classes without themselves being `Serializable`. - * - * This situation is problematic, because the serialization of the inner class would - * require – due to the link to its outer class – always the serialization of the outer - * class which will, however, fail. - * - * ==Implementation Note== - * This analysis is implemented using the traditional approach where each analysis - * analyzes the project's resources on its own and fully controls the process. - * - * @author Michael Eichberg - */ -class NonSerializableClassHasASerializableInnerClass[Source] - extends FindRealBugsAnalysis[Source] { - - override def description: String = - "Identifies (non-static) inner classes that are serializable, " + - "but where the outer class is not." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[ClassBasedReport[Source]] = { - - import project.classHierarchy.isSubtypeOf - - val Serializable = ClassType.Serializable - - // If it's unknown, it's neither possible nor necessary to collect subtypes - if (project.classHierarchy.isUnknown(Serializable)) { - return Iterable.empty - } - - for { - serializableType <- project.classHierarchy.allSubtypes(Serializable, false) - classFile <- project.classFile(serializableType) - if !project.isLibraryType(classFile) - (outerType, AccessFlagsMatcher.NOT_STATIC()) <- classFile.outerType - /* if we know nothing about the class, then we never generate a warning */ - if isSubtypeOf(outerType, Serializable).isNo - } yield { - ClassBasedReport( - project.source(outerType), - Severity.Error, - outerType, - "Has a serializable non-static inner class (" + serializableType.toJava + - "), but is not serializable itself" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/SwingMethodInvokedInSwingThread.scala b/TOOLS/bp/src/TODO/SwingMethodInvokedInSwingThread.scala deleted file mode 100644 index 9f8339c1e8..0000000000 --- a/TOOLS/bp/src/TODO/SwingMethodInvokedInSwingThread.scala +++ /dev/null @@ -1,80 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports calls to `show()`, `pack()` or `setVisible()` methods on - * `javax/swing/` objects. - * - * These methods should only be called from inside the Swing background thread [1], since - * they themselves can cause events to be delivered. If they were called from outside the - * Swing thread, there could be dead locks etc. - * - * The proper way to call these methods is to implement a helper `java.lang.Runnable` - * class that does it, and pass an instance of it to `java.awt.EventQueue.invokeLater()`. - * - * [1]: [[http://en.wikipedia.org/wiki/Event_dispatching_thread]] - * - * @author Ralf Mitschke - * @author Peter Spieler - */ -class SwingMethodInvokedInSwingThread[Source] extends FindRealBugsAnalysis[Source] { - - override def description: String = - "Reports calls to certain Swing methods made from outside of the Swing thread." - - /** - * Runs this analysis on the given project. Reports the method calling swing functions - * outside of swing thread. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[MethodBasedReport[Source]] = { - - // Look for INVOKEVIRTUAL calls to show/pack/setVisible() methods on javax/swing/ - // objects from inside public static main() or methods containing "benchmark" in - // their name. - for { - classFile <- project.allProjectClassFiles - method @ MethodWithBody(body) <- classFile.methods - if (method.isPublic && - method.isStatic && - method.name == "main") || - (classFile.thisType.fqn.toLowerCase.indexOf("benchmark") >= 0) - (idx, INVOKEVIRTUAL(targetType, name, desc)) <- body.associateWithIndex - if targetType.isClassType && - targetType.asClassType.fqn.startsWith("javax/swing/") - if ((name, desc) match { - case ("show" | "pack", MethodDescriptor.NoArgsAndReturnVoid) => true - case ( - "setVisible", - MethodDescriptor( - IndexedSeq(BooleanType), - VoidType - ) - ) => true - case _ => false - }) - } yield { - MethodBasedReport( - project.source(classFile.thisType), - Severity.Error, - classFile.thisType, - method.descriptor, - method.name, - "Calls Swing methods while outside Swing thread" - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/SyncSetUnsyncGet.scala b/TOOLS/bp/src/TODO/SyncSetUnsyncGet.scala deleted file mode 100644 index 47f86535cd..0000000000 --- a/TOOLS/bp/src/TODO/SyncSetUnsyncGet.scala +++ /dev/null @@ -1,89 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* - -/** - * This analysis reports setter/getter pairs where the set method is synchronized and the - * get method is not synchronized. - * - * This indicates a bug because in a multi-threaded environment, the JVM may cache a - * field's value instead of reading it from memory everytime the getter is called. This - * means the getter may return a cached value which may differ from the value in memory. - * This must be prevented by using a synchronized getter, which guarantees to return the - * proper value. - * - * @author Michael Eichberg - * @author Daniel Klauer - */ -object SyncSetUnsyncGet { - - override def description: String = - "Reports getters that are unsynchronized while the setter is synchronized." - - /** - * Runs this analysis on the given project. Reports unsynced getter methods. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def apply( - project: SomeProject, - parameters: Seq[String] = List.empty, - isInterrupted: () => Boolean - ): Iterable[MethodBasedReport[Source]] = { - - // Look through non-static methods of all classes, collecting lists of - // unsynchronized getters and synchronized setters. - var unSyncedGetters = Map[String, Method]() - var syncedSetters = Map[String, (ClassFile, Method)]() - for { - classFile <- project.allProjectClassFiles - if !classFile.isInterfaceDeclaration - method <- classFile.methods - if !method.isAbstract - if !method.isStatic - if !method.isNative - if !method.isPrivate - } { - if (method.name.startsWith("get") && - !method.isSynchronized && - method.parameterTypes.length == 0 && - method.returnType != VoidType - ) { - unSyncedGetters += (( - classFile.thisType.fqn + "." + method.name.substring(3), - method - )) - } else if (method.name.startsWith("set") && - method.isSynchronized && - method.parameterTypes.length == 1 && - method.returnType == VoidType - ) { - syncedSetters += (( - classFile.thisType.fqn + "." + method.name.substring(3), - (classFile, method) - )) - } - } - - // Report only cases where both setter/getter for the same field were found. - // setters/getters that do not belong together are ignored. - for (field <- syncedSetters.keySet.intersect(unSyncedGetters.keySet)) yield { - val classFile = syncedSetters(field)._1 - val syncSet = syncedSetters(field)._2 - val unsyncGet = unSyncedGetters(field) - MethodBasedReport( - project.source(classFile.thisType), - Severity.Warning, - classFile.thisType, - unsyncGet, - "Is not synchronized like " + syncSet.name - ) - } - } -} diff --git a/TOOLS/bp/src/TODO/UrUninitReadCalledFromSuperConstructor.scala b/TOOLS/bp/src/TODO/UrUninitReadCalledFromSuperConstructor.scala deleted file mode 100644 index 79b325c7ec..0000000000 --- a/TOOLS/bp/src/TODO/UrUninitReadCalledFromSuperConstructor.scala +++ /dev/null @@ -1,216 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package frb -package analyses - -import br.* -import br.analyses.* -import br.instructions.* - -/** - * This analysis reports methods which access their class' fields and are called by - * their superclass' constructor. - * - * This is a bug, because while the super constructor is running, the derived class' - * constructor hasn't run yet, and the derived class' fields aren't initialized yet. - * Thus it's not safe to access them, and it's not safe for the superclass' constructor - * to call a method in the subclass which does that. - * - * TODO: Ideas for improvement: - * - Should also check all methods called from such methods - * - Don't complain about accesses to Static Final fields from such methods, assuming - * such fields don't need initialization by a constructor (find out whether that's - * correct) - * - Don't complain about accesses to fields if they don't have a specific initializer, - * then the constructor wouldn't do anything anyways and it doesn't make a difference - * whether the field is being accessed earlier or not. - * - Don't complain if the field is written before being read (or written only and never - * read) in such methods. If it's written first, then there's no "uninitialized" access. - * - Test on real Java projects and check whether/how many false-positives are reported - * - Should ignore methods that don't rely on any uninitialized fields. - * - * We only need to check abstract super classes, but no super interfaces here, because - * this analysis checks for a super constructor containing code calling the overridden - * method. Interfaces, however, can't have constructors. - * - * @author Roberts Kolosovs - * @author Ralf Mitschke - * @author Daniel Klauer - */ -class UrUninitReadCalledFromSuperConstructor[Source] extends FindRealBugsAnalysis[Source] { - - override def description: String = - "Reports methods that access their class'es static fields and are called by a " + - "super class constructor." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def doAnalyze( - project: Project[Source], - parameters: Seq[String] = Seq.empty, - isInterrupted: () => Boolean - ): Iterable[SourceLocationBasedReport[Source]] = { - - import project.classHierarchy - - /* - * Returns true if classFile declares the given Field - * - * @param classFile The ClassFile that is supposed to declare a given field - * @param name The name of the field supposedly declared. - * @param fieldType Type of the field supposedly declared. - */ - def declaresField( - classFile: ClassFile, - name: String, - fieldType: FieldType - ): Boolean = { - classFile.fields.exists { - case Field(_, `name`, `fieldType`) => true - case _ => false - } - } - - /* - * Check whether a method overrides a method in any super class. - * - * @param classFile Subclass with the supposed overriding method. - * @param method Method to be checked for being an overriding method. - * @return True if method in classFile is overriding a method in some superclass. - */ - def methodOverridesAnything(classFile: ClassFile, method: Method): Boolean = { - classHierarchy.allSupertypes(classFile.thisType). - filter(!classHierarchy.isInterface(_)). - exists( - classHierarchy.lookupMethodDefinition( - _, - method.name, - method.descriptor, - project - ).isDefined - ) - } - - /* - * Checks whether the source method contains calls to the given target method. - * - * @param source The method which may contain calls to other methods. - * @param targetType Type of the method supposedly called. - * @param target The name of the method supposedly called. - * @return True if source contains a call to target method of the given type. - */ - def calls(source: Method, targetType: Type, target: Method): Boolean = { - source.body.get.instructions.exists { - case MethodInvocationInstruction( - `targetType`, - target.name, - target.descriptor - ) => true - case _ => false - } - } - - var inconsistencyReports: Set[SourceLocationBasedReport[Source]] = Set.empty - - /* - * Looks up a method reference from an `INVOKESPECIAL` instruction by using - * `resolveMethodReference`, unless the given declaring class is an interface. - * - * @param classFile The class file containing the `INVOKESPECIAL` instruction. - * @param constructor The method containing the `INVOKESPECIAL` instruction. - * @param pc The `PC` of the `INVOKESPECIAL` instruction. - * @param declaringClass The class type referenced by the `INVOKESPECIAL`. - * @param name The method name referenced by the `INVOKESPECIAL`. - * @param descriptor The method signature referenced by the `INVOKESPECIAL`. - * @return The referenced `Method` or `None`. - */ - def maybeResolveMethodReference( - classFile: ClassFile, - constructor: Method, - pc: PC, - declaringClass: ClassType, - name: String, - descriptor: MethodDescriptor - ): Option[Method] = { - - // Excluding interfaces here, because resolveMethodReference() can't be called - // on interfaces, and normally, constructors are not being called on - // interfaces anyways. However, we've found a class file in the Qualitas - // Corpus containing an INVOKESPECIAL doing a constructor call on an - // interface. In this situation, we report that the project is inconsistent. - if (classHierarchy.isInterface(declaringClass)) { - inconsistencyReports += - LineAndColumnBasedReport( - project.source(classFile.thisType), - Severity.Error, - classFile.thisType, - constructor.descriptor, - constructor.name, - constructor.body.get.lineNumber(pc), - None, - "INVOKESPECIAL on interface type; inconsistent project." - ) - None - } else { - classHierarchy. - resolveMethodReference(declaringClass, name, descriptor, project) - } - } - - /* - * Returns the super class constructor called by the given constructor, or None. - * - * @param constructor Constructor which may or may not call a superconstructor. - * @return The first superconstructor to be called or None. - */ - def findCalledSuperConstructor( - classFile: ClassFile, - constructor: Method - ): Option[Method] = { - constructor.body.get.associateWithIndex.collectFirst({ - case (pc, INVOKESPECIAL(typ, name, desc)) => maybeResolveMethodReference( - classFile, - constructor, - pc, - typ, - name, - desc - ) - }).flatten - } - - var reports: Set[SourceLocationBasedReport[Source]] = Set.empty - - for { - classFile <- project.allProjectClassFiles - method @ MethodWithBody(body) <- classFile.methods - if !method.isStatic && - !method.isConstructor && - methodOverridesAnything(classFile, method) - GETFIELD(declaringClass, fieldName, fieldType) <- body.instructions - constructor <- classFile.constructors - if declaresField(classFile, fieldName, fieldType) - superConstructor <- findCalledSuperConstructor(classFile, constructor) - superClass = project.classFile(superConstructor) - if superConstructor.body.isDefined && - calls(superConstructor, superClass.thisType, method) - } { - reports += - MethodBasedReport( - project.source(classFile.thisType), - Severity.Error, - classFile.thisType, - method, - "Called by super constructor (" + superClass.thisType.toJava + "), " + - "while the class' fields are still uninitialized" - ) - } - - inconsistencyReports ++ reports - } -} diff --git a/TOOLS/bp/src/main/resources/application.conf b/TOOLS/bp/src/main/resources/application.conf deleted file mode 100644 index b54dad96fc..0000000000 --- a/TOOLS/bp/src/main/resources/application.conf +++ /dev/null @@ -1,34 +0,0 @@ -# Configuration for the BugPicker tool - -org.opalj { - - bugpicker.analysisParameter { - maxEvalTime = 10000 // default = 10000 - maxEvalFactor = 1.75d // default = 1.75d - maxCardinalityOfIntegerRanges = 16 // default = 16 - maxCardinalityOfLongSets = 2 // default = 2 - fpcfAnalyses = [ - "FieldAssignabilityAnalysis", - "MethodAccessibilityAnalysis", - "InstantiabilityAnalysis", - "CallableFromClassesInOtherPackagesAnalysis", - "PurityAnalysis" - ] - } - - bugpicker.analysis { - RootBugPickerAnalysisDomain { - maxCallChainLength = 1 // default = 1 - } - - FallbackBugPickerAnalysisDomain { - maxCardinalityOfIntegerRanges = 8 - maxCardinalityOfLongSets = 3 - } - } - - callgraph { - # specify additional entry points (e.g. called in native code, via reflection or by an framework) - entryPoints = [] - } -} diff --git a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.css b/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.css deleted file mode 100644 index a0e3f2080d..0000000000 --- a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.css +++ /dev/null @@ -1,117 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -body{ - margin:0px; - font-family: sans-serif; - font-size: 14px; -} - -h1{ - font-size:1.3em; -} - -h2,h3,h4,h5,h6{ - font-size:1.2em; -} - -details{ - padding:1em; -} - -summary{ - padding:0.5em; - background-color: rgb(128, 181, 235); - color:white; -} - -abbr { - border-bottom: 1px dotted black; -} - -.method_name { - color: rgb(19, 5, 248); - font-style: italic; -} - -.type { - color: rgb(11, 117, 11); -} - -.class_type{ - text-decoration: underline; -} - -.base_type { - font-style: italic; -} - -dl{ - margin: 0; -} -dt{ - font-weight: 300; - line-height: 1.0em; -} -dd{ - display:block; - margin-top: -1em; - margin-left: 6em; - margin-bottom: 0.3em; -} - -a.onclick{ - background-color: rgb(19, 91, 204); - padding: 0.3em; - line-height: 1em; - border: 1px solid; - border-radius: 3px; - margin: 0.3em; - width: 1em; - height: 1em; - text-align: center; - display: inline-block; -} - -a.onclick:hover{ - color: yellow; -} - -span.operator{ - font-weight: bolder; -} - -span.value{ - color: rgb(215, 145, 4); -} - -span.keyword{ - font-style: italic; -} - -table{ - white-space: inherit; - line-height: inherit; - font-weight: inherit; - font-size: inherit; - font-variant: inherit; - font-style: inherit; - border: 0; - margin: 0; - padding: 0; -} - -th{ - font-weight: bolder; - text-align: left; - word-wrap: break-word; -} - -td{ - word-break:break-all; - word-wrap: break-word; - vertical-align:top; -} - -.warning{ - color: rgb(242, 112, 46); - font-size: smaller; -} \ No newline at end of file diff --git a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.js b/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.js deleted file mode 100644 index 468f63b728..0000000000 --- a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/html.js +++ /dev/null @@ -1,2 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -NodeList.prototype.forEach = Array.prototype.forEach; diff --git a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.css b/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.css deleted file mode 100644 index b182c92dda..0000000000 --- a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.css +++ /dev/null @@ -1,123 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -/* details fallback */ -details { - display: block; -} - -.noDetails summary { - display: inherit; -} - -.noDetails details:not ([open] ) >*:not (:first-child ) { - display: none; -} - -/*VIEW SPECIFIC*/ -div#analysis_controls { - position: fixed; - top: 0px; - padding: 1em; - height: 0.9em; - margin: 0px; - width: 100%; - overflow: hidden; - background-color: rgba(8, 114, 215, 0.95); - color: white; -} - -div#analysis_controls div { - margin-bottom: .3em; -} - -div#analysis_controls div.issue_filter { - border: 1px white dotted; - margin-right: 2em; -} - -div#analysis_controls:hover { - height: initial; -} - -div#analysis_controls span#search_box { - position: absolute; - right: 50px; - top: 0px; - margin: 10px 20px; -} - -input#relevance { - transform: translate(0px, 6px); - -webkit-transform: translate(0px, 6px); - -moz-transform: translate(0px, 6px); -} - -div#analysis_parameters { - padding: 0em; - margin-top: 3em; -} - -div#analysis_results { - padding: 0em; -} - -dt.analysis { - color: rgb(78, 78, 78); -} -dt.analysis + dd { - color: rgb(78, 78, 78); -} - -.an_issue { - padding: 0.5em; - background-color: rgb(241, 244, 255); - border: 1px solid rgb(224, 222, 235); - border-top: 0px; - display: none; - word-break: break-word; -} - -div.an_issue.issue_visible { - display: block; -} - -.issue { - margin-top: 1em; -} - -.issue_message { - color: rgb(94, 94, 94); - font-weight: 300; -} - -div.issue_additional_info { - border-top: 1px dashed rgb(200, 200, 200); - margin-top: 0.3em; - padding-top: 0.3em; - font-weight: 300; -} - -div.declaring_class { - margin-left: 8em; -} - -div.declaring_class:before { - content: "class:"; -} - -details.locals { - padding: 0; - background-color: rgba(174, 177, 255, 0.24); - border: 1px solid rgb(172, 172, 205); -} - -details#analysis_parameters_summary summary { - background-color: rgb(223, 151, 75); -} - -details#analysis_parameters_summary ul { - background-color: rgb(247, 224, 197); - padding-top: 0.3em; - padding-bottom: 0.3em; - margin: 0; -} \ No newline at end of file diff --git a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.js b/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.js deleted file mode 100644 index e996b8bd14..0000000000 --- a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/report.js +++ /dev/null @@ -1,399 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -"use strict"; - -/* options for JSHint code quality: */ -/* global performance */ -if (typeof String.prototype.startsWith != 'function') { - String.prototype.startsWith = function(str) { - return this.indexOf(str) === 0; - }; -} - -function toggleDetailsOpen(event) { - var details = event.target.parentNode; - if (details.hasAttribute("open")) { - details.removeAttribute("open"); - } else { - details.setAttribute("open", ""); - } -} - -document.addEventListener("DOMContentLoaded", function(e) { - if (!('open' in document.createElement("details"))) { - e.target.documentElement.classList.add("noDetails"); - var parameters = document - .querySelector("details#analysis_parameters_summary"); - parameters.setAttribute("open", ""); - var summarys = document.querySelectorAll("details summary"); - summarys.forEach(function(e) { - e.addEventListener("click", toggleDetailsOpen); - }); - } -}, false); - -var debug_OFF = 0, debug_ERROR = -10, debug_WARNING = -20, debug_INFO = -30, debug_TRACE = -40, debug_ALL = -2147483648; -var debug = debug_OFF; - -function log(something, loglevel) { - if (loglevel === undefined) { - loglevel = debug_INFO; - } - if (debug > loglevel) - return; -// comment in for WebView Debug messages. (Also add the div in BugPickerAnalysis to the HTML) -// document.getElementById('debug_info').innerHTML = document -// .getElementById('debug_info').innerHTML -// + "
" + something; - console.log(something); -} - -/** - * Manages the active filters for the displayed issues. - * - * @namespace IssueFilter - * @author Tobias Becker - */ -var IssueFilter = function() { - /** - * The node that displays how many issues are currently displayed. - * - * @memberof IssueFilter - */ - var issuesDisplayNode; - - /** - * All issues paired with their containing package. - * - * @memberof IssueFilter - */ - var packagesWithIssues = []; - - /** - * The filter functions. - * - * @memberof IssueFilter - */ - var filterFuns = []; - - /** - * The initialization functions of the filter. Will be called once, when - * DOMContentLoaded-Event is fired - * - * @memberof IssueFilter - */ - var initFuns = []; - - /** - * Indicates if the filters are already initialized. - * - * @memberof IssueFilter - */ - var init = false; - var updating = false; - - function initialize() { - log("[IssueFilter] Initialization started."); - log(initFuns); - initFuns.forEach(function(f) { - log("START: " + f); - f(); - log("END: " + f); - }); - log("[IssueFilter] InitFuns executed."); - issuesDisplayNode = document.querySelector("#issues_displayed"); - var packages = document.querySelector("#analysis_results") - .querySelectorAll("details.package_summary"); - packages.forEach(function(p) { - packagesWithIssues.push([ p, p.querySelectorAll(".an_issue") ]); - }); - init = true; - log("[IssueFilter] All Filter initialized."); - openAllPackages(); - IssueFilter.update(); - } - - document.addEventListener("DOMContentLoaded", initialize, false); - - var object = { - - /** - * Registers a new Filter. - * - * @param {Function} - * Initialization function. Will be called when the - * DOMContentLoaded-Event is fired or instantly if it already - * fired. - * @param {Function} - * The filter function. Will be passed a single issue and - * should return a boolean indicating if the issue should be - * displayed (true) or not (false) - * - * @memberof IssueFilter - * @inner - */ - register : function(initFun, displayIssue) { - if (!(initFun instanceof Function)) { - log("[IssueFilter] register: Invalid Parameter 'initFun' " - + initFun, debug_ERROR); - return; - } - if (!(displayIssue instanceof Function)) { - log("[IssueFilter] register: Invalid Parameter 'displayIssue '" - + displayIssue, debug_ERROR); - return; - } - filterFuns.push(displayIssue); - if (init) - initFun(); - else - initFuns.push(initFun); - }, - - /** - * Updates the displayed issues by applying all filters. If an issue is - * considered not to be displayed by a filter, it will not be passed to - * the remaining filters. - * - * @memberof IssueFilter - * @inner - */ - update : function() { - if (!init) { - log( - "[IssueFilter] Update cancelled. IssueFilter not yet initialzed!", - debug_WARNING); - return; - } - if (updating) { - log("[IssueFilter] Update cancelled. Already updating!", - debug_WARNING); - return; - } - updating = true; - log("[IssueFilter] Update started."); - var startTime = performance.now(); - var issue_counter_all = 0; - log("[IssueFilter] Number of filter functions: " - + filterFuns.length); - packagesWithIssues - .forEach(function(packageIssue, pIndex) { - var thePackage = packageIssue[0]; - var issues = packageIssue[1]; - var issue_counter_package = 0; - issues.forEach(function(issue, index) { - log("[IssueFilter] Processing issue " + (index + 1) - + "/" + issues.length + " in package " - + (pIndex + 1) + "/" - + packagesWithIssues.length, debug_TRACE); - var display = true; - var i = 0; - while (display && i < filterFuns.length) { - log("[IssueFilter] Starting filter #" + i, - debug_TRACE); - display = filterFuns[i](issue); - if (typeof display !== "boolean") { - log("[IssueFilter] Filter #" + i - + " returned non boolean", - debug_TRACE); - } - log("[IssueFilter] Finished filter #" + i, - debug_TRACE); - i++; - } - - if (display) { - issue.classList.add("issue_visible"); - issue_counter_package++; - } else { - issue.classList.remove("issue_visible"); - } - }); - if (issue_counter_package > 0) { - thePackage.style.display = "block"; - } else { - thePackage.style.display = "none"; - } - issue_counter_all += issue_counter_package; - // update number of displayed issues in package summary: - var text = thePackage - .querySelector("summary.package_summary"); - var textNode = text - .querySelector("span.package_issues"); - if (!textNode) { - log("[IssueFilter] Creating package-textNode", - debug_TRACE); - text.innerHTML = text.innerHTML - + " "; - textNode = text - .querySelector("span.package_issues"); - } - textNode.innerHTML = " (Issues: " - + issue_counter_package + ")"; - }); - issuesDisplayNode.innerHTML = " [Relevance ≥ " - + inputRelevance.value + "] " + issue_counter_all; - var endTime = performance.now(); - log("[IssueFilter] Update ended. Took " + (endTime - startTime) - + " milliseconds."); - log("[IssueFilter] Applied " + filterFuns.length + " Filter"); - updating = false; - }, - - /** - * Convenience function to add the IssueFilter.update as an - * EventListener. - * - * @memberof IssueFilter - * @inner - */ - addListener : function(listenTarget, listenType) { - if (!init) { - log( - "[IssueFilter] addListener called. IssueFilter not yet initialized.", - debug_INFO); - } - if (!(listenTarget instanceof HTMLElement)) { - log( - "[IssueFilter] addListener: Invalid Parameter 'listenTarget' " - + listenTarget, debug_ERROR); - return; - } - if (typeof listenType !== "string") { - log( - "[IssueFilter] addListener: Invalid Parameter 'listenType' " - + listenType, debug_ERROR); - return; - } - listenTarget.addEventListener(listenType, this.update, false); - } - }; - return object; -}(); - -// Filter: relevance -// -var inputRelevance; -IssueFilter.register(function() { - inputRelevance = document.querySelector("input#relevance"); - inputRelevance.value = 75; - IssueFilter.addListener(inputRelevance, "change"); - log("[RelevanceFilter] Initialized."); -}, function(issue) { - return (issue.dataset.relevance >= inputRelevance.valueAsNumber); -}); - -/** - * Function which removes duplicates from an array. - * - * @param inputArray, which possibly includes duplicate values. - * @returns {Array}, an array with unique values. - */ -function removeDuplicates(inputArray) { - var seen = {}; - var out = []; - var len = inputArray.length; - var j = 0; - for (var i = 0; i < len; i++) { - var item = inputArray[i]; - if (seen[item] !== 1) { - seen[item] = 1; - out[j++] = item; - } - } - return out; -} - -// Filter: data-kind & data-category -// -function initDataFilter(dataType) { - var allValues = []; - - document.querySelectorAll('[data-' + dataType + ']').forEach( - function(entry) { - allValues = removeDuplicates(allValues.concat(entry.getAttribute("data-" + dataType) - .split(' '))); - }); - - document.querySelector("#filter_data-" + dataType).innerHTML = arrayJoin( - allValues.sort(), function(i, e) { - var name = "filter-data-" + dataType; - var id = name + i; - return "" + ""; - }); - document.querySelectorAll("input[name=filter-data-" + dataType + "]") - .forEach(function(input) { - IssueFilter.addListener(input, "change"); - }); -} - -function commonValue(a, b) { - var t; - if (b.length > a.length) { - t = b; - b = a; - a = t; - } - return a.filter(function(e) { - return (b.indexOf(e) !== -1); - }).length > 0; -} - -var inputDataKind; -IssueFilter.register(function() { - initDataFilter("kind"); - inputDataKind = document.querySelectorAll("input[name=filter-data-kind]"); - log("[DataKindFilter] Initialized."); -}, function(issue) { - var checked = []; - inputDataKind.forEach(function(input) { - if (input.checked) - checked.push(input.value); - }); - var actual = issue.getAttribute("data-kind").split(" "); - return commonValue(actual, checked); -}); - -var inputDataCategory; -IssueFilter.register(function() { - initDataFilter("category"); - inputDataCategory = document - .querySelectorAll("input[name=filter-data-category]"); - log("[DataCategoryFilter] Initialized."); -}, function(issue) { - var checked = []; - inputDataCategory.forEach(function(input) { - if (input.checked) - checked.push(input.value); - }); - var actual = issue.getAttribute("data-category").split(" "); - return commonValue(actual, checked); -}); - -function openAllPackages() { - document.querySelectorAll('div#analysis_results > details').forEach( - function(e) { - e.setAttribute('open', ''); - }); -} - -function closeAllPackages() { - document.querySelectorAll('div#analysis_results > details').forEach( - function(e) { - e.removeAttribute('open'); - }); -} - -/* - * Works similar to the join-method of Array, but uses a function for the join - */ -function arrayJoin(array, joinFunc) { - var arrayJoinIntern = function(internArray, index) { - var element = internArray.shift(); - return internArray.length > 0 ? joinFunc(index, element) - + arrayJoinIntern(internArray, index + 1) : joinFunc(index, - element); - }; - return arrayJoinIntern(array, 0); -} \ No newline at end of file diff --git a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/search.js b/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/search.js deleted file mode 100644 index 665f900404..0000000000 --- a/TOOLS/bp/src/main/resources/org/opalj/bugpicker/core/search.js +++ /dev/null @@ -1,92 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -"use strict"; - -/* options for JSHint code quality: */ -/* global performance */ - -// quotes RegExp special character in a String -RegExp.quote = function (str) { - return (str + '').replace(/[.?*+^$[\]\\(){}|-]/g, "\\$&"); -}; - -// Filter: text search -function findTextInIssue(issue, text, category) { - - var erg = false; - var rx = new RegExp(RegExp.quote(text), "gi"); - var processDD = function (dd) { - var attributes = dd.attributes; - var i = 0; - while (i < attributes.length) { - var attr = attributes[i]; - if (attr.name.startsWith("data-")) { - var attrText = attr.value.toLowerCase().replace(/\//g, "."); - if (attrText.indexOf(text.toLowerCase()) >= 0) { - erg = true; - } - } - i++; - } - var nodeIterator = document.createNodeIterator(dd, NodeFilter.SHOW_TEXT); - var currentNode; - while (currentNode = nodeIterator.nextNode()) { - if (currentNode.textContent.toLowerCase().indexOf(text.toLowerCase()) >= 0) { - erg = true; - } - } - }; - if (category === undefined) { - issue.querySelectorAll("dd:not(.issue_message)").forEach(processDD); - } else { - processDD(category); - } - return erg; -} - -var searchField; -var searchCategories = []; -IssueFilter.register( - function () { - searchField = document.querySelector("#search_field"); - // delay the event-listener - searchField.addEventListener("input", function () { - var searchString = searchField.value; - setTimeout(function () { - if (searchString == searchField.value) - IssueFilter.update(); - }, 300); - }, false); - document.querySelectorAll("dt").forEach(function (dt) { - if (searchCategories.indexOf(dt.innerText.replace(/\W/g, '')) < 0) - searchCategories.push(dt.innerText.replace(/\W/g, '')); - }); - searchField.disabled = false; - log("[TextSearchFilter] Initialized."); - }, - function (issue) { - var searchString = searchField.value; - if (searchString.length === 0) - return true; - var categoryLength = searchString.indexOf(":"); - var category = searchString.substring(0, categoryLength); - if (searchCategories.indexOf(category) !== -1) { - searchString = searchString.slice(categoryLength + 1); - } else { - category = ""; - } - var found = false; - if (category !== "") { - var elem; - issue.querySelectorAll("dt").forEach(function (dt) { - if (dt.innerText.replace(/\W/g, '') == category) { - elem = dt.nextSibling; - while (elem.nodeName != "DD") - elem = elem.nextSibling; - } - }); - found = findTextInIssue(issue, searchString, elem); - } else { - found = findTextInIssue(issue, searchString); - } - return found; - }); \ No newline at end of file diff --git a/TOOLS/bp/src/main/resources/reference.conf b/TOOLS/bp/src/main/resources/reference.conf deleted file mode 100644 index 1ed95b4375..0000000000 --- a/TOOLS/bp/src/main/resources/reference.conf +++ /dev/null @@ -1,3 +0,0 @@ -# Specifies the regexp that the packages for which issues should be reported has to be matched. -# If you use the regexp .* all issues will be reported. -org.opalj.bugpicker.issues.packages=".*" \ No newline at end of file diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/Console.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/Console.scala deleted file mode 100644 index e879dab1cd..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/Console.scala +++ /dev/null @@ -1,330 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core - -import java.io.File -import java.lang.Integer.parseInt -import java.net.URL -import java.nio.charset.StandardCharsets -import java.nio.file.Files -import scala.xml.Node - -import com.typesafe.config.Config - -import org.opalj.ai.util.XHTML -import org.opalj.br.analyses.Analysis -import org.opalj.br.analyses.AnalysisApplication -import org.opalj.br.analyses.BasicReport -import org.opalj.br.analyses.ProgressManagement -import org.opalj.br.analyses.Project -import org.opalj.bugpicker.core.analyses.BugPickerAnalysis -import org.opalj.bugpicker.core.analyses.BugPickerAnalysis.resultsAsXHTML -import org.opalj.io.process -import org.opalj.io.writeAndOpen -import org.opalj.issues.IssueKind -import org.opalj.log.GlobalLogContext -import org.opalj.log.LogContext -import org.opalj.log.OPALLogger - -/** - * The command line interface of the bug picker. - * - * @author Michael Eichberg - */ -object Console extends Analysis[URL, BasicReport] with AnalysisApplication { - - val analysis = this - - final val IDLFileOutputNameMatcher = """-idl=([\w-_\.\:/\\]+)""".r - - final val HTMLFileOutputNameMatcher = """-html=([\w-_\.\:/\\]+)""".r - - final val DebugFileOutputNameMatcher = """-debug=([\w-_\.\:/\\]+)""".r - - final val MinRelevancePattern = """-minRelevance=(\d\d?)""".r - final val MinRelevance = 0 - - final val IssueKindsPattern = """-kinds=([\w_,]+)""".r - - override def main(unparsedArgs: Array[String]): Unit = { - try { - super.main(unparsedArgs) - } catch { - case t: Throwable => t.printStackTrace() - } - } - - override final val analysisSpecificParametersDescription: String = - """[-maxEvalFactor= determines the maximum effort that - | the analysis will spend when analyzing a specific method. The effort is - | always relative to the size of the method. For the vast majority of methods - | a value between 0.5 and 1.5 is sufficient to completely analyze a single - | method using the default settings. - | A value greater than 1.5 can already lead to very long evaluation times. - | If the threshold is exceeded the analysis of the method is aborted and no - | result can be drawn.] - |[-maxEvalTime= determines the time (in ms) that the analysis - | is allowed to take for one method before the analysis is terminated.] - |[-maxCardinalityOfIntegerRanges= basically determines for each integer - | value how long the value is "precisely" tracked. Internally the analysis - | computes the range of values that an integer value may have at runtime. The - | maximum size/cardinality of this range is controlled by this setting. If - | the range is exceeded the precise tracking of the respective value is - | terminated. - | Increasing this value may significantly increase the analysis time and - | may require the increase of maxEvalFactor.] - |[-maxCardinalityOfLongSets= basically determines for each long - | value how long the value is "precisely" tracked. - | The maximum size/cardinality of this set is controlled by this setting. If - | the set's size is tool large the precise tracking of the respective value is - | terminated. - | Increasing this value may significantly increase the analysis time and - | may require the increase of maxEvalFactor.] | - |[-maxCallChainLength= determines the maximum length of the call chain - | that is analyzed. - | If you increase this value by one, it is typically also necessary - | to increase the maxEvalFactor by a factor of 2 to 3. Otherwise it - | may happen that many analyses are aborted because the evaluation time - | is exhausted and – overall – the analysis reports less issues!] - |[-minRelevance= the minimum relevance of the shown issues.] - |[-kinds= a comma seperated list of issue kinds - | that should be reported.] - |[-eclipse creates an eclipse console compatible output.] - |[-idl creates an idl report.] - |[-html[=] generates an HTML report which is written to the optionally - | specified location.] - |[-debug[=] turns on the debug mode (more information are logged and - | internal, recoverable exceptions are logged) the report is optionally - | written to the specified location.]""".stripMargin('|') - - private final val bugPickerAnalysis = new BugPickerAnalysis - - override def title: String = bugPickerAnalysis.title - - override def description: String = bugPickerAnalysis.description - - private var cpFiles: Iterable[File] = null - private var libcpFiles: Iterable[File] = null - - override def setupProject( - cpFiles: Iterable[File], - libcpFiles: Iterable[File], - completelyLoadLibraries: Boolean, - analysisMode: AnalysisMode, - fallbackConfiguration: Config - )( - implicit initialLogContext: LogContext - ): Project[URL] = { - this.cpFiles = cpFiles - this.libcpFiles = libcpFiles - super.setupProject( - cpFiles, - libcpFiles, - completelyLoadLibraries, - analysisMode, - fallbackConfiguration - ) - } - - override def analyze( - theProject: Project[URL], - parameters: Seq[String], - initProgressManagement: (Int) => ProgressManagement - ): BasicReport = { - - import theProject.logContext - - OPALLogger.info("analysis progress", "starting analysis") - - val (analysisTime, issues0, exceptions) = - bugPickerAnalysis.analyze(theProject, parameters, initProgressManagement) - - // - // PREPARE THE GENERATION OF THE REPORT OF THE FOUND ISSUES - // (HTML/Eclipse) - // - - // Filter the report - val minRelevance: Int = - parameters. - collectFirst { case MinRelevancePattern(i) => parseInt(i) }. - getOrElse(MinRelevance) - val issues1 = issues0.filter { i => i.relevance.value >= minRelevance } - - val issues = parameters.collectFirst { case IssueKindsPattern(ks) => ks } match { - case Some(ks) => - val relevantKinds = ks.split(',').map(_.replace('_', ' ')).toSet - issues1.filter(issue => (issue.kinds intersect (relevantKinds)).nonEmpty) - case None => - issues1 - } - - // Generate the report well suited for the eclipse console - // - if (parameters.contains("-eclipse")) { - val formattedIssues = issues.map { issue => issue.toEclipseConsoleString } - println(formattedIssues.toSeq.sorted.mkString("\n")) - } - - // Generate a report using the bug description language - // - if (parameters.contains("-idl")) { - val formattedIssues = issues.map { issue => issue.toIDL.toString } - println(s"Analysis of " + cpFiles.mkString(", ")) - println("Parameters") - println(parameters.mkString("\n")) - println("Issues") - val idlReport = "[" + formattedIssues.toSeq.mkString(",\n") + "]" - println(idlReport) - - writeAndOpen(idlReport, "BugPickerAnalysisResults", ".json") - } - - // Generate the HTML report - // - - lazy val htmlReport = resultsAsXHTML(parameters, issues, showSearch = false, analysisTime).toString - parameters.collectFirst { case HTMLFileOutputNameMatcher(name) => name } match { - case Some(fileName) => - val file = new File(fileName).toPath - process { Files.newBufferedWriter(file, StandardCharsets.UTF_8) } { fos => - fos.write(htmlReport, 0, htmlReport.length) - } - case _ => // Nothing to do - } - if (parameters.contains("-html")) { - writeAndOpen(htmlReport, "BugPickerAnalysisResults", ".html") - } - - // - // PREPARE THE GENERATION OF THE REPORT OF THE OCCURED EXCEPTIONS - // - if (exceptions.nonEmpty) { - OPALLogger.error( - "internal error", - s"the analysis threw ${exceptions.size} exceptions" - ) - exceptions.foreach { e => - OPALLogger.error( - "internal error", - "the analysis failed", - e - ) - } - - var exceptionsReport: Node = null - def getExceptionsReport = { - if (exceptionsReport eq null) { - val exceptionNodes = - exceptions.take(10).map { e =>

{XHTML.throwableToXHTML(e)}

} - exceptionsReport = - XHTML.createXHTML( - Some(s"${exceptions.size}/${exceptionNodes.size} Thrown Exceptions"), -
{exceptionNodes}
- ) - } - exceptionsReport - } - parameters.collectFirst { case DebugFileOutputNameMatcher(name) => name } match { - case Some(fileName) => - process { new java.io.FileOutputStream(fileName) } { fos => - fos.write(getExceptionsReport.toString.getBytes("UTF-8")) - } - case _ => // Nothing to do - } - if (parameters.contains("-debug")) { - org.opalj.io.writeAndOpen(getExceptionsReport, "Exceptions", ".html") - } - } - - // - // Print some statistics and "return" - // - val groupedIssues = - issues.groupBy(_.relevance).toList. - sortWith((e1, e2) => e1._1.value < e2._1.value) - val groupedAndCountedIssues = groupedIssues.map(e => e._1 + ": " + e._2.size) - - BasicReport( - groupedAndCountedIssues.mkString( - s"Issues (∑${issues.size}):\n\t", - "\n\t", - s"\nIdentified in: ${analysisTime.toSeconds}.\n" - ) - ) - } - - override def checkAnalysisSpecificParameters(parameters: Seq[String]): Seq[String] = { - - OPALLogger.info("analysis progress", "checking parameters")(GlobalLogContext) - - var outputFormatGiven = false - - import org.opalj.bugpicker.core.analyses.BugPickerAnalysis.* - - val issues = - parameters.filterNot(parameter => - parameter match { - case MaxEvalFactorPattern(d) => - try { - val factor = java.lang.Double.parseDouble(d).toDouble - (factor >= 0.1d && factor < 100.0d) || - factor == Double.PositiveInfinity - } catch { - case _: NumberFormatException => false - } - case MaxEvalTimePattern(l) => - try { - val maxTime = java.lang.Long.parseLong(l).toLong - maxTime >= 10L && maxTime <= 1000000L - } catch { - case _: NumberFormatException => false - } - case MaxCardinalityOfIntegerRangesPattern(i) => - try { - val cardinality = java.lang.Long.parseLong(i).toLong - cardinality >= 1L && cardinality <= 4294967295L - } catch { - case _: NumberFormatException => false - } - case MaxCardinalityOfLongSetsPattern(i) => - try { - val cardinality = java.lang.Integer.parseInt(i).toInt - cardinality >= 1 && cardinality <= 1024 - } catch { - case _: NumberFormatException => false - } - case MaxCallChainLengthPattern(_) => - // the pattern ensures that the value is legal... - true - - case IssueKindsPattern(ks) => - val kinds = ks.split(',').map(_.replace('_', ' ')) - kinds.nonEmpty && kinds.forall { IssueKind.AllKinds.contains(_) } - - case MinRelevancePattern(_) => - // the pattern ensures that the value is legal... - true - - case HTMLFileOutputNameMatcher(_) => - outputFormatGiven = true; true - case "-html" => - outputFormatGiven = true; true - case "-eclipse" => - outputFormatGiven = true; true - case "-idl" => - outputFormatGiven = true; true - case "-debug" => true - case DebugFileOutputNameMatcher(_) => true - case _ => false - } - ) - - if (!outputFormatGiven) - OPALLogger.warn("analysis configuration", "no output format specified")(GlobalLogContext) - - issues.map("unknown or illegal parameter: " + _) - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnalysisParameters.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnalysisParameters.scala deleted file mode 100644 index 872ea0a4ce..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnalysisParameters.scala +++ /dev/null @@ -1,27 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.bugpicker.core.analyses.BugPickerAnalysis.* -import org.opalj.util.Milliseconds - -case class AnalysisParameters( - maxEvalTime: Milliseconds = DefaultMaxEvalTime, - maxEvalFactor: Double = DefaultMaxEvalFactor, - maxCardinalityOfIntegerRanges: Long = DefaultMaxCardinalityOfIntegerRanges, - maxCardinalityOfLongSets: Int = DefaultMaxCardinalityOfLongSets, - maxCallChainLength: Int = DefaultMaxCallChainLength, - fixpointAnalyses: Seq[String] = DefaultFixpointAnalyses -) { - - def toStringParameters: Seq[String] = Seq( - s"-maxEvalFactor=$maxEvalFactor", - s"-maxEvalTime=$maxEvalTime", - s"-maxCardinalityOfIntegerRanges=$maxCardinalityOfIntegerRanges", - s"-maxCardinalityOfLongSets=$maxCardinalityOfLongSets", - s"-maxCallChainLength=$maxCallChainLength", - s"-fixpointAnalyses=${fixpointAnalyses.mkString(";")}" - ) -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnonymousInnerClassShouldBeStatic.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnonymousInnerClassShouldBeStatic.scala deleted file mode 100644 index b9fa98c099..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/AnonymousInnerClassShouldBeStatic.scala +++ /dev/null @@ -1,187 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.br.* -import org.opalj.br.analyses.* -import org.opalj.br.instructions.* -import org.opalj.issues.ClassLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Relevance - -/** - * This analysis reports anonymous inner classes that do not use their reference to the - * parent class and as such could be made `static` in order to save some memory and - * to improve overall comprehension. - * - * Since anonymous inner classes cannot be declared `static`, they must be refactored to - * named inner classes first. - * - * @author Ralf Mitschke - * @author Daniel Klauer - * @author Peter Spieler - * @author Florian Brandherm - * @author Michael Eichberg - */ -object AnonymousInnerClassShouldBeStatic { - - def description: String = "Identifies anonymous inner classes that should be made static." - - private val withinAnonymousClass = "[$][0-9].*[$]".r - - /** - * A heuristic for determining whether an inner class is inside an anonymous inner - * class based on the class name. - * - * @param classFile The inner class to check. - * @return Whether the inner class is inside an anonymous inner class. - */ - private def isWithinAnonymousInnerClass(classFile: ClassFile): Boolean = { - withinAnonymousClass.findFirstIn(classFile.thisType.fqn).isDefined - } - - /** - * Finds the last occurrence of either '$' or '+' in a class name string. - * - * @param fqn The class name to check. - * @return The index of the last occurring '$' or '+', whichever is closer to the end. - */ - private def lastIndexOfInnerClassEncoding(fqn: String): Int = { - math.max(fqn.lastIndexOf('$'), fqn.lastIndexOf('+')) - } - - /** - * A heuristic for determining anonymous inner classes by the encoding in the name. - * - * @param classFile The class to check. - * @return Whether the class is an anonymous inner class. - */ - private def isAnonymousInnerClass(classFile: ClassFile): Boolean = { - val fqn = classFile.thisType.fqn - - val lastSpecialChar = lastIndexOfInnerClassEncoding(fqn) - if (lastSpecialChar < 0) { - return false - } - - val digitChar = lastSpecialChar + 1; - digitChar < fqn.length && Character.isDigit(fqn.charAt(digitChar)) - } - - /** - * A heuristic for determining whether the field points to the enclosing instance - * by checking if its name starts with "this". - * - * @param field The field to check. - * @return Whether the field is the inner class' reference to the parent object. - */ - private def isOuterThisField(field: Field): Boolean = { - field.name.startsWith("this$") || field.name.startsWith("this+") - } - - /** - * Checks whether a class has any methods which read the given field. - * - * Note: This assumes the class also declares this field, and that it's enough to - * check for accesses through the context of that class. In other words, accesses - * through the context of subclasses would not be detected, but that's not required - * when checking the outer class reference field of an anonymous inner class. - */ - private def hasMethodsReadingField(classFile: ClassFile, field: Field): Boolean = { - for (MethodWithBody(body) <- classFile.methods) { - if (body.instructions.exists { - case FieldReadAccess(classFile.thisType, field.name, field.fieldType) => true - case _ => false - } - ) { - return true; - } - } - false - } - - /** - * Checks whether a class has any constructors with multiple ALOAD_1 instructions. - */ - private def hasConstructorsWithMultipleALOAD_1s(classFile: ClassFile): Boolean = { - for (method <- classFile.constructors; body <- method.body) { - var count = 0 - body.instructions.foreach { - case ALOAD_1 => - count += 1; - if (count > 1) { - return true; - } - case _ => - } - } - false - } - - private def isOuterClassReferenceUsed(classFile: ClassFile): Answer = { - // Try to find the outer class reference field. - val outerClassReference = classFile.fields.find(isOuterThisField(_)) - if (outerClassReference.isEmpty) { - return Unknown - } - - // Any constructors with more than one access to their outer class reference - // parameter? It's always read at least once, to store the outer class reference - // into the outer class reference field. - if (hasConstructorsWithMultipleALOAD_1s(classFile)) { - return Yes - } - - // Any methods reading the outer class reference field? - if (hasMethodsReadingField(classFile, outerClassReference.get)) { - return Yes - } - - No - } - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def apply(project: SomeProject, classFile: ClassFile): Iterable[Issue] = { - if (project.isLibraryType(classFile) || classFile.isSynthetic) - return None; - - if (!(isAnonymousInnerClass(classFile) && - !isWithinAnonymousInnerClass(classFile) && - isOuterClassReferenceUsed(classFile).isNo) - ) - return None; - - var supertype = classFile.superclassType.get.toJava - - if (classFile.interfaceTypes.nonEmpty) { - val superInterfacetypes = classFile.interfaceTypes.map(_.toJava).mkString(" with ") - - if (classFile.superclassType.get == ClassType.Object) - supertype = superInterfacetypes - else - supertype += " implements " + superInterfacetypes - - } - - Some( - Issue( - "AnonymousInnerClassShouldBeStatic", - Relevance.Low, - s"this inner class of type $supertype should be made static", - Set(IssueCategory.Comprehensibility, IssueCategory.Performance), - Set(IssueKind.MissingStaticModifier), - List(new ClassLocation(None, project, classFile)) - ) - ) - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysis.scala deleted file mode 100644 index 5521065afa..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysis.scala +++ /dev/null @@ -1,605 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import java.net.URL -import java.util.Date -import java.util.concurrent.ConcurrentLinkedQueue -import java.util.concurrent.atomic.AtomicInteger -import scala.collection.JavaConverters.* -import scala.collection.JavaConverters.collectionAsScalaIterableConverter -import scala.xml.Node -import scala.xml.NodeSeq -import scala.xml.Unparsed - -import com.typesafe.config.Config -import com.typesafe.config.ConfigRenderOptions - -import org.opalj.ai.BoundedInterruptableAI -import org.opalj.ai.InterpretationFailedException -import org.opalj.ai.analyses.FieldValuesKey -import org.opalj.ai.analyses.MethodReturnValuesKey -import org.opalj.ai.analyses.cg.CallGraphCache -import org.opalj.ai.analyses.cg.VTACallGraphKey -import org.opalj.ai.util.XHTML -import org.opalj.br.ClassFile -import org.opalj.br.Code -import org.opalj.br.Method -import org.opalj.br.MethodSignature -import org.opalj.br.analyses.Analysis -import org.opalj.br.analyses.AnalysisException -import org.opalj.br.analyses.FieldAccessInformationKey -import org.opalj.br.analyses.ProgressManagement -import org.opalj.br.analyses.Project -import org.opalj.br.analyses.PropertyStoreKey -import org.opalj.br.analyses.StringConstantsInformationKey -import org.opalj.br.analyses.cg.InstantiableClassesKey -import org.opalj.fpcf.FPCFAnalysesManagerKey -import org.opalj.fpcf.FPCFAnalysesRegistry -import org.opalj.issues.Issue -import org.opalj.issues.IssueOrdering -import org.opalj.issues.PackageLocation -import org.opalj.issues.ProjectLocation -import org.opalj.issues.Relevance -import org.opalj.log.OPALLogger -import org.opalj.util.Milliseconds -import org.opalj.util.Nanoseconds -import org.opalj.util.PerformanceEvaluation.time - -import net.ceedubs.ficus.Ficus.* - -/** - * Wrapper around several analyses that analyze the control- and data-flow to identify - * various issues in the source code of projects. - * - * ==Precision== - * The analyses are designed such that they try to avoid to report false positives to facilitate - * usage of the BugPicker. However, given - * that we analyze Java bytecode, some findings may be the result of the compilation - * scheme employed by the compiler and, hence, cannot be resolved at the - * source code level. This is in particular true for finally blocks in Java programs. In - * this case compilers typically include the same block two (or more) times in the code. - * Furthermore, Java reflection and reflection-like mechanisms are also a source of - * false positives. - * - * @author Michael Eichberg - */ -class BugPickerAnalysis extends Analysis[URL, BugPickerResults] { - - import BugPickerAnalysis.* - - override def title: String = "BugPicker" - - override def description: String = "Finds code smells in Java (byte) code." - - /** - * Executes the analysis of the project's concrete methods. - * - * @param parameters A list of (optional) parameters. The parameters that are - * matched are defined by: - * [[BugPickerAnalysis.MaxEvalFactorPattern]], - * [[BugPickerAnalysis.MaxEvalTimePattern]], - * [[BugPickerAnalysis.MaxCardinalityOfIntegerRangesPattern]], - * [[BugPickerAnalysis.MaxCardinalityOfLongSetsPattern]], - * [[BugPickerAnalysis.MaxCallChainLengthPattern]], and "`-debug`". - */ - override def analyze( - theProject: Project[URL], - parameters: Seq[String], - initProgressManagement: (Int) => ProgressManagement - ): BugPickerResults = { - - import theProject.config - - implicit val project: Project[URL] = theProject - implicit val logContext: LogContext = theProject.logContext - - // related to managing the analysis progress - val classFilesCount = theProject.projectClassFilesCount - - val progressManagement = initProgressManagement(PreAnalysesCount + classFilesCount) - import progressManagement.step - - val analysisParameters = theProject.config.as[Config]("org.opalj.bugpicker.analysisParameter") - - val maxEvalFactor = analysisParameters.as[Double]("maxEvalFactor") - val maxEvalTime = new Milliseconds(analysisParameters.as[Long]("maxEvalTime")) - val maxCardinalityOfIntegerRanges = analysisParameters.as[Long]("maxCardinalityOfLongSets") - val maxCardinalityOfLongSets = analysisParameters.as[Int]("maxCardinalityOfLongSets") - val configuredAnalyses = analysisParameters.as[List[String]]("fpcfAnalyses") - val fpcfAnalyses = configuredAnalyses.map { a => FPCFAnalysesRegistry.factory(a) } - val maxCallChainLength = theProject.config.as[Int]( - "org.opalj.bugpicker.analysis.RootBugPickerAnalysisDomain.maxCallChainLength" - ) - - val debug = parameters.contains("-debug") - if (debug) { - val cp = System.getProperty("java.class.path") - val cpSorted = cp.split(java.io.File.pathSeparatorChar).sorted - val renderingOptions = - ConfigRenderOptions.defaults(). - setOriginComments(false). - setComments(true). - setJson(false) - val bugpickerConf = theProject.config.withOnlyPath("org.opalj") - val settings = bugpickerConf.root().render(renderingOptions) - OPALLogger.info( - "configuration", - cpSorted.mkString("System ClassPath:\n\t", "\n\t", "\n") + "\n" + - "Settings:" + "\n" + - settings - ) - } - - // - // - // PREANALYSES - // - // - - step(1, "[Pre-Analysis] Identifying non-instantiable classes") { - (theProject.get(InstantiableClassesKey), None) - } - - val fieldAccessInformation = step(2, "[Pre-Analysis] Analyzing field accesses") { - (theProject.get(FieldAccessInformationKey), None) - } - - val stringConstantsInformation = step(3, "[Pre-Analysis] Analyzing the usage of string constants") { - (theProject.get(StringConstantsInformationKey), None) - } - - step(4, "[Pre-Analysis] Analyzing field declarations to derive more precise field value information") { - (theProject.get(FieldValuesKey), None) - } - - step(5, "[Pre-Analysis] Analyzing methods to get more precise return type information") { - (theProject.get(MethodReturnValuesKey), None) - } - - val computedCallGraph = step(6, "[Pre-Analysis] Creating the call graph") { - (theProject.get(VTACallGraphKey), None) - } - val callGraph = computedCallGraph.callGraph - val callGraphEntryPoints = computedCallGraph.entryPoints().toSet - - // - // - // Compute Fixpoint properties - // - // - - val analysesManager = theProject.get(FPCFAnalysesManagerKey) - val propertyStore = theProject.get(PropertyStoreKey) - step(7, "[FPCF-Analysis] executing fixpoint analyses") { - ( - { - fpcfAnalyses.foreach(analysesManager.run(_, false)) - propertyStore.waitOnPropertyComputationCompletion(true) - }, - None - ) - } - - // - // - // MAIN ANALYSIS - // - // - - val doInterrupt: () => Boolean = progressManagement.isInterrupted _ - - val filteredResults = new ConcurrentLinkedQueue[Issue]() - val issuesPackageFilterString = config.as[String]("org.opalj.bugpicker.issues.packages") - OPALLogger.debug( - "project configuration", - s"only issues in packages matching $issuesPackageFilterString are shown" - ) - val issuesPackageFilter = issuesPackageFilterString.r - def addResults(issues: Iterable[Issue]): Unit = { - if (issues.nonEmpty) { - val filteredIssues = issues.filter { issue => - issue.locations.head match { - case l: PackageLocation => - val packageName = l.thePackage - val allMatches = issuesPackageFilter.findFirstIn(packageName) - allMatches.isDefined && packageName == allMatches.get - case _ => - // the issue is a project level issue and hence kept - true - } - } - filteredResults.addAll(filteredIssues.asJavaCollection) - } - } - - val fieldValueInformation = theProject.get(FieldValuesKey) - val methodReturnValueInformation = theProject.get(MethodReturnValuesKey) - - val cache = new CallGraphCache[MethodSignature, scala.collection.Set[Method]](theProject) - - def analyzeMethod(method: Method, body: Code): Unit = { - val classFile: ClassFile = method.classFile - // USED DURING DEVELEOPMENT; e.g., if we see a specific method. - val debug = false - - // --------------------------------------------------------------------------- - // Analyses that don't require an abstract interpretation - // --------------------------------------------------------------------------- - - // - // CHECK IF THE METHOD IS USED - // - addResults( - UnusedMethodsAnalysis(theProject, computedCallGraph, callGraphEntryPoints, method) - ) - - // --------------------------------------------------------------------------- - // Analyses that are dependent on the result of the abstract interpretation - // --------------------------------------------------------------------------- - - val analysisDomain = - new RootBugPickerAnalysisDomain( - theProject, - // Map.empty, Map.empty, - fieldValueInformation, - methodReturnValueInformation, - cache, - maxCardinalityOfIntegerRanges, - maxCardinalityOfLongSets, - maxCallChainLength, - method, - debug - ) - val ai0 = - new BoundedInterruptableAI[analysisDomain.type]( - body, - maxEvalFactor, - maxEvalTime, - doInterrupt - ) - val result = { - val result0 = ai0(method, analysisDomain) - if (result0.wasAborted && maxCallChainLength > 0) { - val logMessage = - s"analysis of ${method.fullyQualifiedSignature} with method call execution aborted " + - s"after ${ai0.currentEvaluationCount} steps " + - s"(code size: ${method.body.get.instructions.length})" - // let's try it again, but without performing method calls; - // let's reuse the current state - val fallbackAnalysisDomain = - new FallbackBugPickerAnalysisDomain( - theProject, - fieldValueInformation, - methodReturnValueInformation, - cache, - maxCardinalityOfIntegerRanges, - maxCardinalityOfLongSets, - method - ) - - val ai1 = - new BoundedInterruptableAI[fallbackAnalysisDomain.type]( - body, - maxEvalFactor, - maxEvalTime, - doInterrupt - ) - - val result1 = ai1(method, fallbackAnalysisDomain) - - if (result1.wasAborted) - OPALLogger.warn( - "configuration", - logMessage + ": retry without performing invocations also failed" - ) - else - OPALLogger.info("configuration", logMessage) - - result1 - } else - result0 - - } - - if (!result.wasAborted) { - if (debug) { - import result.* - val domainName = domain.getClass.getName - org.opalj.io.writeAndOpen( - org.opalj.ai.common.XHTML.dump( - Some(classFile), - Some(method), - method.body.get, - Some( - s"Created: ${new Date}
Domain: $domainName
" + - XHTML.evaluatedInstructionsToXHTML(result.evaluated) - ), - domain - )(cfJoins, result.operandsArray, result.localsArray), - "AIResult", - ".html" - ) - } - - // - // FIND DEAD CODE - // - addResults(DeadEdgesAnalysis(theProject, method, result)) - - // - // FIND SUSPICIOUS CODE - // - addResults(GuardedAndUnguardedAccessAnalysis(theProject, method, result)) - - // - // FIND INSTRUCTIONS THAT ALWAYS THROW AN EXCEPTION - // - addResults(ThrowsExceptionAnalysis(theProject, method, result).toIterable) - - // - // FIND USELESS COMPUTATIONS - // - addResults(UselessComputationsAnalysis(theProject, method, result)) - - // - // FIND USELESS REEVALUATIONS OF COMPUTATIONS - // - addResults(UselessReComputationsAnalysis(theProject, method, result)) - - // - // FIND UNUSED LOCAL VARIABLES - // - addResults( - UnusedLocalVariables(theProject, propertyStore, callGraph, method, result) - ) - - // - // FIND STRANGE USES OF THE COLLECTIONS API - // - addResults( - CollectionsUsage(theProject, propertyStore, callGraph, method, result) - ) - - } else if (!doInterrupt()) { - OPALLogger.error( - "internal error", - s"analysis of ${method.fullyQualifiedSignature} aborted " + - s"after ${ai0.currentEvaluationCount} steps " + - s"(code size: ${method.body.get.instructions.length})" - ) - } /* else (doInterrupt === true) the analysis as such was interrupted*/ - } - - val exceptions = new ConcurrentLinkedQueue[AnalysisException] - var analysisTime = Nanoseconds.None - val identifiedIssues = time { - val stepIds = new AtomicInteger(PreAnalysesCount + 1) - - theProject.parForeachProjectClassFile(doInterrupt) { classFile => - val stepId = stepIds.getAndIncrement() - try { - progressManagement.start(stepId, classFile.thisType.toJava) - - // --------------------------------------------------------------------------- - // Class based analyses - // --------------------------------------------------------------------------- - - addResults(AnonymousInnerClassShouldBeStatic(theProject, classFile)) - addResults(ManualGarbageCollection(theProject, classFile)) - addResults(CovariantEquals(classFile)) - - // - // FIND UNUSED FIELDS - // - addResults( - UnusedFields( - theProject, - propertyStore, - fieldAccessInformation, - stringConstantsInformation, - classFile - ) - ) - - // --------------------------------------------------------------------------- - // Analyses of the methods - // --------------------------------------------------------------------------- - - for (method <- classFile.methods; body <- method.body) { - try { - analyzeMethod(method, body) - } catch { - case afe: InterpretationFailedException => - val ms = method.fullyQualifiedSignature - val steps = afe.ai.asInstanceOf[BoundedInterruptableAI[?]].currentEvaluationCount - val message = - s"the analysis of $ms failed/was aborted after $steps steps" - exceptions add (AnalysisException(message, afe)) - case b: Break[?] => throw b - case t: Throwable => - val ms = method.fullyQualifiedSignature - val message = s"the analysis of ${ms} failed" - exceptions add (AnalysisException(message, t)) - } - } - } catch { - case t: Throwable => - OPALLogger.error( - "internal error", - s"evaluation step $stepId failed", - t - ) - throw t - } finally { - progressManagement.end(stepId) - } - } - filteredResults.asScala.toSeq - } { t => analysisTime = t } - - OPALLogger.info( - "analysis progress", - s"the analysis took ${analysisTime.toSeconds} " + - s"and found ${identifiedIssues.size} unique issues" - ) - import scala.collection.JavaConverters.* - (analysisTime, identifiedIssues, exceptions.asScala) - } -} - -/** - * Common constants and helper methods related to the configuration of the BugPicker and - * generating reports. - * - * @author Michael Eichberg - */ -object BugPickerAnalysis { - - // 1: InstantiableClasses analysis - // 2: FieldAccessInformation - // 3: StringConstantsInformation - // 4: FieldValues analysis - // 5: MethodReturnValues analysis - // 6: Callgraph - // 7: FPCF properties - final val PreAnalysesCount = 7 - - // We want to match expressions such as: - // -maxEvalFactor=1 - // -maxEvalFactor=20 - // -maxEvalFactor=1.25 - // -maxEvalFactor=10.5 - // -maxEvalFactor=Infinity - final val MaxEvalFactorPattern = """-maxEvalFactor=(\d+(?:.\d+)?|Infinity)""".r - final val DefaultMaxEvalFactor = 1.75d - - final val MaxEvalTimePattern = """-maxEvalTime=(\d+)""".r - final val DefaultMaxEvalTime: Milliseconds = new Milliseconds(10000L) // in ms => 10secs. - - final val MaxCallChainLengthPattern = """-maxCallChainLength=(\d)""".r - final val DefaultMaxCallChainLength = 1 - - final val MaxCardinalityOfIntegerRangesPattern = - """-maxCardinalityOfIntegerRanges=(\d+)""".r - final val DefaultMaxCardinalityOfIntegerRanges = 16L - - final val MaxCardinalityOfLongSetsPattern = - """-maxCardinalityOfLongSets=(\d+)""".r - final val DefaultMaxCardinalityOfLongSets = 2 - - final val FixpointAnalysesPattern = """-fixpointAnalyses=(.+)""".r - final val DefaultFixpointAnalyses = Seq.empty[String] - - def resultsAsXHTML( - config: Seq[String], - theIssues: Iterable[Issue], - showSearch: Boolean, - analysisTime: Nanoseconds - ): Node = { - // TODO Make the filtering a configurable property!!! - val issuesCount = theIssues.size - val issues = - if (issuesCount > 1000) { - theIssues.filter(_.relevance.value >= Relevance.VeryLow.value) - } else { - theIssues - } - val basicInfoOnly = issuesCount > 15000 - - val totalIssues = { - var is = s"(Total issues: $issuesCount)" - if (issues.size < theIssues.size) - is += "(Due to the number of identified issues all those that are most likely completely irrelevant are filtered.)" - if (basicInfoOnly) - is += "(Due to the number of remaining issues an abbreviated report is shown.)" - - is - } - - val issuesNode: Iterable[Node] = { - import scala.collection.SortedMap - val groupedMessages = - SortedMap.empty[String, List[Issue]] ++ - issues.groupBy { i => - i.locations.head match { - case thePackage: PackageLocation => thePackage.thePackage - case _: ProjectLocation => "" - } - } - val result = - (for { (pkg, mdc) <- groupedMessages } yield { -
- {pkg.replace('/', '.')} - {mdc.toSeq.sorted(IssueOrdering).map(_.toXHTML(basicInfoOnly))} -
- }) - result.seq - } - - val (searchJS: NodeSeq, searchBox: NodeSeq) = - if (showSearch) { - ( - , - - ) - } else { - (NodeSeq.Empty, NodeSeq.Empty) - } - - - - - - {searchJS} - - - - -
-
- Number of issues currently displayed: {issuesCount} { - totalIssues - } - {searchBox} -
-
- Suppress issues with an estimated - importance - less than: - 1 - - 100 -
-
- Manifestation in the Code:
- -
-
- Software Quality Attributes:
- -
-
- Show all Packages:+- -
-
-
-
- Parameters -
    - { - config.filterNot(_.contains("debug")).map(p =>
  • {p}
    • ) - } -
-
-
-
- {issuesNode} -
- - - } - //
<-- add if you want to debug -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysisDomain.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysisDomain.scala deleted file mode 100644 index 6997c3d641..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/BugPickerAnalysisDomain.scala +++ /dev/null @@ -1,274 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import java.net.URL - -import org.opalj.ai.AIResult -import org.opalj.ai.CorrelationalDomain -import org.opalj.ai.TheAI -import org.opalj.ai.TheMemoryLayout -import org.opalj.ai.analyses.FieldValueInformation -import org.opalj.ai.analyses.MethodReturnValueInformation -import org.opalj.ai.analyses.cg.CallGraphCache -import org.opalj.ai.domain -import org.opalj.ai.domain.l2.CalledMethodsStore -import org.opalj.ai.domain.l2.ChildPerformInvocationsWithRecursionDetection -import org.opalj.ai.domain.l2.PerformInvocationsWithRecursionDetection -import org.opalj.ai.domain.la.PerformInvocationsWithBasicVirtualMethodCallResolution -import org.opalj.ai.mapOperands -import org.opalj.ai.util.XHTML -import org.opalj.br.Method -import org.opalj.br.MethodDescriptor -import org.opalj.br.MethodSignature -import org.opalj.br.PC -import org.opalj.br.ReferenceType -import org.opalj.br.analyses.Project -import org.opalj.collection.immutable.Chain - -/** - * The base domain that is shared by all domains that are used to perform abstract - * interpretations of methods. - * - * @author Michael Eichberg - */ -trait BaseBugPickerAnalysisDomain - extends CorrelationalDomain - with domain.TheProject - with domain.TheMethod - with domain.DefaultSpecialDomainValuesBinding - with domain.ThrowAllPotentialExceptionsConfiguration - // with domain.l0.TypeLevelFieldAccessInstructions - with domain.la.RefinedTypeLevelFieldAccessInstructions - with domain.l0.TypeLevelInvokeInstructions - with domain.la.RefinedTypeLevelInvokeInstructions - with domain.SpecialMethodsHandling - with domain.l1.DefaultIntegerRangeValues - // with domain.l1.DefaultIntegerSetValues - // [CURRENTLY ONLY A WASTE OF RESOURCES] with domain.l1.ConstraintsBetweenIntegerValues - with domain.l1.DefaultLongSetValues - with domain.l1.LongSetValuesShiftOperators - with domain.l0.DefaultTypeLevelFloatValues - with domain.l0.DefaultTypeLevelDoubleValues - with domain.l1.ConcretePrimitiveValuesConversions - // with domain.l1.DefaultReferenceValuesBinding [implicitly mixed in via StringValuesBinding] - // with domain.l1.DefaultStringValuesBinding [implicitly mixed in via ClassValuesBinding] - with domain.l1.NullPropertyRefinement - with domain.l1.MaxArrayLengthRefinement - with domain.DefaultHandlingOfMethodResults - with domain.IgnoreSynchronization { - // We want to get the special treatment of calls on "Class" objects - // and do not want to perform invocations in this case; - // hence, we have to mix in this domain AFTER the PerformInvocations domain! - this: domain.l1.DefaultClassValuesBinding => -} - -/** - * This is the fall back domain that is used to perform an abstract interpretation of - * a method without invoking called methods. - */ -class FallbackBugPickerAnalysisDomain( - val project: Project[URL], - val fieldValueInformation: FieldValueInformation, - val methodReturnValueInformation: MethodReturnValueInformation, - val cache: CallGraphCache[MethodSignature, scala.collection.Set[Method]], - override val maxCardinalityOfIntegerRanges: Long, - override val maxCardinalityOfLongSets: Int, - val /*current*/ method: Method -) extends BaseBugPickerAnalysisDomain - with domain.l1.DefaultClassValuesBinding - with domain.l1.RecordAllThrownExceptions - with domain.RecordCFG - with domain.RecordDefUse - -/** - * The base domain that is shared by all domains that are used to perform abstract - * interpretations of methods where methods are potentially called. - */ -trait BasePerformInvocationBugPickerAnalysisDomain - extends BaseBugPickerAnalysisDomain - with PerformInvocationsWithRecursionDetection - with PerformInvocationsWithBasicVirtualMethodCallResolution - with domain.l1.DefaultClassValuesBinding { callingDomain => - - def debug: Boolean - - type CalledMethodDomain = InvocationBugPickerAnalysisDomain - - override protected def doInvoke( - method: Method, - calledMethodDomain: CalledMethodDomain - )( - parameters: calledMethodDomain.Locals - ): AIResult { val domain: calledMethodDomain.type } = { - val result = super.doInvoke(method, calledMethodDomain)(parameters) - if (debug) { - import result.* - org.opalj.io.writeAndOpen( - org.opalj.ai.common.XHTML.dump( - Some(method.classFile), - Some(method), - method.body.get, - Some( - "Created: " + (new java.util.Date).toString + "
" + - "Domain: " + result.domain.getClass.getName + "
" + - XHTML.evaluatedInstructionsToXHTML(result.evaluated) - ), - result.domain - )(cfJoins, result.operandsArray, result.localsArray), - "AIResult", - ".html" - ) - } - result - } - - override def doInvoke( - pc: PC, - method: Method, - operands: callingDomain.Operands, - fallback: () => MethodCallResult - ): MethodCallResult = { - val result = super.doInvoke(pc, method, operands, fallback) - if (debug) { - println("the result of calling " + method.toJava + " is " + result) - } - result - } - - val maxCallChainLength: Int - - def currentCallChainLength: Int - - def shouldInvocationBePerformed(calledMethod: Method): Boolean = { - val result = - maxCallChainLength > currentCallChainLength && - // TODO check me if the following makes sense: - calledMethod.isPrivate && calledMethod.actualArgumentsCount != 1 - if (debug) { - val i = if (result) " invokes " else " does not invoke " - println(s"[$currentCallChainLength]" + - method.toJava + - i + - calledMethod.toJava) - } - result - } - - abstract override def invokevirtual( - pc: PC, - declaringClass: ReferenceType, - name: String, - descriptor: MethodDescriptor, - operands: Operands - ): MethodCallResult = { - - val result = super.invokevirtual(pc, declaringClass, name, descriptor, operands) - if (debug) { - println(s"[$currentCallChainLength] call result of " + - declaringClass.toJava + " " + descriptor.toJava(name) + result) - } - result - } -} - -class InvocationBugPickerAnalysisDomain( - val project: Project[URL], - val fieldValueInformation: FieldValueInformation, - val methodReturnValueInformation: MethodReturnValueInformation, - val cache: CallGraphCache[MethodSignature, scala.collection.Set[Method]], - override val maxCardinalityOfIntegerRanges: Long, - override val maxCardinalityOfLongSets: Int, - val maxCallChainLength: Int, - val callerDomain: BasePerformInvocationBugPickerAnalysisDomain, - val /*current*/ method: Method, - val currentCallChainLength: Int, - val debug: Boolean -) extends BasePerformInvocationBugPickerAnalysisDomain - with domain.RecordMethodCallResults - with domain.RecordLastReturnedValues - with domain.RecordAllThrownExceptions - with ChildPerformInvocationsWithRecursionDetection { - callingDomain => - - override def calledMethodDomain(method: Method) = { - new InvocationBugPickerAnalysisDomain( - project, - fieldValueInformation, - methodReturnValueInformation, - cache, - maxCardinalityOfIntegerRanges, - maxCardinalityOfLongSets, - maxCallChainLength, - callingDomain, - method, - currentCallChainLength + 1, - debug - ) {} - } - - def calledMethodAI = callerDomain.calledMethodAI - -} - -/** - * The domain that is used to identify the issues. - * - * @author Michael Eichberg - */ -class RootBugPickerAnalysisDomain( - val project: Project[URL], - val fieldValueInformation: FieldValueInformation, - val methodReturnValueInformation: MethodReturnValueInformation, - val cache: CallGraphCache[MethodSignature, scala.collection.Set[Method]], - override val maxCardinalityOfIntegerRanges: Long, - override val maxCardinalityOfLongSets: Int, - val maxCallChainLength: Int, - val /*current*/ method: Method, - val debug: Boolean, - val frequentEvaluationWarningLevel: Int = 256 -) extends BasePerformInvocationBugPickerAnalysisDomain - with TheAI[BaseBugPickerAnalysisDomain] - with TheMemoryLayout // required to extract the initial operands - // the following two are required to detect instructions that always throw - // an exception (such as div by zero, a failing checkcast, a method call that - // always fails etc.) - with domain.l1.RecordAllThrownExceptions - with domain.RecordCFG - with domain.RecordDefUse { callingDomain => - - final def currentCallChainLength: Int = 0 - final def calledMethodAI = ai - final val coordinatingDomain = this - - // The called methods store is always only required at analysis time, at this point - // in time the initial operands are available! - lazy val calledMethodsStore: CalledMethodsStore { val domain: coordinatingDomain.type } = { - val operands = - localsArray(0).foldLeft(Chain.empty[DomainValue])((l, n) => - if (n ne null) n :&: l else l - ) - CalledMethodsStore(coordinatingDomain, frequentEvaluationWarningLevel)( - method, - mapOperands(operands, coordinatingDomain) - ) - } - - override def calledMethodDomain(method: Method) = - new InvocationBugPickerAnalysisDomain( - project, - fieldValueInformation, - methodReturnValueInformation, - cache, - maxCardinalityOfIntegerRanges, - maxCardinalityOfLongSets, - maxCallChainLength, - callingDomain, - method, - currentCallChainLength + 1, - debug - ) - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CollectionsUsage.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CollectionsUsage.scala deleted file mode 100644 index 1ba93a0270..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CollectionsUsage.scala +++ /dev/null @@ -1,159 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.Domain -import org.opalj.ai.analyses.cg.CallGraph -import org.opalj.ai.domain.RecordDefUse -import org.opalj.ai.domain.TheCode -import org.opalj.br.ClassType -import org.opalj.br.Method -import org.opalj.br.MethodDescriptor -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.INVOKEINTERFACE -import org.opalj.br.instructions.INVOKESPECIAL -import org.opalj.br.instructions.INVOKESTATIC -import org.opalj.br.instructions.INVOKEVIRTUAL -import org.opalj.br.instructions.NEW -import org.opalj.fpcf.PropertyStore -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Relevance - -/** - * Identifies cases where the collections API is not used as intended. - * - * @author Michael Eichberg - */ -object CollectionsUsage { - - final val UnmodifiableCollectionMethodDescriptor = MethodDescriptor(ClassType.Collection, ClassType.Collection) - - def apply( - theProject: SomeProject, - propertyStore: PropertyStore, - callGraph: CallGraph, - method: Method, - result: AIResult { val domain: Domain with TheCode with RecordDefUse } - ): Seq[Issue] = { - - if (method.isSynthetic) - return Nil; - // - // - // IDENTIFYING RAW ISSUES - // - // - var issues = List.empty[Issue] - val domain = result.domain - val code = domain.code - val instructions = code.instructions - code iterate { (pc, instruction) => - instruction match { - - case INVOKESTATIC( - ClassType.Collections, - false, - "unmodifiableCollection", - UnmodifiableCollectionMethodDescriptor - ) => - val origins = domain.operandOrigin(pc, 0) - if ((origins ne null) && // the instruction is not dead - origins.size == 1 && - origins.head >= 0 && // the origin is not a parameter - instructions(origins.head).opcode == NEW.opcode - ) { - // FIXME Add check if something is done in a loop - // there is just one path on which the value is initialized - val usages = domain.usedBy(origins.head) - if (usages.size == 2) { - // one for the call of the initializer and for the call to Coll... - instructions(usages.withFilter(_ != pc).head) match { - - // TODO Support the matching of other constructors... (e.g., which take a size hint) - case INVOKESPECIAL(_, false, _, MethodDescriptor.NoArgsAndReturnVoid) => - issues ::= Issue( - "CollectionsUsage", - Relevance.DefaultRelevance, - "useless creation of standard collection class", - Set(IssueCategory.Comprehensibility, IssueCategory.Performance), - Set(IssueKind.JavaCollectionAPIMisusage), - List( - new InstructionLocation( - Some("directly use Collections.emptyList/Collections.emptySet"), - theProject, - method, - pc - ), - new InstructionLocation( - Some("useless"), - theProject, - method, - origins.head - ) - ) - ) - - case _ => // other constructors are ignored - } - - } else if (usages.size == 3) { - var foundConstructorCall = false - var foundAddCall = false - val previousUsages = usages.withFilter(_ != pc) - previousUsages.foreach { pc => - instructions(pc) match { - - // TODO Support the matching of other constructors... (e.g., which take a size hint) - case INVOKESPECIAL(_, false, _, MethodDescriptor.NoArgsAndReturnVoid) => - foundConstructorCall = true - - // TODO Support the case of a call to addElement - case INVOKEVIRTUAL(_, "add", MethodDescriptor(IndexedSeq(ClassType.Object), _)) | - INVOKEINTERFACE(_, "add", MethodDescriptor(IndexedSeq(ClassType.Object), _)) => - // is it the receiver or the parameter (in relation to a different collection? - if (domain.operandOrigin(pc, 1) == origins) { - foundAddCall = true - } - - case i => // other calls are ignored - println("let's see" + i) - } - } - if (foundAddCall && foundConstructorCall) { - issues ::= Issue( - "CollectionsUsage", - Relevance.DefaultRelevance, - "useless creation of standard collection class", - Set(IssueCategory.Comprehensibility, IssueCategory.Performance), - Set(IssueKind.JavaCollectionAPIMisusage), - List( - new InstructionLocation( - Some("directly use Collections.singletonList/Collections.singletonSet"), - theProject, - method, - pc - ), - new InstructionLocation( - Some("useless"), - theProject, - method, - origins.head - ) - ) - ) - } - } - } - case _ => // don't care - } - } - - issues - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CovariantEquals.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CovariantEquals.scala deleted file mode 100644 index 3b7ba78e58..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/CovariantEquals.scala +++ /dev/null @@ -1,114 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.br.BooleanType -import org.opalj.br.ClassFile -import org.opalj.br.ClassType -import org.opalj.br.IntegerType -import org.opalj.br.Method -import org.opalj.br.MethodDescriptor -import org.opalj.br.analyses.SomeProject -import org.opalj.issues.ClassLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Relevance - -/** - * This analysis reports classes that have some `equals()` method(s), but not - * `equals(Object)`. This is bad practice and can lead to unexpected behavior, because - * without an `equals(Object)` method, `Object.equals(Object)` is not properly overridden. - * However, the relevance is determined by the presence of a hashCode method. - * - * @author Daniel Klauer - * @author Michael Eichberg - */ -object CovariantEquals { - - def description: String = - "Reports classes with one (or more) equals() methods but without equals(Object)." - - /** - * Checks whether a class has `equals()` methods but not `equals(Object)`. - * - * @param classFile The class to check. - * @return Whether the class has `equals()` methods but not `equals(Object)`. - */ - private def hasEqualsButNotEqualsObject(classFile: ClassFile): Boolean = { - val paramTypes = classFile.methods.collect { - case Method(_, "equals", MethodDescriptor(Seq(paramType), BooleanType)) => paramType - } - - paramTypes.size > 0 && !paramTypes.exists(_ == ClassType.Object) - } - - private def hasHashCode(classFile: ClassFile): Boolean = { - classFile.methods.exists { - case Method(_, "hashCode", MethodDescriptor(Seq(), IntegerType)) => true - case _ => false - } - } - - private def superClassHasCustomHashCode( - classFile: ClassFile - )( - implicit project: SomeProject - ): Boolean = { - - if (classFile.thisType eq ClassType.Object) - return false; - - val superclassType = classFile.superclassType.get - if (superclassType eq ClassType.Object) - return false; - - import MethodDescriptor.JustReturnsInteger - project.resolveClassMethodReference(superclassType, "hashCode", JustReturnsInteger) match { - case Success(m) => m.classFile.thisType ne ClassType.Object - case _ => false - } - } - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @return A list of reports, or an empty list. - */ - def apply( - classFile: ClassFile - )( - implicit project: SomeProject - ): Iterable[Issue] = { - if (classFile.isInterfaceDeclaration) - return Iterable.empty; - - if (hasEqualsButNotEqualsObject(classFile)) { - var message = "missing equals(Object) to override Object.equals(Object)" - val relevance = - if (hasHashCode(classFile)) { - message += " (the class overrides the standard hashCode method)" - Relevance.VeryHigh - } else if (superClassHasCustomHashCode(classFile)) { - message += " (a superclass overrides the standard hashCode method)" - Relevance.High - } else { - Relevance.Low - } - - Iterable(Issue( - "CovariantEquals", - relevance, - message, - Set(IssueCategory.Correctness), - Set(IssueKind.DubiousMethodDefinition), - List(new ClassLocation(None, project, classFile)) - )) - } else - Nil - - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/DeadEdgesAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/DeadEdgesAnalysis.scala deleted file mode 100644 index b140c7a74d..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/DeadEdgesAnalysis.scala +++ /dev/null @@ -1,362 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.BaseAI -import org.opalj.ai.Domain -import org.opalj.ai.analyses.cg.Callees -import org.opalj.ai.domain.Origin -import org.opalj.ai.domain.RecordCFG -import org.opalj.ai.domain.ThrowNoPotentialExceptionsConfiguration -import org.opalj.ai.domain.l0.ZeroDomain -import org.opalj.br.ClassType -import org.opalj.br.Code -import org.opalj.br.ExceptionHandler -import org.opalj.br.Method -import org.opalj.br.PC -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.ATHROW -import org.opalj.br.instructions.CompoundConditionalBranchInstruction -import org.opalj.br.instructions.ConditionalBranchInstruction -import org.opalj.br.instructions.GotoInstruction -import org.opalj.br.instructions.MethodInvocationInstruction -import org.opalj.br.instructions.NEW -import org.opalj.br.instructions.PopInstruction -import org.opalj.br.instructions.RET -import org.opalj.br.instructions.ReturnInstruction -import org.opalj.collection.immutable.Chain -import org.opalj.collection.immutable.Naught -import org.opalj.issues.FieldValues -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.IssueOrdering -import org.opalj.issues.LocalVariables -import org.opalj.issues.MethodReturnValues -import org.opalj.issues.Operands -import org.opalj.issues.Relevance - -/** - * Identifies dead edges in code. - * - * @author Michael Eichberg - */ -object DeadEdgesAnalysis { - - def apply( - theProject: SomeProject, - method: Method, - result: AIResult { val domain: Domain with Callees with RecordCFG with Origin } - ): Seq[Issue] = { - if (method.isSynthetic) - return Seq.empty; - - import result.domain - import result.operandsArray - import result.localsArray - val evaluatedInstructions = result.evaluatedInstructions - implicit val body: Code = result.code - val instructions = body.instructions - import result.cfJoins - import result.domain.regularSuccessorsOf - import result.domain.hasMultiplePredecessors - import result.domain.isRegularPredecessorOf - - /* - * Helper function to test if this code will always throw – independent - * of any data-flow - an exception if executed. - */ - def isAlwaysExceptionThrowingMethodCall(pc: PC): Boolean = { - instructions(pc) match { - case MethodInvocationInstruction(receiver: ClassType, isInterface, name, descriptor) => - val callees = domain.callees(method, receiver, isInterface, name, descriptor) - if (callees.size != 1) - return false; - - // We are only handling the special idiom where the call site is - // monomorphic and where the target method is used to create and throw - // a special exception object - // ... - // catch(Exception e) { - // /*return|athrow*/ handleException(e); - // } - callees.head.body.map(code => !code.exists { (pc, i) => i.isReturnInstruction }).getOrElse(false) - - case _ => - false - } - } - - /* - * A return/goto/athrow instruction is considered useless if the preceding - * instruction is a method call with a single target that _context-independently_ - * always just throws (an) exception(s). This is common pattern found in the JDK. - */ - // We want to suppress false warning as found in JDK 1.8.0_25 - // javax.xml.bind.util.JAXBResult - // when the method - // assertFailed - // is called and afterwards a jump is done to a non-dead instruction. - def requiredUselessJumpOrReturnFromMethod(currentPC: PC, nextPC: PC): Boolean = { - val nextInstruction = body.instructions(nextPC) - ( - nextInstruction.isInstanceOf[ReturnInstruction] || ( - nextInstruction.isInstanceOf[PopInstruction] && - body.instructions(body.pcOfNextInstruction(nextPC)).isInstanceOf[ReturnInstruction] - ) || nextInstruction == ATHROW || ( - nextInstruction.isInstanceOf[GotoInstruction] && - evaluatedInstructions.contains(body.nextNonGotoInstruction(nextPC)) - ) - ) && - isAlwaysExceptionThrowingMethodCall(currentPC) - } - - def mostSpecificFinallyHandlerOfPC(pc: PC): Seq[ExceptionHandler] = { - val candidateHandlers = - body.exceptionHandlers.filter { eh => eh.catchType.isEmpty && isRegularPredecessorOf(eh.handlerPC, pc) } - if (candidateHandlers.size > 1) { - candidateHandlers.tail.foldLeft(List(candidateHandlers.head)) { (c, n) => - var mostSpecificHandlers: List[ExceptionHandler] = List.empty - var addN = false - c.foreach { c => - if (isRegularPredecessorOf(c.handlerPC, n.handlerPC)) { - addN = true - } else if (isRegularPredecessorOf(n.handlerPC, c.handlerPC)) { - mostSpecificHandlers = c :: mostSpecificHandlers - } else { - mostSpecificHandlers = c :: mostSpecificHandlers - addN = true - } - } - if (addN) { - mostSpecificHandlers = n :: mostSpecificHandlers - } - mostSpecificHandlers - } - } else - candidateHandlers - } - - var issues = List.empty[Issue] - for { - pc <- body.programCounters.iterator - if evaluatedInstructions.contains(pc) - instruction = instructions(pc) - opcode = instruction.opcode - // Let's filter those instructions for which we cannot statically determine - // the set of meaningful successors: - // (I) In case of RET we don't know the next one, but the next one - // is not dead... (ever) if we reach the RET instruction - if opcode != RET.opcode - // (II) We don't have an analysis in place that enables us to determine - // the meaningful set of successors. - if opcode != ATHROW.opcode - - // Let's check if a path is never taken: - nextPC <- instruction.nextInstructions(pc, regularSuccessorsOnly = true).toIterator - if !regularSuccessorsOf(pc).contains(nextPC) - - // If we are in a subroutine, we don't have sufficient information - // to draw any conclusion; hence, we cannot derive any results. - allOperands = operandsArray(pc) - if allOperands ne null // null if we are in a subroutine (java < 1.5) - } { - // identify those dead edges that are pure technical artifacts - val isLikelyFalsePositive = requiredUselessJumpOrReturnFromMethod(pc, nextPC) - - def isRelatedToCompilationOfFinally: Boolean = { - // There has to be at least one finally statement. - if (!body.exceptionHandlers.exists(_.catchType.isEmpty)) - return false; - - // All issues related to the compilation of finally manifest - // themselves in dead edges related to conditional branch instructions - if (!instruction.isInstanceOf[ConditionalBranchInstruction]) - return false; - - // Let's determine the index of the local variable that is evaluated - val lvIndexOption = localsArray(pc).indexOf(allOperands.head) - if (lvIndexOption.isEmpty) - return false; - - // Let's find all other if instructions that also access the same - // local variable and which are not in a predecessor /successor relation - val finallyHandler = mostSpecificFinallyHandlerOfPC(pc) - val lvIndex = lvIndexOption.get - val correspondingPCs = body.collectWithIndex { - case (otherPC, _: ConditionalBranchInstruction) - if otherPC != pc && - (operandsArray(otherPC) ne null) && - (operandsArray(otherPC).head eq localsArray(otherPC)(lvIndex)) && - body.haveSameLineNumber(pc, otherPC).getOrElse(true) && - !isRegularPredecessorOf(pc, otherPC) && - !isRegularPredecessorOf(otherPC, pc) && - (finallyHandler intersect mostSpecificFinallyHandlerOfPC(otherPC)).isEmpty => - (otherPC) - } - correspondingPCs.nonEmpty - } - - lazy val isProvenAssertion = { - instructions(nextPC) match { - case NEW(AssertionError) => true - case _ => false - } - } - - // Identify those dead edges that are the result of common programming - // idioms; e.g., - // switch(v){ - // ... - // default: - // 1: throw new XYZError(...); - // 2: throw new IllegalStateException(...); - // 3: assert(false); - // 4: stateError(); - // AN ALWAYS (PRIVATE AND/OR STATIC) EXCEPTION - // THROWING METHOD - // HERE, THE DEFAULT CASE MAY EVEN FALL THROUGH! - // } - // - lazy val isDefaultBranchOfSwitch = - instruction.isInstanceOf[CompoundConditionalBranchInstruction] && - nextPC == pc + instruction.asInstanceOf[CompoundConditionalBranchInstruction].defaultOffset - - lazy val isNonExistingDefaultBranchOfSwitch = isDefaultBranchOfSwitch && - hasMultiplePredecessors( - pc + instruction.asInstanceOf[CompoundConditionalBranchInstruction].defaultOffset - ) - - lazy val isLikelyIntendedDeadDefaultBranch = isDefaultBranchOfSwitch && - // this is the default branch of a switch instruction that is dead - body.alwaysResultsInException( - nextPC, - cfJoins, - (invocationPC) => { - isAlwaysExceptionThrowingMethodCall(invocationPC) - }, - (athrowPC) => { - // Let's do a basic analysis to determine the type of - // the thrown exception. - // What we do next is basic a local data-flow analysis that - // starts with the first instruction of the default branch - // of the switch instruction and which uses - // the most basic domain available. - val codeLength = body.instructions.length - class ZDomain extends { // we need the "early initializer - val project: SomeProject = theProject - val code: Code = body - } with ZeroDomain with ThrowNoPotentialExceptionsConfiguration - val zDomain = new ZDomain - val zOperandsArray = new zDomain.OperandsArray(codeLength) - val zInitialOperands = - operandsArray(pc).tail.map(_.adapt(zDomain, Int.MinValue)) - zOperandsArray(nextPC) = zInitialOperands - val zLocalsArray = new zDomain.LocalsArray(codeLength) - zLocalsArray(nextPC) = - localsArray(pc) map { l => - if (l ne null) - l.adapt(zDomain, Int.MinValue) - else - null - } - BaseAI.continueInterpretation( - result.code, - result.cfJoins, - result.liveVariables, - zDomain - )( - /*initialWorkList =*/ Chain(nextPC), - /*alreadyEvaluated =*/ Naught, - /*subroutinesWereEvaluated=*/ false, - zOperandsArray, - zLocalsArray, - Naught, - null, - null // we don't care about the state of subroutines - ) - val exceptionValue = zOperandsArray(athrowPC).head - val throwsError = - ( - zDomain.asReferenceValue(exceptionValue). - isValueASubtypeOf(ClassType.Error). - isYesOrUnknown - ) || - zDomain.asReferenceValue(exceptionValue). - isValueASubtypeOf(ClassType.IllegalStateException). - isYesOrUnknown - - throwsError - } - ) - - val poppedOperandsCount = - instruction.numberOfPoppedOperands { index => allOperands(index).computationalType.category } - val operands = allOperands.take(poppedOperandsCount) - - val line = body.lineNumber(nextPC).map(l => s" (line=$l)").getOrElse("") - - val isJustDeadPath = evaluatedInstructions.contains(nextPC) - val isTechnicalArtifact = - isLikelyFalsePositive || - isNonExistingDefaultBranchOfSwitch || - isRelatedToCompilationOfFinally - val localVariables = result.localsArray(pc) - val relevance = - if (isTechnicalArtifact) - Relevance.TechnicalArtifact - else if (isProvenAssertion) - Relevance.ProvenAssertion - else if (isLikelyIntendedDeadDefaultBranch) - Relevance.CommonIdiom - else if (isJustDeadPath) - Relevance.UselessDefensiveProgramming - else - Relevance.OfUtmostRelevance - - val summary = - if (isJustDeadPath) - s"dead path found; the direct runtime successor instruction is never immediately executed after this instruction: pc=$nextPC$line" - else - s"dead code found; the successor instruction is dead: pc=$nextPC$line" - issues ::= Issue( - "DeadEdgesAnalysis", - relevance, - summary, - Set(IssueCategory.Correctness), - Set(IssueKind.DeadPath), - List(new InstructionLocation( - Some( - "The evaluation of the instruction never leads to the evaluation of the specified instruction." + ( - if (isTechnicalArtifact) - "\n(This seems to be a technical artifact that cannot be avoided; i.e., there is nothing to fix.)" - else if (isProvenAssertion) - "\n(We seem to have proven that an assertion always holds (unless an exeption is throw).)" - else if (isLikelyIntendedDeadDefaultBranch) - "\n(This seems to be a deliberately dead default branch of a switch instruction; i.e., there is probably nothing to fix!)" - else - "" - ) - ), - theProject, - method, - pc, - List( - new Operands(body, pc, operands, localVariables), - new LocalVariables(body, pc, localVariables) - ) - )), - List( - new FieldValues(method, result), - new MethodReturnValues(method, result) - ) - ) - } - issues.sorted(IssueOrdering) - } - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/GuardedAndUnguardedAccessAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/GuardedAndUnguardedAccessAnalysis.scala deleted file mode 100644 index be839481a6..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/GuardedAndUnguardedAccessAnalysis.scala +++ /dev/null @@ -1,193 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.Domain -import org.opalj.ai.ValueOrigin -import org.opalj.ai.domain.RecordCFG -import org.opalj.ai.domain.l1.RecordAllThrownExceptions -import org.opalj.ai.domain.l1.ReferenceValues -import org.opalj.br.Method -import org.opalj.br.PC -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.AALOAD -import org.opalj.br.instructions.AASTORE -import org.opalj.br.instructions.ARRAYLENGTH -import org.opalj.br.instructions.GETFIELD -import org.opalj.br.instructions.IFNONNULL -import org.opalj.br.instructions.IFNULL -import org.opalj.br.instructions.IFXNullInstruction -import org.opalj.br.instructions.INVOKEINTERFACE -import org.opalj.br.instructions.INVOKESPECIAL -import org.opalj.br.instructions.INVOKEVIRTUAL -import org.opalj.br.instructions.MONITORENTER -import org.opalj.br.instructions.NEW -import org.opalj.br.instructions.PUTFIELD -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.IssueLocation -import org.opalj.issues.Relevance - -/** - * Identifies accesses to local reference variables that are once done in a guarded context - * (w.r.t. its nullness property; guarded by an if instruction) and that are also done in - * an unguarded context. - * - * This is only a very shallow analysis that is subject to false positives; to filter - * potential false positives we filter all those issues where we can identify a - * control and data-dependency to a derived value. E.g., - * {{{ - * def printSize(f : File) : Unit = { - * val name = if(f eq null) null else f.getName - * if(name == null) throw new NullPointerException; - * // here... f is not null; because if f is null at the beginning, name would be null to - * // and the method call would have returned abnormally (raised a NullPointerException). - * println(f.size) - * } - * }}} - * - * @author Michael Eichberg - */ -object GuardedAndUnguardedAccessAnalysis { - - type UnGuardedAccessAnalysisDomain = Domain with ReferenceValues with RecordCFG with RecordAllThrownExceptions - - def apply( - theProject: SomeProject, - method: Method, - result: AIResult { val domain: UnGuardedAccessAnalysisDomain } - ): List[Issue] = { - - import result.domain - val operandsArray = result.operandsArray - val code = result.code - - var origins = Map.empty[ValueOrigin, PC] - var refIds = Map.empty[domain.RefId, PC] - - // TODO We should also log those that are assertions related! - - for { - (pc, instr: IFXNullInstruction[?]) <- code - if operandsArray(pc) ne null - } { - - import code.instructions - import code.pcOfNextInstruction - // let's check if the guard is related to an assert statement - val isAssertionRelated: Boolean = - (instr match { - case _: IFNONNULL => Some(instructions(pcOfNextInstruction(pc))) - case IFNULL(branchOffset) => Some(instructions(pc + branchOffset)) - case _ => None - }) match { - case Some(NEW(AssertionError)) => true - case _ => false - } - - if (!isAssertionRelated) - operandsArray(pc).head match { - case domain.DomainSingleOriginReferenceValue(sov) => - origins += ((sov.origin, pc)) - refIds += ((sov.refId, pc)) - case domain.DomainMultipleReferenceValues(mov) => - refIds += ((mov.refId, pc)) - } - - } - - if (origins.isEmpty && refIds.isEmpty) - // we don't have any "guard instructions" - return List.empty; - - val unguardedAccesses = - for { - (pc, domain.AReferenceValue(receiver)) <- code.collectWithIndex { - case (pc, ARRAYLENGTH | MONITORENTER) if operandsArray(pc) != null => - (pc, operandsArray(pc).head) - - case (pc, AASTORE) if operandsArray(pc) != null => - (pc, operandsArray(pc)(2)) - - case (pc, AALOAD) if operandsArray(pc) != null => - (pc, operandsArray(pc)(1)) - - case (pc, _: GETFIELD) if operandsArray(pc) != null => - (pc, operandsArray(pc).head) - - case (pc, _: PUTFIELD) if operandsArray(pc) != null => - (pc, operandsArray(pc)(1)) - - case (pc, i: INVOKEVIRTUAL) if operandsArray(pc) != null => - (pc, operandsArray(pc)(i.methodDescriptor.parametersCount)) - - case (pc, i: INVOKEINTERFACE) if operandsArray(pc) != null => - (pc, operandsArray(pc)(i.methodDescriptor.parametersCount)) - - case (pc, i: INVOKESPECIAL) if operandsArray(pc) != null => - (pc, operandsArray(pc)(i.methodDescriptor.parametersCount)) - } - if receiver.isNull.isUnknown - if refIds.contains(receiver.refId) || - (receiver.isInstanceOf[domain.SingleOriginValue] && - origins.contains(receiver.asInstanceOf[domain.SingleOriginValue].origin)) - } yield { - if (refIds.contains(receiver.refId)) - ( - refIds(receiver.refId), - Relevance.OfUtmostRelevance, - pc - ) - else - ( - origins(receiver.asInstanceOf[domain.SingleOriginValue].origin), - Relevance.High, - pc - ) - } - - val unguardedAccessesIssues = - for { - (guardPC, unguardedAccesses) <- unguardedAccesses.groupBy(f => f._1 /*by guard*/ ) - } yield { - val relevance = unguardedAccesses.toIterator.map(_._2.value).max - - val unguardedLocations: Seq[IssueLocation] = - unguardedAccesses.map { ua => - val unguardedAccessPC = ua._3 - new InstructionLocation( - Some("unguarded access"), - theProject, - method, - unguardedAccessPC - ) - }.toSeq - - val locations = - unguardedLocations :+ - new InstructionLocation( - Some("guard"), - theProject, - method, - guardPC - ) - - Issue( - "GuardedAndUnguardedAccessAnalysis", - Relevance(relevance), - "a local variable is accessed in a guarded (using an explicit check) and also in an unguarded context", - Set(IssueCategory.Correctness), - Set(IssueKind.UnguardedUse), - locations - ) - } - - unguardedAccessesIssues.toList - } - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ManualGarbageCollection.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ManualGarbageCollection.scala deleted file mode 100644 index 157e0dac26..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ManualGarbageCollection.scala +++ /dev/null @@ -1,67 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.br.ClassFile -import org.opalj.br.ClassType -import org.opalj.br.MethodDescriptor -import org.opalj.br.MethodWithBody -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.INVOKESTATIC -import org.opalj.br.instructions.INVOKEVIRTUAL -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Relevance - -/** - * This analysis reports calls to `java.lang.System/Runtime.gc()` that seem to be made - * manually in code outside the core of the JRE. - * - * Manual invocations of garbage collection are usually unnecessary and can lead to - * performance problems. This heuristic tries to detect such cases. - * - * @author Ralf Mitschke - * @author Peter Spieler - * @author Michael Eichberg - */ -object ManualGarbageCollection { - - def description: String = - "Reports methods outside of java.lang that explicitly invoke the garbage collector." - - /** - * Runs this analysis on the given project. - * - * @param project The project to analyze. - * @param parameters Options for the analysis. Currently unused. - * @return A list of reports, or an empty list. - */ - def apply(theProject: SomeProject, classFile: ClassFile): Iterable[Issue] = { - - import MethodDescriptor.NoArgsAndReturnVoid - - if (classFile.thisType.fqn.startsWith("java/lang")) - return Seq.empty; - - for { - method @ MethodWithBody(body) <- classFile.methods - (pc, gcCall) <- body.collectWithIndex { - case (pc, INVOKESTATIC(ClassType.System, false, "gc", NoArgsAndReturnVoid)) => - (pc, "System.gc()") - case (pc, INVOKEVIRTUAL(ClassType.Runtime, "gc", NoArgsAndReturnVoid)) => - (pc, "Runtime.gc()") - } - } yield Issue( - "ManualGarbageCollection", - Relevance.Low, - s"contains dubious call to $gcCall", - Set(IssueCategory.Performance), - Set(IssueKind.DubiousMethodCall), - List(new InstructionLocation(None, theProject, method, pc)) - ) - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ThrowsExceptionAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ThrowsExceptionAnalysis.scala deleted file mode 100644 index d7b34b8e17..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/ThrowsExceptionAnalysis.scala +++ /dev/null @@ -1,130 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.Domain -import org.opalj.ai.domain.RecordCFG -import org.opalj.ai.domain.l1.RecordAllThrownExceptions -import org.opalj.ai.domain.l1.ReferenceValues -import org.opalj.br.Method -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.ATHROW -import org.opalj.br.instructions.Instruction -import org.opalj.br.instructions.ReturnInstruction -import org.opalj.collection.immutable.Chain -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.LocalVariables -import org.opalj.issues.Operands -import org.opalj.issues.Relevance - -/** - * This analysis identifies those instructions (except of ATHROW) that always lead to an exception. - * - * @author Michael Eichberg - */ -object ThrowsExceptionAnalysis { - - type ThrowsExceptionAnalysisDomain = Domain with ReferenceValues with RecordCFG with RecordAllThrownExceptions - - def apply( - theProject: SomeProject, - method: Method, - result: AIResult { val domain: ThrowsExceptionAnalysisDomain } - ): Chain[Issue] = { - - val operandsArray = result.operandsArray - val domain = result.domain - val code = result.code - - // - // The analysis - // - - val exceptionThrowingInstructions = - code collectWithIndex { - case (pc, i: Instruction) - if operandsArray(pc) != null /* <=> i was executed */ && - i != ATHROW && !i.isInstanceOf[ReturnInstruction] /* <=> i may have regular successors */ && - domain.regularSuccessorsOf( - pc - ).isEmpty /* <=> but i actually does not have a regular successor */ && - ( - domain.exceptionHandlerSuccessorsOf(pc).nonEmpty || - domain.allThrownExceptions.get(pc).nonEmpty - ) => - (pc, i) - } - - // - // Post-Processing - // - - val exceptionIssues: Chain[Issue] = { - - for { (pc, instruction) <- exceptionThrowingInstructions } yield { - val operands = operandsArray(pc) - val exceptions = { - var allExceptions: Set[domain.DomainSingleOriginReferenceValue] = { - if (domain.allThrownExceptions.get(pc).nonEmpty) - Set.empty ++ domain.allThrownExceptions.get(pc).get - else - Set.empty - } - - domain.exceptionHandlerSuccessorsOf(pc).foreach { handlerPC => - operandsArray(handlerPC).head match { - case domain.DomainSingleOriginReferenceValue(sorv) => - allExceptions += sorv - case domain.DomainMultipleReferenceValues(morv) => - allExceptions ++= morv.values - } - } - allExceptions.map(_.upperTypeBound.head.toJava).mkString(", ") - } - - // If we have the case: - // "throw throwsException()", where throwsException always throws an - // exception then we don't want to report an issue. - val relevance = { - val code = method.body.get - val nextPC = code.pcOfNextInstruction(pc) - if (nextPC < code.instructions.size && code.instructions(nextPC) == ATHROW) - Relevance.CommonIdiom - else - Relevance.VeryHigh - } - Issue( - "ThrowsExceptionAnalysis", - relevance, - "evaluation will always lead to an exception", - Set(IssueCategory.Correctness), - Set(IssueKind.ThrowsException), - List(new InstructionLocation( - Some(s"evaluation of $instruction always throws: $exceptions"), - theProject, - method, - pc, - List( - new Operands( - code, - pc, - operands.take(instruction.numberOfPoppedOperands { x => ??? }), - result.localsArray(pc) - ), - new LocalVariables(code, pc, result.localsArray(pc)) - ) - )) - ) - } - } - - exceptionIssues - } - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedFields.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedFields.scala deleted file mode 100644 index 74d3b831c6..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedFields.scala +++ /dev/null @@ -1,119 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.br.ClassFile -import org.opalj.br.ClassType -import org.opalj.br.ConstantString -import org.opalj.br.analyses.FieldAccessInformation -import org.opalj.br.analyses.SomeProject -import org.opalj.br.analyses.StringConstantsInformation -import org.opalj.br.analyses.cg.TypeExtensibilityKey -import org.opalj.fpcf.PropertyStore -import org.opalj.issues.FieldLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Relevance -import org.opalj.log.GlobalLogContext -import org.opalj.log.OPALLogger - -/** - * Identifies fields (static or instance) that are not used and which are also not useable. - * - * @author Michael Eichberg - */ -object UnusedFields { - - def apply( - theProject: SomeProject, - propertyStore: PropertyStore, - fieldAccessInformation: FieldAccessInformation, - stringConstantsInformation: StringConstantsInformation, - classFile: ClassFile - ): Seq[Issue] = { - - val typeExtensibility = theProject.get(TypeExtensibilityKey) - - val candidateFields = classFile.fields.filterNot { field => - (field.isSynthetic) || - // These fields are inlined by compilers; hence, even if the field is not accessed - // it may be used in the source code. - (field.isFinal && (field.fieldType.isBaseType || field.fieldType == ClassType.String)) || - // The field is read at least once... - (fieldAccessInformation.readAccesses(field).nonEmpty) || - // We may have some users of the field in the future... - // IMPROVE use FutureFieldAccess property (TBD) to get the information if we may have future field accesses - (!field.isPrivate && AnalysisModes.isLibraryLike(theProject.analysisMode)) - } - - if (candidateFields.isEmpty) - return Nil; - - val unusedFields = candidateFields.filterNot { field => - // Test if the field defines a (probably inlined) constant string. - field.isFinal && (field.fieldType eq ClassType.String) && - { - field.constantFieldValue match { - case Some(ConstantString(value)) => - stringConstantsInformation.get(value).isDefined - case _ => - false - } - } - } - - val unusedAndNotReflectivelyAccessedFields = unusedFields.filterNot { field => - // Let's test if we can find: - // - the field's name, - // - or the simpleName followed by the field's name - // - or the fully qualified name followed by the field's name - // in the code; if so we assume that the field is reflectively accessed - // and we ignore it - val fieldName = field.name - stringConstantsInformation.get(fieldName).isDefined || { - val thisSimpleTypeName = classFile.thisType.simpleName.replace('$', '.') - val qualifiedFieldName = thisSimpleTypeName + '.' + fieldName - stringConstantsInformation.get(qualifiedFieldName).isDefined - } || { - val thisFullyQualifiedTypeName = classFile.thisType.toJava.replace('$', '.') - val fullyQualifiedFieldName = thisFullyQualifiedTypeName + '.' + fieldName - stringConstantsInformation.get(fullyQualifiedFieldName).isDefined - } - } - - val unusedAndUnusableFields = { - val analysisMode = theProject.analysisMode - if (AnalysisModes.isApplicationLike(analysisMode)) { - unusedAndNotReflectivelyAccessedFields - } else if (analysisMode == AnalysisModes.OPA) { - // Only private fields cannot be accessed by classes that access the currently - // analyzed library. - unusedAndNotReflectivelyAccessedFields.filter(_.isPrivate) - } else if (analysisMode == AnalysisModes.CPA) { - unusedAndNotReflectivelyAccessedFields.filter(f => - f.isPrivate || f.isPackagePrivate || { - f.isProtected && typeExtensibility(classFile.thisType).isNo - } - ) - } else { - val message = s"the analysis mode $analysisMode is unknown" - OPALLogger.error("unused fields analysis", message)(GlobalLogContext) - Nil - } - } - - for (unusedField <- unusedAndUnusableFields) yield { - Issue( - "UnusedField", - Relevance.DefaultRelevance, - s"the field ${unusedField.toJava} is unused", - Set(IssueCategory.Correctness, IssueCategory.Comprehensibility), - Set(IssueKind.UnusedField), - List(new FieldLocation(None, theProject, classFile, unusedField)) - ) - } - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedLocalVariables.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedLocalVariables.scala deleted file mode 100644 index 6083576ace..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedLocalVariables.scala +++ /dev/null @@ -1,288 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.Domain -import org.opalj.ai.analyses.cg.CallGraph -import org.opalj.ai.analyses.cg.CallGraphFactory -import org.opalj.ai.domain.RecordDefUse -import org.opalj.ai.domain.TheCode -import org.opalj.br.Method -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.ACONST_NULL -import org.opalj.br.instructions.BIPUSH -import org.opalj.br.instructions.DCONST_0 -import org.opalj.br.instructions.DCONST_1 -import org.opalj.br.instructions.FCONST_0 -import org.opalj.br.instructions.FCONST_1 -import org.opalj.br.instructions.FCONST_2 -import org.opalj.br.instructions.GETSTATIC -import org.opalj.br.instructions.ICONST_0 -import org.opalj.br.instructions.ICONST_1 -import org.opalj.br.instructions.ICONST_2 -import org.opalj.br.instructions.ICONST_3 -import org.opalj.br.instructions.ICONST_4 -import org.opalj.br.instructions.ICONST_5 -import org.opalj.br.instructions.ICONST_M1 -import org.opalj.br.instructions.IINC -import org.opalj.br.instructions.INVOKEINTERFACE -import org.opalj.br.instructions.INVOKESPECIAL -import org.opalj.br.instructions.INVOKESTATIC -import org.opalj.br.instructions.INVOKEVIRTUAL -import org.opalj.br.instructions.LCONST_0 -import org.opalj.br.instructions.LCONST_1 -import org.opalj.br.instructions.LDC -import org.opalj.br.instructions.LDC2_W -import org.opalj.br.instructions.LDC_W -import org.opalj.br.instructions.LoadConstantInstruction -import org.opalj.br.instructions.MethodInvocationInstruction -import org.opalj.br.instructions.SIPUSH -import org.opalj.br.instructions.StoreLocalVariableInstruction -import org.opalj.fpcf.EP -import org.opalj.fpcf.PropertyStore -import org.opalj.fpcf.properties.LBPure -import org.opalj.fpcf.properties.Purity -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.MethodLocation -import org.opalj.issues.Relevance -import org.opalj.log.OPALLogger - -/** - * Identifies unused local variables in non-synthetic methods. - * - * @author Michael Eichberg - */ -object UnusedLocalVariables { - - def apply( - theProject: SomeProject, - propertyStore: PropertyStore, - callGraph: CallGraph, - method: Method, - result: AIResult { val domain: Domain with TheCode with RecordDefUse } - ): Seq[Issue] = { - - if (method.isSynthetic) - return Nil; - - // - // - // IDENTIFYING RAW ISSUES; IN OTHER WORDS: "THE ANALYSIS" - // - // - - val operandsArray = result.operandsArray - val allUnused = result.domain.unused() - val unused = allUnused.withFilter { vo => - // IMPROVE Improve the identification of unused method parameters... check if future overridings are possible; if it already overrides a method where the parameter is used... - (vo < 0 && ( - ( - method.isPrivate && - !CallGraphFactory.isPotentiallySerializationRelated(method)(theProject.classHierarchy) - ) - ) || - method.isStatic) || - // filter unused local variables related to dead code... - // (we have another analysis for that) - (vo >= 0 && (operandsArray(vo) ne null)) - } - - if (unused.isEmpty) - return Nil; - - // - // - // POST PROCESSING ISSUES TO FILTER LIKELY FALSE POSITIVES - // - // - - val code = result.domain.code - val instructions = code.instructions - val implicitParameterOffset = if (!method.isStatic) 1 else 0 - - var issues = List.empty[Issue] - - // It may happen that a user defines a final local constant - // which is then used by the compiler whenever we have a - // reference in the code; in this case we actually have an unused - // local variable in the bytecode... - // E.g., given the following code: - // final int MAGIC = 12012; - // ... - // if (x == MAGIC) {...} - // then the value 12012 is then directly used in the comparison - // which makes the initial declaration (at the bytecode level) - // unused. - lazy val constantValues: Set[Any] = { - import code.collectInstructions - val allConstantsValues = collectInstructions { case LoadConstantInstruction(v) => v } - val constantValuesOnlyUsedOnces = allConstantsValues.groupBy(v => v).collect { - case (k, occurences) if occurences.tail.isEmpty => k - } - constantValuesOnlyUsedOnces.toSet - } - - unused foreach { vo => - var issue: String = null - var relevance: Relevance = Relevance.Undetermined - if (vo < 0) { - // we have to make sure that we do not create an issue report - // for instance methods that can be/are inherited - if (method.isStatic || - method.isPrivate || - // IMPROVE Check that in all other cases the method parameter is never used across all implementations of the method; only then report it. - method.name == "" - ) { - relevance = Relevance.High - if (vo == -1 && !method.isStatic) { - issue = "the self reference \"this\" is unused (the method could be static)" - } else { - val index = (-(vo + implicitParameterOffset)) - code.localVariable(0, index - 1) match { - case Some(lv) => issue = s"the parameter ${lv.name} is unused" - case None => issue = s"the $index. parameter is unused" - } - } - } - } else { - val instruction = instructions(vo) - - def defaultUnusedValueHandling(): Unit = { - val instructionDescription = instruction.toString(vo).replace("\n", "\\n") - issue = "the value of " + instructionDescription + " is not used" - relevance = Relevance.VeryHigh - } - - instruction.opcode match { - - case INVOKEVIRTUAL.opcode | INVOKEINTERFACE.opcode | - INVOKESTATIC.opcode | INVOKESPECIAL.opcode => - val invoke = instruction.asInstanceOf[MethodInvocationInstruction] - try { - val resolvedMethod: Iterable[Method] = callGraph.calls(method, vo) - // IMPROVE Use a more precise method to determine if a method has a side effect "pureness" is actually too strong. - if (resolvedMethod.exists(m => propertyStore(m, Purity.key) == EP(m, LBPure))) { - issue = "the return value of the call of " + invoke.declaringClass.toJava + - "{ " + - invoke.methodDescriptor.toJava(invoke.name) + - " } is not used" - relevance = Relevance.OfUtmostRelevance - } - } catch { - case b: Break[?] => throw b - case t: Throwable => - val message = "assessing analysis result failed; ignoring issue" - OPALLogger.error("error", message, t)(theProject.logContext) - } - - case ACONST_NULL.opcode | - ICONST_0.opcode | - ICONST_M1.opcode | - LCONST_0.opcode | - FCONST_0.opcode | - DCONST_0.opcode => - val nextPC = code.pcOfNextInstruction(vo) - instructions(nextPC) match { - case StoreLocalVariableInstruction((_, index)) => - // The typical pattern generated by a compiler if the - // value is used to set "some initial value" is that - // after pushing the constant value on the stack, the - // value is immediately stored in a register... - // - // final int i = 0 - // if (x == ...) i = j*1; else i = abc(); - // - - val lvOption = code.localVariable(nextPC, index) - if (lvOption.isDefined && lvOption.get.startPC < vo) { - issue = s"the constant value ${instruction.toString(vo)} is not used" - relevance = Relevance.Low - } - // else... we filter basically all issues unless we are sure that - // this is a real issue; i.e., - // - it is not a default value - // - it is not a final local variable - - case _ => - issue = "the constant value " + - instruction.toString(vo) + - "is (most likely) used to initialize a local variable" - relevance = Relevance.TechnicalArtifact - } - - case BIPUSH.opcode | SIPUSH.opcode | - ICONST_1.opcode | ICONST_2.opcode | ICONST_3.opcode | ICONST_4.opcode | ICONST_5.opcode | - LCONST_1.opcode | - DCONST_1.opcode | - FCONST_1.opcode | FCONST_2.opcode | - LDC.opcode | LDC_W.opcode | LDC2_W.opcode => - val LoadConstantInstruction(value) = instruction - if (constantValues.contains(value)) { - // => the value is only found once in the source code and - // the value is not used! - issue = "the constant " + - instruction.toString(vo).replace("\n", "\\n") + - " is not used" - relevance = Relevance.TechnicalArtifact - } - - case IINC.opcode => - issue = "the incremented value is not used" - relevance = Relevance.DefaultRelevance - - case GETSTATIC.opcode => - val GETSTATIC(_, _, fieldType) = instruction - if (fieldType.isClassType) { - val instr = instruction.toString(vo) - - theProject.classFile(fieldType.asClassType) match { - case Some(cf) => - if (cf.isEnumDeclaration) { - issue = s"the enum value $instr" + - "is (most likely) used to initialize a local variable" - relevance = Relevance.TechnicalArtifact - } else { - defaultUnusedValueHandling() - } - case None => - // we were not able to find the class - issue = s"the field value $instr is not used" - relevance = Relevance.DefaultRelevance - } - } else - defaultUnusedValueHandling() - - case _ => - defaultUnusedValueHandling() - } - - } - - if (issue ne null) { - issues ::= Issue( - "UnusedLocalVariables", - relevance, - issue, - Set(IssueCategory.Comprehensibility, IssueCategory.Correctness), - Set(IssueKind.UnusedLocalVariable), - List( - if (vo >= 0) - new InstructionLocation(None, theProject, method, vo) - else - new MethodLocation(None, theProject, method) - ) - ) - } - } - - issues - - } - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedMethodsAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedMethodsAnalysis.scala deleted file mode 100644 index f9ffdbfa91..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UnusedMethodsAnalysis.scala +++ /dev/null @@ -1,167 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.analyses.cg.ComputedCallGraph -import org.opalj.bi.VisibilityModifier -import org.opalj.br.Method -import org.opalj.br.MethodDescriptor -import org.opalj.br.VoidType -import org.opalj.br.analyses.SomeProject -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.MethodLocation -import org.opalj.issues.Relevance - -/** - * Identifies unused methods and constructors using the given call graph. - * - * @author Marco Jacobasch - * @author Michael Eichberg - */ -object UnusedMethodsAnalysis { - - /** - * Checks if the given method is used/is potentially useable. If the method is not used - * and is also not potentially useable by future clients, then an issue is created - * and returned. - * - * If any of the following conditions is true, the method is considered as being called. - * - The method is the target of a method call in the calculated call graph. - * - The method is a private (empty) default constructor in a final class. Such constructors - * are usually defined to avoid instantiations of the respective class. - * - The method is a private constructor in a final class that always throws an exception. - * Such constructors are usually defined to avoid instantiations of the - * respective class. E.g., - * `private XYZ(){throw new UnsupportedOperationException()` - * - The method is "the finalize" method. - */ - def apply( - theProject: SomeProject, - callgraph: ComputedCallGraph, - callgraphEntryPoints: Set[Method], - method: Method - ): Option[Issue] = { - - if (method.isSynthetic) - return None; - - if (method.name == "finalize" && (method.descriptor eq MethodDescriptor.NoArgsAndReturnVoid)) - return None; - - if (callgraphEntryPoints.contains(method)) - return None; - - def rateMethod(): Relevance = { - - val classFile = method.classFile - - import method.{isConstructor, isPrivate, actualArgumentsCount, descriptor, name} - import descriptor.returnType, parametersCount as declaredParametersCount - - // - // Let's handle some technical artifacts related methods... - // - if (name == "valueOf" && classFile.isEnumDeclaration) - return Relevance.Undetermined; - - // - // Let's handle the standard methods... - // - if ((name == "equals" && descriptor == ObjectEqualsMethodDescriptor) || - (name == "hashCode" && descriptor == ObjectHashCodeMethodDescriptor) - ) { - return Relevance.VeryLow; - } - - // - // Let's handle standard getter and setter methods... - // - if (name.length() > 3 && - ((name.startsWith("get") && returnType != VoidType && declaredParametersCount == 0) || - (name.startsWith("set") && returnType == VoidType && declaredParametersCount == 1)) && - { - val fieldNameCandidate = name.substring(3) - val fieldName = fieldNameCandidate.charAt(0).toLower + fieldNameCandidate.substring(1) - classFile.findField(fieldName).nonEmpty || - classFile.findField('_' + fieldName).nonEmpty || - classFile.findField('_' + fieldNameCandidate).nonEmpty - } - ) { - return Relevance.VeryLow; - } - - // - // IN THE FOLLOWING WE DEAL WITH CONSTRUCTORS - // - - // Let's check if it is a default constructor - // which was defined to avoid instantiations of the - // class (e.g., java.lang.Math) - val isPrivateDefaultConstructor = isConstructor && isPrivate && actualArgumentsCount == 1 /*this*/ - if (!isPrivateDefaultConstructor) - return Relevance.DefaultRelevance; - - val constructorsIterator = classFile.constructors - constructorsIterator.next // <= we always have at least one constructor in bytecode - if (constructorsIterator.hasNext) - // we have (among others) a default constructor that is not used - return Relevance.High; - - val body = method.body.get - val instructions = body.instructions - def justThrowsException: Boolean = { - !body.exists { (pc, i) => /* <= it just throws exceptions */ - i.isReturnInstruction - } - } - if (instructions.size == 5 /* <= default empty constructor */ ) - Relevance.TechnicalArtifact - else if (justThrowsException) - Relevance.CommonIdiom - else - Relevance.DefaultRelevance - } - - // - // - // THE ANALYSIS - // - // - - def unusedMethodOrConstructor: String = { - def access(flags: Int): String = - VisibilityModifier.get(flags) match { - case Some(visiblity) => visiblity.javaName.get - case _ => "/*default*/" - } - - val isConstructor = method.isConstructor - val accessFlags = access(method.accessFlags) - s"the $accessFlags ${if (isConstructor) "constructor" else "method"} is not used" - } - - val callers = callgraph.callGraph calledBy method - - if (callers.isEmpty) { - val relevance: Relevance = rateMethod() - if (relevance != Relevance.Undetermined) { - val issue = Issue( - "UnusedMethodsAnalysis", - relevance, - unusedMethodOrConstructor, - Set(IssueCategory.Comprehensibility), - Set(IssueKind.UnusedMethod), - List(new MethodLocation(None, theProject, method)) - ) - return Some(issue); - } - } - - None - } - -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessComputationsAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessComputationsAnalysis.scala deleted file mode 100644 index bcc6512ad1..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessComputationsAnalysis.scala +++ /dev/null @@ -1,174 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.Domain -import org.opalj.ai.collectPCWithOperands -import org.opalj.ai.domain.ConcreteIntegerValues -import org.opalj.ai.domain.ConcreteLongValues -import org.opalj.ai.domain.l1.ReferenceValues -import org.opalj.br.ComputationalTypeInt -import org.opalj.br.ComputationalTypeLong -import org.opalj.br.Method -import org.opalj.br.PC -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.IAND -import org.opalj.br.instructions.IINC -import org.opalj.br.instructions.INEG -import org.opalj.br.instructions.INSTANCEOF -import org.opalj.br.instructions.IOR -import org.opalj.br.instructions.LNEG -import org.opalj.br.instructions.ShiftInstruction -import org.opalj.br.instructions.StackBasedBinaryArithmeticInstruction -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Operands -import org.opalj.issues.Relevance - -/** - * Identifies computations that are useless (i.e., computations that could be done - * in the source code). - * - * @author Michael Eichberg - */ -object UselessComputationsAnalysis { - - type UselessComputationsAnalysisDomain = - Domain with ConcreteIntegerValues with ConcreteLongValues with ReferenceValues - - def apply( - theProject: SomeProject, - method: Method, - result: AIResult { val domain: UselessComputationsAnalysisDomain } - ): Seq[Issue] = { - - val defaultRelevance = Relevance.DefaultRelevance - val defaultIIncRelevance = Relevance(5) - - val code = result.code - - def createIssue(pc: PC, message: String, relevance: Relevance): Issue = { - val operands = result.operandsArray(pc) - val localVariables = result.localsArray(pc) - val details = new InstructionLocation( - None, - theProject, - method, - pc, - List(new Operands(code, pc, operands, localVariables)) - ) - Issue( - "UselessComputationsAnalysis", - relevance, - s"the expression ($message) always evaluates to the same value", - Set(IssueCategory.Comprehensibility, IssueCategory.Performance), - Set(IssueKind.ConstantComputation), - List(details) - ) - } - - import result.domain - import result.operandsArray - import domain.ConcreteIntegerValue - import domain.ConcreteLongValue - - collectPCWithOperands(domain)(code, operandsArray) { - - // IMPROVE Add support for identifying useless computations related to double and float values. - - // HANDLING INT VALUES - // - case ( - pc, - instr @ StackBasedBinaryArithmeticInstruction(ComputationalTypeInt), - Seq(ConcreteIntegerValue(a), ConcreteIntegerValue(b), _*) - ) => - // The java "~" operator has no direct representation in bytecode. - // Instead, compilers generate an "ixor" with "-1" as the - // second value. - if (instr.operator == "^" && a == -1) { - val message = s"constant computation: ~$b (<=> $b ${instr.operator} $a)." - createIssue(pc, message, defaultRelevance) - } else { - val message = s"constant computation: $b ${instr.operator} $a." - createIssue(pc, message, defaultRelevance) - } - - case (pc, IOR, Seq(ConcreteIntegerValue(0), _*)) => - createIssue(pc, "0 | x will always evaluate to x", Relevance.High) - case (pc, IOR, Seq(_, ConcreteIntegerValue(0), _*)) => - createIssue(pc, "x | 0 will always evaluate to x", Relevance.High) - case (pc, IOR, Seq(ConcreteIntegerValue(-1), _*)) => - createIssue(pc, "-1 | x will always evaluate to -1", Relevance.High) - case (pc, IOR, Seq(_, ConcreteIntegerValue(-1))) => - createIssue(pc, "x | -1 will always evaluate to -1", Relevance.High) - - case (pc, IAND, Seq(ConcreteIntegerValue(0), _*)) => - createIssue(pc, "0 & x will always evaluate to 0", Relevance.High) - case (pc, IAND, Seq(ConcreteIntegerValue(-1), _*)) => - createIssue(pc, "-1 & x will always evaluate to -1", Relevance.High) - case (pc, IAND, Seq(_, ConcreteIntegerValue(0), _*)) => - createIssue(pc, "x & 0 will always evaluate to 0", Relevance.High) - case (pc, IAND, Seq(_, ConcreteIntegerValue(-1), _*)) => - createIssue(pc, s"x & -1 will always evaluate to x", Relevance.High) - - case (pc, INEG, Seq(ConcreteIntegerValue(a), _*)) => - createIssue(pc, s"constant computation: -${a}", defaultRelevance) - - case ( - pc, - IINC(index, increment), - _ - ) if domain.intValueOption(result.localsArray(pc)(index)).isDefined => - val v = domain.intValueOption(result.localsArray(pc)(index)).get - val relevance = - if (increment == 1 || increment == -1) - defaultIIncRelevance - else - defaultRelevance - createIssue(pc, s"constant computation (inc): ${v} + $increment", relevance) - - // HANDLING LONG VALUES - // - case ( - pc, - instr @ StackBasedBinaryArithmeticInstruction(ComputationalTypeLong), - Seq(ConcreteLongValue(a), ConcreteLongValue(b), _*) - ) => - val message = s"constant computation: ${b}l ${instr.operator} ${a}l." - createIssue(pc, message, defaultRelevance) - case ( - pc, - instr @ ShiftInstruction(ComputationalTypeLong), - Seq(ConcreteLongValue(a), ConcreteIntegerValue(b), _*) - ) => - val message = s"constant computation: ${b}l ${instr.operator} ${a}l." - createIssue(pc, message, defaultRelevance) - - case (pc, LNEG, Seq(ConcreteLongValue(a), _*)) => - createIssue(pc, s"constant computation: -${a}l", defaultRelevance) - - // HANDLING REFERENCE VALUES - // - - case ( - pc, - INSTANCEOF(referenceType), - Seq(rv: domain.ReferenceValue, _*) - ) - if domain.intValueOption( - operandsArray(pc + INSTANCEOF.length).head - ).isDefined => - val utb = rv.upperTypeBound.map(_.toJava) - val targetType = " instanceof " + referenceType.toJava - val message = utb.mkString("useless type test: ", " with ", targetType) - createIssue(pc, message, defaultRelevance) - - } - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessReComputationsAnalysis.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessReComputationsAnalysis.scala deleted file mode 100644 index 2fbd3995a3..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/UselessReComputationsAnalysis.scala +++ /dev/null @@ -1,103 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core -package analyses - -import org.opalj.ai.AIResult -import org.opalj.ai.ValuesDomain -import org.opalj.ai.collectPCWithOperands -import org.opalj.ai.domain.ConcreteIntegerValues -import org.opalj.ai.domain.ConcreteLongValues -import org.opalj.ai.domain.TheCode -import org.opalj.br.Method -import org.opalj.br.analyses.SomeProject -import org.opalj.br.instructions.IStoreInstruction -import org.opalj.br.instructions.LStoreInstruction -import org.opalj.collection.immutable.:&: -import org.opalj.issues.InstructionLocation -import org.opalj.issues.Issue -import org.opalj.issues.IssueCategory -import org.opalj.issues.IssueKind -import org.opalj.issues.Operands -import org.opalj.issues.Relevance - -/** - * Identifies computations of primitive values that lead to the same result as a - * previous computation. Such computations (which could be a constant expression) - * are generally useless and hinder code comprehension. - * - * @author Michael Eichberg - */ -object UselessReComputationsAnalysis { - - def apply( - theProject: SomeProject, - method: Method, - result: AIResult { val domain: TheCode with ConcreteIntegerValues with ConcreteLongValues with ValuesDomain } - ): Seq[Issue] = { - - import result.domain.ConcreteIntegerValue - import result.domain.ConcreteLongValue - import result.domain - - if (!domain.code.localVariableTable.isDefined) - // This analysis requires debug information to increase the likelihood - // that we identify the correct local variable re-assignments. Otherwise - // we are not able to distinguish the reuse of a "register variable"/ - // local variable for a new/different purpose or the situation where - // the same variable is updated the second time using the same - // value. - return Seq.empty; - - val operandsArray = result.operandsArray - val localsArray = result.localsArray - val code = domain.code - - val methodsWithValueReassignment = - collectPCWithOperands(domain)(code, operandsArray) { - case ( - pc, - IStoreInstruction(index), - ConcreteIntegerValue(a) :&: _ - ) - if localsArray(pc) != null && - domain.intValueOption(localsArray(pc)(index)).map(_ == a).getOrElse(false) && - code.localVariable(pc, index).map(lv => lv.startPC < pc).getOrElse(false) => - (pc, index, a.toString) - - case ( - pc, - LStoreInstruction(index), - ConcreteLongValue(a) :&: _ - ) - if localsArray(pc) != null && - domain.longValueOption(localsArray(pc)(index)).map(_ == a).getOrElse(false) && - code.localVariable(pc, index).map(lv => lv.startPC < pc).getOrElse(false) => - (pc, index, a.toString) - } - - methodsWithValueReassignment.map { e => - val (pc, index, value) = e - val lv = code.localVariable(pc, index).get - val details = List(new Operands(code, pc, operandsArray(pc), localsArray(pc))) - val location = new InstructionLocation( - Some("useless (re-)assignment"), - theProject, - method, - pc, - details - ) - - Issue( - "UselessReevaluation", - Relevance.Low, - s"(re-)assigned the same value ($value) to the same variable (${lv.name})", - Set(IssueCategory.Comprehensibility), - Set(IssueKind.ConstantComputation), - List(location) - ) - - } - } -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/package.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/package.scala deleted file mode 100644 index ce53e57a1e..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/analyses/package.scala +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker -package core - -import org.opalj.br.BooleanType -import org.opalj.br.ClassType -import org.opalj.br.IntegerType -import org.opalj.br.MethodDescriptor -import org.opalj.br.analyses.AnalysisException -import org.opalj.issues.Issue -import org.opalj.util.Nanoseconds - -/** - * Common constants and helper methods used by the BugPicker's analyses. - * - * @author Michael Eichberg - */ -package object analyses { - - type BugPickerResults = (Nanoseconds, Iterable[Issue], Iterable[AnalysisException]) - - final val AssertionError = ClassType.AssertionError - - final val ObjectEqualsMethodDescriptor = MethodDescriptor(ClassType.Object, BooleanType) - - final val ObjectHashCodeMethodDescriptor = MethodDescriptor.withNoArgs(IntegerType) -} diff --git a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/package.scala b/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/package.scala deleted file mode 100644 index d902da1b3b..0000000000 --- a/TOOLS/bp/src/main/scala/org/opalj/bugpicker/core/package.scala +++ /dev/null @@ -1,30 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package org.opalj -package bugpicker - -import scala.io.Source - -import org.opalj.io.process - -/** - * Common constants used by the BugPicker. - * - * @author Michael Eichberg - */ -package object core { - - def getAsset(path: String): String = { - process(getClass.getResourceAsStream(path)) { in => Source.fromInputStream(in).mkString } - } - - lazy val HTMLCSS: String = getAsset("html.css") - - lazy val HTMLJS: String = getAsset("html.js") - - lazy val SearchJS: String = getAsset("search.js") - - lazy val ReportCSS: String = getAsset("report.css") - - lazy val ReportJS: String = getAsset("report.js") - -} diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/AnonymousInnerClassShouldBeStatic.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/AnonymousInnerClassShouldBeStatic.jar deleted file mode 100644 index 6d675890a78608068d657078cdfa10d400f5b50c..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 7303 zcmcIo2UJsOx6RN6H1rPAL^=r|N(o2_J(K{_r6tr5dY7U==txymdQ%V-1R*FO5|G{n zqz6Snq$vUd3NQRK|I=~J^SNftoUE*MvvSux-*?ac_St6}=n#`I04OLZ0R6Z7)d1fG z1AqhogBmM~Y3Zp;z?Aj0)S*Vk;xP5YZUA5l*4v}2BPKp{Qb$aI8Xb*IdyN92T78;H8Rz=zQ_!v2R_@NLg zNF!f6Ul#|7zqo@REbef8XO5Az{>zID5Mq%MH?MIh4WpXxD3Vqf`~sNRrNRv^Q-R|S zPyvXTTB*_;mCxq4@5KQR0pS@R`cd>n6Q8Sq>9evv8x2djw+_E-eQrDFPAt}Uy{P|~s0i_{VV>BF<7SJ|d-`SO1R z$_=zd*gd9C+V+}z!9UkQhYrSm7#C|}MtC#fnQpj{S+ilHX_H>g8;WPf!NddWq!Oks z)eGu!26&F+*l=I6+5o$Qj+=@Wf+lLFU2Kn~Nb)X7ukuh3KpYk)9bI?6epQZQs)eeh(3;VZ=+I*DZ?LCitNX6W-~Ut- zEF`#0{;8<&X%R!T{yMHn%4qi+J=)fX$!AGD>tZFlV=KgGg$>{Df~+A5AanIBYE^IlPqUP z^?6-0 z@bwXt>MoLhsHt>kPNqHMw|cN1c!bX&7eq9X_u7&_4%pksXBvK{{^^F`OD&guQlDq` z<|7SJ(*B^NP(HaSk=2A!A#uA~2zoQH-+i+p6g?aS`*8BO*bJ)qs3=0QSBQRAY>i(k z_U}aUjbQj;K~R4r+E>#KjX)v2e=mFq9Of}{ktQ^~)XQGi5)N;+uy7XA0-9ZOpn=C; z8QG(qx;^T$++w21T=lVmWwpR0=H6H;sNkV}q zTb+xOa-B*=FT06tc?rk!DxO2ig@`+dRA{%#iRJ-kdu_6H+-*)kbdc)>TCXn9FY)R| zE1sBx4Iu0xwG{Gr_=P`XDE{9v;pdbOKsF^U|cN~mf z7qWb-;&Nl&Gh4+jDIl0^sm=!~7+I)1ykRJy(4SdX-B;3yai8|4?`+-2MsfnDqWW~` zh^O1dpC2se8`n%1RzAr_enu=?@%tkVJUHpUyvhjTwGm#ryrHkpB`eNj#`|c~Q#0_( z#v$F9xLhKn>U86!y|bvz*TBB|Q+X=MZC=~U>|X{(eOf~969K(4ck}gH*v4cZ&137h zuV0wz@@vkYYT9G0zeyCf4Z_Q5WOiQ4!P0o$g-ko#B3n1j4&^Ww9q%JnP&+t(3>L1b z(M>D?EK)yZh6{fSEWe{8lRyhN5Cddl@yTezyX-AX!yP<%MPaj0D+9D3tObF07$ajY z6RLfOQ0ieOB@K^I(r#Qs;F`ozLelPJ`{<*a!xftW9JVtThSk%&RE-FO^ z7CS?gREF|%pq&(F{by4{V9Buf34U`Nf4j;N(Y!IQ0Y}P)rX9Gq z`y$4oz1WjeR#+yXNv&pb>8r~k1#`7pxsd4DM#c)d+ZjS5R;ugF$Hktao!^Wh6uaT4 z%wX_K#r_Lzq3qy*^zm^)JL&uR{vk;ID>o{QtvyBvAh_J~2!mRak!hBZ$-g+RQWM8q z%u@_^C(5YSf`+Jh8;t~OuL^mQ9hh@Bw-GBvoQ}r!^L{Yl;bQCR-u|%t0itMnxbwBg z6tG+U);50LT*JkW?Y(Gdd4}c_TK$n(O{XDz^)f3Ov3$L2IjTU@s0?#(ODJFNLnf=M z#+RrAT2s~VXW{%RZ)|VdozvKJdy_z4kT`cD>7{T=8Le6u$X#8s(gQC0ym)0oU@Qi% zwH0gk5G*^Hq>Ax21*(x!*Kl$4Vg(CU3a+uKmf6vlUp0Om#Iy_jcx{*Oc@@oaibjk= zs{iE(q{tnfEHl4tu{7(qduv>=3z>TMU|Tac5{Hwos=-3#c)AA{uwU+kHW_)J-SK1; z;n#7(*u6_scRk`x?f#_88`!w^nr)1;0<3T=;}me*E7A_Lq*DjJtT)_>XU@cAP;04j z)^kqVn{n_B;W(vPvK^?P@#2La&PQ+Oq?U;sJ#izezgxr4@N`(_;`<|Ew57VFzeaRw zolZz=;-{8K4@>lH>`Pxiju9S@z$>V@ro1b>?Q)M@<6g*CS@ijfLI6h6!k#A}`a{IG zE!*7d6kFWFTBoNJoM!F!;%8=BiJ)BVOxA7D95$`q&mUP<^)}(!7efN`s`qKnA0b>F zZcx_i_Bc(DrYFe^_PV*h4OxH9^|j}vjXP@bz&uPQROvrDm+A()^Cq;z@>PI6^j*XH%ZDMr-Z+F#T%~!)ux@uv5#m2bkYj3xC1X5bIXQ4OvjA(23 zr@6b@Q=O&o-my?C+)3d0iHAMHaxJh5xIRoIF7URqbvjQ zv}yuA)a!wo51-tT3RY19qump*hY}sRZlA5$3U{_oO;jt-4qd5`-KJ5zss2udvj+R6 zbHPP4rrTujKxz7J@)@2BI%!q`?+eEV?aNH|aPXq}Pm6jAklwA!OCvOlTo-*R0|4P` z7&^Poc=!bx|7tOY@2R~!;dK2ri;QBoEQa1~lFK!nFS0$ZOBfbGHl5%kCO zwqCU%Tt}cc@J}J-`maL@hV*szK>XhQDhYEI0ZovRF>&jg@QZ4drv*v1wJPFBPHXF? zM8%r7VKEx%@74!TP4s8YnA3;dc=2$v1&G&R-9X)D;NwwTMei(zWoI`zt>+}nIV}Nl zi{9k7(X0tp>S@U7>}Jw+p?gQ9Syn`oFUPfb^5NDQV{J47`)H&%4)hP;HyF<=6R!FISWOdOD-Xoq254 z`UClc+^>0>u#;3~zMcmUl}YZF(eeQUJa0-bCptdDFCojGZqSwK+R{DOfH1=pJU#Q~ z{S09tfw3CYMhX%WVxP?x8o%fWpA=$E!E~7UZ${Z2QpRyvnAv$MP8e4#b59<@U-3M> z+Mi~yswLl@bmX>FhP2-l;8vy@Y;;7K6+%QtpvWYQwaiEDPqJBsSCSfG@$N6yP*=`w z(a+xGkW#JFW(jF$M>I_bfD>e2IdN@+aWVz&m4}S=a&!2@)~3^Dx2v$SM@*$3Ueg(c z_8PakqQ?jOs}pAh#;z(IL(Gup7Gnq=XMVThLK_ zHmd|!wVzQ*E(pI@8_c$RLC!=wsxm^u@Ibjkc|)`I#`iE$1qV+qw|zLI<}04Zk10lH`}qC14@>oq_Ts|&(&y{@0O%3 zM$8x9ww|Hmq84;I#Dd^)J%NLa^XE3mt`)4heIli*>)-UFU}u{#++7?5QAw#UEJy)+#lQjx>i75Y0C(SwaLGB&lqC-N${Oaosb*R zQ}gF}X9VNPj}>>eX!K<@g;flv-Hx*nFj3h~P^@an=tyL8kyMFVAjhU) zdA%Qp^mVlvPrk1!5{asF%!d3X?}cTo?_FWn<_rE1$Dq8WYfUjS1|yfn*vBY+bZs%Y zA3VBDF$Y?JS*pMF!)#et_^qa`ycoefXy5=mGs!mrSAt#D0oG1GIRyUZP=5XdF8>N zY8~xvf3~5UYI^vUyg)D|y0A&VG1A6ZGD~Mwfr&0-=yn_L=6`G#=a^7|%~~=XbKee{c*-iEZ-#5- z*|6G~)V9<3>yrJPq(pRhoR?Mr+R-UD$kE?pe`(|49Doa79nFACfR>EjOgpUqg zB@{a)tq7F>A#yd(^hsfI;Xye(GlLI03&_6)nRPmP#i7(mN`cfjx0a!pVzJCXMt_Ue z@E*&{)Rmm;l|DA=!Q)vnmXfxCE@w@6hd2|l(!O_#Mz;nUw}$AM)ME{;SPAM=rvPm6 z7L*u9H7*na@4EY5Hqly z`uPXJiuW2Q;&{TB`IooKBs<&0d)S}PsQQ^x4pH>lO-#RmCar8*WbxbGX>gQCZ0>z>gNI!bQ13uy z9J@T$(KG=3L>YTN?DeA8AZ4_P5SA-4d6m>(*`NhUeSdn8=eP-Wy!yvhAdsuKLM0g?S<^m+`T-p}@M#s^0 z>gy5V$26FjP4(2BAm+u%kH!3NL=1p$zWDcs_OUPi=lH)|^6#H=Y<_?5U>=*_-@=Y? z`4_|JuUp|iruyDLJGMl>MIB*_e=F7R$MVNS-+M2|cHFlpBD|*mKhZClb3Z2i-UB$c zb-u+Q+22X}*IWD3boVU<;i`$^SF-%Y=6~WY{J6*O2Z7@W@>^(8{e#(mZJzvbaoY0Wd;u+q``eX{SVK| zy-<8J{dSrjV2WS{R)x_o9;GbBOLb9c&Wh=I`&}>gwhLadpB3 zy7|lM`TG02xdhUFLbwJ0=c|m1w^Kkswy73^0m6<;vDYRHqPQRxgJAHL8-hsvfxP%A zp2+2_dOE9j=SS_07u{`Gc(wpxscQA=rd-nF&XYY@-=K@D3!Bs2P1=@Tk{pNo&M9@3 zE2)U4HP@<-@{W)afVeWSHG`4#ndYAZT!&=u>>Q(DJUHO3h5 zuMomMd4xJ~a51OtwS+a#bvf5zt5y!sj}Xq1L0w+-ulVI5JFVmVOkZrO5XDmgll`6i z94e=p`*Ho~p_-$X{1S=lBQVsss5xlq#-md7raHEN5|4bw+?12-x`c^Qz8?zVB+Y9U zY>~;4Z6zX?A(^a5MD5TngO5foO_EFvzpxhD{!fcyi0)g&b^|9t-7^;CYyw zMy?NGpJ<>0>+PyuTZW}eG+)1kJr;`x&dB-B^kSbIX=_hS(#^X(h^5cRf?IxB z3+aJBmm~i!$|cg<^{W`%FVEdB!!Ugbrr8xJQ*u{-^eVf{2Qm@FI~A-sV~y2`i0H~E z5Vgg*>=v~1Um&1m`O#~qx{BHP8VPIQqlc|0Vj*o2_i`D9=UBzi*(qW;S@V{gUlQ-v zN30JdH=Ow{k)Kn=uJL>e2&7ftoQbRt8n1F;Ir_sdz?v*kbGlrFhR23%!TjrAE0{h? zR}@`P_$VN5iJayYy*{07)zeTL)Y}#-a=G$?GY%|Qi%P19F!0gFgtX#RgYNj@e(Z@? zvFnJ%md`GiI#RKmi)*Nnq+pTQfn_c{ct_%$*c*$nZy@BaB>6K9;!V5Z4DwuBm5H;2 zkw(&cW?|^bIVt^xf)8`s0Mj<1>P(4$j>FRGJStFTu^M1U~#fmE)MH&Vr<;k zJGRk%GF)-q#`=Okkw zWnCp##Psf-MJtMyi#V#CY3dWcp`_QBl8+)V3*;|ekzhXvlbu`2>rGSIBpA(M)t%Lr zw>XFw$n0RI)tpC(^5XW38>oAQ5LOe5*!RV_l$x z=aS5E5hDRDk&o?Jq_(4ifG7Q|vv%A{&k4j2y&Lgv*%@OSQ}tNVdo2YL&W@yU&W(eLn%E8D^TT@lTqMIA1LdMGUy*C4XSpm%(|mVRc@qP!2$)2n_mGy z*M6+zp#YenJloFEhuY~JD*Fbo+cnbuK6%6VkrGu|yy_1aSRx$4B>SC~b;wi@vwggw z&EuP&rA+WqUp*s+2yed5x-r@JG`Mvvv48bMIEZu_#hxHjZP-1A&wki}3G!JUeQ3_Q z;3eY@j|i_=%VT}89A{;ZnHfnm0`_}f#3c@lzZPJ}caLKT;_0VQ$3+7{Ss!}I9?#0k zqfUTSl0yrJuLV6Saqn%K8gp;)Tbc?liufdwvFYCv$v!m=Qhj^UZee_VIM5mg97}pp zY^>*yY$=xvXGy_$y+5?@$~J+i^+|BJTXWxP_;0atPM3Tp%f0I23|6|&1h_oTvE87j z-fYIMktZvZV=LNmu#jDz5B(PhYvmD$qB^*@uaoPaHHm0KsYwuaQlFO#!Jq(mtf4*H zM^}@V9!z!~xPClGBC~@~R_`>f|LLJ7%dyV@9r%2<6d#_s`P%GUS=sH`t=~hj%oqZi zO&z*nKPyz1Q(0r+b-2I!cANL6*m`mbDZuNkUl;Sup<@RkCa}upjUfrR9KRzQI%lEx z(NNH3;9AF4xM^*)l2uYCoEw%3tjS@ac(a=8m{n^y%Zh{2*=Ajvl$X3V(Va6f1GAg% zqvp`HYbjS1oTN=up7;p6y|-nY;{>Y?zDTI`8WPM33t5spFMv(jOv-ucT9u)10(MMd zjO(>ZbrgM`FI-7}CT=Na`7?d9GNfhw@mkY}e@1*1tAVZDONDna!(W`e)!+3!&Ey^S zX2|jxcrxsZ`+Cu@eIWV@QCJA=s5JWf=keE(%kS=$+yZuAda6a!n{jEqdf!t`BIF@8 zxIGCdB2cW(qZsyfYZm+Bg_21B;H}&dFlvzPm(#FSttdS7KuFw%-(uZrHg;;#(SeTN zMIwfzQ1CYkyNG{8DS)wS`w{f34bPhy13RMPsW{1gvjhnJ_#K;)Y&34ed?bb(6rS`8aDZLBl(8dNEm&^s_0d^;wE ze}O3tRk&YFKTrIhFdZBd=UTMTjFx~`xiGY_qvrx_&os2d2z92} z8GB7QrikrTsDle_M@=1Ew!?|?y36*zVT_^Gq4wvrEh1!Fg!1;5at-&dvq$GaD@W}+ zX&WAD-?<&Z413D`vkRqNmf9`R+Bmga+73RZJ(u0Jxqa+_+859o8?`Ukj;!zYE48~| z(r$-pk+j8{YLVNq%>3;d|1?ZmJ*oxJR-K)C5iEP^eS;y;>QQSMZTjrgJIVTA_4ZNO WOc6{J761SX<(ERaS3?J>|Na0s1!{=^ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/BitNops.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/BitNops.jar deleted file mode 100644 index 112806c02aa2b60f64b0c8a14f13cef3d5ed2426..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 3294 zcmai$2UL^y8pauhAP@-{5CnlB$P6QFEJ_RnA&jt5ii{92fQ*;`6;WAX2?2^&mLmiz zS_E0jlwFiPzg7872{PIBl^?m)=^b@bM{z zx5ruj(=D-2tY02|==4HBLGA5dv^V`1wzsZ_0R6*}0#Nej^rfLr_s3fE>DZ1)y}7MC z=}(~gf-tTqs4Cop>?^#1d8uMly{Ibte1s(A@S|&)lFwK+JQDq0jMSOUN|C%x0?7|Z zy3o6e!fnaHXnOTL#cbiy@w{f?6xh#x4tk9OaA%0X;zd(ou7a|ttX{8#FBsYvqvHM_Y zSv`1Ow|00M1QqbSEBA|uJOuw$rNYd*_fXt9NV4i0O7;m*2V79y3p$Go;Z#w*hOKuO z=1SyrL}kIRB%;_dlVoE1!)M~Up`S`9^w+lc9*n+p**smFv!xtxrgG zLYJwq+CZq-e`aH_({AuB^I>IS(PCp}$DVMIodgp*l#iDH$|f@v6fLJ{TXetG!Ja4? zjD6G0*&=!y&a=xJB4m_YkI%4z^tB9LS#_Mt^2s!Xui2>=W-lyx7*#r2&eKkn(~MC! zKVDJ~QDN@|tX^27_9X?$a?8TwoK`8Vqq#-sGns{j-JkiF0mMX{sf+Ze`j_T`LHBy2 z*xOHUv8`{}q|>e)84wX|Aw-(yhW6cOFvWYEizV+dJ%4~HHtHZ#FcVV?!Z(HqNnPd* z`rwwAu-xYG@GWQU51@XB1WVormbYaOpQDl^o`;Lb)eoeO4+2-lUo}PW{)QCxL>I_v zJbZPdL~W;|uxfRAd*g@;P*{LJ!VW%~@uj=(Vu#^mGW8Gpr(NJ$b`2aM*(awfwS; z4TCPM+zV+uQ8ko@)UkhMFZ2@<-L#N2W+lY`?!v3U;kOB`X^>{_zS+%L!A2sW$8ee*S$J^Zjo$0J0e$DiyjmsE$}|Wo^j-&uYf~tthHFtMY(9r&!&sOC{TJM z-^?=os)J~DgiUJ0l)uS^blt9&EcV8fpyJN}2FZZv?>TPokql>Np3c8I>q#b(`_4+h z2f7k*|HE1*e0_)V^6>fTgFl*-8d6Mn0bvq?4z-kT)>?VMS{MGyS|go6P;x^o(QzZ# zO?*k`iG6wx*3n|v~q-d+Hl~BdZRMg71_&lxAU;e zAL*z#gvgF`AGJ&eS$f4HTMWM}JuPT5vRQ$V1VZ3h(8*za%NVy}@>@>ax&)B=#=i2k z+FCTr(Ht#7Q@e+5lp@+@3wUwsUNY<#j;8d%CEfr*!xZ$eo6JuNp{xvespEER3~SXrFouqQ8ACoMcnIJBY{7)24)X>K zII0VlD{(e_OIeW!^fJKq1Kx0=QV&5b8ylR$MC9@d!^6<;gQOzj3u0Mt>ftT`O|Hb4kst3{fQ zgr+K&3Qej#X~S~5o(fZekZqi_e!y;ZPi+(oXlf(#d`ap#xr3FhHPpGaHCANt!j60F zDgUjyiivXD#h!w!LIE$H_B?xoM$Z?5g9l56PX@uLu$su9m&IGo78ur1-Gsf8Go9^Hw~ z5Vr0UBeBMdm5o{EK-YPL1`5P6f#`Ob4UVUK0hfk7O4bkI^|m{{8S;(duY zf}2|FtnPeauLCb`gR-gn=x z;Bw!a_1dPzaO16Y@j18TbB zMqYn6<~Um(lNm@42^%iCk38vmjQ@;i1G|?tEe!h_#9c8@prw>_>jRzmM`ZtXqh2lX zGqrr1opJa}gkP`A?j3&J-i1N4vO!q(BP?_FWJK75^>=}mS%u-I%qfVGQ}@et@AjWl zE3+OWJ27uyiG8uXyAyk6@Q2>tB`Ib##@1%u0*tM_U(0)c$3N8m*x}6GjCW(UA;zZI zuPVTP_y5@&%z_N}Vx9$td+k>+a9{9GFJo?J3=A_(#=z{C!QuV(e;6MO8oR3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f}<^{7Ptdto$@O( z^U^(Yb5m0?6H8KaDns*<@+(qPLh=Jri_-Foa-H*2i;^?*^Yr~v%RTc-Qqxn5Lh@bm zOOtX^!xD2!Q}vQ_5{rwMPKfpwb`&}OpLr?wX{XamD;Pxs7Ct>#`#~^yQErc~)De+c zKP=wLy`FGaa`W7$LiSVb92RxTAK*{5F*Y+(`*1|1_}rPDe?HkizyAKcJ)@1g?SUx= zR$qS>^D@!;v_{~ipsK<(zn{&Sq+IOr(|vNfuk%j_Nm=;|kcV~VSD3a}NAMT?-+yzrxUzR-3$M)st>6z*S+euP)a=eo-4;80@|kbWHiyC* zd>f}`UlQE*F+$f|JRZ)5EN)K-faqM1pg8hrzPS)Hz2Jej7kBLQa+?n}ETz_8f zf&DY~CfIK-Z@szRPIi;-?+1L(Zo1WT-_Wl(@M!!|KZt;iMh3t<>d?~a#fB(aG z?^Nad61w-TIQN!!P11Si>lVj*lV32UePr?9J5Bcf_TTKF6v1=w*|E8d3=9jHkW+*y zT9UIPDMf_l6{Y3?6HSUUC<#Ck!rXw8Nn{=|7#( zeXvwugWd93KPPW{amw)Z_LSz8)+?KKrK~!>wBWXr;r)PLrSsbswu(3=ddRPQ9c);T zzuWoRWtN%6dOP+hc!cp;v8>$n#+cpnhUJopiYKaLHp~vZkh;osx1F*^)h749e4#e0 zmM3`K|2*NrncwU8M=d$%l)JcLQR`F7&1XGVL{4z#)IPRCM)H2DeqQlQGZFD!D@7MO z>UM`Vl`MH|5pjH3D{s>!`7<)xHuxskx=hgTi90&G(qFnFpj+&b$y1N7H$?mEB4>TC z5%EosKPJ3rvVr+#6Jg!pood39FJBE$ng3{8a*`UGc7%c9cVB}_L$Qcol6IX(8GcLt zO!~>1y`QP?q=RUr%(;#m!GcY5XYBmV3W~|CS=o=`fH7$aj!8x)5e7u@ft>F_#Rn?D zRhR^LBTNC65y)u;R7M~`B9KX?5(C*%P%=dJ7AP4aKrzsx#9N9jQ3iOkvVqKF210dU J(Ak1R1^{CJ7m5G? diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/CatchesIllegalMonitorStateException.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/CatchesIllegalMonitorStateException.jar deleted file mode 100644 index b8ecbc5a6782d671078615b73c90006f61438731..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 4606 zcmbVP2T+siwxx&8K|%;klp?)K5$RxPAt6YVAc%wzia@9ysvx~L1w}9*y(u6i1Qdt@ zQl&{zdKFMano%4pCjQcP1mzi(P|L?W;+6w`tqym!B($bRUJW;(ub}E2m zRAev+QcKbRt}6}Gf*a^UOp#JB-NQ~YvQ1cbml0G_s-FoeDb~~7TXj`t@Z$8s>;eTD z0t%q545C=&K39BLmyX}+puI2-SWg3IXRJNi8Rm*}^m6qu^+J1LAwC$a zo0p?2PWl?o1M7VJ#8$@{?dd6nIXR~yy5Mg#fojdA)z`KDm`Ws4Dkz$;ae$Ssuszt* zNBq!vOiIcY`f9yZ<&_=Hpg~HMo4lTrM05vj_o!`WUbJ6rTO3olr{m12FUuoO{Ncx6 zk1+JAt7i--4y`Dz1KG1=f^T!~^x*mEA^L^cK0wZP8Q}gwrb^8I&Bgi&j!e6Dygq-H zTwZAnNT-0+D=b{zh}(P~OkcLuI^@s?nvrxBe~s{((v(m^^%dG`sE*GkgmWU!S5C(p%XRAZ;d!v;oRy!7fti!a)f;_pZ>bfFX~-XIP! z18=#8IpffbqFGxdt1bTN(>OJ&@F7OsY~dd4LDNR{;$LaOE=j^I!Vsk!9FS14NV(i6 z6TXl`QAZ1)CmpJp5wh=pZ^M~iW?M%c-a@v?8Gdzv8rnnw!di3quE3(wFsu>rwjP@d zC)vYy@1aoSWMq;Qr?Y4NOZGJWVfJ8-o}P|4dsAN=#=+w_zkXO-LD|2Pn2&Tdey_L9EZ2(=lx(-+1B`T0 zBePoZs2K3ol#F{Qx`Vxu?}G}uuQnCxH!ILZ9 z*lNLX!4Uxl%+PmiS2`@K4|DU6-WFNZ+su^V z9Cc|r$2iru@3OIr4Vv!}n&&c08L;<4Zd?Ybe*sbEI$km_sroRuDXRUX0mK(aBRa-B z+s7)c>e7wBkAXnnTjC7cShmnm5v3(Ll*QE;x8_9?LH-Z&??rDcl01~vMz@|D_jR6w zF8PiQbqwnhUTv^n-{qF#5quKM1%+>Y<=UvOawzZTv@~2ZpVt-J7f2276`3#RvuQk_ z9`**Zm>g1-7Weyyo&94%u-F_aD)BW(b9QeVV-vr2`6E;Joa1bno1n6X**Q29i#|G4 zV$Y)CB0|C76Z*_I0o4NUbQ)H{a6t`TNwuK=ZAH6H3nkXaM4qSmZ)8^ceKP-x$}Xnd z*MNaiVXJ3A(ZQfWP_4d`zCv=z^H->ReJ2O)TlWWE2i7~6bqv@lRlV#V)@U*N@TMS(btq~_u=DcQP`7K4Is~!C zMcqI|yltMM)#Vblx<<2SMD&th{AclAN1Ey#$PiN=m7M>Eu(`8Axk&)=W#JS3b3+?= z4vLQ(FG{$my{uS?e<)B2eJQM|K^4@LN@1p0!99}BYz`CUrScK7I5g0ajg8`B_SAI( zUu5OW?2<9L>N_M8+E-3!Dh@`Y%-K{DH&LX*s|UHr@jmTMb%CrvMY?zvn>`k-5-%}1 zqRB^VvsPr2a_%VpVcOB;o@;v?1-YI%$YWs^?cGw??8O+UrPWz z*01fgn9xgGGB}GJL;w70N3P@kN(!@23{82ZPpwtUR_xbg1Zo_Hv*E*vy{rZ)mPOd6 zXe~8L8wmn0;|rK^Ht~2KBSeE2TcG(fiyf&?wTmw^gZ*1Hw7$maQ-n0scG(NRK^lX$ zBs9|#+KR8+E>2|(J(Qxn*{Q}i4)j}E&JM4;1mKkSVHF0T7}5sZk>H-HvDBk=R;CcR z*;W-Cr!WZV+llgcA)vH3u+6?##U>SKImM4mWAmi`)boD}1IJ z`FKG7EZ_%TsePU$c|y5mkQwrbd2N#0GLTo`ok!0ApNN~(84Rl#@hItxxK{AHcE9fL z0tf7#WQsw}dLP5j;^u?e7S4jcugA`(EzbURVNB-pN`L$wM^*VA{fLn>gEM6?9(WAw~gnaCIBLQ*rt~8JJ`3( z=l^6zETg{=)0T-c8g6$3bD}UlS8lhb`Dpvmbt{zJP|7L&?! zg00rv6WcUSL<>FG<#d;ljEoC#y3YN75iRw9Smy{2S2wK3|EF1akrFH z2l=M~HsaJ!aY=Te7A`g&`SYT;CC;zAe_-}PUw*#=haAuyvS!J~yamAK-(}5*`q>ws zr^>4DSQ%IL{C2$KC$gHF0x2t^gaC9A3+%W9Le%wq;Fx8ZBRiN^kx6N`gZq{j?CG`d zkfN9T&a2{0y!V?e`o#u$^1yN`2MXneWrWgRCGRj-9!6PPS8)e^XCM>R8c4bK$)43$W6JAHm*w}T?3ebAJSkp+?Yl2ZX4D;=yYK#~DbEWsVOKq`#wsa=VpR(=*4|Z;d z_hR%$enONJERBGZ^(i%sc7tq)oM9b`?S#znpe|s_`R>NiaXAvhGKHNU4};vH3&v}P zS?=rSe$?5%@M+WS6@Wg}BS7@rmEX1{EmytzQq`TJ{$@X9-7KDuPv&vMohWTSUCc^GYJ=Uz-4)Fdvfa96ePL^6Ni2Q`lp?jYn*&gfGqkq$_U-_*1+kF08w(v*` z(=lD(;jm&mt%>CW&Cv^G>DphQHeBg$(VoI|?&1$(Z`!4)OKyO!*mej!&&UfBDTfux zUc?sQ9Va&)?Dc(G>C{Z~*}Eryxm4}ZH z2-A-ZsA`w9V=-=wjC>a0*G0j_7+;|^8u&$ttY-rsp%>t2U95XV_H{2fjj6axTKk-7 z_$Ftw(R#yK)n#h(sSWDgBEueYnIvqQ*DK9u+m|i)Z;Mvlwp{WE3f0RTWl72vH&vDb_mLdZ+r(0QA-~&YJ*o0>tGC9hX#5V|^w`%Wxn1Y$W zE}WyITBe0BY|-WrY)WZ#Dbem8y%bOKAf;$d(MW2}-48+xBiH(Dl{!*h8e6b>LqJN7 zmzoV)J*8*5=Lq2{>7GhkMS{8lmG~p!yp#*_#-ZNdkxb8cvqEv|J&Th1q zEt6p!K|GV1{0N(gH@oJomWJ=c!SpHkiXbVNydlKJ_W-g54dwhPAcWRqTMsQNnn^ z=ChnkiT%rYo(==cI=9vxe!UZ9?YH_)22Vh^OhsZz+lX02vZtLJ~9dt0se7t!htS zG6SZ*CG{Wp7)NGtB>YHxyUJiWIz4*X(N5&$NxS4lRH1X%8BVdZRk!+ z_s>8dU;eHIKaFx?4o^?oC+6^H@E!NDe}eK~tm3a=r{(@+c>ftI$A9TJ!T#=vr=d>z z?deW@GC%x`LE3)?^`EDSU$IVe;iR|!j68R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`0?~F<3(SDB&N=yc zsV@1c#eVrE&WSlW!KDSMMPNbw;QZWF=bXgi;_%FpjQr9Pu&7=#NMvfjX}`k;0y5vH zs8@ zb>(I0Huw6^Z!c$1zp-_Kvc)Sd$&K76C(R3q)pD8O7m?$jKSA*|*DRIoF}*3Pc(N8c z1jt@yf5jrGpP+F_$l4So5EAIQCXJ6}JzV|qCYPHl7NsTr>_7RyFi@u?@OYQm3QZQ?`&)K? zS(hxg(&1=N+gzhC&aRn#j}v5lxusdYT29t8+vu9$Yvkb)wf^b(Jt+aUWY6WjdGh7#do%l{t+ScidG6>p?Nk2C-oA)1O5o^}mJy}ZP7_+WE;ZT|DKdv4CXyZ-%me};66l0fA-?VWy4w@y1f z@tpHSmB)`F)7*G??yam@$31!03*Sqvz8U&Qx;ca<+Ocil+}cwt&i623@vI<2ZtxQRvJxfP?i4Mf&|_0Go)>RbiE;VA z=lg_!{?oh*Z_B&fX6C6CkYcG{)2%bje3i}S@8O3hZ(^;=*<5k;XJ+;p8==R1?u^EU z*Zadh-1pga@`XfUL+r6Cx1E3M%>&mH)}IC+B*`I%bbM8kjUv2d~TK&>w{h#0q+V1_On-=;QIx{|Jd&(868lpMl^Tc!2S8jf{Sa5IO z5vSi=Umttx#4ad&chT2MoP%+Tz=B?>r>VPKA4}RCa6Wa0Q}v7RD&}3bU(d|XSm(0S z^NhB6!pUbXwV!W`)cOd;FK*2B-)|$gXX$+9U8bufYG2pA`>7AgqF2u5E!zQ18{fcL zl#xk<0a11%7rLOb8x`Ox$pgF*rhp1)R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`0@+qn3tWM+&Uv1> z1v#m?sd**E&N=ycsZOOOe)%O}W@1uKsy=>cz2uz4;^L+Lr@an4h}dqgGz*JfZLg3g zCCI#MjfRv!OMtl7!KW&GR;n{StX`JCTy>#I{(*a^@y3pli@lpIp6@%iv)pdKm^{O| z4bK<4?&x`%`*GIiCU4W;&q1GFNA-GLZP7Vfxn<|ugKA&Ya*i#UbMpBMy}2KJ1n(3p zw(e4hXfE*C@c2_F`-The4m5hdP;>ee7`tRom4RJLT~L~i{ARBiHKALscFz!6H>rM} zrHaK&PmbTs29f*AB^oZMv3yUBP5t9G<8J$GUH=|VzAYD;Ds^RFuFw2ZB9^Ik_S{98 zf7O@yOm_Ji9+`IR-1&xQxo2BsOTr&rKF0H5`hw$@Rr%S!9@|&_58r>==j(n(P_QSc zC^fM#GB7*@Vnnb@par`V8Nu$DmjaIxXqX2a1ctdl?PV2TpT$?V-TQj2Lt?}6X-#Y_ zidUM0KFnCsy-Y>gQ+U6(KP#*Kfqo(N%+5*8;{4Y6_h(mbw*LI{>o>-P7H3)ALr11w zKN+ker1*KN^zxt>v7b6;SFe^oawv0&{*y)LUIuXf_WpmfJSpDJ!u()R%g#Qth5r{{ zd)o3%Wm2G>s)lp5U%=fGMIVh95f>5#cEzb2UE{$t@ouh+tv>JHig)ROC$}$}W$&ha z=*sW&&yTa{>To6+Y}xxvBw4tH@8BNaZXJ>Ez@Hy3%Ktrgiq9f#`XTqnvfCvpb^5H& z$hak4@w;Xazk18jjj^3(WtLI1ncgfsePZ>|gV$=}OqqMiFZ`9-JH74ym+ALc{QbKs z>jN(+3c~)pRTTyX|7Vmas6~qc8)Bj$I6pVl8I-)kGfOh^OCfmz68Li`fD?S%|Bcg4 z3~$|v(*N4FJL;egi>Q_!4~NqVrzPu_mu4(inLNpdMc!MSORt7O-fNC$ci4+lk#m0k zd^Z2*pQ`^11wFRR+$`$rcJLi%7-mVXn!WjX(S@ zbFPZJvfOd{v6$zVlj8U)oeG})^^c7fj!^Oq2{7I8$$i!TDIQ|CRwRa=4AEvO)zAKX zVrTEp3Hy2^d2g$(5fm{wzG*{aTcdB&tvR03(Kpl#j_nfRIGSB${M|EDZp+v5h`K4q zYRis(m6k4ED*w{;jk9O79k*7H{qi*njod32)hztlcB%NxOrHBi}z3UHN_$fke_K;%3MDgY565y+%UafoasDDxwyNl@lTfEz%sl4>PpQGje8 kD5WC@A}FOJKr}NE_TfqQ0p6@^Ak$cYa5B*CQmh~z0L}}FuK)l5 diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/CovariantCompareTo.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/CovariantCompareTo.jar deleted file mode 100644 index 63cb916f1a446e55cf5982bcd759919fcd3de527..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 10104 zcmbuF1ys~q_xF+RZjdesiJ?PeXz3h6kfFO9BnJd(DQS^XT2w?3gb}2X4pADBZV(W7 zXMFB`ge&rR|L%((RoE*wJ0u$-x=yYN74KEoJKF?g}<@*Rrs;{LgQ} zruG&f8+Yqp-+bN79_;2;psAt;y@`JpD-827TZr#2DvfnSWGW#xJuk1#j(W&~gAw>y zwWaa^4!tEB z>4q^%UcJycsicHfM-)L%^5X31meubf__hyuZH)=Htj*aI8~6=;8LY7HI(4GeU>9tF zz}EcrI^zwxd^B}sRH)TFckOG)I|BGXxiu+;PkRE{U#SQduXVa~?cOFhZ8yxxUp^LS zSsSicdp%6?74Ivt^;K60|J?`7{nS7?J>fw411=Ac0;!f6l^+v_KEj>`b3RGq^aFpz zhXCqjkC-vVwAM7QcK%nCv6`w9LzKkejX5+pv(1kuFQu*^AQU5B#!TUIX7Uz}7OpmC ze}=6Lh7FMy|E>|KE>!&rhw`P(r{GbD*gxIf9>eRss+WFib$@IFMFUh-nH<&ad zzyKU9Dr^e*!9pL+%o!hHwSjMF$M=_0 zN|KlsyD7r``}D=tv^W;MItoycu%H1Wx3QmE^5|yQB!G3u-j+`B6XzqQSIxRf=rUJwYaRV!X6Gq3kdkhUDa#fT%@eQ{KFHx{T)lktk727-g@7Kr{$d!oNP_D zYm_;REHTn$WW_Hg`>P67JnY?Vob4_CtJwdDFzYW7BB3B_;9q%*H-X8r_lTYapHSM= zRC5=hZ##s8^BULFusicDQ7kmkR)I+_A0IP4>T~}3CT+~8V!QV4skaY`Go&7w0dngd z1r`Wn+)g+&*V&?zH@&|Wi=(f4E@sP@jImQoS}EWI(<6eayS${~%q!(CLu;L}sW&s@ zb3BU}Al@ot9VJAMeHYUo31k|k0f{?pm?~x39(JUp=1CdWmc=IkvSKUCk5_B5`2{M9 z)-YJVnEHV*+Iv7!PnM#Vl6o-sS%}@;mR>Es?pO=Aighwsvku1(5M;@}IjYPUB>*g5 zjQ$iWuGMhon6{JpFvPy}X>Ij}-1UKv+uXc?wW%K;pDgRFZ1-pcn0^DMnB&*zdpm-Mw5Vy zhM;>sk8faAhD>nUgk>0-5oJCjAp@YGBE!u!^6g|tUeILjxJ|@ffAY`-?ND)8qsbBJ zx+i+KI`dY*%LsGPk8B3Hu`T|Y9+t+!4geh`sLr>z>AOI#6MBd$H>W&Jx;8V>+dz4` ztnNw@hQWKj$?vyxEs(NKUM}nFw%fUl!*xMq zZ&XkaV^lsdfh_19(7(yrg7RoS)is`@F2g#v%aMzE9%o!+*&hkcL%<#NBRz}<^`((i z{&F4{M$+F%@9+F)$ieoQjy)j5TN=-KiUk7U-(-B6u8_A-;Ao=aps26>UF~NAbm+Ue zYa;G$xewza^c<$WyGZJ-#-ymyYVz|T@%@82Kkb*NN>hUZlt#!8?RRRvEELW4F~U19kYPj_zSpoqQHf&&fO*kO=WFh zR4gBJ-d6R>0`BW_`$hz!F0$>ox7Up9a^2N#YVFR)H&vZV07G-d$EIC))?5z*4-04c z4F=67t}>OTU-cNC#$LWx20Vg2i}76trW@yp10 zy(F!gc%aj9I-PELDko8S8-X%@^V6M^O~J0a@&1RFi&lf##@Q?4pFhq~9E`mqo6F8~ z&bDVk#CxV7NXu%1fwI+tVV)-59ZN#4SMWUeWyIcnb?M3OqH8_2&HAx<7)3XdpQ&!n z$k-onR1>swf&mG44>r@0c15ErP79U0kPjE0_F2g{?KDV$+2QMNaS(oV@! z+)33TjOg?Jn$cimCF(FKX*`MW!o`-c#kmi}L8C~s)R5lo!xY}}dW%$aCIITpjgP0P z=9n6svVGHk{W+L7snEYAE9jot!bAqZUbsY;$ZA|$$=(!{ku)?#CPFIY=Gf#(jw3pZRBx+-*Pz#kI zSp{58H|6=LTSK<4cgNE{v6zdpvw`NE@`5|b^{pPYK2FHx1}J=x5s=T4ZbJujlg;JW zJOBpU3bJGfKQhpBYNWpp*#QaPYQ73h>eEv*?9eSOEdvo1q$Rsh)9L}|L2-L=G()3# zq+YB!a7@*@DcK@0O!qGptK`L){*6ep9(1ZgZxV-}UQ-~^xXwPI^63goRc{P1BD`5i zQy@WZL^`W6zW;%NvOlX(x$^CA2se^8l?~~FSl-KiNIUqD#(kQ$xG-{r7KF6&wU<10 zX^m)~$?JRV_^ONAL&t;L!q7xrwv9rrwSviprSXQ9G1JjP#-8}a4OZjo*8}X6{9@28 z4<_;y`6YB{{F7VqhXUbxx!$e#6?J$Fk>p>rdU-qJ1@jrpk3JV}bZyA=ICD8pUJHE@ z*IYB15{FGPJ2}jOec-a?=5$l?K(g94J(=>^LTNCxQj>?J;)&*){OoXhkx%P>OU9V) z>XBVKjB2|BVH)p{OQ!w$ZBSZW2l%9`ruQV2G8F{|CnixxLDb>CL*m(<8W}0kITIpp zP*y_h2ZW?0Gdgyl#0%D5x6(ASuhr8ZP$p>+69wx*5nHrJgJkosS-nraA3^ z!{NBHm!hq*I?GMe<=WVFZz$rau1~3^1VFbF*Um1un|hdWob2ruUf{fw%=g~opb9V` z!Z6`<^+!>}>Xw}z1>>G{sXT97%>Ck|sqX6JY~lLPvPfM;>FY7ZnIqXR7&R>fAO{>inS?JvXPcqwck3|xcObr_<=XT>C5c)>eWUJgX^5o#hct= z8VrhPzM@2OxGw`KdbAiHGcZ8)Zai`Kx7txo&tWGM1UoULK;vY$<|f05C+C>@KsKpM942XcMlXlTMJ)Ao;=0D0iEL9LMbF2db{T%rOHCEX%!;SvuO$ zw)!t*a1H8GxB1Y)SP)&RLBWezoDY!~GD!Z(AO_B0L~C4{5!0C681XCv-qrt9EqEL9 zk%@R*+W6utZ+rkpo)asr3*%xzTJ8?y5VJcKGQ~0v4tyK%pHkaZbjgr+`X#G4Y1PLs zs*Qvzj%GwAZC`wC4f%cbE&^%{dl)bLB)lAo-Es4wrbA`gt<^-JN5U$?g>NDsa> zx9dvN;eMOlAUIY=y!|e3#eGXb9W_Ye)Z18jh}@0}dX{nJV!+^AhWH+|Q(J;ev3g}j zpQo;5@`16GUtFm}yymqQ0tLx^lwxr#X&8Bj(JGvc?^k#BvEN5padz*-8kJ2v>>MFHFVBiQ%v@9MydH~()T{CZ2c z5JZ6{EC#CMOCW{aDhrADHu^g6VI#B|2Lg$I_>kWgv1!+#9;j%ec+EeVN+`XCr~H_0 zb|;tVD-N=lA6zhZ($P${PN`jfoPoUK29wuZvp+{tMk9`Z$!Cv=(Zf-nw0df^sZHbL>>%-er z%Bs=fT$m>Kuc{ey7p7pNV&vH$Ry*J8i>5A8WTqB#1GauLKP1gH2}FZ9IsgP_@848{ zN_F3!L?7XImX*iwLoQqAMl>`Q?bD$=y^%}MzSVWtYA({5fXCKYHHXs)!_Jzng!hj*U?2qfo9?eeg$w2mZqYB`hY&jK9Rxq*mY+Cj*Y0MN9JhL#29V>MEABepI6R;EUlErd|By96!DsWdNunwktE;Uq;_^L+Bu`I`F@KqLX*Pz#{%N)tBxGL;e@Vq_D6q&wiOxZ{ zB1RXzo=v-njb3|X9Ac{0n#<~x#C!Km(^wioBf&S9Z*$-5u(zH&b2`uS5Sp#c;k1BM z`Pf{#Si7}WoH+}~Dx>%qPjU80=ak+@PwR1WD6@hE`xirOs@V4u!$<}NZC{)YK4GPd z$rt^G3YQs*?)?S;42_xuZdgr--&#~z8N&7`D2L3cQHp;8V$#M! zo)|+pHubtrP#w`w6Ekvst|c)NjkfU~pQ_gZ`c#YaXj)HT;oF`UN5|U-CJ6xMjUYl}FL2>D+;TJ%AJ&)Aq8-8DkkJwt`+kKv4pav_)sahAP9jnea zt@5g+;j_jYKEXl`_KrEaJ%k|>RUmlf9U(U-hQ_FBFoq#=zu^AZvG)|;B1CM@e!4Hf z@KxldHotai96J9B4%!n!HqPxk_nrgNGoW^{T4l2s7*2)wZDgxM%f%^cm4z*0H+0ON zu0M&OdZ_@R2`r=G#=}BqGBo9s7@n&g?>u$)EKfr&O?Ru0t*B7iyAwwdYn6FrFZ2%f zX$iWozuXIqXv(h`hk6G{57uiUfS3;A_??xZf+VDk*Yo?VQj$1*Gimn-GO(r&5RM?W zGOh2&F}E2^NTDl9PeCZcjsBL`QnMCtktQ_oud1nu9-zP>vzx?*xxye{JEuO0fAl>? zFIL|l#?UNHBPFN_xkQ|5s$D_aSgVmxF6!E2d>{c3Jwzke^i_SiP)3)^@D9jhKt+nI z&qI>kcTXb(C78^wXWOHv=g5&Zr@{##wz7ypR(Q=DFg*^%5uNa6@E_ZbE_Yv>xrI&b z>#RqhB39IbZUZI0t1!ym>HfOw+BEDFynce4bM2A#&+sMV_`tu@d2(Ai$et zTLg`v)4gd~UY0pMD{K277RZ7C)V2}4nHdui9PLJvJBLW+kX0Qg2uG4TL+~r#8O6ga zw0RszI;o8U&s?2ino3>!H}BQ67aDL`?9FtnKUdqKCJgk* zfZ23PTV|gwzS16ucSt>wCdpI`6GUa$4sl6cTC98$L_e?*-a#5nw}`e`k)9zc8@nh=m`ml5{uEI zvr}uK5Bk$db1DX#qrmd`awgjH5xR~=1 z&MMDSEXsSDwpFS?+A+V3Sw2SOr0Y~@VhNvxF227ANPyTGobnik*?0JjD5=oBd-?75adTWo4~?$B@`nMiVDl*%*tg! zC}jI``JwGGx@NiCeCw<;y6N7}>X1{Xr^r&*p%s?Re8g(z?A_O-b0@y?);I{@-@s%8 zP35+!<5;kl7v(kd8rebBv2>afv$LcR-h55hQzh?tciNEGq8@u=WW4yEm;d`vNYT4T zW-pZQmAxkkEmG!uVPqL>xglm-%;<7$)$(2-a2>}pU{4SgNPAL zmrtk1r?BGl>8h)YmpOF-?U0h16y9-AfVR68N%RtZ`aQq3`h{%24{rkBG+YsGDvzVi z9UFE7Cn-1>#<4=%%5k}A%ajur%le3HNFDlU+oSjwy9#*O6SQb)roWM`+I}}4YZ@Wx zBD`pEGQwSt_8K( zk=*A3UNcVnSRyOUOE#^Lj|VQ2OnT-pRDprwfYvXJC20+GF0x`t0d*WaJ)ZuWU>Jh5 zF*$7<3pfGD=aj@JkYmM=l}cE-H$HnPK&7{!XN=9`$U`Wop?^OkTBK+*yWtuhVE!b; zh~20Zh}6GUiIa!>Ur=lut^S(Ns&%Tqav<;02m5wV+xC*2FqkuZV zUc(P0EuJBy;P}@a-n@e5jtxB7_sRngh(}2~4cAFmKvfhUz8OOYlcx(!*9-8E;^`PN zzY}f@Y)ik_>-HiyQ2?Axi2q}5Lq0DBV~occ6_-YOq6NKaID7aTvShD|P9z(U|09c0YTMle@)s?Ow5+nQ^u%Dfb!w2l=?RVq$vrmEN zt+TUQ_?6+OfnhKIRTlg8&HrKcPnTzhi0~osPlF$zU!U^d#Cc&^^y~XC_Ih@-1&<9s zZ5auYdqWQzWLK5?3D$^rB2VU@ejS7?Xbf8=RXY_>q2k;KTA8?LWDPMe;P8*h0ZR< zcQ)-_fpk&m-|9Nyz`L-<|s3`24jR3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`0>%PV3siuz&iQ4D zMVX0tC9Z{~i8;mke)$lFZ)!o*cr(2qOV6t~YsZKER-s8R_+Rv|dc`6pmh@18g1 z-v^$uW}}YDu?ALW{&X?-el(vIf9J{rqgz)$u=e+??QY24ZS_86)jNAoFzx;7a^Wg4 z5VRSQgGm4_m`t$*lXHGiQEGBYPNjcYYEe;UN=j-TX1GoD-|ctUL10d44!e(nqD_^G ziV&Ahi;J*}uw$wRqnBfOr~ebB$HLP$tN!b3J zKUfOd?yA{1*<4v_;PvF&tDOQjn|2x&Wo@1wsM#Bssr5Pax!bLoezQMt&fTfuI;ZoG zp`7nC8($9nkacfV7hZhb&-pK4xsem|Yh4x&&bKa4KW(d+&+B*U2dIuD*Nd+i$90o9;t0$ z{;;*+{NtYWPi~}$84D#B{OQ}eeU)q>&+12lW)|C~G55^wY0=%1{n2vqbCZ9syEesZ zexH6f>g6WBZQ6(Pj+WJd6KLL*^^D@cP=A0D@=9nSuZ=b2Q4%b2I_-sp_a6pf503t( zJ|@*=2UvxC1$Xthw;SohkjS+3Hui4hpzh~ zy3mwEjioxoXKBBf+3kV{LRJ$`J&pY;a{80wk(nxA7AXndJmRt;Z`L-yt4$aB|7|@p zp*VFdCwudY^wk^nLhYp4`dOA=SgGTCXT9M;dGXMhC!|w1_5V9#VQePTtlwNI7G5K` z__$VzTH5n3ywdBx-bgQbohBdM^Y$wHv)r^pd{(_bn{FD({Z2hAdF9;Ut6K_Zt?IsO zwIO`<-h5E{{#s|;&kGFULnxtai5AL^SVI{jeLLo*pcNL#VZSuspdXW=Ky53lh@e30 zZuNsM*N+_G&PwW-7iO7YQK6l~teP$Dee+2Dr$;A`G|NA5mt5X@Stz;3_RMVax#pjZ zz+vxqQA_dog|{!KNS~a#w=U{Kirlv?hDkY-pVw*iOf1y7GPTP%cKac}(io=$0rNjj zY3B@|yup6f#7PS)^rmi^&hxV@{e-}m5}i{gk~cRob@6QV&??+sA;VdG-n}y+!=>uX zIuisGlrY%vv#AwI#7qFQ2G@<7aun{U zrL0)AO=!O0vpH%NCpE0&ZbtoEH$`uC@^Sq&i$1>YSuCIa=9gskJk$M*pa@#MBE{SY z7&)a(paO`INrVAW6(E=4psD~B;HnsqO#zkn$VD8eyhngUAQLS@v6lYGCW4Aa8bz# diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/DmRunFinalizersOnExit.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/DmRunFinalizersOnExit.jar deleted file mode 100644 index 93f34f0589dbc8a2328968c9065e7423b559cd13..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1183 zcmWIWW@Zs#;Nak3xYK6k!hi%s7+4s5T|*poJ^kGDeI5Ng-CTo1^nBg^onm14?0e?4 zkGHPgMP6@Rt#fD2Zw@lJV*KFgqo+&^0p9E!o9da~Ndt|N1mXa=1?SN$&;!c4^^!Rb!^g03u8<20-A$JvTlo*M35 z*yn%r#LI8Ta}+qa+G7eTT_&tGuVUF*W|1Pc$sqShpn}HEm<^XzUTl8R^sUw{pztu` z*J_hTR`VxVRvt}mTJ}5MUf1?;Qs$zbuEwA8&-Uz&*mS^6l>1b~42}7w=DMFRSa$E2 zFt0~~H_BB<=*iZ;)I`bEY+)R$>Pv1#9JXpKT&o$cv3HmC*LfjdRxA}ys7w^%jc9)z zulx7g-sQ_T@IK}Km2$;b*UQy8wa;mh!TlPykBYj{T4F()8YM;Fo@Z;_yz;=E>mMAo z*k<%=gl73i{1V$B!ep(HRPJ?TPKQ9wlDV_xL6Mb~9R4_vk%2*$2|2R1qeYep&d733 z%*iRn5{r;1o9e&Y@34cw9B&!v9!156fq@rhwkIu_qA<%rtJ_0j=>ltO@f|1ZyuVp8 z{p;d#ImrGYuw!c_ry$q589QswynA!{^=0D*IWyfW61&t-RxV@<`WSJqQ%8Q)W$BfB z?fM_r_#JFIcwyEj$?r+)*6m5O5S^H2(7$BTuNe#9z3Y+ask0I@dlgY~q2c6(FH42e zU4^>dG_`L`$oQRk-Z$s6iU5FGTM02>Gq*l{L>HSu5*2~ zpxLy|?^`uPZkfLKh^--zd|1_JN_lM!~a X@h6l3Z&o&tDa=5~0t}N@W)KemJ`}Fk diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/DoInsideDoPrivileged.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/DoInsideDoPrivileged.jar deleted file mode 100644 index 132d8bf206e05bfb1a3f3a245fe987c51c15a986..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 3418 zcmbtWc{o%HA0EpvOd89KD6%A>WKh|+WEo@3WczG4jit;rxEUtf5LvP$WDlk67ZHVs z7#ap;)W~fpVbrH=SrX!#`EJjb+pV7Gd+zT%=a2K8bAIo0-t&8Z?~6flaYF$h5D4H% z(mw&%R!{&p0A*rpq>QjKRY4h9AxuqdY!9PMH>m)?BC4;~5~+NcCV*5{dffM<&Kmwq zeT+HIb>9C{Cv_pno>=z&tDr5b=p|0(p}UGWK+pdweufL1t))GBT<|nA3Vw zkR#RBn$HoGl$$JueehcE9q*u!z+8+9y6E8jj`BH&>OJ)*8hseDAP)v?{o;H`#?H$r zdUvcU?|UydFMnQ1tuf|YaPr;U^ZahqSjLV}MzeL}V;-3%#dWn2*-j*rE9%~aR)?X4 zqKLM9KoK8u!cZKZn#&DVOEpYO!BJa-^fi6KTg6>mf@g9Ie42PORc>wg+kivWr18lE zI>`_klp^~+*h)_K?6~}g==f?-hG_@Bd}PD>>WdNhZ(tKiplHZUcc;&Yj3pt$c(|Gg zHbZqA##n#qhsn7HxDZ>yUl&IWyie`HeK)BN#35PEf|%>vZ8qawAA3|EZEeVDTKTV} zqi@yWnNU-vP9NFEl4LSfSCKcRS-jRefH8_~Q_suUrI+0$5To~zcaH14$ssy*mq%>2 zlv|;ro(nopk2danJ*EFZ!j%>KyE3A$DCL@^B;76XlU*>nE|PmF<+uRwnPb>xgp?B1 zWdE%YM9z4a_(4mju>#@Vgma$Jf;wh95t2m&)$+2*>Wavra4z-;jtkYbwsJXC+80#~iN#7FYYF z)#m&6$H>iuHVL~dafB%>$j?wSu95R{2xHgguHTlt;Jiet2kmlK???6o;iqEoCW~ox zUPX3}trmAf@<8wU;*8%`)9p>1n7v+^m0DGxS!dGzf%LIa56R0Yr-~W=$@2~YQs0ZYRG$5A4IoK46bw`B1 zV-aM@@iPjIen{cpRQz|T%c=g!Y_Y8~nkD1Sl7`|&!zS0s3Lqou5YVV_pr|k{1$wl+ zy$sz;RJhn%{l{q9>g@G-+5uP9_T1Hnkoo7U;7)bp3}2L9|+p8Bhg`MoP|=A_I3 zQz_2{-MV3;fs|daQvt3)Zmz>E)Ps*IaE$OAUSRKdtI9omxRyc=T@Y*jK6kwYd(Da- z)OxqK%Fs9o>)=T8rRxfX!L9sYm4=NwjSmeAh5N^Hr~6h(o56cKgp3MguCGDzmgJ2+ z=vDKYVom{GUcZ`(`Dl-u!=r7~ZdA!hY*yZD=z5SP{~8{U?$TSYfkJl^$YQDSs+A+B ztkjV4F%NdzmG8?qoIiB_DJ;W9f+RLD@T4Zln@94zYWG9V*!Y71FG}XxgxjsKsNb5? zt}?}jRHIJDmMB5euNN-n>3bFpgqr`_h=w(f4XP&d#S-tkPGuv^MYrDhw}7H zFpgbLTgcLlNs2vUJO`7}mRB{YT6{8vdSLz_H6QFFLVieJwT<_Q-Spm2W61NY zclD^HdO$w%v&Rxbk=&B(y97UyHJW>N;iybTk>6k@E}kN&l33x+bM(qAOofnM9dS2P zWv6AqQiERLA;xly&FENrGIH4|^P(if<^T_A^ju?UZYL?pS`-^{^K^W4nE2Z*SxdBp zTANONXp|r+a;k4q<898I*Jq1T!577-;7K1Y$@-@_m8$%=)NxKzeuDJz_-+Vjp{*i4_GOrXFU#9cn)9NlAjK7>6Bo*LT@0Mvw*oknG zayvy!R_Zamcn{`2nIk_gv>zW^R>v1b+Fj`Z8GWq;w8JAZMbU3cZ=5y;pLh zSG^?3GPNgZp97|uVk_Bn*bU*hoqIl!E(;5p5-5Khe@1$1%ZNaK=8W=)FMs$USM#pp z1{b6(@|t7yR{=&4;>y&Ssq=MOKPzco$AeOlvYAuOK@$&vBGuz6pa@FRhv)`d z)fX#rRjmpNAJ%6MO|(2qSKgbLY}a&44%rEHPCefQaVzZ#JxG&1*5JP*g2~T-Fjon|HxoiPF%A?~pgv z#B5WE;B{_vuZyry@0$bc#px3Da{4xFY2tqBJ&He?4Le_dPdqlj)5Dl;LSL*0gF=!G z1xelpgPmU9-k&!OPn5y>+Aqc>WQiJqlx#y^9Yc=ZLCO6gy5SgtnID79o5k1FdV%+j zkoz8A)9`!sp7MsFb3x?2Q?~oCpGg*0mW!6)>!y`yv1Bqf8dHmLNxV@Wl;+T_md+E_ zr`JVpJwGaWso+fa^&ZSLA=YxHhMeMK8u?pFFN}%G0MTBB!(wi26?4P6(4@FwBeiDQwVhoal6AJhmgSY2bb`1V&{U{V~@50Wy z+arkKUs_;USN}Bmev7u0PK6>#2|q@>{oeMhXIRhAeepi9|V|wng9R* diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/EqualsHashCodeContract.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/EqualsHashCodeContract.jar deleted file mode 100644 index 3f7876e8ce67dc6e008c75efacc6379a928af5af..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1652 zcmWIWW@Zs#;Nak3c(d5bg#ihOFt9NAx`sIFdiuHP`#So0y1532==r++JH^28+4sz8 zA8%c~i@e^tTIbH3-yCFc#rVO~M^Bj;0=(HdHq|q|lLi_k3B&<#3nbAjumj4v7M3RF z6ni8VXE^7lq&ny4l@ui=m*_j^Bo-HkXO?96r2>i6B8W1-{34i2y=0Jzxf4!%9d;0D z`~Oncw`be7Yrk2|gS2O~av$xQy=VtV=!z>}xA484VsbG>=|{w_fP#n2KLQ@j+>*uW zSRnTN%$(2X&HvBY{(X8lL-h@V2}u?fJ9~GE&;7XKKF2y&V*#God%YCmtSDCJ`t4pz5rFLbX;KpA>pX&*!md+z&ipgDy{mtU#4U~F zz8*HipX+vbMzfuB)u_E1wD7^z=O)g*L0cAE2ARBg5|B1!^Vaky@{_i?8cr8k zJ!4TuKg*Qm!UxV=fBKh&ZAQPw6fOUVA8Zj*8l^tnnAtERnd5NOqL}~SINX<@q!q!) zz~IA#9EY)JacG1)4k2*{ip2cV64ZE`>Tm0R*ny`uZxWl+!lgAlIXS$mW-S!*7W8IK z>PTP^?R+cb_hi+CjwgrKCnY*1Jz)Q^SYV%uPAe;a-M0Dj=l%Wp^&ewGSFE_~p&xHn z3T0L*o=TZ_|8(WNmrh5lGLCKcQmn>5`O8r%q@!Dl-i|3E|v(s|)vzs=U zbA|WM{#nkVe!Wwt=e7Q<2eHpX1y2{J`dR$AoSc+m!D7!LEW7T9;W@o>MrA`Q_xy;6);gr z!XdS+$u*`mLWOUC*V15BwmJrTu0lU%rw&&B?=|n=ZJu}EKJGq)OtQ=YMVIIPy&A7} zuJ}B2-*n^HSzak>|BT*EIa!))7R_jLC_{6eYfQ%{#eII$jf`3ThfF;+NAS+!lT8mI z4O+U_GFE-yJnS;{)2d3J)KcwBPC~~z&$(_0&~repJ%7&B>;ti9yw>bpZ2D_;nM~2w=;Ef_bPA(P9&hLhXAU;Y>LA!JQ)$$d{9zD4lPvkr!wO- XA5X#y@MdKLxse43i-0lk1{}x$iq2wh diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/FieldIsntImmutableInImmutableClass.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/FieldIsntImmutableInImmutableClass.jar deleted file mode 100644 index d8aea804d78b078461abd181a809285b6d963748..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 12105 zcmcI~1ymGjyDptWw{&-RNeqp2r^L`PGy;+m(k&p}jg&|ujRH!EAV>)e(j5|B@ZbLt z-T(1$_dWMz%~~^yS@X;{&zsNtsVc(4;X)xHAwel8_((zBGF&J)C?#o4308S!8FnQJ zWqBEC4NW#BnX9)@PzOpwgAWv0*+$V6S()Aqy{}W}nBZPmSz3XCQdLAms`ZE2CcgeC zqU(q1e*u)l{|caX{a+ay3ww~ftD~E|gM+)9shPcnyyJg81=^dsy0R+(s< zZWbUN8#imEf4x!F-OS#`T*k)H)c(h(u$kYyy-;0ArAr*s7d2U-G~o1&64-WvOvH>w zPBI9e#+HLDr8b_{!ftKy`$}h=^%BOeEKxE1;-{X$#~ohWb?27{d+-YYEgYiI^dj7= z96YAa_hPAs&)cm_L#B7V2!%dIYrm?}%xS`ZB3l}^rPn}w5^JcWO@Pq)KH(`990EI&iqakvV>5 ziZU~QmTedHhSVSj!eMP_D5zqXKar|(cT$017Z(e2H+wI62PbsHE-`QD zyQ}pPTd({j+rw{T9CfkLb?>)k=C6+DASeEQey9sPWKvkFairYQ z>yizQP1E|7i|Z?8@h_iS7L|S6_-dE7>DK2#lE0*#4YFg_%D2?5s;NHH#ifKd8vF(n zHTqE5>(<^ngo+Y$;$RS%pfwU-Q`uZ@u$^J-KqyfQ^=hy=--PBB8kxp%-)ieuHYNVI zT6I+HlVNb``9&02GdZeGq~rQY2H!N`1F_{xVgXij#5oXvGQ=MxCV_|8>MxeXNjJC+@V&tPCKIJU? zi1>*^e6XUW9(`0l&Mpiuxc?}WBi3av*C;<(b%f92es%dQCOQwE@F-q>vbr;%pUCU8 z6FVyD3Eh1u0}|2PB^u>3S?PTlF=HBxGgQ2XOG83j-1y2#wR4k#c#z&nWw0U?sI0-l ziPlQLPcvVeFGDYoRpE8j+6TeUoV~LT0ZodQMx8w#C5|r^^yn!+>xnF)(YGxo#U0f~ zkg5{(=drJ5^(>s*%5WAfjL9;6jA16!iI)x*J=PtflR9(j;|MQh5Yk%aRH9_g(oGM4 z#43dQrIJW37+zf&6tYYeLCo|C>mVP~>)r1D_mQGzAWJVUBd0C%V|6WWMRhEEhdMdd}`tw_IApyh9>DIbtcKQ ztT5rvh~TtDdG%(?;AIYRZwY|$k2#0f$MA+<&Ljt>@VQ$#%4JZFh3{M` zonJ7&mRa=!&UN#`l?*Ps7aaR}$awLQ=GZbv=%*aed$ngNR*g)Cht?en3Y=#sI%h^c z(X+x2susU7S-wh07w30jUG{#y?0vC-H>5^`@tq!p#&&__%`o=aR=O_Rqdmc;H^%;j zCy%bq1IE%HpKs2K!6AarnCe`8xoEqP6(FJjq*TjJL#yzioRlwEL;H+vqY2@4_tQw_ z7U_UlSagbA?^NdH`MnKdAXBgAb>YE&Cd4#T0K8Q=cAag0f0r?Vo8_~Bq{drHxl!S`u zZex&B?2!O+2>Vui!?w7Wl`l5Lx*{q{TBj&sXp^y!o_OtJ>o$XFs~Urf$oQcK_Z1?lhQI(=~n@k8JlBV-T_U~51rnZGUO_QQ`*HNd(t0CY57uhiQsdg(GEi2 zkFJ<}84&#{MfbV-YTcxPl$Xk#_GRI>U5gLmbPP z$2RdL8I^+muiN8Gt@xpRzC&kJv>5qkwSC;9`q&0n1%1;6B$f?C4_$WwQ?P&XrU!TT zre9h+DVv*);9s4chJ~A(h09-Fq&BGBC5|hqVXUr(iAU?`hS)O&zs*5|0IZ-?=*gL} zNgIgc;@z59vufg?W4nM7d;7@X-c+*_=Ls()!-wnO^56_UC)yht0ocJF!e0X{+&U8( zo81epd}i_fi>bBI(dJ^4di$#WgYCjB;{owTZ$iN=H(5zLEZjJYlA%-XS0YtpmBdyu zNC?N0{gwmS^0e+Ll;hShM75&+R1ZMa#*)x>fR#YaC86iSRE?1Y+?t5(gKeA`pxNT? zimbPBi!QrjRl)^?D3{`;ru_ZV9QG-3z^n%yT&dJzD2Agcd+UAVhssNcCMEMS3WH6A zgQ^LcNi@FFlNg8!)^@9J=_6mPPLBB?$}Up@#d=J7v`e^3igfaH3*O}oF+lXmIpz~K zuzMeKiS!}#j==;dCE?_vG^o3zjL1YelD6hIo29?0SIQWd%54xYL~(wZXwOld?qoZq z=(!Esal*xSkdLsm6iY&>jC?f>fA|LW7#T9muRF*B4h5Gms@t=Gi! zplBMYEHJSNrMb8;ByiUwU8#tttw7n`o@$h8yU>qumo{~C3v!6I-VIk-LfYHK?n58e zjEjdj34-vH+cb&UBef~zGi@4{6^ts7U z4ol&ZWt+|wk5KZ!-4YR>i84;MB)i7aRk?(WEE+k6SVap}tK!wDc;d*OUil2m^Ab?f z3);gAfw)Cox{MRruc<`E!OY*k_aO#PnrF}k-g9aHwt#VI<40|JLOC8v&AXb!YJl!k zQCTVakePZFx&!HKFf#cC^sy;UHMt2;0_~`_7FpM@E|bAK$KxVqGM$yl+Mt498JUlz zAqB=hPovcnbyo7lgafSD4Kpw-PfKX7nOVJl{2Zn5f1A~`{vk6`7M2!{t~MSPK(LdS zilvsLog>)O@yFct7ftGVU>r`&D>}V<*kk9b_VWo;?qB!t;mXvR;NjI7jC%6xob|(^ zNiEviuC!=XX_@w5Pu1|g(87@sAN6Jtz4x>h>2UPBfU6EkCgBS1%Suoy$G0=s@W5ey z9$)d*R5x0RVEtXv@^?BsV{s+zBp&MEbk?Tek*jWywDy z$c}SpJrCi2KYd@s4|;X7N>#U|?=%H6&*2r4wv*bi?2QolSh;{CeYPb;&)z(| zE<{X#R}p1rmE9z;ju*lO!i}%Q$|}Atz4jCTKjvnIJNk--IyVRJFWLD& z#c`#Yl47?wZid4+hWX2v-UrLQ>^-cwDtHo1A#$45ilX50-u480le+LLR+S(`{{S(C z*@9dhcH_{rX)o}6`{mWy1u_-ZhCddv4is3LkO42BLltz{hAlCg@4bQtKL_ApEG(@UFDzwU?hevC4lqX#prpAo_ZI@{&(|3=qJMA8l(eQ zE5othD;kI9-#7^RL!vMVxZdo<#RskAxQaC%{uQ+&{8>gETcJHfS}pObq4 zOLC35TF@g6wD%-oUmjpI?mW{Rsnum4LfzE0uY{eFZV}kQZ47fvn?dyZQ9y@qzjCo& zlXUb;K>z>KMkHKZOuhcAiYi=lB|2VE8eLO))Ha@pZwr@#my3&1TFS_jykwgY2A5yCke5z-fwR@~7iB}>*0~c|KMr_to%GlowgOpX%$LMXtG)1Pe#4G}7Mz+7C z<~Ttx39SsBysE0Z^C<)8!uyAUL$y$8E0QFtEpw5cxB47jEE75BRVHIu z2p6M89gS@n^&znCa7w;UO+-6-hN#ZmlUSHv6szVPI(|X3>^|j?eZC!in8(j_Z;rWw z0FOB*4`iWTj7&;DrPf>~V)ss3N$dT=I(Ji`QXv}N42<88&U(r21pMHdMyfwn%{#^$ z(B0Jy>~P0;!}J|5BA>LiJIdo{&kI@|F_(^0pul9c4u>eUOfkM;qe(yZ^uiW7g}qQ) zqC@LVCt#1|2hRfzEIV%MCct?@GTLdUCJN$L6qQZWgr&yf`?BzhE+|d-9d~}BaA7@` z%)5tEEJchjbbBy}4N%c@J8+p7`y|_%6RjDoLPw0*?Yk9<;P#P+iM8z=k&g}{;})Wh z3_Vo)9SK?cnq6RMRCo`uQgNfx0)$^w>8tp>wQI441sOWfy${?}-k8-0$xlOK0Um!M3~ktvA5MOZ`9zLE!dMXp zXD0DHBq6YVKEpS3HgIB$jLR+EKd~Vcp!_~c8cVMtIZifQlEmABibrVOC}O3V{@ARv-)or?+R&|w$f^tA7#7iCspqoHIL zJ~W$>ODHDIPtz{NNAemNfsPP<@8+3ZeI>{61m%NEncHFxaF(qscs<+Rr5xJkm3&n= zM7wO}>PPJOhR9HIUUP*1$Jn_eN6O%z`tc1%|CWZYwPn|Tx0^<(Xf$5G^wkHkh;ek@!oOd<1F9hwz{%r>3x zoqa=JfZCv<0;DKa5&OP*De{J=KdX$W8RXj?n%nI7(&0PFoHO{5=p6Bx%gkli<6E>uzf-22z4kWae7sZ&p_V?sL*3FvR zG!j8JJ(wqIY-m`>q4tpm-ahuW&8{2sPn7jNRCtBTx-W(7QRd=W06LZaRqitCW!xo7 z8lMR!hY>?3qD4Kty%WzZdpmHCFZdcu6#? zr(#ZJnp_DI8s?-v5wB6Gk*OErn(C)==PTx6p~Qf*PP5ky&>pb1O+k6jI?wL=X3tQtzL7jojdLZwgZEl6#4u_acGu(z^ow zqKn`rCYy_l>V2>I2LF-oJLby2tpvdCZojm$|E_n}q)Xt6=C|lK*jQwPkFXgh?w?x2 znX=f+$%J5uMhmSB2;pp3jC3$D1U>Z=7h`HRk35=GWIy>b)CS4&fqXeQA{9s5@B$IW zz%b?+6EfqVhlMX@$_3lrF8y@+~b8q_8g@vvj)GOph{P_6|tKU1ySdvOv|ZYO6r2 zoM0*&#a4k3T3EEbUvjNRtTL{pwnq^Kt@^X5(g(ikg43?5)2InTg$NP3OH*uBZ;25d zZyp1Pt-`rn7(Q`5}3qA5b)XkFztp{ISfF~&taP^ z7SOp-7cNKeA!X;CbYf<_Lr(-s*%DZl1w0mC%ceaJ=h|t(K-GP4Hpp14GS}Yp zf&LMOM#3yy#igys_$pvjwQhMww7q8BUu^iABOonsp-Xs+D+> zFv}U$nB3?CSw7oCm)%>W0Y+JllgOm-hh`R;*N+y)nMss-Z=2=Wdf5IfoV9FxVqA zM_3=q^aGF-?b&6@LP>3y>JA*hiDDSi91FD{LlhPFby(Gr?&#r`0<84wIRz#Z`NBK7}^)ITsM`%gAk|R%Xv>n5!Qx?|RN- zt=wzpnEb^#Xnw25GXKyyfL`W5_JBW=eWk`6DL2;3fseLS2 zyFB0PGaepq4sFVLyRU9p27b~$&&NDx+9RW{qt1mmn%@wp02)eHuN_j#4bBVZaAPcy z<{yy(YlMQXMlm3-9#g8QyU$%AmQu+}pA;l`XY=s$*#Y7cK4Q{!JvDgR$rDHDKm`=$ z;|zZU0LY`7KfRZF)?z&>RYora?tCo(%wtLx*sfpC^POhR-zv-M{(KKSST&C!bC`K3 zOENd&Q?!^yU|hWQw00Ba1;+5)_I;$#LoZpIX>8uFil2(I*+ivTEy@+FTfPqXr2F@8 zNvL>Lj5>E8Y6I)7jqM<;i;f9Lx_1z1j8(X@8^N(bK!WzWjII!v_^B#QzLee#m1$f_}$Pel(B$KK#x zun1E z09%UvZFUTWX#9ESG{fSutCEMoC@Y!*-WRhRRrh4+!gzod1I4rGjq5Y7GIMv)fMvzJ zPd<1M)mo{`yS|GnZTS4WKhDEV2RE+E3`-C<+_2Kiiz6vwfMQV9QJ&T@Pfhj#*_Q-D zZT(M>z9&1h1!&PKn(@|&?AF$iW!9heU+Q42J9bH)iChA}R=gtFy$Y>96g-y#S? ze6CPu2V7Rg`V{)mYIYwG0@?)q7pj)Nw)qeZOB-^ndFu5ogeb1Z#t`Y#b0x1Z+MplP z146TvLf}bBiRrYJDp#2#;a^FmGA3DS+KUAKn_iPoi@kXg?#CrXtRITtY}B><)e%>CR&+ug0?$FIrj+M z=FXsBx6v)0ayW%06bJw|sSI2#nZTw;FKKhPT_WF*k-SB1M|4ew;4frw|L>C_@dq-z zHGAk(k)%W!@M6>5Y7F?0mw~%hUU5M|Vz0?*mGhp`vmbGBgFWWV=Qhv#2Z;l)j<3mp z;4n_G{Edt~)Y-Q#+y5eiFr9p<*;50c@uyh^^)&!7=rwG^~S z`%a22MYh|*Q10blQ}jh__sctbSoY^UfnjOFt~*15Cv)5_Vt)QMu#Fhh5t!ZMTAf?0 zb8`q8rKyec;DgJ8|N=YYWvt^pA& zNV2D~$lRHX+-qK*k^Q;3{DFi^YKPp*?*_1C$=MVdCGr&0wYW860vFX`Or@5Y(!_BI z2*06rEpAlGMDz30Vs@K!RvLIr+oCk>2)O&}JObE#)|{`jti=(YeVB~0GM>iG&nLtC zP-Ou@9k9uZrs3`QHi4c{QY+CA5gJlE;X<1!NWhyuYd3v3nQF4edZvB3^8DqCZ$&~R z>`j%HnJ-YL`_mlLxtZs=y4UKSeThV1M^(WzffPBBVpD55HG(%k^tPL3ev3{tgm5ZL z+8y?Wa4@**Fux72kiqh{<2f1Gh8>RDjNIhJo_?`bz7`MOizp&s_HNWgmW}8q6zEdr zyT~;Abm18lo>;j!k&QeY6DY!FG~Fe94zVuB&0WO!bi4`7Y^VLcLyGgpaJ3RpVDL*`lZduS@2_wK zT1cm(Knd4#GA;ATQ+}0+E3!sPqnLiU7D+YeJ-}TV(Fhz4P;kaS{c%OeX&whF{yH&9 zU$2{06`^5pp?+R1yL~6@=4#om_TODJyZtFQadrC=(oGNX(@d|Q{;%IA`yKxFF8$`F z(@*2OKK32q?|Sd)cktV**PC_yPuoWPzXiYB^8WX4aC=R7v*P_}BG;D-?s)uPB+mbC z;rl!C?KRlV8uF)M1O6HEe_CeTM!i|F-Cn5Ntk`~91=>GD{UwwCr-j??uW;k=x7P(X z>c~%?*#cjtDnC^-d1aV{dL_4?*#cbh35CU z>|f2}@3^;xfEz97r)k{#XSn~pGISgJMryb{m)=MXKh25cpJCq~UHCxT1`akyPn5O^$ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBeFinal.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBeFinal.jar deleted file mode 100644 index d889ad8187d68bb854ed3db5dec64119bd9d5ff9..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1382 zcmWIWW@Zs#;Nak3Xxn1r!hi%s7+4s5T|*poJ^kGDeI5Ng-CTo1^nBg^onm14?0e?4 zkGHPgMP6@Rt#fD2Zw@lJV*KFgqo+&^0p9E!o9da~Ndt|N1mXa=1^wODC>H1gW!*AU zb5epc@=J44oKoE~^AdCPgY$D!opTb4i^DTZfD$EOCB=HlAfeuX(|(5y1Z2KXRTGJd zIg#~KPE6+=AI(w}_@p|{MLylr)oRuOHr{?h-eX1kT^`nh{YQl=Diyf;O z`^7ET^mw)EXg%KVn)xtEU?UUvR4{qE#|Ka5jo(=N@ z*IkR>@KyVP08_5W#YlmT&y{$7XFfkD4vMN7W%rBy7#SFpnUJIE&t}xLpoTrF!V-%z z^Gl17W2iOAH~+GOK<#Xk!biJId^t@-GG^6Hn6hnI<7{7k5hX3x0uNEn!YK9CDcaYk zy)hMfwcg1xgy{(X19!zVb0ytHLUwP?R2zRzE4yZ2U;CHwfu)sL5l` zcVUJ4M~^87H@r*WbbV`ERKULNo0*Kx;-tjMiC?FA=9p}FnjoEh<+S;xU0K%;a;>_R zZMkCMqP@24-vd%3-ktQ=b6SsS;+#y*y(cS9IR7=0nt!(B^NmFpuedDZIeYJa+@y6` z-yiEp23_#@Cu)0Ta`NQ13;YpIvaBMUku61R(-Y5sR8qXf{4;eg>!#AZ%*ijqrfkpp z^e$*m+K)~9Zt})u-#ad4Sem5A@%sIOBFm%AuO5l;Ykw=R?mB+|!jFR1XCl_dk510X zs5cDqe|bl>@~^-6ho-iV87KyXTD`Jfb!06f6lfyHnv=|8}ml?|ki83?}v=}53o0cJH8 AwEzGB diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBePackageProtected.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/FieldShouldBePackageProtected.jar deleted file mode 100644 index abc436ad31400e17a36bcb57f9286bc9b9d00072..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1404 zcmWIWW@Zs#;Nak3=-Fc9!hi%s7+4s5T|*poJ^kGDeI5Ng-CTo1^nBg^onm14?0e?4 zkGHPgMP6@Rt#fD2Zw@lJV*KFgqo+&^0p9E!o9da~Ndt|N1mXa=1zczr7y@P8GE;L> zf-~|C(p=3jOYnd2K} zZN}{ztl`->P0Z_Z|CL1rjV`tgA%U7&Q-eaC=3F~>>gJlqz4NSaY7hojG=N37WC;mjT;9lX4Hs_3Wm37+> zt~?PMCKeX5V@BeN`JLaDJY1yM*B>?xGPF=Sf3*EL&(!VhJnuY2lw~h{47;D@y>`-r zsfw;MPUtn82NY_R%=B)%7dk6`iK*m^n5Bi^g^FinNuJ)b`~KhDz2>E=CX0i7pY<#X z;bQ8opKW-hDsWNI((jV1-kuF!RW*}$DLdC$L+;~8bK6?A7yXQI=}zY4HF|$jY}qTl z_U>7Zr)91`kSLko?7zdb@AZzr!_Gy*i76}GWr|lApZOZ9)qm=9z%%t_`%lhxRWg*n zH^*OXS?Csx#d0f~7GD0}U+=d0SM!=P%9RUpzVE;HZWiZ8ugX;=>M|y0-?Yq1lS;BZ zB>E#`=1h+5XI!RNoIm4w!}xH-y0%IakBtuMp6Q=UUi}NN@0lIH;m0$kvxe_{I;w+{ zmi{a3xq7VG@S6QiGwCgQ!5j(g*Z55DE)MYD=pZN@!Qd$9;rp#Z@jnjV zSUb-*F{yCbHS{~J@nv!JIx4z*`)=dn;@=;Ce&c%}Q7u)(qaLeSb6(O_`2KDY+jsXq zE_`uxqR={_c~4y$U;MD~%v-9|bLv888;&F2N@ z175hyGnmkxx2QwN`RKHTJ7%#k3*P_Gs4tOK_M~Y4`Q(|`E~h#6rW`8B`hPsy`f0bz z%N2{3CI0LWd~O)1WDt0qYo-d{;Z<{cQ&YYsNou(tZDN0GbWNgbWnW?fbF`G1zsrYBllR4H=}UuK_k=6l@~qmBHZ+P*w_;nux)MPO=R z+LZ3K;Zx>s+UU4(is|f#1sQeB8v1EW-u6#6`|wHzCnX@v69$YuOD0h4F*1oTAc_{`G67VypaNV44YDbq@&h@2fXWX9NCYxT pE=`b)2PHCO4}cOG0?Y<_3BU39l3ai{D;vlxW+3DR22do}{{RS-8aDs{ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/FinalizeUseless.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/FinalizeUseless.jar deleted file mode 100644 index 0392c1b25de0957b9c56726fca02fbb17bd3f4e5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1893 zcmWIWW@Zs#;Nak3*gnbHg#ihOFt9NAx`sIFdiuHP`#So0y1532==r++JH^28+4sz8 zA8%c~i@e^tTIbH3-yCFc#rVO~M^Bj;0=(HdHq|q|lLi_k3B&<#3lh*QPzB1mW#%R3 zWLBky7N_Q<78mP7X_&BHa!z7#acjUvzrzLswbz$<8a6s{uUR1-vPjaZDMDbbl7zi9;GxHaHPFZ(p(gXR-)u)r4iu3EeKKO0YR=seljmZZ>k9hQ~J;;6Q{MD@w zUWA`z46|&DXE|o-cD^?yZ2765@3m%L-ACr1;?X$mXW!I8;VbyXk&%~? zfnf^}Bf@t%TKKA958t%X9Ms^g4ZP?l>?mT(yma>!ty^47Tzno2Rd=lZxbc{{GUqbE z$xio|-_Df0ac;uhNbP@9?J^!U%Rg|Je81-Qlzlt+zu(ze{Cv*l@BjXN{w&@QZt-Qq zfep25wsc$-ubg)(Vp*n##hFK$SDiZ_{#*J(k)10UKY*_!o zFV}cdSi2+EC2^*W-MQsB<(M` zCp)~$wA0jj`{#$G3^~<*Pevizm%=*!La)*aXcvZ%vjWR5D^9*z5#>t*t5_-yY z{+r_LIr>?d25aViXuQZi&A;VbKARVtawQ6nYDR}vT{m=TJrL9Sp`r8WHlfK3?Ka4#zDR{}csW!`XpO^&tahvR0 z7#97%&$oTgfxArKIXu(q)i!&E91yIrQD4OH`bqm^)^8s^O)FVEAuZ#Xesnz}D4qE1 zj9POIm_}YPA*YjP6Hzm|5tek~49a)mnI#$dr6sNv1v#0?nI)*HW@=D${$&FR+dS{f z(>CP2JoWcc@9A9~s!Ve26*DEARxzwh?r=B%8s?vAbM)MiZ|ltrCsaIO|FBqK{^dgs z&K??<%I%NO_y6+M`=_-NSDL8Z^Jq1EKSlQSA-n$@=C5+O zIp0_=i|2FoBZng^Pn12re%N+qL|a$o5rHq~rI=^0&MCiJDrbCU{wklF={#5Oy)tvo zb?#5$4*g*#m0@OZe8ZnO@fsz*%4NFdK}D%QH*7ekdHA@|^g!W~ZT;LU%moCJvUPr* z%h}kme~XRaO|FG1;_OkqPgc0-{Q3}(p7A|YEnal;!ZX{C7);HJpW9Iq{p8fs%}Hnb zrY3g$`mfA=ck`~rrNZU~rw^aCSCNvD(pI<2d(7u6IAfu;sMpIMyem^YwKdgV>*_pQ z*PhyTF8-F?yN7no+uwU-x~c5_Tx4As%^drr^G?V+Gw=VmtcohErd(U}Jz!z~5?$r| zXET4>rbJKKt5KYw_@}2kvEZf1TZ0G-*XKKA-cI5TP`<6a+iQZrXOZ}2UG}VxxYkWd z-%-}LrMl_$L-#HAjsA=IT+@#fKW)oq>DOK2va~sJ#rxhD(Vp+5y*rkCcFhdvXP+D4LLo7N;d>J t2=odTBQeT4WD`O8067>y`2Yc4GGm%ZI9CLCv$BEAU;#pJpqp60JOGyI{7nD= diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/ImmutableClassInheritsMutableClass.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/ImmutableClassInheritsMutableClass.jar deleted file mode 100644 index c809257083418dd6ba7c9f47ef71977c87a07257..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2771 zcmbuB2{_dGAIHZ%xvw0dQLZ(GnX(4uS_Wf`#E?l9^pM zU5<)%#F9}|46U;gky>Q_Gk-nI`akt-{Xf6w_dLJr`+NU>pV#L?Be}RG0YD%S5S&3W z1F)GSfE$2CjxV?iW%6zjM09Z!#_E;k|GzWx`8sNU({#rZ8&{6u- zpm%5}0`HFv!4X4IY}d4` zOc7`kJU*D{O~m?sdIE>{GY<(4`t+P8hP9Z2Mj`JROI{6nWQM69Er1#P&5$;8UeHG}`ifgN%sD43s>c9lCs$*&h4JdxS{7o|T|Npyoe1QsK7mUR^h5JfJD zbEs(_ohnUvXBb7`;f3PD+@|auj}Jp*yaVm7sMHkaHbfdgVOIqCg zJYS22jr3bM|En>lQ9G(QIEkiXYQ8+P>O%?q-EvOvGBR4PMr^e$)c6i}@Iui5MoL?L zR-wiFb+(qmhg7^$;mO!)28JG58#x|8xbS+ok?R~6ivVijSo9ta0N_1y-yu+u{!he~ z-$1|#NAwR4BYpzmjmKcO++U7vv$_uvjUIX3;OgY`ej3#loBSlUbFaw_foyPzUH=IF z_u9Iy!E2kjYHhI~x@px1i8%An42aMh(Y169OY9QoF*T!=0? zpC9CL`29d^4Bu0*j5$Sn$G!Q@nq5CSwP;7m#x>4#NdD+zu)ahhaCZp2tMa|p zTY4KIrC-mvpe|eE$NBNjN9Wc($yZhfI_E{Xnm9`nQ}0rj&2mLhpcsTh892oeA@s(q zv+ufio;kyl0H%*ihh3Q$2++qff{q0o1O`5*b=Xlcm5H=Ii}(qZ@Pnlk_p%jbnq6)W z;t9_TJe1q3uWJ^Xslms~_nUL%LZgFUG#@w>bS%ePY!fGh7H3L)?Xdg6^@o2N9KT#Bq|*vp>r{ivWhulCaE9&qvsaxXoI^dl=i8IyN=Eq*Z4I7K&y&7Y9Km28l1m|M&k61$$T6iu&yI z9-DTwXad7jfX7VK;kIH@u269`-C&^U02FsIoO}T1tgr}FDgVA)#;b=13hm%qB&UYD zN;MG&^cdDNMZq@fAD5SS=rV5md<1Vo_n|n)!pt5`yr`ZKjtk~{@w7SLu*e@Ro0G5+ z|5Etu`pprAWY5-C&pD_}mRdh1G0akx8u(b4if~9xvkf|0fqG+GMm`CRm8==^xZYr2 z93y)_{c`2ym;_~0D)!bS{>VH(!=!x<)${VquMeZ$rfW;~3BH1wmcHvh?Vgdn{xOQE z{g)y%>XhX;Nuos!AEcHpOA4Em3Zw3Jl%)8v0l{GG;4~s z${7fJQzOv*n)3xK+h3j4+_+riz2m`8(}iw)$4Pco5)`26#~ic{PngRzGN18GM2MTO zTe~F(xCT6{o80rr%Ky}j1_qx;*~1u#n!>?~qgiLtJlx|x_-Nx3v?QWpi&sup%dR0? zSecbnXR;Q^#A)tpG0Pnw&|KI#aBYBuh0RUd+7RQW9Js|7sKh~8n=>Px# diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/ImplementsCloneableButNotClone.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/ImplementsCloneableButNotClone.jar deleted file mode 100644 index 78b4632a81054c938ea4c9d1521988fcf70a767c..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1685 zcmWIWW@Zs#;Nak3SW{%@!hi%s7+4s5T|*poJ^kGDeI5Ng-CTo1^nBg^onm14?0e?4 zkGHPgMP6@Rt#fD2Zw@lJV*KFgqo+&^0p9E!o9da~Ndt|N1mXa=1vAksZ~)4B<`(3n z=BDPA6g%hS=cOhl<)k{5miXnDfVui;(vEp4aAkVQIf=!^a|2F$9S#t%y=>#V`0BQI zrPH+}Hdsfq=yEu%;9mN`$WwpTr1mA|b<@{zan&`*tNL9MQsoxcdna@5jHPk;v(K;J zG9M85%@)q?+(>}yL-c5{?6Qqoq%LX;PF*>p&TD?N1`h)xa$(xw@ZZ7?B z`Nuw8x45pyV#d=aN^D&$y5{<-oZ>61mo(@0eT!<4Es^-S;l}M5{;Sg(e)8>#U-W^dgezVg?7Q0RZD+S)6?$iVO(h;fI$Gs&Tk7CDdzSQ@a`@34Wyp7p-M9F5aH zv2-jon9w-UzSGOYBT&-e?%WTYF_vatviG_Xo;ggvKS5xXNYjh&CD@7{!cr!F|F zNw60-ujxha!QKQkH}pC1rOPO1U~YK z+Ts*`?$N!S&+iq#oB8uk)qjS9p0-AwgC|Q3K1LpJk}R(gG`jWuW~$O|r)5hYcQ%yP zNFDzk)8}I3%KL=lRPrwm+4*hG&zIS!F?$ABJXf49&T{jaW52?6LH;vNV#|7MxL8!D zx38JaQY&`%r7MeQIM0gviv_QLoxVRwph?Qg9>j*KkK=Tc*0kH;|$@55JoWRMbl3UJ+d&&AH2LbR z%dtQX*mBf{>MalOBg32$IZL*m2lWuvpD$!)(8IwalQ{yY!>QI1Ctb z7EGWl!N?@SfGG2j3oB5WhYE0&fXJqR3O3|S=YV2FB9Mnxj-llw!o?iAZOEw+l#vnO uKG2t>*@osANK!<%5IF!ri5vk;mqRv$BEAVgbTlpwmBr!yf=f{(;W` diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/InefficientToArray.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/InefficientToArray.jar deleted file mode 100644 index a66379e0731e231805927f9008612f72ee0a0a4e..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1319 zcmWIWW@Zs#;Nak3_`B4~g#ihOFt9NAx`sIFdiuHP`#So0y1532==r++JH^28+4sz8 zA8%c~i@e^tTIbH3-yCFc#rVO~M^Bj;0=(HdHq|q|lLi_k3B&<#3yjb#&<4tS=B1{k zWhQ5)=9PrxI~ElsR_bF4=_ThR78myh#d0S{^rb{z4rSUZXDaxtJpS` zIetsjCe7CMSqJkZK1DCzpQ3zh!rn*bcRuc@e<)+V&L!ATW!0tWS?ve4)?SrNsy?{W zcgP!_myAM-$2rN9tmFbhzbuetAg7eCfXaD~0K6R^MR_=pJjP~iQZ=zhsw-M7L!&e>8Wg4f)bv-URcc;-S0;F7 zQEf++W=jWC;_7ynj(K6Tvr?jyWt)G6@0Ad7J^y#bi!*EP9s$PboVlNCpIhIbQ~ST7 zigiO{Q=?+r(yr6`dM?fd;bGCc=cV7D`MZ{t*|9C<^1iLU$IJB3KCYTLyh$=vlk}( zJ$!20qR-n*CZtGQo@Nzfv5Zak;xt1QfzU*qzQUA_dt%>XqSr{AFj`XgF0fE_|C4!1 z{>KbkGufPf6-#s-HD3My)NO6%EVeYsWA)6ou}`lmdhll?#7$Oxe2Ymg_H8;n*kl42oBLVT#HR`Fu^_pxUMz zmv&X|-@aVhQK)!^`cs{~m1ib>bIRYY$u!n`0=`2aM!%;7Dd<5@A3T z4#>G0R5+jlTt!8IH^LN934ol8KqUYIBm$Y3nIC6)fNU@*6(TzwlnN2R4Comw24hc? T0p6@^Ag#R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f+sDg7H9xv^HNLn zvyw9l^b_;)@=Fp+GV}9__5JcoLNba{6H|f{(^B=4a}tY-TYG)I4?767-Cw!(;;+!^ z&k9%Ns!I6fY&m-sGITRVj$AgAeLd~%GL_j*|7Wq+H`sg4sW9MR6i<8pxc1)6^XtF! zGfaQMmLc$~Z*P=J+R`n>E3e;Mq8GmS%JF>3*Ee1E7d5CY+?V7UUuLiLNkC=0W ztFCU@wEFe^Nf+iVah>*|ccagXe>bZGXK|_rKHL-eY4XXlSBg^4aXv5K%HEb4q;s=! zUaX+s>zNVh#orcfzjjNkXixn4)@i3hKc*dJGJpKM(8FSNy7IRsFV!axh^>r^jDl zfNf*M7o;k(U7PfWc- zwNJPOpc@hk4qOoA@9~-H zvDE9&N+$;=pFE4uKAGiNbG-g$@zgNbg&b{N7^#%_vgUd9{_lS_|NO;P(0!Rf_fTu{ z`b$T2rj+S@zcu@gXx60ErPqy5Gu~>cTNNG^`S#hX%4tQ9nBNGoeciTg)x|QElK4+W zGe6vjQ2VlNruo!~1!7ar&F;DHlb8}M&3)*qbMlYcc~c~<&(AM!`JAS9?X+d}MQiO` z@1H+*&E(b%5ByklkZJql@0lJua?*gQ_LRz#5ArFqq9?Cm7-X``33k9;d?nFFV zviI)ZpK0%2|9&idK(vo}3kUP@xTT$unr~yCZ8e{%9r9=1=6U{KrP(utf31wmPTd;4 z;&|k#PW}zL*M4pNw(8@3j~9NMjr@Nc0|w@+3#U(cT6B6nKRao@Z(`cC>~u$q{nidG2$Ki$!i)(p>!;-S;B1qfea|KO2*=v#ZNoTWp8yejlepk;c*+#Y5B-+y5&} zJ~JytIYGeI_Q>|{4<|U>nDlCal`hNv?|fxT`CVRm-50L?FM7n{fMV6vV=o@RU{;EgZ^R5~LUGN95K0TO{sV#{iDQ<3u% zsDMI%EkK`OH5IM6LN^gPS)rOJ&y2%Fv|Nd9B68S*k|P3S0Rt1O8_^SIfHx}}NE<5< MP6m2xJ1d9>03KS=;{X5v diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations-license.txt b/TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations-license.txt deleted file mode 100644 index 043690f230..0000000000 --- a/TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations-license.txt +++ /dev/null @@ -1,6 +0,0 @@ -/* - * Copyright (c) 2005 Brian Goetz - * Released under the Creative Commons Attribution License - * (http://creativecommons.org/licenses/by/2.5) - * Official home: http://www.jcip.net - */ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/JSR305Annotations.jar deleted file mode 100644 index 8d65c3031b595166d9a2c8979773fd3c1dad5a32..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1935 zcmWIWW@Zs#;Nak3U~V;bVL$>R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f+sDg7U%$Fvl7b^ zEA$id^72a(OEUBG^po@Rl1qz*r$cs<57zPFM6!9oE(=2VMLkBzeR_VwqU zU;oYCpe>`GA#iDD)XMEXmd~5Hj_vlTUcP!$iuk5SOH)kGUNu(F5ZX2I?3$v@Z|aQF zWrcEtt7gBGpZ+i3GvoO_Ez|pwr(4b)`(orLW=99e-{oHWv@3q%i ziuO-lnm*hzPcy{wu|ie$(j3*<`mc62KFtVS6Ce2??W2X1z`0j94cQ%+3K{)nm#obG zV)bsnAW%JXb4yDSlXBo;deDp6P@wJq%C)OQv%fxbT-9W|i@kqdSC|0Tw0BA! z%T4%HQ_Uyl2EAEb`GK)UqwvwfuNx8)j3)ow|5H8wzWjWKb%k>lIPRFUdTEva)UD^V z^XK?(-E0*i8a>}`O6rHKsDdW7h0+(d1e8s)^LxIgwkg*s|MK5tqloD(WzU?J{=6sR z^J0zd`bP>6Q-s!-tJ=?Oo%k-Tz|lhf>a6>gvR*&s_umundp$EI)cD(??bB9qZ2GZi zp0t?E+D})dx$m5rf86;{q^)(L{)!N%Z~q;Stuv?+{eHiXE%KVWz&4erj^&L{zTZOx z>HY=@_7@KfKtcK!oKAO&2gUsY2H0kbg4DeF)HX=V4J(v+Ylo21z*I`t`llBzV@nDRS3XcZt4A4_f{&!)Wo5 zstnFKSMJ&?Hcu5Pm~N!)@!-QBr8N&vNG-jb-B>n7Ty5dPQ!`$!af=IEap2;P3t?wp zy6Rq0S!`9VSRi9|u5YR5$)Zo0pQ|TaoKr78J^#oA>l&Uz){WPK1?+nwzRZeE-jtJc zblyMv6UFmZE?ILZ|FEOTS5}s5KX&Y?I5_*uhJ&XLKFiNd?tU+~IyY@kxJ8R>$*N7= zc~_O*B>rayC0wPw&!TvNA-ofBDC-kQxPJL1m<58rKa-)r(fbNJy8cg?&E8z4@bQtH zO_frY`l7bGGbH?%_Cy3lZ7%7oG3Bpgu%A-+%F*QJ5w*8Izw187+1uT}$2e#4+y!nH zb62%i`A#jiTamEGdu#bF9j-FPy&o0p^&)zWzaHUy)e?3jc=a8Xy|TWM?JTcb&b|6N zJ@EZvHz*f&R|7q|Y^2LR3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f}72#78nC%ee(0t zoia;`L-JknOOtX^J@d-)vr|+2^E~rP^wA~tl5-M^i>FSA)@ODUIsX6fw$<4$TX)@G zAG^KwgNI9o$}HYVUE=6L`eB~;6nV$iErR#mt4SLJm#xmpqaD2W!0DRYvz zm?ex1f2`hAbM?ZWykrSwlLc9q_EhToaX*!7aeB3hZ)be`W`j0P;m16-^-FSnlDZD= z>2PZ7iPLeLf0SvHP-O3#6A4p8jn{mV6)c^aFI%RnB;0A`xaC%cd%RE9rIV`XPpFH% zyI3f^T=!CnOvwe$tok^G`=ZRd_ILMl&QzHH*0rkm597^Cy1(XH_xx)pGVl=hoIc@@ zkx@kFLg7O5oBAspt$HO7ExXVdc_wgLqTMnPJ8(pEzOp*d!N|bSz=Rypr_dtWh)_fW zBO5sppvCjztGU+~t^NJikMk~j{}JZiC7T?BUUo0fwNA{kR=&OR2>XZBJs%q;{9t&b z{X^@~8KLbJ8&6uMKaZ*VZ2$R7)qjozQA=)cM7z&+GUpF*+^WT>f6BP@P?^ywrlM}+M92QtH~drI*YZ_ebpQE4 zeD<+o>+V(&HiMMJ564qp?paxR_@IGXhWXV+p}+U6(3!GZo@=GI)swp9v&SUVbb5@x z{0S^G=+tC;ePsz#W}eQB@}#CU9%0Jb1~*i%a;>h3mI&Ru|Jxa9gJlj*3H!``Ek3TA zfAQqf6B^s}?1ZJy%lf78o}9CAV$RR59${>G8D2C9;AUl%ExgHhydeMsp=N zni-iy7!XAUa$W}&8K?kP0TSSiFa=aDASWbHxqtwPKqh)YKtw5lYyl`eB6|Up9udF` b=qbDwU`?F?-mGjOGnj#p9T+r*V4nj3c;XLJ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/ManualGarbageCollection.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/ManualGarbageCollection.jar deleted file mode 100644 index d92fb63a6a2aed1e1153054d52f018b85fe7c47e..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2010 zcmWIWW@Zs#;Nak3Xzj6eVL$>R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f;-))78n9$eG~Ia z6LZ`Xi;@!4Q=Rj3a#E8^GV}BFgDZZjhh$ zZSTzO^W#^WHgL=QDqwLdPtm$0tR-~niN*D(WlK-_n$*TlD>C%V_tos3JK@_yt}oBN zI89WW?8<*~&Pk?wQ;k;b5zF9hGiEHGV}FuCx5R17L(Y=q)F-uDJyJe;bWUUXYvJ#C zenr5x`#g6)Me4HpJ+6<~B~q}-#DTw7zIy*1(>DUUuQ?fBkA*;+ILEB2XENb9lsX+SEk_GtA_%&=NxW3u;cKJjp^o(7-tpOU-)~Gt>-|; z`MFoBZgal5e)XU^D4Z`YS(?bn$iT1^h;fIrI-YP2Dg}maZmN4SBy?N-cl!ZDcaE>j zY>CO@E#d7MpC)V&NEPr^xg;@xVX6J>$vaP2dLMhXKZ7Cg17nRy()kEa$AhBQzh~T> z{rA_uA1noJ&g`a#E>6AB>XD|z?W(gpbJ7Wo@Ri^4x#zB4I>(hy$0=QLUh8}g+27_5 zn>1N|$7D{87kJhDa882nW%ieg`j)k`%{XBYmW+M zzq_Q={bZ@px~SFh{yiegA6O^G^&0Q%UwnA#d5@mni_&Isr#7Cxs5hHAr|3%^XHRsG z@0PGfg_ewS%D2Q{j6WUgmT=@q;m$)LEq{%ye=vfAyn5-nxpKhZK8QESjfe?yENS~R zF!Xt3zE8X$@Pe7^3xCuKDaAh57_C4>)(H$>_i?V?aJ5XiwdMaKrVeKL1MZ4@6odE+ z68Yt-ZMLP`@4siyFel-`A~%V6u3!#Z@kkXROYg1I3fBb*-w{y@*S74}_tEQJ+ER8= zp=8=4PnM_|Dm(h7tx>aBerm;^o&fniv6f>xd#B62%J`XaNO6mE>XXooT`6ViO1hkT z4SHMSI(%;KQj-4JT&3c3=zqm5p)Aig3!CS4>n+^9E&OEdn}q2PRE^e4IMrKl)pIT{ zJ3X&I_w~))zTG<0o}aRk{!?0+B>q6+PwtKI$36Q`Uwo>SpmOZlLv6Epr?(xysCiP* z%<`8#(=pv+)AmO5%1@O&Q0x4g_3zgm$1`s89ec_ZE%@#9n+MXM2-w>n^HUKR__y&! zfEu0%fR!!KB<}}F@})U7IVgMP)m0`R-xNlkPMY|y4_pT6%tmibaj$} z*D0SDJ6BA38t=WmF2MUx;-~n&;%j0~GZ~zFYI6Q_UhQ&vbK|t%Ji(^OovVy0m%f?! z@4LGCwWi>LtQ$oYkG9;YO*2$BEIWSwMn%><=67+Mdp4Z3&0+1SJtnuU?u_8AqIiQJ zUx9_mjPtVQb*DLYpWX7E6BMvH0lfySz(DN=2P`9#2m_*CKrYZh^#UruRZ9eTBTNAm z{>a4@sPIRCL?DyossP=19^-C7F@yzqg%`GiSOv*`h&PgmT*7wUVfs2G^mShB!Cgo%%yJe>4q!jBVgOtpj z80*axDA0C)@#@uSQDNT_ov!spE%_$vX5O?RAum9pJKWv&<;1JJeDZF$ z?t1#iMQ+LE-Ll(#Zm#o6EXxt)Ivh0LzvAGN!+DPRUtMn}CY=A0$@9 z0<5m9Y>Em#Z7MOP>#CsOkBt(p5{9SFJ(EfdIIO|Mu}e#^wM)Qxk6Qa8JGm`KUfi48 z{O`&dGjr)0mDqZ@kU8_VNS@kSuOG5Zt>%jExxPuagLvjiD3xEUxFQz%GRdgE)S@Jx zSyJkrfB2illgkv3-tm1l(LgCh{Dkp|^3RWchP!-TsoB}AIW2zA5z$SY8Y$c<-63I4 zJnj)oPn=uBlkLGYFG`)~^A)znv>7*KE-$T;pIa@b<|6UcHtC1x-2kRtf*h~h0*?8i)}e4#0Fve9w1ucSe-z5P?^|3*dzhGZt> z*sefJP7Z`(+soNAz%ef`za+6FH3byi$Y}!>-RJ$73PAOqKeKUpK7~@-5wiHty4UEhxPG9 zb*W1>yS_i)zlA}&hk_9ZUr9jGTGK~ z^`=Jqrk&m)af$Zl+f|f5rYy8H%uVCTj_9wE4!m>Z+L?H!I&cPVxR?@=3XD=elqfAj zi&AHjqcp#?1T$8b2Kf3PauBFh=3rtK+@D`%aIx(|v%5?3tQl8AOtL=gnG!l}O04tt zKl=Q~jx^gJkWZbX6qql!=gjTO%KWr@`|9`XW3)IDCdl357an0cRs0g)S%nJ+E9OL9 z>|ZM1t@82Q-v_TkvXfh*L#$VBxk?nzpEB3`h+-(){&qUw`(y@~-2D}K4D zhh^LrF4QXCb5m8MZ%Wv=8KuA3ZJq9!Ge^4dg|e$o@mA2Wj&Nx-42decTo~_{w|O&1 z?*$j7cb%Q5ep$}k?mSh%?@;~HOyN`JYI9va`J@Ja|7Wyi)039BuS23ur`b-`h%+nK z;Pbn|xpm7ujiCN{KOXLVfBM#qr#o)$7YN&QrpNW2*oGter~Wl(x6b4%J`zzF|6oVy zcgd~GXKpyR)lB-Li=3{RNu|hxnv)j~yz<#@w)*vrgfrK2nC63WVcJ@~bxy!2;{`_< zBa;XNqF6^Rk3q#cD!^692Y4e)0hQgz`5aVsBS0dMi5#zFl;p^kfr<{~6zG7k3CQvX vdJwN=L=+^*wt-SLa^QhdH3BFBLyI)qu%__O1l#E@LpNalXY{W^*yx#eDnTqDXYmrU+* zDPNKza?4llq(c9#@Av!X>))@_@0|L-c6QFT_x66j_IZ4suNwvp0Pdjyfj~5l&Z-(T z+iVXFkVYG&50^fvqbaKm*Ey+)($kmG*4%8Pp;^-IXg`gXmg!+ZOG|ckbd_S|dgb4a zkB-yQV9*Sp5`WrRUdmS7lqcqY4_I{i_W>6vt2z$$dIV=13!;seg(Z=IBwDz*Xj!f3t3w>Q|Wk?GheY3LVstD%mWnU2kMKVN|Ii5Efe zc?Kti=rHzlFAhI(?{uvfwOS6FymJ{^VstM|9R()_B5b7Pmi9594T5nNW$=bi<-(Tl z9c}?xtrk4*;~p83%D;;4^vV*BGvyF?HJ+u$!;x3xA#A(9Km`|QlNsd3uvZZjSLUAM zEg2oW-gv7uGxDH9wK8M`=cv7Opn26PPc1@n`Auv57BQ)AO-4^;AvXXG_yRBf;h*-E3^Nw)7_yn5KNz{A07 zplHce`a`+dfx&`OsY*zWpg4m?#Zc0M*~%&9 z^(+&q1#(5_9L;9IJ1~Xe~UMjRVTeal%Bv&uw-BCUEP~5?Z`{Z;S&=NwZaf0mKep7Js9mcK z$*r+R01}z+@$V+5sT#J{By%v&h;AIH@UM&>tUFnu^=BBVaX~^{KAn3=1&0f{E>U*R z^B7b)?bdus2h*Ie70#Q;@7!VeLI3iwoQZGq>->7zk`7)X9U5wihvAyS!-{w+L*3qu z4?LwW3;3qYxI5_$78K@&KUAje?_&O+WT}k?9HPjws1Tk1sLz27EYKS)<)IJE)so6m z)A!cx$LRF|-Ae`54by<&O&b4L<>bA_K((;I*3(1Pt-M3clY_7TJ)(CD+lBtA+K9NT zy`}p!OSr=h*o2Ka3lMFk@%@aoJ>I#g?yHj{wVVbarH8z+282Y`D*!~g&1}{U z)k~cE7*VKOZ2X&LC-HZKVTc+$VlM>RFeia421^P>9Q|t9&Rsv3tiU?{sIB+1|N4Zo zOBg2c*(pW0nC{Q{C`MRaVYpgxIUg!g+C$vsy!o8Vd?jMy@FeO!Z6`NY)vNLOwM^)e zsq
    Bt!n4&Jb0_@*Y*t+SSQ*!<=q7gfiE>1H+)%^={*#V1=kgESt(0V^*XyLCLG+u0L0uR*tKx zi87%6>`Ot0M~*qPWIOBgUR{iu!`FOF&gWM=@w+r(vo3*fTFe_8HURZiKjeER7Xu?1 zOWwoB$eoJ~^%F-Bbfs+8W76@-j>nbMY*=!$-SD^eb740wOHKRtDAVY|Mp4zCZ3ELY ziDBR|ogs|JIFg=z(1)F9nP|6gFwjYK#E`=Tk+=Zi=}R!1T%yNw(h(2!y&SeE$ed@P z!ZWuuxC^Jid-Fpg-f_5g*M|xdoTKJyLw4~(0_~bZ(rt7>poiw&w z7$m`@0S@io=hkx5j?2BDl|REj7YXG54EUUxp>*vI>5nWz!pEWNxs6fZj&Ev361lb5 z1d?m};{)06dqGSM`%KwFZwad=yPx+=+im$Y(Y;)==cVZ<146VMN8%Iu!$5EG*^qZk zbA2{$S4z0pN_x~o;&|W+>;m%%$*JPHsCy*8BMbJA`4QQ(9|^1^I%b!aBrSYTP@pKH zDi5&8GTu5dbzdsjHdR+#VLieZr*=_0)Fv_ z-~<03z;C}(z5)L~)UhVANH}COyFBwC!&x_5)9_;zBux(yc8QGV^8vMOWr_uS-q9{P zYLMe?!CIN2EvTbNczCqDfmjF7Cxz->bIUo!QZJjykQF%C&4 zl~&$2OfKSJ=bSs84R1N>*ljBknG$?#H`}Po8Fhbc8_({lOIlyoeEkNJ`o|U+J6k8g za%?PNj{P69zh=GOpN$D z?(6+ksAU&kzuwdInVA0v61)<~xttBc`e0unvkV9NP~}g7lu9k=YwJIy8atCT*5#DZ zVR_haM|o*!%-roRSsI3y-BJ5rEAl-SH5G-fK##^37?GD`LM|Vjt}d~AAFAcn`)1|~ z;PNMMyBr)DZoc|7CdZguTcik68(3kq`3mI{O-d@4E2o*udawr_Ivu-iAVn(0O^b|)XlAH;q&o682_q9Q;jG=oIv$Cx zH*a$86~Pb}HN-w07kjb0>2UGd3%O@U8~TLUt7&|_CsP|4B9w+iqX>zt_{$b03J8;C zRcE1ENE-_JKxUqiL?|dpwa#zxy6(ofMn{bbM%w$ja1_*x@buGXu2m&+> z1!3BNEQjJ%!qxVGj$Dyk%8Y64%K~s45ti+~M5yR@8hq^tg_iHP z%4-+x9-6Ij$o4q~bsX|<`%l9W40>x9>da$%CrzDsY?%e+<&MF{Z<~PZ^lE$ONbTac zOq6mZewSC@Zyt8~w!Ool_O4sjPRX>t%(v~Kb7#KX>C*NBo!VM$SsmSPa_Q%;)%N0( z+8=CL48yN;?5`lR^P+68f2if{mSGtG>$A7h_?blZQ^oF1kGH4cz%6$vuTC=mevh~R z#qU;WJKf!$O8zYbSC-%I?)RB*kC)UOwq<7EU*yt12h-70H)oi+omSpDV73+KE=9ZQuCgr5+CFdj-7q|BA_F@hcX#3yU>Av{cB~3?>?kRbRnW-Ba z9rD&lJFfAYrZ}hI+ZvU0;ZIp&b`AWZM%fc1bSwVY@30=IL5|61$%xGcZ zg&G|`PV>Nbdpv)hUDM<9e~W^9> zp?9ZmcI;gc#Ch{C`^=PUD$$IgCbCEWCf-mL@H>*Nv4-iZ^!Wn4oywuHW#aM*$5hu{ z(6Dk7UTX^qv8Lzw?$3bX(ZC1_F-9g421KMFhbAaePywzeLN)~y^2j!TLLLDUflU1I V5a7+q22#%igp+{uWS}b<7yyrLyU_pu diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/ProtectedFieldInFinalClass.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/ProtectedFieldInFinalClass.jar deleted file mode 100644 index 1ed7e90866b8381b9e1fdd9872595a8221bf4340..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1502 zcmWIWW@Zs#;Nak3a7ndwVL$>R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`g1gD67U+Xyi}FiS zlS@)l+%i*hQatnAGV>C1oO2S3i}eGFGRqQ6QlVmc$sobr2?xCnI|#J>_q=xO*o|w~ z(lypLIod?+5n*awz`FFi@1_^iN|`-xegCA;Dp$iG?={D_`s1_2wD14F&wrS_zy4c1 z!@B~>1Ij+rLvOCw6X?2Vs-~FP#jsgBCzi_UYww-fYgNU_lDJ`7w4`)q{Nv?0XNy@b z#c(^NFI$@@$MG*^mr_S%9nV(jVsu*iE0U72a7U?N&cOU&bbH=8@;}3Ke|I_fB+vaxc|1dHxTc z^<^=SgfFsd^V`1LTUNx=$eDip#pW))OrC;^@1(Z9yr>Tf(}fa;BfbMeEQ1kWm>Loa zQ)qCbgzD4)aH!T!J^~8VRr>>0ErJDV)1}{PktL^gHL85wZ`1MMApeKOM{Y*gRD3o# zyl1AlasIQma}uO(vQoFRTXE1FYSAftnSwF){bMh;kFCPJjUC8RsEgv`d8dj zH{oNEp&FY*Os)5Lvb|L{Z@K(NUP+(xV(iv++;cb0F8ndQ;2Gb6ohv>*<==F~^OaJO z(b4a$XCHX7xE#+Any*7835 z0t~P`lpwW6%LgVz2dQ5^B>h6t>eLDQ{SF%l9NX{hMLCQd!h{smH`c zO)Rh8sfg_`+BRj$9&u);qz8-@8b>T$eRO!rcb)&f`*V7I-QIeJ84opD+-Kaowry&v z_UaJN*i^Mpw->EqzLWoKGupi6wp&MoK~#78#Ee9_NwbsAvNVdgyS+F&HSn$JL3`_X z!KT)=DJ=5UhE8w3Io{~s*esVgLtA3bB<`=Ikr(VuKyr4FO_o31M z`RBErO47|sHG`jCllgzp=dN+Vp?Nj`1ooYhe63ZKX8Aqx?88D<7x8= z`=mwPf9BkT6I%B!NjzL|+w|Rw!}*}F-B&hW@E0)T%E4jF$RxsmC}og~2T&=43UHM< z0p18xKt&01h5!{M2#^S5l31{y8;+bbKzRxQwt_r_uhhbp!;p;!r7z^r0i`bl;9w@! Xc+}Ju;LXYgGKB>QQ-DrP0S7ApAKxa@ diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/PublicFinalizeMethodShouldBeProtected.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/PublicFinalizeMethodShouldBeProtected.jar deleted file mode 100644 index 0263ec5496b0f5f0a466acf39077b33bcaa5c9a3..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1209 zcmWIWW@Zs#;Nak35YM%7VL$>R3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`0!B0o96++ANjaIx zZkc(BIhj?dzNsY{`6Ux(&NhNJ<}@JEY4iht+H#vWS{3oXHuVpuFQ#OIp<`< zsW13)Z@IKigil6a$f{4pPJdri_-)WDRgt~2@!_IIwS{k2hujn4Z#eiW(oO($nV0o_XA(r}v+ARQ}WLhqp%Z{l4+!)juwY?Gh*7 zq=wF}?v7l(Me^Uqm+Nw6+#a;FHhZnU8?^H~Gbk#Sm0YfnWn^G@55$P5;6;lHXX2v* z7AdH428oTO0lWPUI|$72ons;4tiY%xW!1zWu371+5G2_#MdR;HyAQ6%#4XJf{&jJ6 zHt|1LEKsecq~Lf|)OvUI;+r>XtLrOSFC1;_<$Aaxo~4tkT1&LEYKpi~f2m1F=|q?1 zo94faY1`SeXZ;)Xi*2qElHJx1Rh9OBT-Ri{nd7VT)K!0G1l)bs!*Ok9-;!o6v6w3X z>L#^QPn~{bHsNLfOQ*_~8riNC6{FNwk(W;;o2t(F@!zP@AtUCz70dHKic==Xye!E| zo_b;4Zuw&~_nA-by}GSCHTkOK3nlJUe@W-r^*uMtm2NQU^L*Bt^Kp?(?m8Q{q&07C z7Jm$>vzB?Cy1Ci4@11&MVdq7o#WSz!6z?n0y!=<~@~qPqJqPrJzt>GvS~K;`SAI~8 zXd6mjRRqSy4{(eyGKnxC@*i@>0p&kbfGal!cq2>!WisSAcR(>B5y-=qnMlcU$hLvf k5wd?k=?DSdfP6??2FI7G0=!w-K!!2{p(@bGI%W_L00_&vxc~qF diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/Readme.txt b/TOOLS/bp/src/test/resources/classfiles/analyses/Readme.txt deleted file mode 100644 index 6eefcb8d05..0000000000 --- a/TOOLS/bp/src/test/resources/classfiles/analyses/Readme.txt +++ /dev/null @@ -1,7 +0,0 @@ -JSR305Annotations implementation: -JSR 305: Annotations for Software Defect Detection in Java -http://code.google.com/p/jsr-305/ - -JCIPAnnotations implementation: - stephenc / jcip-annotations -https://github.com/stephenc/jcip-annotations diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/SerializableNoSuitableConstructor.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/SerializableNoSuitableConstructor.jar deleted file mode 100644 index ea117e701385c10b868021e8cd6e2380ecd2d3da..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1232 zcmWIWW@Zs#;Nak3IFW7R!hi%s7+4s5T|*poJ^kGDeI5Ng-CTo1^nBg^onm14?0e?4 zkGHPgMP6@Rt#fD2Zw@lJV*KFgqo+&^0p9E!o9da~Ndt|N1mXa=1#V~-gaT!QQ;RYa zb26(ElX6o1@`Fn=OF%5={Ji3lqSEA&{33m16`pw+K=mcXZbkXISXJvK=Oh*vuMIfu zb=X0~)_hxM+qG*^^R=hj9Y~7Ry6eI13+t zXLpwGF-uQ<%s4Va{{Rg_{ zuIed}{ku6kT}Stft+(~#2@m*7^OA0cA3gWZ$?JG)@(t#Xg*E#BV=E$_?Ku=@@nPqp zM`?Yld%j2%TkLLk*Uzw-KF74Lu5;c7Cvn|%X3urjERNmvDyey+Q}*gPH~+DK;_72( z$0SWg28IYG-8xw=6#)2F#Yf0lgZO2mz^v+ znB>(_eECMu-R%9(OJ0AO`d?K20sDjA8?3uzl-K21vd=mClfCSoB+HG*65F4!I>jtH z{^G}W&fgXpt}MSKwgk1mJ@bJb6xbK1NqT()2IVSXfCqRpGKnxC@*Z-g0p&eZfGZ~= zn*z#U$k7SPU zQ+us3yEMPV3a~Nf;H-~l-8juC1!9~w|0aO{fk2({);`i7?`w&T@FQSQ_$!1!EaUR| z8QL!l>xDUEMfkjO2*+YneS*Bg!}Dz|t-B2PubJx>{J6@e3d} zxZiew*W|vPof$UrneUXE&4ybw%fdpo-~`;q>6azzW4k@_35r&5Gc~lcwcW1-00&~73OfTPFW(=g}!hK5Sr|y_5VtLU zEXfG$wlZ1^TjEJho;c^0eO3gARLAwp8#&#qGRoi!`N4ZpDES=}GTLZz1Gq}#V76>X zFmo8q0sw@t9&On}-0wA^`xjb<^um1Z87ep=2pf#WM|ef}6Y#%vugu=XS^y#ViG2cJ z$()8>gHR}?!ysKIz9ajGg%6&C;{oES5>%2?ZX$XW*ydO_Kzc~L-Afj^CO6!x25f=z zKc47MNo|UvhydBNrsm?xOzrmF)V|%pW_VHQ`j@eNLyK@T44Mb{O2c_IZDbhpZV%U8 za$hOCUD-r*c+ze!O&>Q8e+H^oA)g|7y$*{XbFx1Pg^8>d$BuR%uTjqw*sJ_;DcHl| zpcdN1Yn-<%4RUO}q!m);MJr9nYO?bpQSLjc^$#6d(Bi(*`Bg46mf*b5Y%%rbBCy)1 z6h@!TOlz$bW#1t_BqrXA_V|!+_J$MnhFM&dxCD9L7(LKcaTA>?cTXIr?mO$=EcC8O zPJHS+eCVJL%sKw20Lc^`jEMr>N67+l^ zs5&xQbGS8{9SGTYnoHipilMGQpl`5cL69}VP301G3YQ1cGIl+!Jg8?Mz?VJv=;fOC zN2CX3Ui4P1+hg?Q=fum3j+gd8&-e2t2I-Gq0D9KO>_NU=lX1CV_-S2%>&#kLNT#ih zz(OBL?nKL60hhfxenNdCkBce_jp3a6#XU1hN64pccjU3WFRbyCY{R9y^1|ww(1|Ln zUHdnu98X*`^3}e1)+DmN+YJirE(XV{R4#_*5a{wuL9dJ$==w6mJa_DDd}qTgKygH{mcmfIqT>-}ZCkWP+H(`pXkW|Km)=!yJIqkzVdOqy9lO0*(agqK3$ zzA%UA9gPZ^YUQVQQ&|l|Z|i}Ss4-;E-ZGGiVP$Z89FMn;RBZi?pFzSG%%Hi~QbzmS zhyjJ2{>zD*Bx+8!ZULx1KR}CbrR#bI2Qaw_J@2QxlD2$S#W`s80$;0c4*Ot^6+BO! zg4maAGAQ#culuDoT~ovw*D!;h?y=YP+4Q~{fmI%nRJ_w~=5Cr@-tKoX*X7W(&CTce zY;)czTgYOlvbV@2@Yh4}1h1`UoIh3w;okQbITTwC-^n4zNJ>(Tk(OPc^KBE>w8p|2 zTN+L~8>X5oe3gfTV74V}j9kjg>VdKB;9Nm^O5N6at4-{r$8O}=1A{31d#61~)U=b1 zK6GFWeyKV1SV=)(Q1hnvvYJbiiy*cATa{haMhp7b}ofFB(;C5wd-Xoum8vv9S{v` zj18^%dTICLn-+>vx0p!`e;cq}kD@u+?m+>tgT8T?QfUfe8jLEhG#PFVDVi?3wvtARR<8U(fS z#UdEa-N-=yX{o2t`c+bM_k zw^4fvNd@_2xZGn$HkL?NC9!7)>%@bo<+Ke*HOs_%49Ll2p0)Gw%H>qYr(ss)B*$tQ z=}AId2RDq~2?#jwV^=%V((6%h)ld5f3u{bG$R5UsD@r>>n{U<{n~U z6$E@qkVm5*GeQ0y|1D1*t-_3nN7D#1CVqhzG9sAjtTvKP&&g z0?tt;rl}mY8|JL}f+fbk`7@@!JbC^|d$dDLFZ+T6_Pv=W5OBTy? zU-H{8o#McFTeCE9;tmF_OG`o~Itg+;VN-dcvigBWsmg7~M{{>DbaHia%Qdt+omqF6 z>0Q*LB-`ET&wKVu{(ipxy*%#3qS-RLJ>p z_;5vd)3FT}W%fJH9r@~huKV8%ekHbNMj_VqU-CpM{=E>4{gSyglQ)Amv#{+^^7-$J zY}@u^ewEnrtmH)LlZ_b%4zyZ^NCvPS-qgs{#ltOo{<-_+$9DX2JO6Tuub;(tr?Wxi zxyzMB-{VdMy#G^feq?#8O_sr$8P6Z8-u8&opFM4rW#YZ%3ES4rW7wCtpk?Qct@^jK zk9+zSR^MK*Zqn_vHQQVABro`X4O=76@poS1sg-pH7L+gFoN!=%<)Z6f*G${Ss+N^< z{xZ9sg1Vc>?l}sRH_maf?G%;NezM@<<>GmM{vPR0TlXg(To-3^@RInD(dQDCQe=;$0IP&C3clM5z3^#vFVan8W z%vJ%DLDLjW?*umGEOU(0a*%kp%JGcJ3F%LJ&N5t_+H)4q7K&woO%t&YX~}+M&F;td1F!;-X&Nzaq-Sz#z&BN^y)#A`FN`jhq@m si5eB)O5(_-fKo294WN{Z0Es{*iRn1No0Sb@022@{2GW;-PG?{M0DyU5^Z)<= diff --git a/TOOLS/bp/src/test/resources/classfiles/analyses/UninitializedFieldAccessDuringStaticInitialization.jar b/TOOLS/bp/src/test/resources/classfiles/analyses/UninitializedFieldAccessDuringStaticInitialization.jar deleted file mode 100644 index 5ad6220233b3678070216f08df3b5e1fb483a9d2..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 11295 zcmb_ibyQUC_NKdQD3NZE?hb(&x};@*p&7b6q`RfNL!?6*BqXI2BqUU%I~0C!?{}|$ zu6zB%-`%rj%{gmk&2!Fq_TKN_`+ZbF@CXDjC@3f}$p-IaV16n=Ra`&wk)Cy|lVgwu0E2Nt&8MoSkJ{ovff18ZKZLD^rDk z{o?M#9{NZN>IAU`yFkpO?V&DC_O{ZtU}tAZcGLThYPELdJ`Ms==-bdxiTus)djSDx zQ-Qc42+x3ogc!vS7P9&SSk~nuf&;qXkZ|B1cFR%i9N?AFr0!gcoKrmL>J;sQS&$ic z9Gdqo!N6&te6^X?(t$q6aK*y0BUi>CrO=ruxE zwLiXXR5w;{6L5T-{EhMW;Lao1MgBUIH1@4J3DsDYl?d@$Xh{gJ2R>_#(5GWP|qaX}`Ih zb@YOTff1BUzbGHRr<}aG*h+dq5BToZJ@0+;RV?O$v3TqEs4<6BuUxT#r;((w)u||Wl?!nlzo%l!?mruj<-u< z)&^)#I5+qV9@VXw$v)YwRnD}_A{>u-%nw$yzwDZ4>Q?^<3`3o(AEL9|(> zdZ0akARYJ2=!EkHx19m6n#{0-xbz`*#534rlITi=BOhR$j$y?o&JbMqJ`CjBX?O-` z3q>3?dLeP4WukdX!CcWJtaWYa5QdI5)KDolht?;b@)ftSIok8D&8TCn(36JLfv!|E zq2J$k^;dGFE8~RKEF=vFZ>}V#6uGAt+>|6l^EiE$NVN{GKvO4WYfA8zITuB9u{4dx zaz`lTP_}7KeSgwZ$!Ls;e}!bmc?mIlJ8rqJsKkuecJoJwK{@>EC@xP*9!`0*;G5;?&5Cy?Y;`k=TwbSM(L`PPqls#j@;6sv} zkyyoxvb-8wHqo9FZiyqfs_d6~ae#bL*#9m@&ocAbyXWWTTbT9NhnHtqtHg_9z>q1s zD${Hm@JV4LlHT*r2EY_Znry{-y8^otTbMW@Mq*1l?Q0*l8Trj)+6)42E1A^GGMpN1 zY6Z$MKH8b9X`LQ!DbHJDV3`4JLPhWkqCB*?Ni^50!GS)-Vtx~If_!{>_4IQ2#(|Zh zd3P?% zB2*}PcIL5L3gF2x6nn97$e`mMEjqT6!|t6~P0?9!+FbleF9-t5H|f~NZ#X*#xTnUt zwk3x2jvBJxQX}_g)W||z?X;XB&I&Hh5L@%V=+M;Hc&mzYgJqT3Ak!Tr%Wj0z&u73) z?U7I27~sZwfTLHsu0bk=89HO7{`i}go{O=Ina`P=;GSTzx9`hrg{EuB`Jz3)_tEvl zxirjMo%pH2`0@58o9m{vh1{wb$f6V9bcvPcvPrddJLChu&*B>jxp)o7BoNe2cwg6O z?wr*^<8eT~>F5GyV(eP#fCf^k`OwBqrcZ3T(PRo3>x_>M_8Ddc1C9BVmR}yS6ko#cZP|6POpoBS-x7=;bz< z81@+_xt0+gs47|_aG2&>wlUGB9?J&x1)t*3Hf2wM)z*5WeExACKA|ffS!M)4(+vA+ zwV0^=1F2?%__jU~l~@weUU4A+t}e9U%r--{T4c#q@bfBj_bKCOzo7{+)+TkFZyc|T zJ~SS%Oe1*J7PlvQg4X;9XBV)S=U|Ui*c>8EaHY_xDOYQRF~eB~2zJHz;!S)*jka9u z9m2{HiF))HapaMZTTE}Qyjwt3MGWTNdJf+q=6fr*FiT(|(xCiVi*YzAR!T>FJS!H= z0A~f~J7c9pNQc5MOTz?%3l%IqVvHBTWF9KMS66}vi186wrD@BB-ZWMe)AFZC9*2PP z!zkOGqG}Gd>2;*A$0+`!5nQ`4Dt>|Ag=;aH9Q{K*!MV4H_u(ObXaK6X3ym$r-z{AK z%X&rXUs2UE7;;E?_1-$kLX=9@SyHJ?JC*g1rLD;K> zIHt~M#r=t*VJjV;rvI!~dQEUiq`odO7OK-Vw54TB)45vkV?YvjuuULsrRDNk3s+JO zIM1(IBZ`U2cX()$1{0vx3AEm_8z?EAEx4|1ip_p_Cy;c!qd*D-*g(Ayb()!`4_H*~ zZEli7yoIsku;3Xv3Ph>a>Sz%P14J${{J_+ZVK)LaUn&#G`h;2jnx%-D+978wo<^}~ z3Qp|%TfQki^iIt|T-=V}c2y&N5A}YG{44Hl-AA#|YK}^aak<&;L*+tA@)2psDLdA_ zYCXBm$IJR}3`^r;aNfFSksYWs-fNj^q>8*Ba*Ft&po^XbZt!@(Ja5WGwUScbi4*ZVuF2>34f z+59&73H@2}ll~`>+3Lf}WOvKYE<}V6lOD{lBhb%RiNp~R6mN`^NEa0q$U-{EHa*3W zy2FXw83F30QpdUs@X<`J$N?t|pguHuRZ;UK^V5FUia(64DNR^%_qb=7^aHC$lkOF+ z1zM9rC%&`06z4)h9ni-{Mc=PXkpy=g-i}cn^KB+bjJP7mWDmzmymuuJZbuU5-h-kp zT>Ev;Vl%4N7@(Lfxq&vRI9L;&4eY#g?5O?^nySq`XFZQb7D*M?Wi4x#x+JJEC<=Gx=8*yLBU@%FmPK&+WEF zX5=CWDVXgF9D5V$U#k#CRCrR~9u8-fOxm6cbqYkBWA2rDyAY5bB_GQyH5`Y}yV76PG8BBHiwSy1=0i6X%Evs8ds05;^E zD0fJ;Yi(X+*KPI}`!;X^M!-mGuH3e+6m{`TXVBa=3IdTiutSL4<~ZT zTQ|RNMjASzx7K5L39zc@otCu|Kj&069l#(Ks%mgDUZi?xmQ8s`R+{Zw*zyUV^HL%sSq1HZYb{Duw#f<_NYj$js-o{>OrMY*j< zM_`N3F}jP_%5?brn`EPo8qRRXOPbXNTBt`+Ou_&anFE4}?S%FP&B@D&%}W>cMp*9g zVgQ0s#k6^cUWQzunuU^GZkroDuzVDbB@Y(e;$&PG4^xfT%5e46Gm*Tu-b&jd~0a>^Hd3b;0zE6>RLKOe0PtMv@G9o6gN@9%1my-GF! zi4PKy3X?u|0#nG6^a(w7iQZnwE1axTdrki!)75sWPU|(_gGJY!$vTZedZ#qUXIHI2 zm8XnHE9#@4-CgPoELw-B`=&>yUvqVH^>g)d4RVch4da<|>f*7M*Sc6@?j`8WP;$u6 zQxsHUYAoWbZC&7&g=xwTg8A^CK8Z+9(XY@nKYHGr2ZAq33H^sLY z2%t!%ibC`!>`QG^<>M`o&0em;&(X2a?`pB1mJK2um)?yJdoDS59V`0XTpeLbpt)<= zs>kOvDvr7+R@;j40yRq1*p)uFffwKD%{FYI$8M#2K|cg1M-paMB}bEt>AujqAd~?# z%IQ^A=^od8`B;!IjHY)Qsm0Z5PhBH1?8%B6m-*zJc0yMZ-uy6!| z%7H*1Dr)A2SH@aVCBwRb_<)1ncJD1lU(w97TisBmCn~77#~6a;3?4&K7?F zRwQXQAlX7MC6-i7#0Qs=H7TDODu!LHqE$6ckkc9<<;c?}2jB~b6mY2YRW{;V?fBta z759PUE#jI{`fzG{t|cee9LE;baxGWWkqyrVUVDnI>en!{p9}dP$@ssQpej#9ro&dC zNbS&aqW6?J;_LbDQu{!y_X7swL>=n4^S=1O{Z;=mLMoqh1v$C&?lsF>JTbk9kC{5r&O%jmI6V7nlRr^Fm`g}#g zLII2)>9!6@(LK=d_lKMjM?F+>9;yvkEL=p&UBtc)!I;{yDnQZG$nH^1vlm8(o=vfu z&oM|vOudft7#(6TxTM@WsDSGgU{p>28UP1DtvIwiJ_;eXXb2qVe`!}gQyR0^5a9~M zTV|~8NoQaI7G7Jf2ad=EtY7kl(L~w9Jm<2CCmq!*K0ckV;2DhtLx}=E&^&2>KR+^+ z=2l%~SK4H!+w^IdkL>jg zQ&lN42)Yr1W|q9Snr}@(o3{ejB@!>y?fF>Si#(0C8B8}74H*?DM{uv^QN1`n1Zrm0 z8VgW3QE!+H?NW`#3ri`JK&et5hhDjnnj{^sQ!@(ioXmAjC``yWN zs;t5<-GsYtO2_tP$825>VUkOx7})89G%r1RtI7k)FLGW1-@ILPs!hMOBjMdDW=fER zBZ{XX(&5nsJ-v5?qP^qQgu4<7_O~U}AGS@hb`CC{zYKsOPJgvcDs{?z5*WVoC8!}% zEZX$_a2RIB2vk&g>a!@JQs<)s%r!LtmsZN2r<_!r2e3W_+lB#%oF8m#hyffqci0{EZz9=<^+h^i&pNa`B9+wbX2eu(G3~Uv zGBEVPnT=!kc6Sv&&_$0|dn&vyG`kBTw??qE7Iex*#^E4q|CdqweDsk62l5R6m!Cj-zb8<|VUMHCfyEq?U4HoxvjMljn?iL-E4+ zz+#MNF*1UnOpIOhDBcVWWwL^B=n2y2%M#63eA+xTC;2iPJT#3x{JhTx!)PH2ss~$M z;jkEp#Acsw3(3L6G#EY4f|ED_rMlPo@j)B#nfJ+x*L%kA(oglMueb(9wg+SUn+6F;29~Db={w&aQDmL7O_9NB zq@Rs(=kQ*m-4h;590l)vM|Q|>n^ws`BV3YJ0SbjU{ne!ut15x|ByfD+HYkvp>VKV| z4GupuMn9Wlo&i$fbZC07ltk6^W73u*`zN7%lss6)K9Gy3*FRlV1Grf%cRc6kzP>rU zLRv*xqyUE86l?1d0%^C6#$N;JkHO@lBI5dHz^6)RYGnf7#*O2*#~t`*^vp{sMnaaK zBB0C`%hZDM;@2pZqu-$Ryc18y8!2>Qx1p>;DC?%JTqZN>ZiU-}roh!HoLef*~UcE)9av}xK;a@~D6m<=@* zRY!XC=F-EE_$?`a*fajMg_W(X>!G2AbECqfL|UTi zMo2glWQRDtlv%RF%df+jJeC?%kj(QcHJK-nmaTGxIvjl!jy(_VC3E=nOHG+2v8O%< zvrnG-p3d$cJCC=X)6d73in(lwb06mlTZ}(f@V`DE7lje>JIs@zY~dqO8LU6Fr0yKu zv5w4)sBvI5H|L7Fo<1~lx8ci(d7Y7sVpNoP^8&dTE=6?erc4}H$?f`y>sfkTm4t!- zC1nQPB*Np6Mj<*^I%)Ookph-l3eCjb&F7Z2&o{aP&@0ou2p^h#F~k84DFW*9+e!@c zcoMg{Mmb5ay$-q$uuO0$q)19_5JspDIKZ?cBZrJ7o*b?o`j1iK%Gqc#mX1(^sQ3>Tbe{Uz1Fyy^$EAN;j??}{b^K)4=<;wBLCXhxDFXN@KCk@bs|rp zyIv~;PoXn%dn?0Dx4AgP{OgJ2LyM-Y$sj@>_qA9kw~c7nc82*EJz1S>cM?4b(p}NH(~GgANPFD5;sR zx2!fPM>=G_+Eu=Kg|fq{nrwT6X_=n92LU?k5VnI|NJUu~i@RJ`2*(w6j_$*4-m8EuMwBj|#iTi#rI=y0x2EAFUE7E@H=KHr%%M#Bx}iU5Yov2onfn9L zu3|dex}JKSWr1i$>}aDMt9~AR6gJI);9B&XHlB9D99)z}3hR&?*9t)-)cF@u+Gq4@sg*P?v-Hv-_J$Agzh2rS z91B-w-sU(=EVmkU&u46dUcV`6sgUt#vh{#f-;Aa$cpg3M%2;19S|4Ne?O3g+FWQ2R zrk30R=xt{RwaKlPdzWEr2>v?NL}B_Bs2|sODo`xPO&W*#?L&lw0u68hX-YIeAvm2Y zKo0591F}n5QIt+4+epx;{wCR^iNICeQXQcf1=DyOhUkNoP9Pl-aW5Bgl}k4%a)Y38 zHhhkIcNEsbMnF2ek(0y{EGlvldAyrMF1(w7adT4sR=^YTg9`W{tc9-uzE}(U0l`p8 zbO)VktYd2wdnO;vHFrX>nqG18eunwhIl7DJP0^Y+)RK1|TK3wygA^oKsXaK>)r=v0p}CKNIT8KQwC$z)WRXrRC z?U$F&AmFVzdH2Pozh{^I9X9@V!5er_)sMmA-47uh+%tOkE9qg+Tb(Ba&vV+ZkLS-H z!cds>Ne1S7U)B~4B_%_#Y(uwk zZ@a(8%Z1%UttAkUNSCunRk!sSHwwceUF(V@vJ;O`7`(w}(lkvOp3;ou*fp}q<3y)m zX5^aDJkhQkBAGOKDtqK9MlrI%`!F;ye>n~j8(Bn6C`W{-y`%#j9YkTRH#WXpo(wMa zr|44|X$c2mrQX&(@KNLzJe%x=aFKuF34FX#q_xvUJIgwRH~hN4Gx94|4d+fyX%ywd z$oSIoFftu5V;LLLoUld9O0EZ(aB4-Uh+r+VFJ79@+ZSWvR??60d0U6^4T8{IkFZ^1HaY}t zq1N~eC{>%2GzvAsG$=H}?=}aXl5EoNB?@NGdu*vij5KuFz2$r%F&^z?Q6OS7RqC5G z(`3$ClezeP<=)923?59J-jxP^zwL$ouqpnxll{^Zs}2ME?+Q0w5LbjF-+ZCm>1tk% zSr8>wU|>&hq4WL;&wD)lp^uVXKoJy*Z!qG(sy)Y^dTnXDj`OyP<>jYFu;eChWn(zn z6kRJoYHyjmWaMHb$EHmak8T}hByVo{^Vf!gHqiT5TVua(`&LicbYwfCXWrFr=3U> zw%yMywwkkv#Oo6$W&;ZAiud~7_OglVsfN9pz$Jbu5ni)P`t>_CnV0i9$@hmDrkQf7 zc&sow1Eg}jZL)Sg|Bxd=l+8qF@30a^lcl&SpCsojof4P@6 z{j7Ys?{|L~`0nt3EOPo4{Ab<8y}0Iw>D=A$AAtWism-szKdTDvWgS24$=!qep8)^e z;eWk=pZ9I=#S1^|=q}&?!3F#$DZ{UzKW``gooigwKLY)ag0{bUvtPk~-nF{#Gk(}U z+8=@cwSW05&d+oEzvCcc{t?c9xu2hBiT5k;53|AfBOK|!?+N^RUq6qm?vwEk6DRop z;r-rIf1cm`-D%{B{s{MXQCvg9)=zhidd7=Ni$L>@95zfCC_y3Id^Wyb)kJY64 b|Ka`Wv50r`d>9yY3DKiP9}!W4(OsfO?*tK1 z21AI)z3=~$mvxi>yL;AetvNGmzP;w#-#PnyTMLSbMG3&e!vmDP+E4)e5R?EcfV!fd z9Ji{560f?PhN_aHt{#uN(zjj!U|+qz?>3a1XNVZe%`wnFSfj%?DzLD+w2A@Hg5u&; z2ViW|T|m)XJX-%rQ2JAX>lfeNaeC+mv(a*O@UV1;DLKF#ZQOYO`i#fg(bCQBp_V$d zU6#ymq!U?KeD+@d)vE=$_jue(+PgYrPjZ8dcI#ECXDP0BE1y3L)6v?&Mc+8lMNW>E zhE00yd#p80o_#w;V>}4;BV?67y49;oGsAih%s@v8UoxzNBH*6X86E=jh`yI?%^aGYIY}%Fh&gT?>n!jC)(sk=gzfmEt>|=C$OoG~)@h zuaABdlkyec+spzUQ#Xxtjrn|J<^F7tBm)rU=-F0{S?dzP@WIqJGnwp=!1&v&RmnNw zWgP@|7D&af006Hqo?q92=T~*OsEjVm)xpwHALi=j;OulqRpGCyM92MEmC$*IL?s9u z{wgA?5f6duwti6+@}z8e_3aFsA#NAo-cay)Z{k8L<3cP28=dA-Ysh4ppVt~(re#hB z&|mc>2a>APzytFzFG3WpBqw<3Vd&6*(0{f^nov} z-6lyEErZX%n)88!qV}L}eAmd|G=x0C7OS04O z+$hN}h|c*f*?hku`_GN=3%X-vph#J=j`^9@Smg5~<@>eOWGFISlVTG$W_G!d{bA<> z#iOTm-A>y+hWOO}0GT9F)iPuo_uPP_e}CigsrNa6ue~{z!Lnf(5q}IR5N_**vqsJ+ zWWG*Hrch+&%u{P>c(b=irUb7d*JeWLy1yug*-rAe$YRV=;6&=san`CUXhVUsH-bEi zYpdPl&sPMQL?ij1T{)S+C%4Gpi%L%MJb-ePD#ueN@P+q90rAY*&tf+w>|l6yyXU<1 z*RlGl%lSLg$-@GyKmHLdioxbcu?*mm{N}gqJ+Ty#o?pf!p*@YcjUo>IKuuHa{mLtf z96oUcWIaqWbHBLB`I23c$%8Dw1+$UAWtZVs>|RLu-v>&HgPtA?)O8Nz30~+Mu2-=2 zK-n(|g;-vNz_5^hHz|i_a6k{X`1AM{nv-C44w1=*G=>ftDQl6ig1QN-Dcictk+5bx zbMcp?W3Q{v`y_yK8bb7I$7fkSc5^;n-@c611Z0ZhXOqnrGWW<21lju-*Sna(^KVd+ z-c@dMvNoQ>@X)a|?lz;@#9MunWA8RMbCSFmS|2iMUxr{^QQ|Tf;bu`b!l35oupX*= z#7-p4nKtDwk4`HNuyAOC>w|Yd^6` z|D8xf0UaJzGs&SpH072GxE9ik`nh**bFWi-7g9frl+-1B+mTh=F-tKxie29b7#vd+ zd}ywK@Vf^;N>D%cu-YwrY?`%BHPNb2@ty=nh-$JGIbIS-#f7#z&}aeA(S{2@J7^^^vnXnA4RV%ep$*r}U5hDM1?qLuwr{8?Map7vj-apI z3Zz6+zM@tc8wJOe7n{o38{LR2cF2^iDX^n7Wh^5!z6SXBrH~~Sq z8zg}_>D!c`@(riJ`1Eb62ZEm|KzSSffxhab1lv(g-YVHx%al^gd}bqg7_fAPtEojB z_<^qKngqAUQAx4|g)gxS?Y;FaN(zH9Ms7id_AzRNn%Ma?N0)p-d=?};;4YK@d) zL<*?}!qQ_1N8#S4*Q3CMhBeGXJI@bOP9A(Z)oP;CuZa?RGBc$GSMbVp=(?*Q`cbat z+ZP(G!U6o(9U~8DzvM4{4v-|fH;(9Ne}4G(Q7qF_#Qr3oEE|}jZ`o6EnMhr9R3|0o zXxEZMy7K)O84^O@CpErhWjfp5V@vM55PM0Ic{iG-VYm36Zz1hi!*0ku6Rl{D z+4>?{^Idt@^Gws^VN|+-4;<53d)7a_p`&V3axLWby9M)LmSn>ObJi47#IuArB~6h= zUQIm+QI^pjy^5l5ugDhoC?%aLjoc~SfDkh(F*>2~PE^|6 zHewd@Hmr#lp@Sllvb=(gPX}g)mJ3k3q2|iG0=^i2xr>SGtD(3XiNqDzcWKQOUsyd7 z@+(;!S)b9Bl1`MK-VsB2g_>(t-13!f8s8B=k#7eM0qL5bH23eUqP*Mb)@Q<{=K9T{ zQov(>ffp5FX~L1p{vI*y4-;5(H4=~CmNEW(X51;eMGyN7>vjEb9RP2h9^_SuK~7<8&_+2E_pbm_3{K3?Wcp7@MPel$T& z;q#m*yeUS8eYbwOB5vX%x|BuyS^xs+-zB5IMC0#Th`hq4yClX2UBVV#gEk^{*j!R! z@kmZCC`(K=*E7-1;p;=I=nPgfiQ%)mqOC_~{aI6X!f;xF)Sj(_cEs(kAd`+6VhBTG z`k)2?`}8JkyjQy)E9pVovS^2nhMi;zzqO@pKdf#l_2olJxPV)2wAfVZ>6VSZ$G)yl zT875jDnP*X>HLEvUGV|m=SZ&SmP!M+=zx5{`Q40wcf{!M4~IAvTIWyP(noB)d zlV|02c2o=oot<7bqnz76@C!^+RL6hwT2%jxZb(%}4!gmS{JO}TR1 zJSos8xp%?L#NUQ_eA}k(0&}3DJl`yG^;z!S$<=4u6f_k>@%U}GT#{?;CMGahi4EHj%R>w_`2D0On2Ed$m%J^H?RQ! zIl|xFe-wYyG*q2bot$8T$vV?&7nfBjW4N_dEyC!FXQ@7RFnfeP zB^4G^k=B9VG!Lz+NP;7_3{(!A@f0AV_MA9md?}dNhTqL&t-pWL*Dt^qV*;5Th}FJ` zC{xb$rtyw73D?y`k9EHRuiVa3z1ep4g|c?@?EOxh1fn#bZ{62k^cjE5_2uP=U@F*d zWN&G$T=ba8QR(=ag&MumuAj5KnM@bDqN+s&26^9izX8i3^b;mR3Aj_a%TFETi&lK- zWo}%8ne*AqX1ATuF?fqRJyvbPYS(@Vsg2Yd)nnEHyMk`{K2 zR}sk2roLClKK>NZaHzI+?a=LcA~++L-hz&%+GEQYBujllqYw~m8CHFeb{v$mg{A{% zVCmm(g8p%6q|%S0im_j1Dx1}8xJO+TMJ2`MRr-$fQWa|^X|{P6*N7*Wzf*#ZyBwPN~muZh7m4+c+j>Z$FM1 zYwHrxJY4P?0Jlech+bk)-1<6v7ni8O%9E*pGZf`w00e_h?xUEkb8s<*iHP`7lnBW9 zet{@lxP-Z3WlWZDrKz$rn3Lhyd!Biu!6fumIlqL=rUoZD=T+<|8qnFT$UR7zLVKqu zxafJMs`brBJynbiN%AGt5m?S!2bK}y@55smDDD#qqzdr$@tuaXM0;`ZfjrX*Sc<8e zV#*@cKiP=ui#aL@-GjU~K+krD##mNPM`eF9v3$@#gHi0+97NH+C}Vd-EJ0P%0@_T( zQLac_bv^OMFIX3OuiU6=A9k2tH9r2Lr?Jidwr{nKzzU`#v+}q`WeC$sPKzZ`9i>N) z@ryJ~P>*J_MFY15>+p1v<4XwAF+9IAb%Is2cI|2!tc-$(!U(hZPmfwRJ2iKy0>j^` zfa8Bu!M}ZxcArL@ETt5LFi8ii^s#ft<9KjeTR~?C3z!9|Om>KQyE0!RQCbDf1w<9yhX{ya`=sTt`J%mFg>aDeSKKbDwR%4!!U{B+?PV_#u?2@G@F5;x^=6YKl z$fZMc9K+pVjg}^x<75Oi?=usC&yqL5}kp-a?Z z^+9+L?4Da{O7UP7Jgt+yAhx4Gs)W@Wr$|mQ^LB-nY;Zm8VYpBVwdlJ=`GDG@F3}v* zmo>UZR11IZf=T?J+KQ@)Zn9!1qzck28qNQO1AAuLc`GqFl}^ess{+{|mzM zV)g$`FMdY*(IQ^D?(ea2@h|=s?Ux?>XY3yh(xu7#9{Lvw|6AM@?KV$uP{$BRp@3BGfYpj3NiGNP{<7U4+*uTd)(LYZ4*IxfQ#gAINJT<-t aHtGMC;{R~5aV~$0ck$}J&~*>lQ{0O3bAw9@Qj47P^NLG~N|Q_Si}Zs_lag~1i;EqTlT(X}Q&XHO z!AihlPN`}6MX8=ZL-fG>wUfNP4?74P|DTd#mh*;I2hB_7@fkYs79l-1fNW{{2#!hrbu?yx!~m=+3+yAyHR2 zk`zuBd`VB?FHmg0rv4-3tKKdCtzXtDX)sUTlFhSnEywP|6C&a)(>=mMf@gRnTxe=+ zG?8f2`J#N(AZYqL3!dA&3;in(i}KvuRkWk}+}55)>r;#}Jm*`j`@foN_LaA(QppnL z6Vgw_e3p(Y+gTpEZFil*Eip9%Pv;dA(oSE0oV@bXag%}s_NWivmUU*Hk(!Zs;%`w- zBHw2oH+8R_a%VTjbh8-die|Zoq?$y3%s)F#$!?m*ZWdc^x7jQzx83inXx%h%y*N z_s=hViMG}qMIV_#>7YKbY*#xY1H(}!evLjDy*7zYNlvSZ3h=QZWFYYOSCIirHE-L z&J~=lv#hH%&*$=$7RL*-F0#KmGR1%H>ytgKT?>llMaK$Esb)`RIxMQVIl%4gF(EBe zoyB>F;wJp+Uzya|%Qh=Y&FJl=uU$ndbEG8;pK71XFj|r1YOOU*i(9tDca2cVzl<## z+e(>==LH*HFSC7rz1ZvWWkJ#xi#x+kn!;N>AGx4 zXIJ`9w-2)%`dQw8$?<#td$F=)g zuins#ylY**`McR3@i-3t|5-Po_=onzK(vLZmz*0dcJP|PBAci_C0gj z$6HtLBCofu*10q1HwPJ9F@Es$(NiXd0B?4VP4!Igq=80B0&xJ`f(I?RC>H1fWkZWo zb5e_oJ@b-_Qgc)DN<8y|QcFsU^7KRVic)hDOHxyua}tY-^^!qkZ-B4&VF!WQ+sBsm zzHDFnHTvM>T+!kW5f_~uHCRNmtM6}fzB?&LWw+p;$f|%35BNX0cg}usu!+4qamM$w zd$(`?{83ZQUeIJKZQ0hma8bjQSEoIF6g}@wH(xS2qRLq^_<*TzHDmaxwxa>FKeNAM zjXAex^~X7CvlbR;ExC}+^E0gaNW#}enwBRPKS|9v=NU6VNX;6DGA4pO_P{eNwl`y$eO z?z&gpp3^-omi?I4&z!X4_r(@=Ww~yV{}ZO|6Yg60_J6T?EL*yO>c?8Mkei zd-H9|-QDq^Sh>(}<+?Q^1H&yKM#RePR@7*>z!xi?c_nU{sW~Ya@db&XsS|H|0VAmG ze{S+>)7-6JYna||@#qc}v58$FqU7qB?YQ3Ow(IsK(jGzg9cm@{Il3OS@;`9yoP6V0 zz}AF>wD0qOeomdSr+&{q#)v~DB8qK)HlF3pyFF`7)SiP&7oT)~XQDgv@{(YIJ1hRa za9L=;bLFeIZTgE(Hst{;Kd(A`fTi`Az)gW5i)fyQJAWEAZ%V#a!ISu9b;qLZ{5*xC zwjBm4-Avi-w&4Oo=nT#01X= z#ruav;Zl=;aqi2E9Pc8{sPS$?Al?HKixP8FOHzw)#Qod}(70deyK3vaS2yEcPUVsc z(1_Y_DuirQK&GF~A zts8trj64Lpp4*l0ct3m5yN_z(mqgTKw%H`kaFR3bH{JQ^yA#_EA6Z%$ zvin)7=Y{gz#M4HJ36)QqCfqBRw&`Z%dAh(+y(epK)k~AkiG4a_x_5)7-&zaaGwd6q z-iEE-81*ttyXDQw+n-+T$zr$P_~m)e>w}LI1z)WcsM%$e`EXv~%!NuTSFGKa^ubj& z=!BbEg6QF_^QAmmeJu@vJ+5b~wU#yA(hXcV*CgG!(D&|kIi@tLWh@I4WrP(?<}cWm z9OAg~mThs)mxDe@T8E}gQ7?GO`0U-r_TV>LOMEk7^p|G)~0<-_x*RMY@t*$W)Yj7%a7h+-YNJO&l(r~p?XAK;BJ1ypt; zmmi?A8vzo5Op;1+WTQa^5ONX)6+j5^9q1*TMiVHGkZl1acjO=fC3ggP4-7PXwh&7E U0p6@^Ak$cYun_3ttE?a%0G)U8wg3PC diff --git a/TOOLS/bp/src/test/resources/empty.properties b/TOOLS/bp/src/test/resources/empty.properties deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/TOOLS/bp/src/test/resources/invalid-value-1.properties b/TOOLS/bp/src/test/resources/invalid-value-1.properties deleted file mode 100644 index 0063d56fa5..0000000000 --- a/TOOLS/bp/src/test/resources/invalid-value-1.properties +++ /dev/null @@ -1 +0,0 @@ -Analysis1 diff --git a/TOOLS/bp/src/test/resources/invalid-value-2.properties b/TOOLS/bp/src/test/resources/invalid-value-2.properties deleted file mode 100644 index d0448646c4..0000000000 --- a/TOOLS/bp/src/test/resources/invalid-value-2.properties +++ /dev/null @@ -1 +0,0 @@ -Analysis1=1 diff --git a/TOOLS/bp/src/test/resources/not-a-property-file.gif b/TOOLS/bp/src/test/resources/not-a-property-file.gif deleted file mode 100644 index 65c117ac7913dc62159a542c1d317b8de21de308..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 600 zcmZ?wbhEHb6krfwI2OfVz+_~~WMKwG%obM6Hnz<6cFc}0%%n{+t z(NQe1F)RsjEJ=whsmUzq$t)QuEE%aRnQ1JUB`lStER|)fRh6uDHLMLatc?w~?^Ke&he@L~2-N7>IF=Qw|g{o+}Us~0$K+~#=n zh~xDG&KHk4UO(Y@^MvE=Gmdx9Io?0#eE*X3<4ev@Z#cic<^1*zguZ{^{PBVF=SR+8 zpE!Si=KS-8^Y1s#f8RL&f9L%Flk@*S&j0^`i0eQ7f#N?w=c3falGGH1^30M91$R&1 z00zaMER0+X^$a=;Kmdv;2KEIF^-WD7t!>R6^=;kl9X(%=ym`6sasYI%a>dQo$NqGCqDq7fSi(7GM88L})S%&&c zvkU1MvN4K9Y6{xOOZxgMm_>xEsRlDRXiG=h@;TKjnS_RFD2Evf>#pb2V9~4$I>9Nd e71U?J=*rTy#Iu*fQD=&W;L mutableData = new java.util.ArrayList(); - - @Override - public Object clone() throws CloneNotSupportedException { - // Call super.clone() and down-cast result - CorrectlyImplementedClone copy = (CorrectlyImplementedClone) super.clone(); - - // Duplicate fields of this class as needed - copy.mutableData = new java.util.ArrayList(); - - return copy; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/SomeClassWithoutClone.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/SomeClassWithoutClone.java deleted file mode 100644 index a442306034..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CloneDoesNotCallSuperClone/SomeClassWithoutClone.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CloneDoesNotCallSuperClone; - -/** - * Some class without clone() method shouldn't be an issue for the analysis. - * - * @author Daniel Klauer - */ -public class SomeClassWithoutClone { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneAndCloneable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneAndCloneable.java deleted file mode 100644 index 2c178a9770..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneAndCloneable.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CnImplementsCloneButNotCloneable; - -/** - * A class that implements clone() and Cloneable. Implementing Cloneable isn't enforced by - * the compiler, but it's required by the Object.clone() contract. - * - * @author Daniel Klauer - */ -public class ImplementsCloneAndCloneable implements Cloneable { - - @Override - public Object clone() { - return new ImplementsCloneAndCloneable(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneButNotCloneable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneButNotCloneable.java deleted file mode 100644 index 35e6503dbe..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/ImplementsCloneButNotCloneable.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CnImplementsCloneButNotCloneable; - -/** - * A class that has a clone() method but does not implement Cloneable. This violates the - * Object.clone() contract. - * - * @author Daniel Klauer - */ -public class ImplementsCloneButNotCloneable { - - @Override - public Object clone() { - return new ImplementsCloneButNotCloneable(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/SomeClassWithoutClone.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/SomeClassWithoutClone.java deleted file mode 100644 index 04329970f1..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CnImplementsCloneButNotCloneable/SomeClassWithoutClone.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CnImplementsCloneButNotCloneable; - -/** - * Some class without clone() method shouldn't be an issue for the analysis. - * - * @author Daniel Klauer - */ -public class SomeClassWithoutClone { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithCovariantCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithCovariantCompareTo.java deleted file mode 100644 index d7de5394e3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithCovariantCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * A Comparable abstract class that does not implement the proper compareTo(Object) - * method, but rather a covariant one. - * - * This is bad practice: There should be a proper compareTo() which subclasses can - * override, rather than an incorrect one which may end up unused in practice: Subclasses - * are forced to implement the proper compareTo() by the compiler, but then they will - * override Comparable's compareTo(), instead of that of this abstract class. - * - * @author Daniel Klauer - */ -@SuppressWarnings("rawtypes") -public abstract class AbstractComparableWithCovariantCompareTo implements Comparable { - - // Does not override Comparable.compareTo(Object) - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithMultipleCompareTo.java deleted file mode 100644 index 70746b8f70..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CovariantCompareTo; - -/** - * Abstract Comparable with multiple compareTo() methods, one of which is the correct one. - * Since the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -@SuppressWarnings("rawtypes") -public abstract class AbstractComparableWithMultipleCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(Object) - @Override - public int compareTo(Object o) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithProperCompareTo.java deleted file mode 100644 index 7fd0bda122..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractComparableWithProperCompareTo.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CovariantCompareTo; - -/** - * Comparable abstract class with proper compareTo() method: should not be reported. - * - * @author Daniel Klauer - */ -@SuppressWarnings("rawtypes") -public abstract class AbstractComparableWithProperCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(Object) - @Override - public int compareTo(Object o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithCovariantCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithCovariantCompareTo.java deleted file mode 100644 index 3d0c46c1f5..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithCovariantCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * A generic Comparable abstract class that does not implement the proper compareTo(T) - * method, but rather a covariant one. - * - * This is bad practice: There should be a proper compareTo() which subclasses can - * override, rather than an incorrect one which may end up unused in practice: Subclasses - * are forced to implement the proper compareTo() by the compiler, but then they will - * override Comparable's compareTo(), instead of that of this abstract class. - * - * @author Daniel Klauer - */ -public abstract class AbstractGenericComparableWithCovariantCompareTo implements - Comparable { - - // Does not override Comparable.compareTo(T) - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithMultipleCompareTo.java deleted file mode 100644 index 919ef6e87a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,24 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Abstract Comparable with multiple compareTo() methods, one of which is the correct one. - * Since the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -public abstract class AbstractGenericComparableWithMultipleCompareTo implements - Comparable { - - // Properly overrides Comparable.compareTo(T) - @Override - public int compareTo(T o) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithProperCompareTo.java deleted file mode 100644 index 3c2e57e9f0..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractGenericComparableWithProperCompareTo.java +++ /dev/null @@ -1,19 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Generic Comparable abstract class with proper compareTo() method: should not be - * reported. - * - * @author Daniel Klauer - */ -public abstract class AbstractGenericComparableWithProperCompareTo implements - Comparable { - - // Properly overrides Comparable.compareTo(T) - @Override - public int compareTo(T o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithCovariantCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithCovariantCompareTo.java deleted file mode 100644 index aa24a10138..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithCovariantCompareTo.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CovariantCompareTo; - -/** - * An abstract class Comparable to itself, without implementing the proper compareTo() - * method. This is bad practice because now the derived classes must implement it. It - * would be better to have the implementation residing in this class, instead of spread - * out in one or multiple subclasses. - * - * Since there is a covariant compareTo() implemented here, we can assume the author did - * not want to run into the problem mentioned above. - * - * @author Daniel Klauer - */ -public abstract class AbstractSelfComparableWithCovariantCompareTo implements - Comparable { - - // Does not override compareTo(AbstractSelfCovariant) - public int compareTo(String v) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithMultipleCompareTo.java deleted file mode 100644 index afb88b9605..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Abstract self-Comparable with multiple compareTo() methods, one of which is the correct - * one. Since the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -public abstract class AbstractSelfComparableWithMultipleCompareTo implements - Comparable { - - @Override - public int compareTo(AbstractSelfComparableWithMultipleCompareTo v) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithProperCompareTo.java deleted file mode 100644 index 084e2f107f..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/AbstractSelfComparableWithProperCompareTo.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Self-Comparable abstract class with proper compareTo() method: should not be reported. - * - * @author Daniel Klauer - */ -public abstract class AbstractSelfComparableWithProperCompareTo implements - Comparable { - - @Override - public int compareTo(AbstractSelfComparableWithProperCompareTo v) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithMultipleCompareTo.java deleted file mode 100644 index 3a6437ab2f..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,24 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Comparable with multiple compareTo() methods, one of which is the correct one. Since - * the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -@SuppressWarnings("rawtypes") -public class ComparableWithMultipleCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(Object) - @Override - public int compareTo(Object o) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithProperCompareTo.java deleted file mode 100644 index 8bd36386ff..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ComparableWithProperCompareTo.java +++ /dev/null @@ -1,18 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Comparable class with proper compareTo() method: should not be reported. - * - * @author Daniel Klauer - */ -@SuppressWarnings("rawtypes") -public class ComparableWithProperCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(Object) - @Override - public int compareTo(Object o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableAndOverrides.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableAndOverrides.java deleted file mode 100644 index e663b76e96..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableAndOverrides.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * This is a subclass of a proper Comparable class, and it properly overrides the parent's - * compareTo(). This should not be reported. - * - * @author Daniel Klauer - */ -public class ExtendsProperComparableAndOverrides extends ComparableWithProperCompareTo { - - @Override - public int compareTo(Object other) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithCovariantCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithCovariantCompareTo.java deleted file mode 100644 index 861622b997..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithCovariantCompareTo.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package CovariantCompareTo; - -/** - * This is a subclass of a proper Comparable class, but does not override the parent - * class' compareTo(). Instead there is a suspicious covariant compareTo() method. This - * case should be reported, because we can assume that the programmer intended to override - * the parent's compareTo() but just used the wrong parameter types accidentally. - * - * @author Daniel Klauer - */ -public class ExtendsProperComparableWithCovariantCompareTo extends - ComparableWithProperCompareTo { - - // Does not implement Comparable.compareTo(Object), - // but this could be intentional, so no report. - int compareTo(String other) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithoutOverriding.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithoutOverriding.java deleted file mode 100644 index 3404053a66..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/ExtendsProperComparableWithoutOverriding.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * This is a subclass of a proper Comparable class, but does not override the parent's - * compareTo(). We do not generate a report for this case because there are no suspicious - * covariant compareTo() methods. - * - * @author Daniel Klauer - */ -public class ExtendsProperComparableWithoutOverriding extends - ComparableWithProperCompareTo { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithMultipleCompareTo.java deleted file mode 100644 index e2f773b619..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Generic Comparable class with multiple compareTo() methods, one of which is the correct - * one. Since the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -public class GenericComparableWithMultipleCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(T) - @Override - public int compareTo(T o) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithProperCompareTo.java deleted file mode 100644 index 45dea32f91..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/GenericComparableWithProperCompareTo.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Generic Comparable class with proper compareTo() method: should not be reported. - * - * @author Daniel Klauer - */ -public class GenericComparableWithProperCompareTo implements Comparable { - - // Properly overrides Comparable.compareTo(T) - @Override - public int compareTo(T o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithMultipleCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithMultipleCompareTo.java deleted file mode 100644 index bf4b500e68..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithMultipleCompareTo.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Self-Comparable with multiple compareTo() methods, one of which is the correct one. - * Since the correct compareTo() is not missing, we should not generate a report. - * - * @author Daniel Klauer - */ -public class SelfComparableWithMultipleCompareTo implements - Comparable { - - @Override - public int compareTo(SelfComparableWithMultipleCompareTo v) { - return 1; - } - - // This 2nd compareTo() should not cause a report - public int compareTo(String o) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithProperCompareTo.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithProperCompareTo.java deleted file mode 100644 index 49af247df8..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantCompareTo/SelfComparableWithProperCompareTo.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantCompareTo; - -/** - * Self-Comparable class with proper compareTo() method: should not be reported. - * - * @author Daniel Klauer - */ -public class SelfComparableWithProperCompareTo implements - Comparable { - - @Override - public int compareTo(SelfComparableWithProperCompareTo v) { - return 1; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenAndCovariantEqualsMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenAndCovariantEqualsMethod.java deleted file mode 100644 index 193afdd072..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenAndCovariantEqualsMethod.java +++ /dev/null @@ -1,21 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantEquals; - -/** - * A class with a proper `equals(Object)`, and also a covariant one. Since there's a - * correct `equals()`, we do not report the covariant one. - * - * @author Daniel Klauer - */ -public class CorrectlyOverriddenAndCovariantEqualsMethod { - - @Override - public boolean equals(Object other) { - return true; - } - - public boolean equals(String other) { - return true; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenEqualsMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenEqualsMethod.java deleted file mode 100644 index cdf74a8122..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CorrectlyOverriddenEqualsMethod.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantEquals; - -/** - * A class with a properly overridden `equals(Object)` and no other. This should not be - * reported. - * - * @author Daniel Klauer - */ -public class CorrectlyOverriddenEqualsMethod { - - @Override - public boolean equals(Object other) { - return true; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CovariantEqualsMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CovariantEqualsMethod.java deleted file mode 100644 index 6bbc171114..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/CovariantEqualsMethod.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantEquals; - -/** - * A class without proper `equals(Object)` but instead a covariant one. This should be - * reported. - * - * @author Daniel Klauer - */ -public class CovariantEqualsMethod { - - public boolean equals(String other) { - return true; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/NoEqualsMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/NoEqualsMethod.java deleted file mode 100644 index 5e63566d8f..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/CovariantEquals/NoEqualsMethod.java +++ /dev/null @@ -1,12 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package CovariantEquals; - -/** - * A class without any `equals()` method. This should neiter be reported nor cause trouble - * for the analysis. - * - * @author Daniel Klauer - */ -public class NoEqualsMethod { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/CallsRunFinalizersOnExit.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/CallsRunFinalizersOnExit.java deleted file mode 100644 index e144595d75..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/CallsRunFinalizersOnExit.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DmRunFinalizersOnExit; - -/** - * Invokes System.runFinalizersOnExit, an extremely dangerous method. - * - * @author Roberts Kolosovs - */ -public class CallsRunFinalizersOnExit { - - @SuppressWarnings("deprecation") - public void doStuff() { - System.runFinalizersOnExit(true); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/SomeUnrelatedClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/SomeUnrelatedClass.java deleted file mode 100644 index 72eda1efc0..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DmRunFinalizersOnExit/SomeUnrelatedClass.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DmRunFinalizersOnExit; - -/** - * Some class that does not call System.runFinalizersOnExit() and shouldn't be an issue - * for the analysis. - * - * @author Daniel Klauer - */ -public class SomeUnrelatedClass { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleInsideDoPrivileged.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleInsideDoPrivileged.java deleted file mode 100644 index a9f36708a7..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleInsideDoPrivileged.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DoInsideDoPrivileged; - -import java.security.AccessController; -import java.security.PrivilegedAction; - -/** - * Invokes setAccessible inside of doPrivileged. - * - * @author Florian Brandherm - */ -public class CallsSetAccessibleInsideDoPrivileged { - - ClassWithAField t = new ClassWithAField(); - - public void method() { - AccessController.doPrivileged(new PrivilegedAction() { - - public Void run() { - java.lang.reflect.Field[] fs = t.getClass().getDeclaredFields(); - for (java.lang.reflect.Field f : fs) { - f.setAccessible(true); - } - return null; - } - }); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleOutsideDoPrivileged.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleOutsideDoPrivileged.java deleted file mode 100644 index a7a5dd062a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/CallsSetAccessibleOutsideDoPrivileged.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DoInsideDoPrivileged; - -/** - * Invokes setAccessible outside of doPriviledged. - * - * @author Roberts Kolosovs - * @author Daniel Klauer - */ -public class CallsSetAccessibleOutsideDoPrivileged { - - ClassWithAField t = new ClassWithAField(); - - public void method() { - java.lang.reflect.Field[] fs = t.getClass().getDeclaredFields(); - for (java.lang.reflect.Field f : fs) { - f.setAccessible(true); - } - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/ClassWithAField.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/ClassWithAField.java deleted file mode 100644 index 3e944c0f25..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/ClassWithAField.java +++ /dev/null @@ -1,13 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DoInsideDoPrivileged; - -/** - * Some class with a field for CallsSetAccessibleOutsideDoPrivileged to call - * setAccessible() on. - * - * @author Daniel Klauer - */ -public class ClassWithAField { - - public int field; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/UnrelatedClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/UnrelatedClass.java deleted file mode 100644 index 091855b143..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/DoInsideDoPrivileged/UnrelatedClass.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package DoInsideDoPrivileged; - -/** - * A class without setAccessible() calls. It should not be reported. - * - * @author Daniel Klauer - */ -public class UnrelatedClass { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/ClassWithNeitherEqualsNorHashCode.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/ClassWithNeitherEqualsNorHashCode.java deleted file mode 100644 index b02c896841..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/ClassWithNeitherEqualsNorHashCode.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package EqualsHashCodeContract; - -/** - * A class with neither equals() nor hashCode(). It should not be reported. - * - * @author Daniel Klauer - */ -public class ClassWithNeitherEqualsNorHashCode { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/EqualsWithoutHashCode.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/EqualsWithoutHashCode.java deleted file mode 100644 index 13c6482de4..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/EqualsWithoutHashCode.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package EqualsHashCodeContract; - -/** - * Class with an equals() method but no hashCode() method. This breaks the equals/hashCode - * contract. - * - * @author Daniel Klauer - */ -public class EqualsWithoutHashCode { - - @Override - public boolean equals(Object other) { - return false; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/HashCodeWithoutEquals.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/HashCodeWithoutEquals.java deleted file mode 100644 index f8fbd64c01..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/EqualsHashCodeContract/HashCodeWithoutEquals.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package EqualsHashCodeContract; - -/** - * Class with a hashCode() method but no equals() method. This breaks the equals/hashCode - * contract. - * - * @author Daniel Klauer - */ -public class HashCodeWithoutEquals { - - @Override - public int hashCode() { - return 0; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/CustomAnnotatedWithTrivialMutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/CustomAnnotatedWithTrivialMutable.java deleted file mode 100644 index 2ecc32a87a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/CustomAnnotatedWithTrivialMutable.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import OwnAnnotations.Immutable; - -/** - * Some class annotated with a custom Immutable annotation and a trivial mutable field. - * This should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class CustomAnnotatedWithTrivialMutable { - - public int whatever; // trivial mutable -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithCyclicFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithCyclicFields.java deleted file mode 100644 index 47b997ab9b..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithCyclicFields.java +++ /dev/null @@ -1,21 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * This immutable class has classes with cyclic dependences as fields. This can cause the - * analysis to execute an infinite recursion and crash with a stack overflow error. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithCyclicFields { - - // The field classes contain each other as fields. - // This cycle can crash the analysis if not handled properly. - @SuppressWarnings("unused") - private MutableClassWithCyclicFieldsA foo = new MutableClassWithCyclicFieldsA(); - @SuppressWarnings("unused") - private MutableClassWithCyclicFieldsB bar = new MutableClassWithCyclicFieldsB(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDefensiveCopyOfUnknownClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDefensiveCopyOfUnknownClass.java deleted file mode 100644 index 3892fbb67c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDefensiveCopyOfUnknownClass.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Class defensively copying a class with fields of a type unknown to the analysis. As the - * analysis does not have enough information for an evaluation the unknown class is - * considered to be mutable and the defensive copy to be too shallow. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithDefensiveCopyOfUnknownClass { - - @SuppressWarnings("unused") - private MutableClassWithUnknownField foo; - - public JCIPAnnotatedWithDefensiveCopyOfUnknownClass(MutableClassWithUnknownField arg0) { - foo = new MutableClassWithUnknownField(arg0.foo); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDirectPublicSetter.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDirectPublicSetter.java deleted file mode 100644 index 97fcf061d3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithDirectPublicSetter.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and an direct public setter for a - * private variable. This should get reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithDirectPublicSetter { - - @SuppressWarnings("unused") - private int x; - - // This method violates the immutability of the class. - public void setX(int y) { - x = y; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithIndirectPublicSetter.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithIndirectPublicSetter.java deleted file mode 100644 index ebffa9592c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithIndirectPublicSetter.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and an indirect public setter. This - * should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithIndirectPublicSetter { - - @SuppressWarnings("unused") - private int x; - - private void setX(int y) { - x = y; - } - - // Public method that indirectly sets x. - public void indirect(int a, int b) { - // With this x really isn't that immutable any more. - setX(a + b); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalArray.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalArray.java deleted file mode 100644 index 3966e04df1..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalArray.java +++ /dev/null @@ -1,18 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some Class annotated with Immutable and a public final array. This should get reported, - * as Arrays are always mutable. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithMutablePublicFinalArray { - - // The ELements of the Array can still be changed, even if the Array is final. - public final int[] foo = { 1, 2, 3 }; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalField.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalField.java deleted file mode 100644 index ff56e0fc04..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithMutablePublicFinalField.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some Class annotated with Immutable and a mutable public final field. This should get - * reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithMutablePublicFinalField { - - // Field is a reference to a mutable type. final isn't enough to ensure immutability. - public final NotImmutableWithPublicFields mutable = new NotImmutableWithPublicFields(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTooShallowDefensiveCopy.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTooShallowDefensiveCopy.java deleted file mode 100644 index 3b3e1293a9..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTooShallowDefensiveCopy.java +++ /dev/null @@ -1,37 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and a defensive copy that is not - * deep enough. This should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithTooShallowDefensiveCopy { - - private final NotImmutableWithPublicFields foo = new NotImmutableWithPublicFields(1, - new int[] { 1, 2, 3 }); - private NotImmutableWithPublicFields[] bar = { - new NotImmutableWithPublicFields(1, new int[] { 1, 2, 3 }), - new NotImmutableWithPublicFields(2, new int[] { 1, 2, 3 }) }; - - public NotImmutableWithPublicFields getFoo() { - // No defensive copy for foo.foo, which it should have. - NotImmutableWithPublicFields v = new NotImmutableWithPublicFields(foo.x, foo.foo); - return v; - } - - public NotImmutableWithPublicFields[] getBar() { - NotImmutableWithPublicFields[] result = new NotImmutableWithPublicFields[bar.length]; - // The elements of the array are mutable. They should be defensively copied - // instead of being passed right through. - for (int i = 0; i < bar.length; i++) { - result[i] = bar[i]; - } - return result; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTrivialMutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTrivialMutable.java deleted file mode 100644 index 3d2c7b8518..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithTrivialMutable.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and a trivial mutable. This should - * get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithTrivialMutable { - - public int whatever; // trivial mutable -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopy.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopy.java deleted file mode 100644 index 77fea69504..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopy.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and without a defensive copy during - * output. This should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithoutDefensiveCopy { - - private final int[] foo = { 4, 2 }; - - // Here a defensive copy should be made. - public int[] getFoo() { - return foo; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopyAtInput.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopyAtInput.java deleted file mode 100644 index d99c1aa67b..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPAnnotatedWithoutDefensiveCopyAtInput.java +++ /dev/null @@ -1,26 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation and without a defensive copy during - * input. This should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPAnnotatedWithoutDefensiveCopyAtInput { - - // Final applies only to the array, and not to its elements. - @SuppressWarnings("unused") - private final int[] foo; - - // Here a defensive copy should be made, since the source of arg0 still has a - // reference to the array and can change its elements. - public JCIPAnnotatedWithoutDefensiveCopyAtInput(int[] args) { - // This is an error. - foo = args; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectlyImplementedImmutableClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectlyImplementedImmutableClass.java deleted file mode 100644 index c1bb1a6b22..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectlyImplementedImmutableClass.java +++ /dev/null @@ -1,95 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Some class annotated with JCIP Immutable annotation. Everything is implemented - * correctly. This should not be reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPCorrectlyImplementedImmutableClass { - - public final int foo = 0; - private NotImmutableWithPublicFields bar; - private String bum; - private int[] baz = { 1, 3, 3, 7 }; - private String[] werWohntHier = { "Das ", "ist ", "das ", "Haus ", "vom ", "Nikolaus" }; - - // Constructor calls the private setters. - public JCIPCorrectlyImplementedImmutableClass(NotImmutableWithPublicFields arg0, - int[] arg1, String arg2) { - setBum(arg2); - setBar(arg0); - setBaz(arg1); - setBazWithClone(arg1); - } - - // Setter for bar, only used by the constructor. No defensive copy needed, as strings - // are immutable. - private void setBum(String arg0) { - bum = arg0; - } - - // Getter for Bum. No defensive copy needed, as strings are immutable. - public String getBum() { - return bum; - } - - // Private setter for Bar with deep defensive copy by cloning. - private void setBar(NotImmutableWithPublicFields arg0) { - bar = new NotImmutableWithPublicFields(arg0.x, arg0.foo.clone()); - } - - // Public getter for bar, with deep defensive copy by cloning. - public NotImmutableWithPublicFields getBar() { - int[] arr = new int[bar.foo.length]; - for (int i = 0; i < arr.length; i++) { - arr[i] = bar.foo[i]; - } - NotImmutableWithPublicFields temp = new NotImmutableWithPublicFields(bar.x, arr); - return temp; - } - - // Setter for baz, only used by the constructor. Implemented with defensive copy. - private void setBaz(int[] arg0) { - int[] blub = new int[arg0.length]; - for (int i = 0; i < arg0.length; i++) { - blub[i] = arg0[i]; - } - baz = blub; - } - - // Setter for baz, with defensive copy by cloning. - private void setBazWithClone(int[] arg0) { - baz = arg0.clone(); - } - - // Public getter for WerWohntHier, with defensive copy by cloning. - public String[] getWerWohntHier() { - String[] out = werWohntHier.clone(); - return out; - } - - // Public getter for baz, implemented with defensive copy. - public int[] getBaz() { - int[] v = new int[baz.length]; - for (int i = 0; i < baz.length; i++) { - v[i] = baz[i]; - } - return v; - } - - // No member of the class is returned. No defensive copy is needed. - public NotImmutableWithPublicFields getParity() { - int[] retArray = { 1, 2 }; - if (bar.x % 2 == 0) { - return new NotImmutableWithPublicFields(1, retArray); - } else { - return new NotImmutableWithPublicFields(0, retArray); - } - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectyImplementationWithFactoryMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectyImplementationWithFactoryMethod.java deleted file mode 100644 index b44180a62e..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JCIPCorrectyImplementationWithFactoryMethod.java +++ /dev/null @@ -1,37 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Implements immutable class correctly with private constructors, and a factory method. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JCIPCorrectyImplementationWithFactoryMethod { - - private String foo; - - private JCIPCorrectyImplementationWithFactoryMethod() { - // Implemented to override the default construcor, so that this class cann now - // only be build with the factory method. - } - - private JCIPCorrectyImplementationWithFactoryMethod(String arg0) { - foo = arg0; - } - - public String getFoo() { - return foo; - } - - // This is the factory method to call the private construcor. - // The only way to get an instance of this class. - public static JCIPCorrectyImplementationWithFactoryMethod makeJCIPCorrectyImplementationWithFactoryMethod( - String arg0) { - return new JCIPCorrectyImplementationWithFactoryMethod(arg0); - } - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JSR305AnnotatedWithTrivialMutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JSR305AnnotatedWithTrivialMutable.java deleted file mode 100644 index af578eba5c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/JSR305AnnotatedWithTrivialMutable.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import javax.annotation.concurrent.Immutable; - -/** - * Some class annotated with JSR305 and a trivial mutable field. This should get reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Immutable -public class JSR305AnnotatedWithTrivialMutable { - - public int whatever; // trivial mutable -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsA.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsA.java deleted file mode 100644 index 480f4a365a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsA.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -/** - * First mutable class used to form a cyclic dependence. - * - * @author Roberts Kolosovs - */ -public class MutableClassWithCyclicFieldsA { - - // MutableClassWithCyclicFieldsB contains this class as field. - @SuppressWarnings("unused") - private MutableClassWithCyclicFieldsB bar = new MutableClassWithCyclicFieldsB(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsB.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsB.java deleted file mode 100644 index bd4b682d0a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithCyclicFieldsB.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -/** - * Second mutable class used to form a cyclic dependence. - * - * @author Roberts Kolosovs - */ -public class MutableClassWithCyclicFieldsB { - - // MutableClassWithCyclicFieldsA contains this class as field. - @SuppressWarnings("unused") - private MutableClassWithCyclicFieldsA foo = new MutableClassWithCyclicFieldsA(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithUnknownField.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithUnknownField.java deleted file mode 100644 index 2ee825bf1f..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/MutableClassWithUnknownField.java +++ /dev/null @@ -1,19 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -import FinalizeUseless.ClassWithoutExplicitFinalize; - -/** - * Class for testing handling of classes with missing class file in immutability analysis. - * - * @author Roberts Kolosovs - */ -public class MutableClassWithUnknownField { - - // The .jar containing this class is not loaded during testing. - public final ClassWithoutExplicitFinalize foo; - - public MutableClassWithUnknownField(ClassWithoutExplicitFinalize arg0) { - foo = arg0; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/NotImmutableWithPublicFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/NotImmutableWithPublicFields.java deleted file mode 100644 index cc41d15abc..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldIsntImmutableInImmutableClass/NotImmutableWithPublicFields.java +++ /dev/null @@ -1,26 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldIsntImmutableInImmutableClass; - -/** - * Some class with public Fields, but without an immutable annotation. This should not be - * reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -public class NotImmutableWithPublicFields { - - public int x; - public int[] foo; - - public NotImmutableWithPublicFields(int arg0, int[] arg1) { - x = arg0; - foo = arg1; - } - - public NotImmutableWithPublicFields() { - x = 5; - int[] temp = { 1, 2, 3, 4 }; - foo = temp; - }; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/SomeClassWithoutFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/SomeClassWithoutFields.java deleted file mode 100644 index e5d36f7ec5..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/SomeClassWithoutFields.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldShouldBeFinal; - -/** - * Some class without fields shouldn't be an issue for the analysis. - * - * @author Daniel Klauer - */ -public class SomeClassWithoutFields { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/VariousFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/VariousFields.java deleted file mode 100644 index 4630c4a067..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBeFinal/VariousFields.java +++ /dev/null @@ -1,39 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldShouldBeFinal; - -import java.util.Hashtable; - -/** - * @author Daniel Klauer - */ -public class VariousFields { - - /** - * These fields are final already, and they are just int/String, so they are - * definitely immutable, and should not be reported. - */ - public static final int int1 = 123; - public static final String s1 = "abc"; - - /** - * Both fields are non-final, and could be modified. They should be reported. - */ - public static int int2 = 123; - public static String s2 = "abc"; - - /** - * These fields are mutable despite being final, because they are not primitives. Only - * the reference is final, not the array content, etc. The analysis does not report - * these though. - */ - public static final int[] array1 = new int[10]; - public static final Hashtable hashtb1 = new Hashtable(); - - /** - * These fields are non-final, but should not be reported because they are not - * primitives. The analysis explicitly ignores arrays and hashtables to avoid - * detecting too many false-positives. - */ - public static int[] array2 = new int[10]; - public static Hashtable hashtb2 = new Hashtable(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/SomeClassWithoutFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/SomeClassWithoutFields.java deleted file mode 100644 index 353b952bd3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/SomeClassWithoutFields.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldShouldBePackageProtected; - -/** - * Some class without fields shouldn't be an issue for the analysis. - * - * @author Daniel Klauer - */ -public class SomeClassWithoutFields { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/VariousFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/VariousFields.java deleted file mode 100644 index d021a24df4..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FieldShouldBePackageProtected/VariousFields.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FieldShouldBePackageProtected; - -import java.util.Hashtable; - -/** - * @author Daniel Klauer - */ -public class VariousFields { - - /** - * Both fields already are package-protected, no report. - */ - static final int[] array1 = new int[10]; - static final Hashtable hashtb1 = new Hashtable(); - - /** - * Both fields are public, so they should be reported. - */ - public static final int[] array2 = new int[10]; - public static final Hashtable hashtb2 = new Hashtable(); - - /** - * Both fields have primitive types that the analysis does not check, so no report. - */ - public static int int1 = 123; - public static String s1 = "abc"; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/ClassWithoutExplicitFinalize.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/ClassWithoutExplicitFinalize.java deleted file mode 100644 index f1c661e558..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/ClassWithoutExplicitFinalize.java +++ /dev/null @@ -1,18 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FinalizeUseless; - -/** - * A class without explicit `finalize()` method. This should not be reported. - * - * @author Roberts Kolosovs - */ -public class ClassWithoutExplicitFinalize { - - private String s1 = "You may not see it but it is here."; - private String s2 = "The finalize. It can't be avoided."; - - public void foo() { - System.out.println(s1); - System.out.println(s2); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UsefulFinalize.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UsefulFinalize.java deleted file mode 100644 index 072b7cdba3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UsefulFinalize.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FinalizeUseless; - -/** - * A class with a `finalize()` that does more than just call `super.finalize()`. This - * should not be reported. - * - * @author Roberts Kolosovs - */ -public class UsefulFinalize { - - @Override - protected void finalize() throws Throwable { - System.out.println("So I will be running finalize now."); - System.out.println("Just so you are informed."); - System.out.println("Ok, finalize is about to run."); - System.out.println("I don't want to die..."); - super.finalize(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UselessFinalize.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UselessFinalize.java deleted file mode 100644 index 75f163ac07..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/FinalizeUseless/UselessFinalize.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package FinalizeUseless; - -/** - * A class with a useless finalize() method. Since it just calls super.finalize(), it may - * aswell have been omitted, which would have caused super.finalize() to be called - * directly. - * - * @author Daniel Klauer - */ -public class UselessFinalize { - - @Override - protected void finalize() throws Throwable { - super.finalize(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedImmutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedImmutable.java deleted file mode 100644 index cf05a0aace..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedImmutable.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImmutableClassInheritsMutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Immutable class. Should not be reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedImmutable { - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritingFromMutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritingFromMutable.java deleted file mode 100644 index b7d2101328..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritingFromMutable.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImmutableClassInheritsMutableClass; - -import ImmutableClassInheritsMutableClass.MutableClass; -import net.jcip.annotations.Immutable; - -/** - * In and off itself immutable class inherits from a mutable class. Thus it should be - * reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedInheritingFromMutable extends MutableClass { - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritsFromDirectImmutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritsFromDirectImmutable.java deleted file mode 100644 index e7dbeef634..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedInheritsFromDirectImmutable.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImmutableClassInheritsMutableClass; - -import net.jcip.annotations.Immutable; - -/** - * Immutable class inheriting from an immutable class. Should not be reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedInheritsFromDirectImmutable extends JCIPAnnotatedImmutable { - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedWithoutInheritance.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedWithoutInheritance.java deleted file mode 100644 index 9e96e45bb5..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/JCIPAnnotatedWithoutInheritance.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImmutableClassInheritsMutableClass; - -import ImmutableClassInheritsMutableClass.JCIPAnnotatedInheritingFromMutable; -import net.jcip.annotations.Immutable; - -/** - * Immutable class inherits from another immutable class. Should not be reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithoutInheritance extends JCIPAnnotatedInheritingFromMutable { - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/MutableClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/MutableClass.java deleted file mode 100644 index 811dba2635..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImmutableClassInheritsMutableClass/MutableClass.java +++ /dev/null @@ -1,26 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImmutableClassInheritsMutableClass; - -/** - * Some class with public Fields, but without an immutable annotation. This should not be - * reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -public class MutableClass { - - public int x; - public int[] foo; - - public MutableClass(int arg0, int[] arg1) { - x = arg0; - foo = arg1; - } - - public MutableClass() { - x = 5; - int[] temp = { 1, 2, 3, 4 }; - foo = temp; - }; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneAndCloneable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneAndCloneable.java deleted file mode 100644 index 4a1c09ddd3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneAndCloneable.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImplementsCloneableButNotClone; - -/** - * A class that implements Cloneable and overrides the clone() method. - * - * @author Daniel Klauer - */ -public class ImplementsCloneAndCloneable implements Cloneable { - - @Override - public Object clone() { - return new ImplementsCloneAndCloneable(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneableButNotClone.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneableButNotClone.java deleted file mode 100644 index 12202d9401..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/ImplementsCloneableButNotClone.java +++ /dev/null @@ -1,10 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImplementsCloneableButNotClone; - -/** - * A class that implements Cloneable but does not override the clone() method. - * - * @author Daniel Klauer - */ -public class ImplementsCloneableButNotClone implements Cloneable { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/SomeClassWithoutClone.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/SomeClassWithoutClone.java deleted file mode 100644 index 34978e7916..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ImplementsCloneableButNotClone/SomeClassWithoutClone.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ImplementsCloneableButNotClone; - -/** - * Some class without clone() method shouldn't be an issue for the analysis. - * - * @author Daniel Klauer - */ -public class SomeClassWithoutClone { - - void test() { - System.out.println("test\n"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/EfficientToArray.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/EfficientToArray.java deleted file mode 100644 index 6a97a80695..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/EfficientToArray.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package InefficientToArray; - -import java.util.ArrayList; - -/** - * Fixed version of InefficientToArray, should not be reported by the analysis. - * - * @author Daniel Klauer - */ -public class EfficientToArray { - - void test() { - ArrayList list = new ArrayList(); - - // Passing "new Integer[...]" to get the correct result type - // (Integer[]), - // because toArray() alone would return Object[]. - // - // Doing new Integer[list.size()] instead of new Integer[0] to allow - // toArray() to - // re-use - // that array to return the result, instead of having to allocate a new - // one. - @SuppressWarnings("unused") - Integer[] array = list.toArray(new Integer[list.size()]); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/InefficientToArray.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/InefficientToArray.java deleted file mode 100644 index feacf31895..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/InefficientToArray/InefficientToArray.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package InefficientToArray; - -import java.util.ArrayList; - -/** - * A class with a method using toArray() in an inefficient way. Should be reported by the - * analysis. - * - * @author Daniel Klauer - */ -public class InefficientToArray { - - void test() { - ArrayList list = new ArrayList(); - - // Passing "new Integer[0]" to get the correct result type (Integer[]), - // because toArray() alone would return Object[]. - @SuppressWarnings("unused") - Integer[] array = list.toArray(new Integer[0]); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/IntBitsToDouble.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/IntBitsToDouble.java deleted file mode 100644 index a3efbf8687..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/IntBitsToDouble.java +++ /dev/null @@ -1,18 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package LongBitsToDoubleInvokedOnInt; - -/** - * A call to `Double.longBitsToDouble()` with `int` argument. This is dangerous; normally - * `Double.longBitsToDouble()` takes a `long` argument, as a `long` is needed to hold a - * `double`, while an `int` is too small. This should be reported. - * - * @author Daniel Klauer - */ -public class IntBitsToDouble { - - void test() { - int i = 0xAABBCCDD; - double d = Double.longBitsToDouble(i); - System.out.println(d); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/LongBitsToDouble.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/LongBitsToDouble.java deleted file mode 100644 index 1d3bf02ce3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/LongBitsToDoubleInvokedOnInt/LongBitsToDouble.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package LongBitsToDoubleInvokedOnInt; - -/** - * A call to Double.longBitsToDouble() with long argument. This is the correct usage and - * should not be reported. - * - * @author Daniel Klauer - */ -public class LongBitsToDouble { - - void test() { - long l = 0xAAAABBBBCCCCDDDDl; - double d = Double.longBitsToDouble(l); - System.out.println(d); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGc.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGc.java deleted file mode 100644 index 558f55da3b..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGc.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ManualGarbageCollection; - -/** - * A class that invokes Runtime.gc() from the main() method. This should be reported. - * - * @author Daniel Klauer - */ -public final class RuntimeGc { - - public static void main() { - java.lang.Runtime.getRuntime().gc(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGcIntentional.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGcIntentional.java deleted file mode 100644 index a924baabf7..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/RuntimeGcIntentional.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ManualGarbageCollection; - -/** - * A class that invokes Runtime.gc() in a method named gc(). The heuristic of the analysis - * should ignore this case because it seems intentional. - * - * @author Daniel Klauer - */ -public final class RuntimeGcIntentional { - - public static void gc() { - java.lang.Runtime.getRuntime().gc(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGc.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGc.java deleted file mode 100644 index 2b66ff96ee..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGc.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ManualGarbageCollection; - -/** - * A class that invokes System.gc() from the main() method. This should be reported. - * - * @author Daniel Klauer - */ -public final class SystemGc { - - public static void main() { - java.lang.System.gc(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGcIntentional.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGcIntentional.java deleted file mode 100644 index 426d8d36e4..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ManualGarbageCollection/SystemGcIntentional.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ManualGarbageCollection; - -/** - * A class that invokes System.gc() in a method named gc(). The heuristic of the analysis - * should ignore this case because it seems intentional. - * - * @author Daniel Klauer - */ -public final class SystemGcIntentional { - - public static void gc() { - java.lang.System.gc(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithNativeMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithNativeMethod.java deleted file mode 100644 index d6cf4137d7..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithNativeMethod.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package NativeMethodInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * This class is annotated as immutable and contains native code. This is a problem, as - * the native code may change the classes fields in unexpected ways. This should be - * reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithNativeMethod { - - // Field is immutable because of lack of setter - private int foo = 42; - - // Returning foo is allowed as it is a java primitive and thus passed by value. - public int getFoo() { - return foo; - } - - // This method may do anything. There is no easy way to know. We assume immutability - // to be violated. - public native void changeFoo(int v); - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithoutNativeMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithoutNativeMethod.java deleted file mode 100644 index 188a79556a..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/JCIPAnnotatedWithoutNativeMethod.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package NativeMethodInImmutableClass; - -import net.jcip.annotations.Immutable; - -/** - * This class in annotated as immutable and does not contain native methods. It should not - * be reported. - * - * @author Roberts Kolosovs - */ -@Immutable -public class JCIPAnnotatedWithoutNativeMethod { - - public final int foo = 42; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/NotImmutableWithPublicFields.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/NotImmutableWithPublicFields.java deleted file mode 100644 index acb3bb5f6e..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NativeMethodInImmutableClass/NotImmutableWithPublicFields.java +++ /dev/null @@ -1,26 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package NativeMethodInImmutableClass; - -/** - * Some class with public fields, but without an immutable annotation. This should not be - * reported. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -public class NotImmutableWithPublicFields { - - public int x; - public int[] foo; - - public NotImmutableWithPublicFields(int arg0, int[] arg1) { - x = arg0; - foo = arg1; - } - - public NotImmutableWithPublicFields() { - x = 5; - int[] temp = { 1, 2, 3, 4 }; - foo = temp; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/NonSerializableOuterClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/NonSerializableOuterClass.java deleted file mode 100644 index b5e3132746..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/NonSerializableOuterClass.java +++ /dev/null @@ -1,26 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package NonSerializableClassHasASerializableInnerClass; - -/** - * A non-Serializable outer class with various inner classes, some Serializable, some not. - * - * @author Daniel Klauer - */ -public class NonSerializableOuterClass { - - class SerializableInnerClass implements java.io.Serializable { - - private static final long serialVersionUID = 1l; - } - - class NonSerializableInnerClass { - } - - static class SerializableStaticInnerClass implements java.io.Serializable { - - private static final long serialVersionUID = 3l; - } - - static class NonSerializableStaticInnerClass { - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/SerializableOuterClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/SerializableOuterClass.java deleted file mode 100644 index 1f66fd08c5..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/NonSerializableClassHasASerializableInnerClass/SerializableOuterClass.java +++ /dev/null @@ -1,24 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package NonSerializableClassHasASerializableInnerClass; - -/** - * A Serializable outer class with a non-Serializable inner class which has various inner - * classes itself, some Serializable, some not. - * - * @author Daniel Klauer - */ -public class SerializableOuterClass implements java.io.Serializable { - - private static final long serialVersionUID = 1l; - - class NonSerializableInnerClass { - - class SerializableInnerInnerClass implements java.io.Serializable { - - private static final long serialVersionUID = 1l; - } - - class NonSerializableInnerInnerClass { - } - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/OwnAnnotations/Immutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/OwnAnnotations/Immutable.java deleted file mode 100644 index f5fd8d8c0e..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/OwnAnnotations/Immutable.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package OwnAnnotations; - -import static java.lang.annotation.ElementType.TYPE; -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -import java.lang.annotation.Retention; -import java.lang.annotation.Target; - -/** - * Our own Immutable annotation for test purposes. - * - * @author Roberts Kolosovs - * @author Peter Spieler - */ -@Target(TYPE) -@Retention(RUNTIME) -public @interface Immutable { - -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/PrivateInFinal.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/PrivateInFinal.java deleted file mode 100644 index 43a9a657cc..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/PrivateInFinal.java +++ /dev/null @@ -1,11 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ProtectedFieldInFinalClass; - -/** - * @author Daniel Klauer - */ -public final class PrivateInFinal { - - @SuppressWarnings("unused") - private int i = 1; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInFinal.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInFinal.java deleted file mode 100644 index 12c66020bc..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInFinal.java +++ /dev/null @@ -1,11 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ProtectedFieldInFinalClass; - -/** - * @author Daniel Klauer - */ -public final class ProtectedInFinal { - - // this could also be private since the class can not be inherited from - protected int i = 1; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInNonFinal.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInNonFinal.java deleted file mode 100644 index 6bb6091a35..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/ProtectedFieldInFinalClass/ProtectedInNonFinal.java +++ /dev/null @@ -1,10 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package ProtectedFieldInFinalClass; - -/** - * @author Daniel Klauer - */ -public class ProtectedInNonFinal { - - protected int i = 1; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/ProtectedFinalizeMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/ProtectedFinalizeMethod.java deleted file mode 100644 index 07d9240548..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/ProtectedFinalizeMethod.java +++ /dev/null @@ -1,16 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package PublicFinalizeMethodShouldBeProtected; - -/** - * This class contains a `protected` `finalize()` method. This is ok and should not be - * reported. - * - * @author Daniel Klauer - */ -public class ProtectedFinalizeMethod { - - @Override - protected void finalize() throws Throwable { - super.finalize(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/PublicFinalizeMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/PublicFinalizeMethod.java deleted file mode 100644 index d7e1c48d75..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/PublicFinalizeMethodShouldBeProtected/PublicFinalizeMethod.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package PublicFinalizeMethodShouldBeProtected; - -/** - * This class contains a `public` `finalize()` method. Because it is `public`, it can be - * called from the outside, at any time, which is not the intention of `finalize()`. This - * should be reported. - * - * @author Daniel Klauer - */ -public class PublicFinalizeMethod { - - @Override - public void finalize() throws Throwable { - super.finalize(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableInheritsFromNoSuitableConstructor.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableInheritsFromNoSuitableConstructor.java deleted file mode 100644 index e67ce1e9be..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableInheritsFromNoSuitableConstructor.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SerializableNoSuitableConstructor; - -/** - * This class implements java.io.Serializable and inherits from - * SerializableNoSuitableConstructor which does not have a zero-argument constructor, - * which however is required for Serializable. The superclass is supposed to be reported, - * but not this subclass. - * - * @author Roberts Kolosovs - */ -class SerializableInheritsFromNoSuitableConstructor extends - SerializableNoSuitableConstructor implements java.io.Serializable { - - private static final long serialVersionUID = 1L; - - public SerializableInheritsFromNoSuitableConstructor(int[] args) { - super(args); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableNoSuitableConstructor.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableNoSuitableConstructor.java deleted file mode 100644 index 8ced6a78d7..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SerializableNoSuitableConstructor/SerializableNoSuitableConstructor.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SerializableNoSuitableConstructor; - -/** - * This is a superclass of SerializableInheritsFromNoSuitableConstructor, which implements - * Serializable, but this superclass does not have a constructor with no arguments. Thus - * it should be reported. - * - * @author Roberts Kolosovs - */ -public class SerializableNoSuitableConstructor { - - public SerializableNoSuitableConstructor(int[] args) { - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/BadSwingImplementation.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/BadSwingImplementation.java deleted file mode 100644 index b7e819c758..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/BadSwingImplementation.java +++ /dev/null @@ -1,31 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SwingMethodInvokedInSwingThread; - -import java.awt.BorderLayout; -import javax.swing.JButton; -import javax.swing.JFrame; - -/** - * Incorrectly implemented javax/swing functionality. The setVisible() function should be - * called in the event dispatching thread. Further information: - * http://en.wikipedia.org/wiki/Event_dispatching_thread Source code: - * http://web.archive.org/web/20090526170426/http://java.sun.com/developer - * /JDCTechTips/2003/tt1208.html#1 - * - * @author Daniel Klauer - * @author Roberts Kolosovs - */ -public class BadSwingImplementation { - - public static int main() { - JFrame frame = new JFrame(); - frame.setTitle("Title"); - frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); - JButton button = new JButton(); - button.setText("Hello, World!"); - frame.getContentPane().add(button, BorderLayout.CENTER); - frame.setSize(200, 100); - frame.setVisible(true); // This should be called via EventQueue. - return 0; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/GoodSwingImplementation.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/GoodSwingImplementation.java deleted file mode 100644 index 71f467683c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/GoodSwingImplementation.java +++ /dev/null @@ -1,43 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SwingMethodInvokedInSwingThread; - -import java.awt.BorderLayout; -import java.awt.EventQueue; -import javax.swing.JButton; -import javax.swing.JFrame; - -/** - * Correctly implemented javax/swing functionality. The setVisible() function is called - * through invokeLater() function of the EventQueue. Source code: - * http://web.archive.org/web/20090526170426/http://java.sun.com/developer - * /JDCTechTips/2003/tt1208.html#1 - * - * @author Roberts Kolosovs - */ -public class GoodSwingImplementation { - - private static class FrameShower implements Runnable { - - final JFrame frame; - - public FrameShower(JFrame frame) { - this.frame = frame; - } - - public void run() { - frame.setVisible(true); - } - } - - public static void main(String args[]) { - JFrame frame = new JFrame(); - frame.setTitle("Title"); - frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); - JButton button = new JButton(); - button.setText("Hello, World!"); - frame.getContentPane().add(button, BorderLayout.CENTER); - frame.setSize(200, 100); - Runnable runner = new FrameShower(frame); - EventQueue.invokeLater(runner); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/NoSwingUsed.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/NoSwingUsed.java deleted file mode 100644 index 046d7a4d6c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SwingMethodInvokedInSwingThread/NoSwingUsed.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SwingMethodInvokedInSwingThread; - -/** - * A class that does not use javax/swing functionality at all should not cause any issues - * for the analysis. - * - * @author Roberts Kolosovs - */ -public class NoSwingUsed { - - public int randomInt; - - private String randomString; - - public void setRandomString(String v) { - randomString = v; - } - - public String getRandomString() { - return randomString; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SyncSetUnsyncGet/VariousSettersAndGetters.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/SyncSetUnsyncGet/VariousSettersAndGetters.java deleted file mode 100644 index 3a078c8533..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/SyncSetUnsyncGet/VariousSettersAndGetters.java +++ /dev/null @@ -1,80 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package SyncSetUnsyncGet; - -/** - * A class with several setter/getter pairs. Some don't use synchronized at all, some use - * synchronized on both setter & getter, and some use synchronized only on the setter, but - * not the getter. - * - * @author Daniel Klauer - */ -public class VariousSettersAndGetters { - - /** - * s1 with synchronized setter, but unsynchronized getter (dangerous, this is an issue - * that FindRealBugs should report) - */ - private String a = ""; - - public synchronized void setA(String a) { - this.a = a; - } - - public String getA() { - return a; - } - - /** - * Same as above, but with different data type. - */ - private int b; - - public synchronized void setB(int b) { - this.b = b; - } - - public int getB() { - return b; - } - - /** - * Here, both setter and getter are synchronized, so there's no issue. - */ - private int c; - - public synchronized void setC(int c) { - this.c = c; - } - - public synchronized int getC() { - return c; - } - - /** - * Here, neither the setter nor the getter is synchronized. This should not be - * reported. - */ - private int d; - - public void setD(int d) { - this.d = d; - } - - public int getD() { - return d; - } - - /** - * Setter/getter pair where only the getter is synchronized. Currently this won't be - * reported. - */ - private int e; - - public void setE(int e) { - this.e = e; - } - - public synchronized int getE() { - return e; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/A.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/A.java deleted file mode 100644 index aabe12bba3..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/A.java +++ /dev/null @@ -1,155 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * Superclass in the A->B->C class hierarchy. All tests are based on the static - * initializer here in the superclass. - * - * @author Daniel Klauer - */ -public class A { - - // Direct access to subclass'es static field, should be reported. In the source code, - // this access appears in static initialization outside the `static { }` block, but - // when compiled it will also appear in ``, which is what the analysis - // analyzes. - static int A1 = B.B1; // uninitialized - static int A2 = C.C2; // uninitialized - - static int A20 = 42; - - static int A_getA20() { - return A20; - } - - static int A_getB21() { - return B.B21; - } - - static int A_getC22() { - return C.C22; - } - - static int A23 = 42; - static int A26 = 42; - static int A30 = 42; - - static int A_getA30() { - return A30; - } - - static int A_getA30_viaA() { - return A_getA30(); - } - - static int A_getB31() { - return B.B31; - } - - static int A_getB31_viaA() { - return A_getB31(); - } - - static int A32 = 42; - - static int A_getA32_viaB() { - return B.B_getA32(); - } - - static int A_getB33_viaB() { - return B.B_getB33(); - } - - static int A34 = 42; - - static int A_getA34() { - return A34; - } - - static int A_getB35() { - return B.B35; - } - - static int A36 = 42; - - // Static fields in the class and its subclasses may have the same name. That should - // not confuse the analysis though - it has to reference fields not only by name, but - // also by their declaring class. - static int samename1 = 42; - static int samename2 = 42; - - static int A50 = 42; - - static { - // Direct access - System.out.println(B.B3); // uninitialized - System.out.println(C.C4); // uninitialized - - // Various indirect accesses (1 level of indirection) - System.out.println(A_getA20()); // ok - System.out.println(A_getB21()); // uninitialized - System.out.println(A_getC22()); // uninitialized - System.out.println(B.B_getA23()); // ok - System.out.println(B.B_getB24()); // uninitialized - System.out.println(B.B_getC25()); // uninitialized - System.out.println(C.C_getA26()); // ok - System.out.println(C.C_getB27()); // uninitialized - System.out.println(C.C_getC28()); // uninitialized - - // Access to uninitialized field through 2 levels of indirection - System.out.println(A_getA30_viaA()); // ok - System.out.println(A_getB31_viaA()); // uninitialized - System.out.println(A_getA32_viaB()); // ok - System.out.println(A_getB33_viaB()); // uninitialized - System.out.println(B.B_getA34_viaA()); // ok - System.out.println(B.B_getB35_viaA()); // uninitialized - System.out.println(B.B_getA36_viaB()); // ok - System.out.println(B.B_getB37_viaB()); // uninitialized - - // Accessing this class'es static field first, it's initialized already. - // The following access to the subclass'es static field should still be detected - // as uninitialized access (but would not be if the analysis only checked fields - // based on their name). - System.out.println(samename1); // ok - System.out.println(B.samename1); // uninitialized - - // Accessing the subclass'es static field first, this is an uninitialized access. - // The following access to this class'es static field should not be mis-detected - // as uninitialized access (but would be if the analysis only checked fields - // based on their name). - System.out.println(B.samename2); // uninitialized - System.out.println(samename2); // ok - - // Direct access but through context other than the field's declaringClass, - // shouldn't confuse the analysis - System.out.println(B.A50); // ok - System.out.println(C.A50); // ok - System.out.println(C.B50); // uninitialized - - // Second access to an uninitialized field. Only the first access should be - // reported. - System.out.println(B.B60); // uninitialized - System.out.println(B.B60); // uninitialized, but ignored - - // Initializing a field manually prevents the uninitialized access - B.B70 = 42; - System.out.println(B.B70); // ok - A_initB71(); - System.out.println(B.B71); // ok - B.B_initB72(); - System.out.println(B.B72); // ok - } - - // Inner class that also is a subclass - static class InnerB extends A { - - static int InnerB40 = 42; - } - - static int A40 = InnerB.InnerB40; // uninitialized - - static void A_initB71() { - B.B71 = 42; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/B.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/B.java deleted file mode 100644 index 5d6bc6e8df..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/B.java +++ /dev/null @@ -1,82 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * Subclass in the A->B->C class hierarchy. - * - * @author Daniel Klauer - */ -public class B extends A { - - static int B1 = 42; - static int B3 = 42; - static int B21 = 42; - - static int B_getA23() { - return A23; - } - - static int B24 = 42; - - static int B_getB24() { - return B24; - } - - static int B_getC25() { - return C.C25; - } - - static int B27 = 42; - static int B31 = 42; - - static int B_getA32() { - return A32; - } - - static int B33 = 42; - - static int B_getB33() { - return B33; - } - - static int B_getA34_viaA() { - return A_getA34(); - } - - static int B35 = 42; - - static int B_getB35_viaA() { - return A_getB35(); - } - - static int B_getA36() { - return A36; - } - - static int B_getA36_viaB() { - return B_getA36(); - } - - static int B37 = 42; - - static int B_getB37() { - return B37; - } - - static int B_getB37_viaB() { - return B_getB37(); - } - - static int samename1 = 42; - static int samename2 = 42; - - static int B50 = 42; - static int B60 = 42; - static int B70 = 42; - static int B71 = 42; - static int B72 = 42; - - static void B_initB72() { - B72 = 42; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/C.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/C.java deleted file mode 100644 index f73de80460..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/C.java +++ /dev/null @@ -1,31 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * Subsubclass in the A->B->C class hierarchy. - * - * @author Daniel Klauer - */ -public class C extends B { - - static int C2 = 42; - static int C4 = 42; - static int C22 = 42; - static int C25 = 42; - - static int C_getA26() { - return A26; - } - - static int C_getB27() { - return B27; - } - - static int C28 = 42; - - static int C_getC28() { - return C28; - } - - static int C50 = 42; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/ClassUsesItself.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/ClassUsesItself.java deleted file mode 100644 index a2362dfe9c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/ClassUsesItself.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * A class that references itself during , and should not trigger reports. - * - * @author Daniel Klauer - */ -public class ClassUsesItself { - - public final static String text = "hello"; - - static { - // A GETSTATIC instruction during the static initializer. - System.out.println(text); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/CodePaths.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/CodePaths.java deleted file mode 100644 index f2ed664424..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/CodePaths.java +++ /dev/null @@ -1,106 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * This test covers the analysis' ability to track the code-path-specific initialization - * status of static fields. - * - * @author Daniel Klauer - */ -public class CodePaths { - - public static int condition10 = 0; - public static int condition11 = 0; - public static int condition12 = 0; - public static int condition20 = 0; - public static int condition21 = 0; - public static int condition22 = 0; - public static int condition30 = 0; - public static int condition31 = 0; - public static int condition40 = 0; - - static void test11() { - if (condition11 != 0) { - } else { - System.out.println(CodePathsSubclass.i11); // uninitialized - } - } - - static void test40() { - if (condition40 != 0) { - System.out.println(CodePathsSubclass.i40); // uninitialized - return; - } - - System.out.println(CodePathsSubclass.i40); // uninitialized - } - - static { - // Uninitialized access on only 1 of 2 code paths - if (condition10 != 0) { - System.out.println(CodePathsSubclass.i10); // uninitialized - } else { - } - - // same but in a subroutine - test11(); - - // Uninitialized accesses on both code paths - if (condition12 != 0) { - System.out.println(CodePathsSubclass.i12); // uninitialized - } else { - System.out.println(CodePathsSubclass.i12); // uninitialized - } - - // Field initialized manually, but only on 1 of 2 code paths, - // potentially causing an uninitialized access later - if (condition20 != 0) { - CodePathsSubclass.i20 = 1; - } - System.out.println(CodePathsSubclass.i20); // maybe uninitialized - - if (condition21 != 0) { - CodePathsSubclass.i21 = 1; - } else { - CodePathsSubclass.i21 = 2; - } - System.out.println(CodePathsSubclass.i21); // ok - - if (condition22 != 0) { - CodePathsSubclass.i22 = 1; - System.out.println(CodePathsSubclass.i22); // ok - } - - // Field initialized manually on one code path, - // and accessed uninitialized on the other. - if (condition30 != 0) { - CodePathsSubclass.i30 = 1; - } else { - System.out.println(CodePathsSubclass.i30); // uninitialized - // (if the analysis didn't track code paths, but just looked through - // instructions one by one, this would probably not be detected as an - // uninitialized access. - } - - if (condition31 != 0) { - System.out.println(CodePathsSubclass.i31); // uninitialized - } else { - CodePathsSubclass.i31 = 1; - } - - test40(); - } -} - -class CodePathsSubclass extends CodePaths { - - static int i10 = 42; - static int i11 = 42; - static int i12 = 42; - static int i20 = 42; - static int i21 = 42; - static int i22 = 42; - static int i30 = 42; - static int i31 = 42; - static int i40 = 42; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EmptyStaticInitializer.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EmptyStaticInitializer.java deleted file mode 100644 index cc5dc4c2d6..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EmptyStaticInitializer.java +++ /dev/null @@ -1,12 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * @author Daniel Klauer - */ -public class EmptyStaticInitializer { - - static { - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EnumUsesItself.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EnumUsesItself.java deleted file mode 100644 index 1670d8fb06..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/EnumUsesItself.java +++ /dev/null @@ -1,22 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * An enum that references itself during (due to the implicit code generated - * by Java, such as the values field), and should not trigger reports. - * - * @author Daniel Klauer - */ -public enum EnumUsesItself { - A("a"), B("b"), C("c"); - - private String text; - - private EnumUsesItself(String text) { - this.text = text; - } - - public String getText() { - return text; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/Recursion.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/Recursion.java deleted file mode 100644 index f6a578e0a6..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/Recursion.java +++ /dev/null @@ -1,34 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * The analysis must be able to deal with recursive calls when analyzing called methods, - * to avoid infinite recursion. - * - * @author Daniel Klauer - */ -public class Recursion { - - static void limitedRecursion(int i) { - if (i < 10) { - limitedRecursion(i + 1); - } - System.out.println(RecursionSubclass.i1); - } - - static void infiniteRecursion() { - infiniteRecursion(); - System.out.println(RecursionSubclass.i2); - } - - static { - limitedRecursion(0); - infiniteRecursion(); - } -} - -class RecursionSubclass extends Recursion { - - public static int i1 = 123; - public static int i2 = 123; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/StaticNativeMethod.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/StaticNativeMethod.java deleted file mode 100644 index c18ce0d4a4..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/StaticNativeMethod.java +++ /dev/null @@ -1,28 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * A class that calls a `static native` method during ``. This is special because - * references to `native` methods can be resolved, but they can still not be analyzed - * because they don't have known bodies. - * - * This test class must have a subclass with a static field, or else the analysis would - * simply skip it immediately. - * - * @author Daniel Klauer - */ -public class StaticNativeMethod { - - public static native int f(); - - static { - System.out.println(f()); - System.out.println(StaticNativeMethodSubclass.i); - } -} - -class StaticNativeMethodSubclass extends StaticNativeMethod { - - static int i = 123; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassA.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassA.java deleted file mode 100644 index fedc1a9fd8..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassA.java +++ /dev/null @@ -1,18 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ - -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * Invokes System.runFinalizersOnExit, an extremely dangerous method. - * - * @author Roberts Kolosovs - */ -public class UnrelatedControlClassA { - - @SuppressWarnings("deprecation") - public void doStuff() { - System.runFinalizersOnExit(true); - } - - static int bla = UnrelatedControlClassB.blubb; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassB.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassB.java deleted file mode 100644 index 5c023d6fae..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UninitializedFieldAccessDuringStaticInitialization/UnrelatedControlClassB.java +++ /dev/null @@ -1,20 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UninitializedFieldAccessDuringStaticInitialization; - -/** - * This class deliberately contains "useless" code to test checkers that search for it. - * - * It contains: - a finalize method that just calls super.finalize(); - * - * @author Michael Eichberg - */ -@SuppressWarnings("all") -public class UnrelatedControlClassB { - - @Override - protected void finalize() throws Throwable { - super.finalize(); - } - - static int blubb = 5; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Unused.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Unused.java deleted file mode 100644 index b05d1361ab..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Unused.java +++ /dev/null @@ -1,23 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UnusedPrivateFields; - -/** - * A class containing various unused private fields. - * - * @author Daniel Klauer - */ -@SuppressWarnings("unused") -public class Unused { - - // Normal field without initializer - private int a; - - // Normal field with a constant initializer - private int b = 111; - - // Final field with non-constant initializer - private final Unused c = new Unused(); - - // Final field with another constant initializer - private final int d = 222; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UnusedSerialVersionUID.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UnusedSerialVersionUID.java deleted file mode 100644 index a67a6f24ad..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UnusedSerialVersionUID.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UnusedPrivateFields; - -/** - * Class with an unused private serialVersionUID field. serialVersionUID is not special - * here, because this class is not Serializable, thus it should be reported. - * - * @author Daniel Klauer - */ -public class UnusedSerialVersionUID { - - @SuppressWarnings("unused") - private static final long serialVersionUID = 1L; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Used.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Used.java deleted file mode 100644 index 9e2632c357..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/Used.java +++ /dev/null @@ -1,102 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UnusedPrivateFields; - -/** - * A class containing various used private fields, testing that the analysis detects field - * accesses to normal instructions and handles the many special cases for final constant - * fields. - * - * @author Daniel Klauer - */ -public class Used { - - private int normali = 0; - - private final int im1 = -1; - private final int i0 = 0; - private final int i1 = 1; - private final int i2 = 2; - private final int i3 = 3; - private final int i4 = 4; - private final int i5 = 5; - private final int i6 = 6; - private final int i123 = 123; - - private final long lm1 = -1; - private final long l0 = 0; - private final long l1 = 1; - private final long l2 = 2; - private final long l3 = 3; - private final long l4 = 4; - private final long l5 = 5; - private final long l6 = 6; - private final long l123 = 123; - - private final float fm1 = -1; - private final float f0 = 0; - private final float f1 = 1; - private final float f2 = 2; - private final float f3 = 3; - private final float f4 = 4; - private final float f5 = 5; - private final float f6 = 6; - private final float f123 = 123; - - private final double dm1 = -1; - private final double d0 = 0; - private final double d1 = 1; - private final double d2 = 2; - private final double d3 = 3; - private final double d4 = 4; - private final double d5 = 5; - private final double d6 = 6; - private final double d123 = 123; - - private final String s = "abc"; - - void test() { - System.out.println(normali); - - System.out.println(im1); - System.out.println(i0); - System.out.println(i1); - System.out.println(i2); - System.out.println(i3); - System.out.println(i4); - System.out.println(i5); - System.out.println(i6); - System.out.println(i123); - - System.out.println(lm1); - System.out.println(l0); - System.out.println(l1); - System.out.println(l2); - System.out.println(l3); - System.out.println(l4); - System.out.println(l5); - System.out.println(l6); - System.out.println(l123); - - System.out.println(fm1); - System.out.println(f0); - System.out.println(f1); - System.out.println(f2); - System.out.println(f3); - System.out.println(f4); - System.out.println(f5); - System.out.println(f6); - System.out.println(f123); - - System.out.println(dm1); - System.out.println(d0); - System.out.println(d1); - System.out.println(d2); - System.out.println(d3); - System.out.println(d4); - System.out.println(d5); - System.out.println(d6); - System.out.println(d123); - - System.out.println(s); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedInInnerClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedInInnerClass.java deleted file mode 100644 index 0ea7d38770..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedInInnerClass.java +++ /dev/null @@ -1,35 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UnusedPrivateFields; - -/** - * Private fields unused in their own class, but used in an inner class. The analysis has - * to analyze inner classes too in order to detect this. - * - * @author Daniel Klauer - */ -public class UsedInInnerClass { - - // This field really is unused, it should be reported. - @SuppressWarnings("unused") - private final String reallyUnused = "reallyUnused"; - - // These fields however aren't unused -- they're used in inner classes, and should not - // be reported. - private final String usedByInner = "usedByInner"; - private final String usedByInnerInner = "usedByInnerInner"; - - class InnerClass { - - void test() { - System.out.println(usedByInner); - } - - class InnerInnerClass { - - void test() { - System.out.println(usedByInnerInner); - } - } - - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedSerialVersionUID.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedSerialVersionUID.java deleted file mode 100644 index 62b02ea5aa..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UnusedPrivateFields/UsedSerialVersionUID.java +++ /dev/null @@ -1,13 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UnusedPrivateFields; - -/** - * A Serializable class with a private serialVersionUID field. The serialVersionUID field - * is used by Serializable, and thus it should not be reported. - * - * @author Daniel Klauer - */ -class UsedSerialVersionUID implements java.io.Serializable { - - private static final long serialVersionUID = 1L; -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SubclassAccessedBySuperclassBeforeInit.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SubclassAccessedBySuperclassBeforeInit.java deleted file mode 100644 index 07b2b304a5..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SubclassAccessedBySuperclassBeforeInit.java +++ /dev/null @@ -1,25 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UrUninitReadCalledFromSuperConstructor; - -/** - * A subclass that is accessed by its superclass before it (the subclass) has been - * initialized. This can happen if the superclass accesses the subclass during its own - * initialization, because subclasses are initialized after superclasses. - * - * @author Roberts Kolosovs - * @author Daniel Klauer - */ -public class SubclassAccessedBySuperclassBeforeInit extends - SuperclassWithAccessToSubclassDuringInit { - - int i = 123; - - /** - * This method is called from the parent's constructor, but at that point, this child - * class' i field hasn't been initialized yet. - */ - @Override - void f() { - System.out.println(i); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SuperclassWithAccessToSubclassDuringInit.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SuperclassWithAccessToSubclassDuringInit.java deleted file mode 100644 index f402e43c99..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/SuperclassWithAccessToSubclassDuringInit.java +++ /dev/null @@ -1,17 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UrUninitReadCalledFromSuperConstructor; - -/** - * Abstract superclass for UrUninitReadCallFromSuperConstructor test - * - * @author Roberts Kolosovs - * @author Daniel Klauer - */ -public abstract class SuperclassWithAccessToSubclassDuringInit { - - abstract void f(); - - SuperclassWithAccessToSubclassDuringInit() { - f(); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/UnrelatedClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/UnrelatedClass.java deleted file mode 100644 index d2a8536a06..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UrUninitReadCalledFromSuperConstructor/UnrelatedClass.java +++ /dev/null @@ -1,15 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UrUninitReadCalledFromSuperConstructor; - -/** - * Some class that neither accesses a subclass nor is accessed by its superclass during - * initialization. - * - * @author Daniel Klauer - */ -public class UnrelatedClass { - - public UnrelatedClass() { - System.out.println("test"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntFieldIncrementInReturn.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntFieldIncrementInReturn.java deleted file mode 100644 index 0ad286c23e..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntFieldIncrementInReturn.java +++ /dev/null @@ -1,37 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UselessIncrementInReturn; - -/** - * Various methods incrementing the int field during return instructions. - * - * In this case the increment is not useless, even though it happens as part of a return - * statement, because the resulting value is stored into the field, instead of being - * thrown away. Thus, none of these cases should trigger reports. - * - * @author Daniel Klauer - */ -public class IntFieldIncrementInReturn { - - int i = 0; - - int standaloneIncrement() { - i++; - return i; - } - - int intToIreturn() { - return i++; - } - - long intToLreturn() { - return i++; - } - - float intToFreturn() { - return i++; - } - - double intToDreturn() { - return i++; - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntParameterIncrementInReturn.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntParameterIncrementInReturn.java deleted file mode 100644 index 53ac896149..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/IntParameterIncrementInReturn.java +++ /dev/null @@ -1,33 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UselessIncrementInReturn; - -/** - * Various methods containing int increment and return instructions. The analysis should - * only report those cases where the increment appears in the return and thus is dead - * code. - * - * @author Daniel Klauer - */ -public class IntParameterIncrementInReturn { - - int standaloneIncrement(int i) { - i++; // should not be reported - return i; - } - - int intToIreturn(int i) { - return i++; // should be reported - } - - long intToLreturn(int i) { - return i++; // should be reported - } - - float intToFreturn(int i) { - return i++; // should be reported - } - - double intToDreturn(int i) { - return i++; // should be reported - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/UnrelatedClass.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/UnrelatedClass.java deleted file mode 100644 index d56ff38231..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/UselessIncrementInReturn/UnrelatedClass.java +++ /dev/null @@ -1,14 +0,0 @@ -/* BSD 2-Clause License - see OPAL/LICENSE for details. */ -package UselessIncrementInReturn; - -/** - * Some class that doesn't have any increment instruction. - * - * @author Daniel Klauer - */ -public class UnrelatedClass { - - public UnrelatedClass() { - System.out.println("test"); - } -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/GuardedBy.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/GuardedBy.java deleted file mode 100644 index 52500549eb..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/GuardedBy.java +++ /dev/null @@ -1,38 +0,0 @@ -package javax.annotation.concurrent; - -import java.lang.annotation.ElementType; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; - -/* - * Copyright (c) 2005 Brian Goetz - * Released under the Creative Commons Attribution License - * (http://creativecommons.org/licenses/by/2.5) - * Official home: http://www.jcip.net - */ - -/** - * GuardedBy - * - * The field or method to which this annotation is applied can only be accessed when - * holding a particular lock, which may be a built-in (synchronization) lock, or may be an - * explicit java.util.concurrent.Lock. - * - * The argument determines which lock guards the annotated field or method: this : The - * string literal "this" means that this field is guarded by the class in which it is - * defined. class-name.this : For inner classes, it may be necessary to disambiguate - * 'this'; the class-name.this designation allows you to specify which 'this' reference is - * intended itself : For reference fields only; the object to which the field refers. - * field-name : The lock object is referenced by the (instance or static) field specified - * by field-name. class-name.field-name : The lock object is reference by the static field - * specified by class-name.field-name. method-name() : The lock object is returned by - * calling the named nil-ary method. class-name.class : The Class object for the specified - * class should be used as the lock object. - */ -@Target({ ElementType.FIELD, ElementType.METHOD }) -@Retention(RetentionPolicy.CLASS) -public @interface GuardedBy { - - String value(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/Immutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/Immutable.java deleted file mode 100644 index 6c4e170b0e..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/Immutable.java +++ /dev/null @@ -1,35 +0,0 @@ -package javax.annotation.concurrent; - -import java.lang.annotation.Documented; -import java.lang.annotation.ElementType; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; - -/* - * Copyright (c) 2005 Brian Goetz - * Released under the Creative Commons Attribution License - * (http://creativecommons.org/licenses/by/2.5) - * Official home: http://www.jcip.net - */ - -/** - * Immutable - * - * The class to which this annotation is applied is immutable. This means that its state - * cannot be seen to change by callers. Of necessity this means that all public fields are - * final, and that all public final reference fields refer to other immutable objects, and - * that methods do not publish references to any internal state which is mutable by - * implementation even if not by design. Immutable objects may still have internal mutable - * state for purposes of performance optimization; some state variables may be lazily - * computed, so long as they are computed from immutable state and that callers cannot - * tell the difference. - * - * Immutable objects are inherently thread-safe; they may be passed between threads or - * published without synchronization. - */ -@Documented -@Target(ElementType.TYPE) -@Retention(RetentionPolicy.CLASS) -public @interface Immutable { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/NotThreadSafe.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/NotThreadSafe.java deleted file mode 100644 index 764f951f02..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/NotThreadSafe.java +++ /dev/null @@ -1,30 +0,0 @@ -package javax.annotation.concurrent; - -import java.lang.annotation.Documented; -import java.lang.annotation.ElementType; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; - -/* - * Copyright (c) 2005 Brian Goetz - * Released under the Creative Commons Attribution License - * (http://creativecommons.org/licenses/by/2.5) - * Official home: http://www.jcip.net - */ - -/** - * NotThreadSafe - * - * The class to which this annotation is applied is not thread-safe. This annotation - * primarily exists for clarifying the non-thread-safety of a class that might otherwise - * be assumed to be thread-safe, despite the fact that it is a bad idea to assume a class - * is thread-safe without good reason. - * - * @see ThreadSafe - */ -@Documented -@Target(ElementType.TYPE) -@Retention(RetentionPolicy.CLASS) -public @interface NotThreadSafe { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/ThreadSafe.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/ThreadSafe.java deleted file mode 100644 index 06aed5aa61..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/javax/annotation/concurrent/ThreadSafe.java +++ /dev/null @@ -1,22 +0,0 @@ -package javax.annotation.concurrent; - -import java.lang.annotation.Documented; -import java.lang.annotation.ElementType; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; - -/** - * ThreadSafe - * - * The class to which this annotation is applied is thread-safe. This means that no - * sequences of accesses (reads and writes to public fields, calls to public methods) may - * put the object into an invalid state, regardless of the interleaving of those actions - * by the runtime, and without requiring any additional synchronization or coordination on - * the part of the caller. - */ -@Documented -@Target(ElementType.TYPE) -@Retention(RetentionPolicy.CLASS) -public @interface ThreadSafe { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/GuardedBy.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/GuardedBy.java deleted file mode 100644 index 1bd301e313..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/GuardedBy.java +++ /dev/null @@ -1,64 +0,0 @@ -/* - * Copyright 2013 Stephen Connolly. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.jcip.annotations; - -import java.lang.annotation.Documented; -import java.lang.annotation.Retention; -import java.lang.annotation.Target; - -import static java.lang.annotation.ElementType.FIELD; -import static java.lang.annotation.ElementType.METHOD; -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -/** - * The presence of this annotation indicates that the field or method must only be - * accessed when holding the specified lock. - */ -@Documented -@Target(value = { FIELD, METHOD }) -@Retention(RUNTIME) -public @interface GuardedBy { - - /** - * The specified lock that guards the annotated field or method. Valid values are: - *
      - *
    • {@code this} indicates the intrinsic lock of the instance containing the field - * or method.
      • - *
    • class-name.this which allows for disambiguation of which - * {@code this} when dealing with inner classes
      • - *
    • {@code itself} which is valid for reference fields only, and indicates that the - * referenced instance's own intrinsic lock should be used as the guard
      • - *
    • field-name indicates the named instance or static field is - * to be used as the guard. If the field type is not a sub-type of - * {@link java.util.concurrent.locks.Lock} then the intrinsic lock of the referenced - * instance is to be used
      • - *
    • class-name.field-name indicates the named static - * field is to be used as the guard. If the field type is not a sub-type of - * {@link java.util.concurrent.locks.Lock} then the intrinsic lock of the referenced - * instance is to be used
      • - *
    • method-name() indicates that the zero-argument method - * should be called to obtain the lock object. If the return type is not a sub-type of - * {@link java.util.concurrent.locks.Lock} then the intrinsic lock of the returned - * instance is to be used
      • - *
    • class-name.class indicates that the intrinsic lock of the - * specified class should be used as the guard
      • - *
    - * - * @return The specified lock that guards the annotated field or method - */ - String value(); -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/Immutable.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/Immutable.java deleted file mode 100644 index 5f027667b0..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/Immutable.java +++ /dev/null @@ -1,49 +0,0 @@ -/* - * Copyright 2013 Stephen Connolly. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.jcip.annotations; - -import java.lang.annotation.Documented; -import java.lang.annotation.Retention; -import java.lang.annotation.Target; - -import static java.lang.annotation.ElementType.TYPE; -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -/** - * The presence of this annotation indicates that the author believes the class to be - * immutable and hence inherently thread-safe. An immutable class is one where the state - * of an instance cannot be seen to change. As a result - *
      - *
    • All public fields must be {@code final}
      • - *
    • All public final reference fields are either {@code null} or refer to other - * immutable objects
      • - *
    • Constructors and methods do not publish references to any potentially mutable - * internal state.
      • - *
    - * Performance optimization may mean that instances of an immutable class may have mutable - * internal state. The critical point is that callers cannot tell the difference. For - * example {@link String} is an immutable class, despite having an internal int that is - * non-final but used as a cache for {@link String#hashCode()}. - *

    - * Immutable objects are inherently thread-safe; they may be passed between threads or - * published without synchronization. - */ -@Documented -@Target(TYPE) -@Retention(RUNTIME) -public @interface Immutable { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/NotThreadSafe.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/NotThreadSafe.java deleted file mode 100644 index 9c35168c8f..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/NotThreadSafe.java +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright 2013 Stephen Connolly. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.jcip.annotations; - -import java.lang.annotation.Documented; -import java.lang.annotation.Retention; -import java.lang.annotation.Target; - -import static java.lang.annotation.ElementType.TYPE; -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -/** - * The presence of this annotation indicates that the author believes the class is not - * thread-safe. The absence of this annotation does not indicate that the class is - * thread-safe, instead this annotation is for cases where a naïve assumption could be - * easily made that the class is thread-safe. In general, it is a bad plan to assume a - * class is thread safe without good reason. - */ -@Documented -@Target(TYPE) -@Retention(RUNTIME) -public @interface NotThreadSafe { -} diff --git a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/ThreadSafe.java b/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/ThreadSafe.java deleted file mode 100644 index 3309a18e1c..0000000000 --- a/TOOLS/bp/src/test/resources/sourcefiles/analyses/net/jcip/annotations/ThreadSafe.java +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright 2013 Stephen Connolly. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.jcip.annotations; - -import java.lang.annotation.Documented; -import java.lang.annotation.Retention; -import java.lang.annotation.Target; - -import static java.lang.annotation.ElementType.TYPE; -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -/** - * The presence of this annotation indicates that the author believes the class to be - * thread-safe. As such, there should be no sequence of accessing the public methods or - * fields that could put an instance of this class into an invalid state, irrespective of - * any rearrangement of those operations by the Java Runtime and without introducing any - * requirements for synchronization or coordination by the caller/accessor. - */ -@Documented -@Target(TYPE) -@Retention(RUNTIME) -public @interface ThreadSafe { -} diff --git a/TOOLS/bp/src/test/resources/valid.properties b/TOOLS/bp/src/test/resources/valid.properties deleted file mode 100644 index 4a92f61f53..0000000000 --- a/TOOLS/bp/src/test/resources/valid.properties +++ /dev/null @@ -1,4 +0,0 @@ -Analysis1=yes -Analysis2=yes -Analysis3=no -Analysis4=yes diff --git a/build.sbt b/build.sbt index f620123fc1..9267a2ab21 100644 --- a/build.sbt +++ b/build.sbt @@ -177,7 +177,6 @@ lazy val `OPAL` = (project in file(".")) av, apk, framework, - // bp, (just temporarily...) tools, hermes, ce, @@ -414,19 +413,6 @@ lazy val `Framework` = (project in file("OPAL/framework")) ) .configs(IntegrationTest) -/* TEMPORARILY DISABLED THE BUGPICKER UNTIL WE HAVE A CG ANALYSIS AGAIN! -lazy val bp = `BugPicker` -lazy val `BugPicker` = (project in file("TOOLS/bp")) - .settings(buildSettings *) - .settings( - name := "BugPicker", - scalacOptions in(Compile, doc) ++= Opts.doc.title("OPAL - BugPicker"), - fork := true - ) - .dependsOn(framework % "it->it;it->test;test->test;compile->compile") - .configs(IntegrationTest) - */ - lazy val hermes = `Hermes` lazy val `Hermes` = (project in file("TOOLS/hermes")) @@ -519,7 +505,6 @@ lazy val `ConfigurationExplorer` = (project in file("TOOLS/ce")) br % "compile->compile", apk % "runtime->compile", demos % "runtime->compile", - // bp % "runtime->compile", hermes % "runtime->compile" ) .configs(IntegrationTest) diff --git a/src/site/UsingOPAL.md b/src/site/UsingOPAL.md index 5bd1d2e031..b6e6bb0d61 100644 --- a/src/site/UsingOPAL.md +++ b/src/site/UsingOPAL.md @@ -71,8 +71,3 @@ The architecture validation framework facilitates the development of tools for s Provides support for the analyis of APKs, with automatic conversion from dalvik to java byte code. libraryDependencies += "de.opal-project" % "apk_2.13" % "6.0.0" - - -[comment]: # "Exploring the Abstract Interpretation Framework" - -[comment]: # "To get a good, first idea what the abstract interpretation framework can do, you can use the *BugPicker*. It enables you to perform some local abstract interpretations. To get good results it is usually necessary to load the JDK and all related libraries." diff --git a/src/site/index.md b/src/site/index.md index 60a5b52c66..39f8263b1d 100644 --- a/src/site/index.md +++ b/src/site/index.md @@ -15,12 +15,6 @@ In-depth tutorials on developing static analyses with OPAL can be found in the n Publications about OPAL's core concepts and about uses of OPAL in scientific research, and information on **citing OPAL in scientific works** can be found [here](/Publications.html). -[comment]: ## "OPAL based Tools" - -[comment]: # "### BugPicker" - -[comment]: # "Find bugs in your Java project using [BugPicker](tools/bugpicker/index.php)." - ### OPAL Java Bytecode Disassembler OPAL's [Java Bytecode Disassembler](DeveloperTools.html) disassembles your Java bytecode.