Backport handle errors gracefully to prevent SEGV to v5.0.x #13539
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oob_allgather_test() do not check isend() call success, leading to the possibility to use oob_req->reqs[] un-initialized upon error and thus to SEGV. Signed-off-by: Bruno Faccini <bfaccini@nvidia.com> (cherry picked from commit 109f4bc)
QiaoK
changed the title
bosilca
previously approved these changes
Dec 1, 2025
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: e85fe16: coll/ucc: Fix indentation issue with tab.
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
jsquyres
reviewed
Dec 1, 2025
Comment on lines
+256
to
+258
| if (OMPI_SUCCESS != rc) { | ||
| return UCC_ERR_NO_MESSAGE; | ||
| } |
Member
There was a problem hiding this comment.
Please don't use tabs -- we only use 4-space indenting here in Open MPI.
https://docs.open-mpi.org/en/v5.0.x/developers/source-code.html
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oob_allgather_test() do not check isend() call
success, leading to the possibility to use
oob_req->reqs[] un-initialized upon error and
thus to SEGV.
(cherry picked from commit 109f4bc)
Backport this fix in main branch to v5.0.x, so 5.0 version can run with UCC without segmentation fault.