Skip to content

Backport handle errors gracefully to prevent SEGV to v5.0.x #13539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v5.0.x
Choose a base branch
from
+13 −4
Open

Backport handle errors gracefully to prevent SEGV to v5.0.x #13539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a7ce3
handle errors gracefuly to prevent SEGV
bfaccini May 6, 2025
a2d64e1
coll/ucc: Fix indentation issue with tab.
QiaoK Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ompi/mca/coll/ucc/coll_ucc_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
* Copyright (c) 2021 Mellanox Technologies. All rights reserved.
* Copyright (c) 2022 Amazon.com, Inc. or its affiliates.
* All Rights reserved.
* Copyright (c) 2022 NVIDIA Corporation. All rights reserved.
* Copyright (c) 2022-2025 NVIDIA Corporation. All rights reserved.
* Copyright (c) 2024 Triad National Security, LLC. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -220,7 +221,7 @@ static ucc_status_t oob_allgather_test(void *req)
size_t msglen = oob_req->msglen;
int probe_count = 5;
int rank, size, sendto, recvfrom, recvdatafrom,
senddatafrom, completed, probe;
senddatafrom, completed, probe, rc;

size = ompi_comm_size(comm);
rank = ompi_comm_rank(comm);
Expand All @@ -245,10 +246,16 @@ static ucc_status_t oob_allgather_test(void *req)
senddatafrom = (rank - oob_req->iter + size) % size;
tmprecv = (char*)oob_req->rbuf + (ptrdiff_t)recvdatafrom * (ptrdiff_t)msglen;
tmpsend = (char*)oob_req->rbuf + (ptrdiff_t)senddatafrom * (ptrdiff_t)msglen;
MCA_PML_CALL(isend(tmpsend, msglen, MPI_BYTE, sendto, MCA_COLL_BASE_TAG_UCC,
rc = MCA_PML_CALL(isend(tmpsend, msglen, MPI_BYTE, sendto, MCA_COLL_BASE_TAG_UCC,
MCA_PML_BASE_SEND_STANDARD, comm, &oob_req->reqs[0]));
MCA_PML_CALL(irecv(tmprecv, msglen, MPI_BYTE, recvfrom,
if (OMPI_SUCCESS != rc) {
return UCC_ERR_NO_MESSAGE;
}
rc = MCA_PML_CALL(irecv(tmprecv, msglen, MPI_BYTE, recvfrom,
MCA_COLL_BASE_TAG_UCC, comm, &oob_req->reqs[1]));
if (OMPI_SUCCESS != rc) {
return UCC_ERR_NO_MESSAGE;
}
Comment on lines +256 to +258
Copy link
Member

@jsquyres jsquyres Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use tabs -- we only use 4-space indenting here in Open MPI.

https://docs.open-mpi.org/en/v5.0.x/developers/source-code.html

Thanks!

Copy link
Member

@jsquyres jsquyres Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still looks wrong.

}
probe = 0;
do {
Expand Down Expand Up @@ -276,6 +283,8 @@ static ucc_status_t oob_allgather(void *sbuf, void *rbuf, size_t msglen,
oob_req->msglen = msglen;
oob_req->oob_coll_ctx = oob_coll_ctx;
oob_req->iter = 0;
oob_req->reqs[0] = MPI_REQUEST_NULL;
oob_req->reqs[1] = MPI_REQUEST_NULL;
*req = oob_req;
return UCC_OK;
}
Expand Down