From 1d0bfe411399c9c16f6a8c0641289dbd287e213a Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Wed, 21 Sep 2022 07:56:49 +0200 Subject: [PATCH 1/6] [CI] Removed push event from workflows Signed-off-by: Esteban Martinena --- .github/workflows/build.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 810ba5c..ef3972f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -1,6 +1,5 @@ name: build on: - push: pull_request: schedule: - cron: '35 0 * * *' From b8eb0dcc15324173c9b3e40319102c451019cacd Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Thu, 8 Dec 2022 08:35:24 +0100 Subject: [PATCH 2/6] Add "push" on main to the triggers of the build action Signed-off-by: Esteban Martinena --- .github/workflows/build.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index ef3972f..a175086 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -1,6 +1,9 @@ name: build on: pull_request: + push: + branches: + - main schedule: - cron: '35 0 * * *' From 6548b27032eb5e2aafc1d9c127e2039f9237106e Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Thu, 8 Dec 2022 08:47:23 +0100 Subject: [PATCH 3/6] Bump version of ros-tooling/setup-ros action Signed-off-by: Esteban Martinena --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a175086..4c2e709 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -17,7 +17,7 @@ jobs: - name: pwd run: pwd - name: deps - uses: ros-tooling/setup-ros@v0.2 + uses: ros-tooling/setup-ros@v0.4 with: required-ros-distributions: rolling - name: build From 870b3b075e48b5eb29019c90f67de0acf1184973 Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Sat, 17 Sep 2022 02:43:38 +0200 Subject: [PATCH 4/6] [CI] Reusable CI Signed-off-by: Esteban Martinena --- .github/workflows/build.yaml | 41 ++++++------------------------------ 1 file changed, 7 insertions(+), 34 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 4c2e709..60aef1e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -6,40 +6,13 @@ on: - main schedule: - cron: '35 0 * * *' + workflow_dispatch: jobs: build_and_test: - name: Build and test - runs-on: ubuntu-latest - container: - image: ubuntu:latest - steps: - - name: pwd - run: pwd - - name: deps - uses: ros-tooling/setup-ros@v0.4 - with: - required-ros-distributions: rolling - - name: build - uses: ros-tooling/action-ros-ci@v0.2 - with: - target-ros2-distro: rolling - # build all packages listed in the meta package - package-name: | - rmf_utils - vcs-repo-file-url: | - https://raw.githubusercontent.com/open-rmf/rmf/main/rmf.repos - colcon-defaults: | - { - "build": { - "mixin": ["coverage-gcc"] - } - } - colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/master/index.yaml - - name: Upload coverage to Codecov - uses: codecov/codecov-action@v1 - with: - files: ros_ws/lcov/total_coverage.info - flags: tests - name: lean_and_mean_codecov_bot - + name: rmf_utils + uses: open-rmf/rmf_ci_templates/.github/workflows/reusable_build.yaml@main + with: + # NOTE: Avoid adding comments in the packages lines, this can break some of the called scripts in github actions + packages: | + rmf_utils \ No newline at end of file From 5845fbf3e4d52e58dbc42c6fd4812f3c3567f8a2 Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Wed, 21 Sep 2022 16:10:36 +0200 Subject: [PATCH 5/6] Minor uncrustify fix Signed-off-by: Esteban Martinena --- rmf_utils/include/rmf_utils/clone_ptr.hpp | 4 ++-- rmf_utils/include/rmf_utils/impl_ptr.hpp | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rmf_utils/include/rmf_utils/clone_ptr.hpp b/rmf_utils/include/rmf_utils/clone_ptr.hpp index beaf46e..a1d23bc 100644 --- a/rmf_utils/include/rmf_utils/clone_ptr.hpp +++ b/rmf_utils/include/rmf_utils/clone_ptr.hpp @@ -39,7 +39,7 @@ class clone_ptr; //============================================================================== template -clone_ptr make_clone(Args&&... args); +clone_ptr make_clone(Args&& ... args); //============================================================================== template @@ -194,7 +194,7 @@ class clone_ptr //============================================================================== template -clone_ptr make_clone(Args&&... args) +clone_ptr make_clone(Args&& ... args) { return clone_ptr(new T(std::forward(args)...)); } diff --git a/rmf_utils/include/rmf_utils/impl_ptr.hpp b/rmf_utils/include/rmf_utils/impl_ptr.hpp index 52e9c2b..ec678db 100644 --- a/rmf_utils/include/rmf_utils/impl_ptr.hpp +++ b/rmf_utils/include/rmf_utils/impl_ptr.hpp @@ -320,7 +320,7 @@ inline bool operator>=(std::nullptr_t, const unique_impl_ptr& p) template -inline unique_impl_ptr make_unique_impl(Args&&... args) +inline unique_impl_ptr make_unique_impl(Args&& ... args) { return unique_impl_ptr(new T(std::forward( args)...), &details::default_delete); @@ -474,14 +474,14 @@ class impl_ptr : public unique_impl_ptr }; template -inline impl_ptr make_impl(Args&&... args) +inline impl_ptr make_impl(Args&& ... args) { return impl_ptr(new T(std::forward( args)...), &details::default_delete, &details::default_copy); } template -impl_ptr make_derived_impl(Args&&... args) +impl_ptr make_derived_impl(Args&& ... args) { return impl_ptr( new D(std::forward(args)...), From 5dcd92dacbe39ff79e8aec2b0fdd8e86504046b0 Mon Sep 17 00:00:00 2001 From: Esteban Martinena Date: Wed, 7 Dec 2022 19:17:54 +0100 Subject: [PATCH 6/6] Removed build ci for [foxy|galactic] focal Signed-off-by: Esteban Martinena --- .github/workflows/build.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 60aef1e..f144810 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -13,6 +13,8 @@ jobs: name: rmf_utils uses: open-rmf/rmf_ci_templates/.github/workflows/reusable_build.yaml@main with: + # Avoid execution on [foxy|galactic] focal ( + dist-matrix: '[{"ros_distribution": "humble", "ubuntu_distribution": "jammy"}, {"ros_distribution": "rolling", "ubuntu_distribution": "jammy"}]' # NOTE: Avoid adding comments in the packages lines, this can break some of the called scripts in github actions packages: | rmf_utils \ No newline at end of file