Skip to content

Review the correctness and documentation of setFunctionVarRefs #964

@zapateo

Description

@zapateo

Review the correctness and documentation of:

func (em *emitter) setFunctionVarRefs(fn *runtime.Function, closureVars []ast.Upvar) {

This is because the terminology used within this method appears a bit different from the rest of the code. Is this just a misunderstanding in its interpretation, or does it actually express different concepts or handle things differently than other parts of the code, thus hiding potential errors?

It is therefore necessary to delve into this function well, understand what it is supposed to do and evaluate whether it is necessary to make changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions