fix(helm): accept "multibot-mentions" in allowUserMessages validation#472
Merged
thepagent merged 3 commits intoopenabdev:mainfrom Apr 19, 2026
Merged
Conversation
The openab binary added the `MultibotMentions` variant to `AllowUsers` in openabdev#464, but the Helm chart's validation block was not updated. Any user who follows docs/discord.md § Multi-Bot Setup and sets `allowUserMessages: "multibot-mentions"` is blocked by a template fail before the pod ever starts. Fix: - Add `"multibot-mentions"` to the `has ... (list ...)` check for both Discord and Slack in `charts/openab/templates/configmap.yaml`. - Update the trailing documentation comment describing the mode. - Document the new option (and its semantics) in `charts/openab/values.yaml`. - Add helm-unittest cases covering renders + invalid-value rejection for `allowUserMessages` (the test file previously only covered `allowBotMessages`). Verified: $ helm template openab ./charts/openab \ --set agents.kiro.discord.allowUserMessages=multibot-mentions \ ... | grep allow_user_messages allow_user_messages = "multibot-mentions" $ helm unittest charts/openab Charts: 1 passed, 1 total Test Suites: 2 passed, 2 total Tests: 18 passed, 18 total Fixes openabdev#471 Refs openabdev#464 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
taking a look |
- Error messages now include '(use hyphen form, not underscore)' to help users who copy from Rust config (which accepts both forms) - Add Slack-side allowUserMessages test for multibot-mentions Co-authored-by: thepagent <thepagent@users.noreply.github.com>
chaodu-agent
approved these changes
Apr 19, 2026
Collaborator
chaodu-agent
left a comment
There was a problem hiding this comment.
LGTM ✅
Reviewed the full diff across 3 commits:
- Core fix:
multibot-mentionsadded to allow-list for both Discord and Slack validation - Error messages now hint about hyphen form to prevent underscore copy-paste footgun
- Test coverage: 5 new cases (Discord × 4 + Slack × 1), all 19 pass
values.yamldocs updated with clear mode descriptions
CI green, no nits remaining. Ship it 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
The openab binary added
MultibotMentionsto theAllowUsersenum in #464, but the Helm chart's validation block incharts/openab/templates/configmap.yamlwas not updated. Any user who followsdocs/discord.md§ Multi-Bot Setup and setsallowUserMessages: "multibot-mentions"is blocked by a template fail before the pod ever starts:Fixes #471
Refs #464
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365150664560881/1495429672920416357
At a Glance
Prior Art & Industry Research
allowBotMessagesalready validates withhas ... (list "off" "mentions" "all")and has corresponding unit tests. This PR alignsallowUserMessageswith that existing pattern.Proposed Solution
Add
"multibot-mentions"to thehasallow-list for both Discord and Slack, plus update the documentation comment andcharts/openab/values.yamluser-facing docs. Mirror the existingallowBotMessagestest pattern forallowUserMessages.Same one-line change at the Slack block. Added 4 new helm-unittest cases covering
involved/mentions/multibot-mentionsrenders plus the invalid-value rejection (the test file previously only coveredallowBotMessages—allowUserMessageshad no test coverage).Why this approach
allowBotMessagespattern — same validation style, same test style, no architectural change.must be one of: ...message, now accurate.Alternatives Considered
allowBotMessagescheck.has ... list"multibot-mentions") and leave underscore ("multibot_mentions") as binary-onlyValidation
helm template openab ./charts/openab --set agents.kiro.discord.allowUserMessages=multibot-mentionsrendersallow_user_messages = "multibot-mentions"successfully.helm template ... --set allowUserMessages=bogusstill fails with the updated error message listing all three valid values.helm template ... --set allowUserMessages=mentionsstill renders the pre-existing behaviour (backward-compatible).helm unittest charts/openab→ 18 passed, 0 failed (including 4 new test cases forallowUserMessages).