[Security] Empty allowed_channels should not default to allowing all channels

[chaodu-agent]

Summary

Currently, when allowed_channels is empty ([]) or omitted in config.toml, the bot responds to all channels in the Discord server. This is an "open by default" design that poses security and resource risks in production.

Current Behavior

// discord.rs
let in_allowed_channel =
    self.allowed_channels.is_empty() || self.allowed_channels.contains(&channel_id);

Empty = allow all.

Problem

• Users who forget to configure allowed_channels unknowingly expose the bot to the entire server
• Session pool (max_sessions = 10) can be exhausted quickly if the bot responds across many channels
• Bot may respond with sensitive content in unintended channels

Proposed Options

Option A: Empty = deny all (secure by default)

• Safest approach
• Downside: new users may be confused when bot does not respond after setup
• Mitigation: clear error log at startup: ERROR: No allowed_channels configured. Bot will not respond to any messages.

Option B: Empty = allow all + startup warning

• Keep current behavior but log a prominent warning:

  ⚠️ No allowed_channels configured — bot will respond in ALL channels
  

• Lower friction for development/testing

Option C: Require at least one channel (fail fast)

• Refuse to start if allowed_channels is empty
• Clearest signal, zero ambiguity

Recommendation

Option A or C for production safety. The cost of setting one channel ID is trivial compared to the risk of accidental full-server exposure.

References

• src/config.rs: allowed_channels: Vec<String> with #[serde(default)]
• src/discord.rs: is_empty() check in message handler

[chaodu-agent]

Issue at a Glance

config.toml
┌──────────────────────────────┐
│ allowed_channels = []        │  ← empty or omitted
└──────────────┬───────────────┘
               │
               ▼
         discord.rs:32
         allowed_channels.is_empty() → true
               │
               ▼
         in_allowed_channel = true
         for ALL channels ❌
               │
               ▼
         bot responds everywhere
         session pool exhausted quickly

Hi @chaodu-agent,

Confirmed — discord.rs line 32 treats empty allowed_channels as "allow all". This is an insecure default that affects every new deployment where the operator forgets or omits the config.

+1 for Option A (empty = deny all + clear error log). It's the safest default and the startup error message makes misconfiguration obvious. Option C (fail fast) is also acceptable. Happy to accept a PR for either.

Relabeling as bug + p1.

[JARVIS-coding-Agent]

Slack Side — Pending

src/slack.rs:711 has the same pattern and has not been patched yet:

// slack.rs — same insecure default
if !allowed_channels.is_empty() && ...

The Discord side is fixed by PR #398. The Slack side will be addressed in the same PR.