MAC address is not persistent on Rebooting the system.

[swe12345]

On rebooting the system expecting that the newly assigned MAC address must persist

Steps:

1. Assign a valid MAC address xx:xx:xx:xx:xx:xx to the system using the curl command
   curl -k -H "X-Auth-Token:${bmc_token}" -X PATCH -D patch.txt -d '{"MACAddress":"xx:xx:xx:xx:xx:xx"}' https://$bmc/redfish/v1/Managers/bmc/EthrnetInterfaces/eth0
2. Now GET and verify if the MAC address has changed using
   curl -k -H "X-Auth-Token:${bmc_token}" -X GET  https://${bmc}/redfish/v1/Managers/bmc/EthernetInterfaces/eth0
3. Now reboot the BMC and verify if the MAC address remains the same

Expectation:

Expecting that the MAC address should persist on rebooting the system.

@sunharis @raviteja-b

[williamspatrick]

Does your machine have configured a place to store the MAC? Or are you expecting it to be saved in u-boot?

[swe12345]

@ratagupt @wak-google

[prkatti1]

The MAC address we assign was persistent on reboot in earlier builds, this issue we are noticing is only on recent builds.
We are expecting the same behavior.

[wak-google]

Specifically, what version of phosphor-networkd are you using?

[wak-google]

Also, did you possibly enable https://github.com/openbmc/phosphor-networkd/blob/master/meson_options.txt#L13 in your config?

[swe12345]

We are using the lastest networkd. @raviteja-b @sunharis Can you please answer Wak's questions.

[raviteja-b]

Also, did you possibly enable https://github.com/openbmc/phosphor-networkd/blob/master/meson_options.txt#L13 in your config?

yes, enabled persist-mac meson flag.
@wak-google do we need to persist user-configured MAC address after reboot? what's the right behaviour here

[wak-google]

Are you sure you have 9caa64d

[raviteja-b]

Are you sure you have 9caa64d

yes @wak-google

[mdmillerii]

Have you checked the u-boot environment to see if the MAC has been set? fw_printenv ethaddr eth1addr for the first and second interface known to u-boot. Also you can check the u-boot prompt with printenv to verify it is looking in the same place for its environment.

[prkatti1]

Do we have any update here? We are expecting MAC address to be persistent on reboot like earlier.

[williamspatrick]

Do we have any update here? We are expecting MAC address to be persistent on reboot like earlier.

Seems likely no one has further ideas and you will need to debug and fix it?

[prkatti1]

Do we have any update here? We are expecting MAC address to be persistent on reboot like earlier.

Seems likely no one has further ideas and you will need to debug and fix it?

I'd love to fix, need some info why the earlier function is changed? which commit has introduced this issue? as we are seeing this issue very recently.

[williamspatrick]

I'd love to fix, need some info why the earlier function is changed? which commit has introduced this issue? as we are seeing this issue very recently.

If we knew this, the fix would probably be obvious. You’re welcome to experiment with git bisect.

[mdmillerii]

Have you performed any of the troubleshooting i suggested to help isolate which step might be failing? What were the results?