Disabling DHCPv6 is disabling SLAAC also

[swe12345]

Disabling DHCPv6 is disabling SLAAC also

Disabling DHCPv6
curl -k -H "Content-Type: application/json" -H "X-Auth-Token: ${bmc_token}" -X PATCH -d '{"DHCPv6": {"OperatingMode" : "Disabled"}}' https://$bmc/refish/v1/Managers/bmc/EthernetInterfaces/eth1

Seeing that
IPv6AutoConfigEnabled in eth1 is being set to False

[swe12345]

@ratagupt @williamspatrick

[williamspatrick]

Not sure why I am tagged here.

[mdmillerii]

Was it enabled before your patch? Was it in the network configuration file?

Search ipv6AcceptRa in https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/ethernet.hpp#L1143 to see how it's translated from redfish to dbus and this search in phosphor networkd https://github.com/search?q=repo%3Aopenbmc%2Fphosphor-networkd%20IPv6AcceptRA&type=code

[prkatti1]

DHCPv6 has dependency on SLAAC as it does not provide default gateway.
SLAAC has no dependency on DHCPv6.
I think @swe12345 is trying following scenario:
Pre-condition: When SLAAC is enabled & DHCPv6 is enabled, if user disables DHCPv6, it is disabling SLAAC also.

[mdmillerii]

The request was to actually verify it was reported and recognized to help isolate which components need to changed.

[prkatti1]

Submitter is expecting, if DHCPv6 is disabled it should disable only DHCPv6 and not other functions.
Fix is required in Redfish DHCPv6 disable function

[chaul-ampere]

Submitter is expecting, if DHCPv6 is disabled it should disable only DHCPv6 and not other functions. Fix is required in Redfish DHCPv6 disable function

bmcweb sets DHCPEnabled property on DBus as DHCPv6/OperatingMode is set (https://github.com/openbmc/bmcweb/blob/02ea923f13de196726ac2f022766a6f80bee1c0a/redfish-core/lib/ethernet.hpp#L1445). I guess in the scenario of the submitter, DHCPEnabled did not fall on any of these conditions (

phosphor-networkd/src/ethernet_interface.cpp

Line 390 in dce7fe7

auto newra = EthernetInterfaceIntf::ipv6AcceptRA(

), so ipv6AcceptRA was set to false as a result. Correct me if I'm wrong.

[raviteja-b]

Not sure why I am tagged here.

I think she wanted to tag @wak-google

[prkatti1]

Any update here @swe12345 @wak-google @chaul-ampere ?
Are we going to get the fix here?

[swe12345]

Expecting that disabling DHCPv6 must not disable SLAAC as well. Can you please update us. @chaul-ampere @wak-google

[chaul-ampere]

Following my previous comment here #76 (comment), did you try to debug and see what value the DHCPConf was when DHCPv6 was disabled via Redfish. I guess it was either DHCPConf::none or DHCPConf::v4, which do not fall on any of the condition for EthernetInterfaceIntf::ipv6AcceptRA to be true here

phosphor-networkd/src/ethernet_interface.cpp

Line 390 in dce7fe7

auto newra = EthernetInterfaceIntf::ipv6AcceptRA(

. Then you can update the result here for the maintainer to look at or submit a patch.

[mdmillerii]

@swe12345 please provide log excerpts of your testing including both before and after state including the properties that have been mentioned and the complete patch request. Both myself and Chaul have asked for specific details before continuing our investigation. The other commenters have just been guessing about your test environment or expectations.

Please format logs with markdown by including text in triple backtik``` blocks.

[swe12345]

@chaul-ampere
The config file before and after
====Before when DHCPv6 and SLAAC are enabled

SendHostname=true
UseHostname=true
UseDomains=true
UseDNS=true
UseNTP=true
ClientIdentifier=mac
[IPv6AcceptRA]
DHCPv6Client=true
[DHCPv6]
SendHostname=true
UseHostname=true
UseNTP=true
UseDomains=true
UseDNS=true
[Network]
DHCP=true
IPv6AcceptRA=true
LinkLocalAddressing=ipv6
[Link]
MACAddress=xx:xx:xx:xx:xx:xx
[Match]
Name=eth1
====Now on disabling DHCPv6 alone - observing that SLAAC is also getting disabled
DHCPv4]
SendHostname=true
UseHostname=true
UseDomains=true
UseDNS=true
UseNTP=true
ClientIdentifier=mac
[IPv6AcceptRA]
DHCPv6Client=false  =======> disabled DHCPv6
[DHCPv6]
SendHostname=true
UseHostname=true
UseNTP=true
UseDomains=true
UseDNS=true
[Network]
DHCP=ipv4
IPv6AcceptRA=false =======> This is disabling SLAAC as well
LinkLocalAddressing=ipv6
[Link]
MACAddress=xx:xx:xx:xx:xx:xx
[Match]
Name=eth1

[swe12345]

Any update on this? Are you looking for any other information please.

[mdmillerii]

I still don't see the actual request that was made.

I haven't looked but don't see obvious signs about the state of SLAAC in either log. If it's enclosed in some of the state please point out where.

This is still just asking for clarification and not a commitment to actually suggest a change.