unittest flaky: data race in pkg/storage/fs/posix/lookup/lookup_test.go

[rhafer]

https://ci.opencloud.rocks/repos/4/pipeline/371/141

from the logs:

WARNING: DATA RACE
Write at 0x00c000532368 by goroutine 67:
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/lookup_test.init.func1.1()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/lookup/lookup_test.go:28 +0x285
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/spaceidindex.(*Index).updateIndex()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaceidindex/spaceidindex.go:112 +0x8b3
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/spaceidindex.(*Index).updateIndex()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaceidindex/spaceidindex.go:108 +0x875
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/spaceidindex.(*Index).updateIndex()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaceidindex/spaceidindex.go:88 +0x404
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/spaceidindex.(*Index).Add()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaceidindex/spaceidindex.go:55 +0x279
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs.(*Decomposedfs).linkStorageSpaceType()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaces.go:874 +0xb3
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs.(*Decomposedfs).updateIndexes()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaces.go:844 +0xc1
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs.(*Decomposedfs).CreateStorageSpace()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/spaces.go:204 +0x2fae
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/testhelpers.(*TestEnv).CreateTestStorageSpace()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/testhelpers/helpers.go:367 +0x734
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/testhelpers.NewTestEnv()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/testhelpers/helpers.go:264 +0x2350
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/lookup_test.init.func1.1()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/lookup/lookup_test.go:24 +0xf6
  github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/node.go:524 +0x2e
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/suite.go:942 +0x6ed

Previous read at 0x00c000532368 by goroutine 72:
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/testhelpers.NewTestEnv.func1()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/testhelpers/helpers.go:190 +0xac
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata.HybridBackend.LockfilePath()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/metadata/hybrid_backend.go:494 +0x73
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata.HybridBackend.Lock()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/metadata/hybrid_backend.go:501 +0x8d
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata.HybridBackend.SetMultiple()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/metadata/hybrid_backend.go:213 +0xfd
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata.HybridBackend.Set()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/pkg/decomposedfs/metadata/hybrid_backend.go:206 +0x184
  github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata.(*HybridBackend).Set()
      <autogenerated>:1 +0x29
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/tree.(*Tree).WarmupIDCache()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/tree/assimilation.go:957 +0x864
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/tree.New.func2()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/tree/tree.go:163 +0x57

Goroutine 67 (running) created at:
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/suite.go:907 +0x149c
  github.com/onsi/ginkgo/v2/internal.(*group).attemptSpec()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/group.go:231 +0x10e4
  github.com/onsi/ginkgo/v2/internal.(*group).run()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/group.go:381 +0x1206
  github.com/onsi/ginkgo/v2/internal.(*Suite).runSpecs()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/suite.go:515 +0x11f1
  github.com/onsi/ginkgo/v2/internal.(*Suite).Run()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/suite.go:136 +0x6d3
  github.com/onsi/ginkgo/v2.RunSpecs()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/core_dsl.go:314 +0xec4
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/lookup_test.TestLookup()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/lookup/lookup_suite_test.go:12 +0x4d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1792 +0x225
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1851 +0x44

Goroutine 72 (running) created at:
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/tree.New()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/tree/tree.go:162 +0x158a
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/testhelpers.NewTestEnv()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/testhelpers/helpers.go:226 +0x1cc5
  github.com/opencloud-eu/reva/v2/pkg/storage/fs/posix/lookup_test.init.func1.1()
      /go/src/github.com/opencloud-eu/reva/pkg/storage/fs/posix/lookup/lookup_test.go:24 +0xf6
  github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/node.go:524 +0x2e
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
      /go/pkg/mod/github.com/onsi/ginkgo/v2@v2.27.2/internal/suite.go:942 +0x6ed
==================

full logs:

opencloud-eu-reva-371-test.log