RHAIENG-2111: chore(trustyai): podman build in rhds: error: command 'g++' failed: No such file or directory

[jiridanek]

https://issues.redhat.com/browse/RHAIENG-2111

Description

How Has This Been Tested?

• https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/open-data-hub-tenant/applications/opendatahub-release/pipelineruns/odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-requt9764
• RHAIENG-2111: chore(trustyai): podman build in rhds: error: command 'g++' failed: No such file or directory red-hat-data-services/notebooks#1731
  • konflux build todo

Self checklist (all need to be checked):

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Improved development environment setup to ensure more reliable builds across different platforms.
  • Simplified compiler configuration for streamlined development workflows.
  • Fixed minor formatting inconsistencies in build scripts.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

This change modifies a development environment setup script to install gcc and g++ upfront to support jpype1==1.5.0 compilation, replaces gcc-toolset-13 with standard gcc/g++ packages, and removes trailing whitespace from a git clone command.

Changes

Cohort / File(s)	Summary
Build environment setup jupyter/trustyai/ubi9-python-3.12/devel_env_setup.sh	Adds upfront gcc and g++ installation for jpype1 compilation support; removes gcc-toolset-13 in favor of standard gcc/g++; removes trailing space in apache-arrow git clone command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single shell script file with straightforward dependency and formatting changes
• No control flow modifications or error handling additions
• Changes are isolated to package installation declarations and whitespace cleanup

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description lacks essential details. While it references the issue tracker, the Description and How Has This Been Tested sections are empty, leaving the actual changes and testing approach unexplained.	Fill in the Description section explaining what changes were made to fix the g++ compilation issue, and provide clear testing instructions in the How Has This Been Tested section.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references the issue (RHAIENG-2111) and accurately summarizes the main change: fixing a g++ compilation error in the trustyai podman build.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5ecb1 and c015f91.

📒 Files selected for processing (1)

• jupyter/trustyai/ubi9-python-3.12/devel_env_setup.sh (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
• GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build

🔇 Additional comments (1)

jupyter/trustyai/ubi9-python-3.12/devel_env_setup.sh (1)

132-132: Minor cleanup: trailing whitespace removal.

The trailing space in the git clone command for apache-arrow has been cleanly removed, improving consistency.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Fix incorrect package name: use gcc-c++ instead of gcc-g++.

The package gcc-g++ does not exist in the UBI9 repository. The correct package name for the C++ compiler is gcc-c++. This will cause the dnf install command to fail.

This inconsistency is evident when comparing with line 41, where the correct gcc-c++ package is used for s390x.

Apply this diff to fix the package name:

-dnf install -y --setopt=keepcache=1 gcc gcc-g++
+dnf install -y --setopt=keepcache=1 gcc gcc-c++

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	# compiling jpype1==1.5.0 requires g++ and this gets compiled on all platforms
	# gcc and g++ is present by default on registry.access.redhat.com/ubi9/python-312:latest
	dnf install -y --setopt=keepcache=1 gcc gcc-g++
	# compiling jpype1==1.5.0 requires g++ and this gets compiled on all platforms
	# gcc and g++ is present by default on registry.access.redhat.com/ubi9/python-312:latest
	dnf install -y --setopt=keepcache=1 gcc gcc-c++

🤖 Prompt for AI Agents

In jupyter/trustyai/ubi9-python-3.12/devel_env_setup.sh around lines 21 to 23,
the dnf install uses the non-existent package name gcc-g++; replace it with the
correct UBI9 package name gcc-c++ so the C++ compiler installs correctly (make
the same change as used on line 41), and ensure the dnf command remains
otherwise unchanged.

[openshift-ci]

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebook-jupyter-tai-ubi9-python-3-12-pr-image-mirror	c015f91	link	true	/test notebook-jupyter-tai-ubi9-python-3-12-pr-image-mirror
ci/prow/images	c015f91	link	true	/test images
ci/prow/notebooks-py312-ubi9-e2e-tests	c015f91	link	true	/test notebooks-py312-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.