From a8dd5984f81f97123423d4d30621fa2c2c3a3a8c Mon Sep 17 00:00:00 2001 From: Jawad Khan Date: Sat, 6 Dec 2025 00:18:21 +0500 Subject: [PATCH 1/3] fix: removed depricate storage path --- course_discovery/apps/core/tests/test_prod_config.py | 1 - course_discovery/settings/production.py | 8 -------- 2 files changed, 9 deletions(-) diff --git a/course_discovery/apps/core/tests/test_prod_config.py b/course_discovery/apps/core/tests/test_prod_config.py index a59ece630a..e2ae6cd86d 100644 --- a/course_discovery/apps/core/tests/test_prod_config.py +++ b/course_discovery/apps/core/tests/test_prod_config.py @@ -16,7 +16,6 @@ def test_production_media_storage(monkeypatch, tmp_path): AWS_QUERYSTRING_EXPIRE: false AWS_S3_CUSTOM_DOMAIN: cdn.org AWS_STORAGE_BUCKET_NAME: tests - DEFAULT_FILE_STORAGE: storages.backends.s3boto3.S3Boto3Storage MEDIA_ROOT: media MEDIA_URL: https://cdn.org/media/ """) diff --git a/course_discovery/settings/production.py b/course_discovery/settings/production.py index 726008987a..007ef20cc7 100644 --- a/course_discovery/settings/production.py +++ b/course_discovery/settings/production.py @@ -42,14 +42,6 @@ vars().update(config_from_yaml) MEDIA_STORAGE_BACKEND = config_from_yaml.get("MEDIA_STORAGE_BACKEND", {}) - default_backend = MEDIA_STORAGE_BACKEND.pop("DEFAULT_FILE_STORAGE", None) - static_backend = MEDIA_STORAGE_BACKEND.pop("STATICFILES_STORAGE", None) - - if default_backend: - STORAGES["default"]["BACKEND"] = default_backend - - if static_backend: - STORAGES["staticfiles"]["BACKEND"] = static_backend # Unpack media storage settings. # It's important we unpack here because of https://github.com/openedx/configuration/pull/3307 From c47196fc7f7894c90842ee7bf18d603f9ce8fd08 Mon Sep 17 00:00:00 2001 From: Jawad Khan Date: Sat, 6 Dec 2025 00:52:55 +0500 Subject: [PATCH 2/3] fix: Fixed test case --- course_discovery/apps/core/tests/test_prod_config.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/course_discovery/apps/core/tests/test_prod_config.py b/course_discovery/apps/core/tests/test_prod_config.py index e2ae6cd86d..da0b34ec92 100644 --- a/course_discovery/apps/core/tests/test_prod_config.py +++ b/course_discovery/apps/core/tests/test_prod_config.py @@ -18,6 +18,9 @@ def test_production_media_storage(monkeypatch, tmp_path): AWS_STORAGE_BUCKET_NAME: tests MEDIA_ROOT: media MEDIA_URL: https://cdn.org/media/ + STORAGES: + default: + BACKEND: storages.backends.s3boto3.S3Boto3Storage """) fake_config.write_text(fake_yaml_content) From c8c14a717725656d73d602dbabbb8230daff9360 Mon Sep 17 00:00:00 2001 From: Jawad Khan Date: Tue, 9 Dec 2025 13:44:22 +0500 Subject: [PATCH 3/3] fix: run flaky test --- course_discovery/settings/production.py | 1 - 1 file changed, 1 deletion(-) diff --git a/course_discovery/settings/production.py b/course_discovery/settings/production.py index 007ef20cc7..d540b8af29 100644 --- a/course_discovery/settings/production.py +++ b/course_discovery/settings/production.py @@ -42,7 +42,6 @@ vars().update(config_from_yaml) MEDIA_STORAGE_BACKEND = config_from_yaml.get("MEDIA_STORAGE_BACKEND", {}) - # Unpack media storage settings. # It's important we unpack here because of https://github.com/openedx/configuration/pull/3307 vars().update(MEDIA_STORAGE_BACKEND)