Skip to content

Conversation

@Faraz32123
Copy link

Ticket: COSMO2-716

  • dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work.
    • So, replace dialogClassName with simple className to apply same styles to get the past behavior for the modal.

Please review
paragon v22 Modal Props VS paragon ModalDialog Props API which used className instead of dialogClassName.

- dialogClassName was working with Modal from paragon, but after paragon v23 upgrade. We replaced Modal with ModalDialog with which dialogClassName doesn't work.
  - So, replace dialogClassName with simple className to apply same styles.
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (9bf5d01) to head (e66951c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         344      344           
  Lines        5792     5792           
  Branches     1331     1372   +41     
=======================================
  Hits         5261     5261           
+ Misses        514      512    -2     
- Partials       17       19    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Faraz32123 Faraz32123 force-pushed the fix/modal_size_for_lti_content_upstream branch from 2b1b243 to e66951c Compare September 9, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant