Skip to content

Conversation

@PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Mar 21, 2025

Added a Dates page displaying the scheduled dates for all courses.

Light Dark
Screenshot 2025-04-16 at 11 15 08 Screenshot 2025-04-16 at 11 15 37
Screen.Recording.2025-11-21.at.14.23.12.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 21, 2025

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 24, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 24, 2025
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/dates_page branch 4 times, most recently from c1b7023 to 88af319 Compare April 1, 2025 09:50
@PavloNetrebchuk PavloNetrebchuk self-assigned this Apr 1, 2025
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/dates_page branch 5 times, most recently from 185a09a to f245cf3 Compare April 8, 2025 08:14
@volodymyr-chekyrta volodymyr-chekyrta self-requested a review April 9, 2025 08:57
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/dates_page branch 3 times, most recently from 22e84d7 to b75448c Compare April 9, 2025 10:14
@PavloNetrebchuk PavloNetrebchuk marked this pull request as ready for review April 9, 2025 10:18
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/dates_page branch 2 times, most recently from 9345680 to c3843ea Compare December 4, 2025 15:26
@edschema edschema requested review from RawanMatar89 and removed request for RawanMatar89 December 26, 2025 18:08
@edschema
Copy link

Can I request some color changes?
left bar colors:
Past due: yellow (as shown), This week: Accent (blue), Next week: secondary dark, Future: light

Grouping Theme Color
Past Due Light warning (yellow)
Past Due Dark warning (yellow)
This week Light Accent (blue)
This week Dark Accent (blue)
Next week Light light dark (gray)
Next week Dark light dark (gray)
Upcoming Light light (lighter gray)
Upcoming Dark half dark (darker gray)

We can keep put these changes as a future change request too if absolutely necessary, but I think it's much easier to fix here.

@PavloNetrebchuk
Copy link
Contributor Author

@edschema Done 👍

@edschema
Copy link

edschema commented Jan 6, 2026

@PavloNetrebchuk after talking to @IvanStepanok I think we should keep the colors as you had them before the change I requested. I'm sorry for the back and forth!

@edschema edschema requested a review from RawanMatar89 January 6, 2026 16:07
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions Jan 22, 2026
Copy link

@RawanMatar89 RawanMatar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👏🏻
follows the Open Edx project style perfectly.
please just check the attached recording I faced two unexpected behaviour: first, the dates did not opened after tapping the date from dates tap. the second seems that the views pushed twice after tapping the date from dates tap.

overall LGTM thank you! ✅
Screen_recording_20260125_185453.webm

@SerializedName("grade_range") val gradeRange: Map<String, Float>?,
@SerializedName("assignment_colors") val assignmentColors: List<String>?
) {
// TODO Temporary solution. Backend will returns color list later

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still having these hardcoded colors I think we need to finish it asap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree with you, but unfortunately the backend is not ready yet

@PavloNetrebchuk
Copy link
Contributor Author

Hi @RawanMatar89, thanks for the feedback. I’ve fixed the second issue, but unfortunately I wasn’t able to reproduce the first one. My assumption is that the unit does open, but with a delay, since we need to fetch the course structure before navigating. I’ve already created a PR to optimize course structure loading, and I’m hoping it will help resolve this issue. Please check it after it’s merged.

@volodymyr-chekyrta volodymyr-chekyrta merged commit 5707e95 into openedx:develop Jan 26, 2026
6 checks passed
@volodymyr-chekyrta volodymyr-chekyrta deleted the feat/dates_page branch January 26, 2026 11:20
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants