Add a scrollbar when there are too many localized datasets #671
Conversation
|
I tested it and it does solve the issue. I get what you mean though when you say the end result still needs some work but at least I can get things done now :) One thing to note, these changes should also be made in package_dialog.ui for non-cloud projects! I did some testing on my side just replicating what you did here and it also fixes the issue. |
|
@suricactus , I did some more tweaking, I think we're there. Cloud project creation/conversion information panel: Package [non-cloud] project: I've removed the quite unhelpful "most location is /QField/basemaps" as this was never a true statement. Instead I propose we add a link to the localized datasets documentation page when we upgrade the content to take into account recent changes et al. |
| self.tr( | ||
| "The current project relies on datasets stored in localized data paths, make sure to copy the relevant datasets into the localized data path of devices running QField." | ||
| ) | ||
| + " " | ||
| + self.tr( | ||
| "The layer stored in a localized data path is:\n{}" | ||
| ).format("\n".join(localizedDataPathLayers)) |
There was a problem hiding this comment.
| self.tr( | |
| "The current project relies on datasets stored in localized data paths, make sure to copy the relevant datasets into the localized data path of devices running QField." | |
| ) | |
| + " " | |
| + self.tr( | |
| "The layer stored in a localized data path is:\n{}" | |
| ).format("\n".join(localizedDataPathLayers)) | |
| self.tr( | |
| "The current project relies on datasets stored in localized data paths, make sure to copy the relevant datasets into the localized data path of devices running QField." | |
| " " | |
| "The layer stored in a localized data path is:\n{}" | |
| ).format("\n".join(localizedDataPathLayers)) |
OR
| self.tr( | |
| "The current project relies on datasets stored in localized data paths, make sure to copy the relevant datasets into the localized data path of devices running QField." | |
| ) | |
| + " " | |
| + self.tr( | |
| "The layer stored in a localized data path is:\n{}" | |
| ).format("\n".join(localizedDataPathLayers)) | |
| self.tr( | |
| "The current project relies on datasets stored in localized data paths, make sure to copy the relevant datasets into the localized data path of devices running QField. \nThe layer stored in a localized data path is:\n{}" | |
| ).format("\n".join(localizedDataPathLayers)) |
Improves readability.
There was a problem hiding this comment.
I guess you tried to save a translatable string, I see this pattern multiple times across the code?
There was a problem hiding this comment.
I am not sure if we want to introduce the branching just because we support plural. In any of the other products we do not support plural properly, including QFieldSync, so we can stick to the trick I learned from you: "The layer(s) stored in localized data path are:\n{}", even if it is not great English.
There was a problem hiding this comment.
I guess you tried to save a translatable string, I see this pattern multiple times across the code?
Correct, I was trying to avoid a bit of sweat for our translation community :)
There was a problem hiding this comment.
Do you want it tweaked or shall we keep it as is to recycle what's already translated?
Attempt to fix #670 .
I am not super happy with the end result, if @nirvn has a better understanding how QSrollArea works, feel free to hijack the branch.