Skip to content

Facility is now open [...] but will open [...] #489

@homersimpsons

Description

@homersimpsons

I do not know if this should be considered a bug or a feature.

When using dates with public holidays such as Jul-Aug Mo-Su,PH 00:00-24:00 in France the display gives a slightly incorrect message:

Facility is now open, comment: "Fête nationale"
but will open tomorrow, 15 July, in 23 hours and 59 minutes, comment: undefined.

Image

While without public holidays such as Jul-Aug 00:00-24:00 in France the display gives a correct message:

Facility is now open
but will close 1 September, in 48 days.

Image

I believe the message should read differently when public holidays are in the contiguous open / close range. One suggestion is to have the exact same message as without the public holidays specifier. Or alternatively if we need to enphase the fact that public holiday is in the range we could have:

Facility is now open, and will remain open on ..., and will remain open on ..., but will close on ...

Notice that there could be multiple public holidays here in the range (for the above range there is July 14th and August 15th).

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: needs ownerThis issue is tentatively accepted pending a volunteer committed to its implementation.tag: good first issuetype: bugA confirmed report of unexpected behavior.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions