-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371226: Thread class description needs section on Thread Interruption #28216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/csr |
|
@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request. @AlanBateman please create a CSR request for issue JDK-8371226 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
Webrevs
|
viktorklang-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Alan!
liach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proofread the text, appears very straightforward.
pavelrappo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this and for taking on board my earlier suggestion from a core-libs-dev thread not to use "reset" when talking about re-asserting interrupted status. I can see that you chose "restore" instead. This is much better and matches, for example, "Java Concurrency in Practice".
src/java.base/share/classes/java/lang/InterruptedException.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/InterruptedException.java
Outdated
Show resolved
Hide resolved
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement.
pavelrappo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This is docs only change to a add a new section to the Thread class description on Thread Interruption. The new section provides guidance on handling InterruptedException. A subset of that guidance is also proposed for the InterruptedException class description.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28216/head:pull/28216$ git checkout pull/28216Update a local copy of the PR:
$ git checkout pull/28216$ git pull https://git.openjdk.org/jdk.git pull/28216/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28216View PR using the GUI difftool:
$ git pr show -t 28216Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28216.diff
Using Webrev
Link to Webrev Comment