Skip to content

8369692: JFR: Don't record thread metadata in case jdk.ThreadStart is disabled #28222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8369692: JFR: Don't record thread metadata in case jdk.ThreadStart is disabled #28222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/share/jfr/support/jfrThreadLocal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ void JfrThreadLocal::on_start(Thread* t) {
JfrCPUTimeThreadSampling::on_javathread_create(jt);
} else {
assert(jt->thread_state() == _thread_in_vm, "invariant");
if (tl->should_write()) {
if (EventThreadStart::is_enabled() && tl->should_write()) {
JfrCheckpointManager::write_checkpoint(t);
}
send_java_thread_start_event(jt);
Expand Down Expand Up @@ -252,7 +252,7 @@ void JfrThreadLocal::on_exit(Thread* t) {
} else {
JavaThread* const jt = JavaThread::cast(t);
assert(jt->thread_state() == _thread_in_vm, "invariant");
if (tl->should_write()) {
if (EventThreadEnd::is_enabled() && tl->should_write()) {
JfrCheckpointManager::write_checkpoint(t);
}
send_java_thread_end_event(jt, JfrThreadLocal::jvm_thread_id(jt));
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/jdk/jfr/jvm/TestWaste.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static void main(String... args) throws Exception {
.withoutStackTrace();
// Unused threads should not create unreasonable amount of waste
r.disable("jdk.ThreadStart");
r.disable("jdk.ThreadStop");
r.disable("jdk.ThreadEnd");
// jdk.GCPhaseParallel can often, but not always, take up a very
// large part of the recording. Disable to make test more stable
r.disable("jdk.GCPhaseParallel");
Expand Down