8371493: Simplify search for AdapterHandlerEntry

[ashu-mehra]

AdapterHandlerEntry stores a direct pointer to AdapterBlob. Therefore, when looking for a AdapterHandlerEntry corresponding to a CodeBlob, we can use direct comparison instead of using CodeCache::find_blob.
This patch also replaces the call to AdapterHandlerLibrary::contains in CodeBlob::dump_for_addr with a more trivial check is_adapter_blob.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371493: Simplify search for AdapterHandlerEntry (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28223/head:pull/28223
$ git checkout pull/28223

Update a local copy of the PR:
$ git checkout pull/28223
$ git pull https://git.openjdk.org/jdk.git pull/28223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28223

View PR using the GUI difftool:
$ git pr show -t 28223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28223.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371493: Simplify search for  AdapterHandlerEntry

Reviewed-by: kvn, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2910032: 8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572
• 76a1109: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out
• e1c9526: 8361339: Test gc/shenandoah/TestLargeObjectAlignment.java#generational fails on macOS aarch64 with OOM: Java heap space
• ... and 1 more: https://git.openjdk.org/jdk/compare/cc54d2c06b0e1f799c771d747cfb4059a8774e28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@ashu-mehra The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (311b08d9)

[vnkozlov]

Good.

[adinn]

Looks good.

[ashu-mehra]

@vnkozlov @adinn thanks for the reviews.

[ashu-mehra]

/integrate

[openjdk]

Going to push as commit bbeb6bf.
Since your change was applied there have been 7 commits pushed to the master branch:

• 405d5f7: 8371297: C2: assert triggered in BoolTest::BoolTest
• cbd77fc: 8370244: [PPC64] Several vector tests fail on Power8
• 2902436: 8371019: G1: Support heap expansion during startup
• ... and 4 more: https://git.openjdk.org/jdk/compare/cc54d2c06b0e1f799c771d747cfb4059a8774e28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ashu-mehra Pushed as commit bbeb6bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.