8371083: FollowReferences reports non-class objects as JVMTI_HEAP_REFERENCE_SYSTEM_CLASS #28224
+211
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FollowReferences with null initial_object starts heap walking from "heap roots", which include system classes.
All oops from ClassLoaderDataGraph are reported with JVMTI_HEAP_REFERENCE_SYSTEM_CLASS kind, but some of the objects are not classes.
The fix updates FollowReferences to report non-class objects from ClassLoaderDataGraph as JVMTI_HEAP_REFERENCE_OTHER
Testing: tier1..4,hs-tier5-svc
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28224/head:pull/28224$ git checkout pull/28224Update a local copy of the PR:
$ git checkout pull/28224$ git pull https://git.openjdk.org/jdk.git pull/28224/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28224View PR using the GUI difftool:
$ git pr show -t 28224Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28224.diff
Using Webrev
Link to Webrev Comment