8371625: G1: G1HeapRegion::print_on misalignment

[walulyai]

Hi,

Please review this fix to a misalignment in G1HeapRegion::print_on. Additionally, increased the field width for hrm_index as this also causes misalignment on large heaps.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371625: G1: G1HeapRegion::print_on misalignment (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28229/head:pull/28229
$ git checkout pull/28229

Update a local copy of the PR:
$ git checkout pull/28229
$ git pull https://git.openjdk.org/jdk.git pull/28229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28229

View PR using the GUI difftool:
$ git pr show -t 28229

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28229.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371625: G1: G1HeapRegion::print_on misalignment

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 2910032: 8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572
• 76a1109: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out
• e1c9526: 8361339: Test gc/shenandoah/TestLargeObjectAlignment.java#generational fails on macOS aarch64 with OOM: Java heap space
• ... and 61 more: https://git.openjdk.org/jdk/compare/1b3889a47092e018ab9ecb6aaa922046d8d0e916...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@walulyai The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (46dd7c34)

[walulyai]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 400a83d.
Since your change was applied there have been 74 commits pushed to the master branch:

• 76a0732: 8366691: JShell should support a more convenient completion
• 6df78c4: 8371065: C2 SuperWord: VTransformLoopPhiNode::apply setting type leads to assert/wrong result
• 15dcbf0: 8363950: Incorrect jtreg header in TestLayoutVsICU.java
• ... and 71 more: https://git.openjdk.org/jdk/compare/1b3889a47092e018ab9ecb6aaa922046d8d0e916...master

Your commit was automatically rebased without conflicts.

[openjdk]

@walulyai Pushed as commit 400a83d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.