8363950: Incorrect jtreg header in TestLayoutVsICU.java

[jayathirthrao]

TestLayoutVsICU was added when harfbuzz is integrated as default opentype layout engine under https://bugs.openjdk.org/browse/JDK-8143177 to replace ICU in JDK 9. ICU code is removed under https://bugs.openjdk.org/browse/JDK-8183978 in JDK 10. This test was used to manually check harfbuzz generated glyphs with already stored ICU one from the XML file.

This manual test has many dependencies to make it work and it is not documented properly. Harfbuzz has gone through many iterations of stabilization already. Since this test is almost a no-op we are planning to delete it. More details about history is in JBS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8363950: Incorrect jtreg header in TestLayoutVsICU.java (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28234/head:pull/28234
$ git checkout pull/28234

Update a local copy of the PR:
$ git checkout pull/28234
$ git pull https://git.openjdk.org/jdk.git pull/28234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28234

View PR using the GUI difftool:
$ git pr show -t 28234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28234.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363950: Incorrect jtreg header in TestLayoutVsICU.java

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• bbeb6bf: 8371493: Simplify search for AdapterHandlerEntry
• 405d5f7: 8371297: C2: assert triggered in BoolTest::BoolTest
• cbd77fc: 8370244: [PPC64] Several vector tests fail on Power8
• ... and 24 more: https://git.openjdk.org/jdk/compare/d570765e2720a11c88c806554df9b13587a041a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jayathirthrao The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7a58b008)

[jayathirthrao]

/integrate

[openjdk]

Going to push as commit 15dcbf0.
Since your change was applied there have been 30 commits pushed to the master branch:

• 8531fa1: 8358735: GenShen: block_start() may be incorrect after class unloading
• c6a8027: 8370154: Update @jls and @JVMS taglets to point to local specs dir
• f5eacbe: 8371534: C2: Missed Ideal optimization opportunity with AndL and URShiftL
• ... and 27 more: https://git.openjdk.org/jdk/compare/d570765e2720a11c88c806554df9b13587a041a2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jayathirthrao Pushed as commit 15dcbf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.