8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly

[elifaslan1]

Clean backport to make JDK-8319879 backporting cleaner. Ran Tier 1-2 on Al2, all passed. GHA tested as well.
The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test():

-XX:CompileCommand=RepeatCompilation,Test::test,1000

When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation).

---

Progress

• Change must not contain extraneous whitespace
• JDK-8311588 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4172/head:pull/4172
$ git checkout pull/4172

Update a local copy of the PR:
$ git checkout pull/4172
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4172

View PR using the GUI difftool:
$ git pr show -t 4172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4172.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 22fef0a: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests
• c9f4ceb: 8310915: Typo in aarch64.ad: "envcodings"
• 6d2e15c: 8294314: Minimize disabled warnings in hotspot
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/e3c50e1b14afde0d02d8d39b3ae8569c97d1855b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (447542c9)

[elifaslan1]

/approval request Clean backport to make JDK-8319879 backporting cleaner. Ran Tier 1-2 on Al2, all passed. GHA tested as well.
The compiler directive RepeatCompilation can be used to repeat compilations of specific methods, for example for Test::test():

-XX:CompileCommand=RepeatCompilation,Test::test,1000

When using this compiler directive in combination with StressIGVN/CCP/GCM/LCM, C2 only sets the stress seed once to a random value. Afterward, it keeps the seed for all repeated compilations. This should be changed to always select a random seed with each repetition (i.e. get the same behavior as the flag RepeatCompilation).

[openjdk]

@elifaslan1
8311588: The approval request has been created successfully.

[elifaslan1]

/integrate

[openjdk]

@elifaslan1
Your change (at version 447542c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit fadb26f.
Since your change was applied there have been 5 commits pushed to the master branch:

• 22fef0a: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests
• c9f4ceb: 8310915: Typo in aarch64.ad: "envcodings"
• 6d2e15c: 8294314: Minimize disabled warnings in hotspot
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/e3c50e1b14afde0d02d8d39b3ae8569c97d1855b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @elifaslan1 Pushed as commit fadb26f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.