Workspace.remove_folder performs the same deletion twice

[meymchen]

Component

pygls/workspace/workspace.py

Summary

remove_folder calls pop(..., None) and then immediately attempts del on the same key, which is entirely redundant. Both operations are attempted and two unquote calls are made for the same value.

Expected Behavior

A single removal operation.

Actual Behavior

Two removals and two unquote calls.

Affected Code (pygls/workspace/workspace.py, ~L211-216)

def remove_folder(self, folder_uri: str):
    self._folders.pop(unquote(folder_uri), None)
    try:
        del self._folders[unquote(folder_uri)]
    except KeyError:
        pass

Proposed Fix

Delete the del block; keep only the pop.

[meymchen]

Note: All issues submitted today were identified while maintaining an automated pipeline combining pygls, tree-sitter, and LLM. Any potential performance issue is critical for my use case.