Skip to content

Transformations Refactor #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pshriwise opened this issue May 29, 2025 · 2 comments
Open

Transformations Refactor #3422

pshriwise opened this issue May 29, 2025 · 2 comments

Comments

@pshriwise
Copy link
Contributor

Description

We have a few places where transformations are applied. These are currently serialized into XML and read into vectors on the C++ side. It would be nice at some point to create a class on the Python side for transformations that can be exported to an XML element (<transformation>) and a corresponding struct in C++ that holds the transformation values.

Alternatives

Leave it as-is. This isn't a huge priority, just an opportunity for improvement :)

Compatibility

This may cause compatibility issues, particularly on the Python side where these transformations are defined.

@gonuke
Copy link
Contributor

gonuke commented May 29, 2025

@connoramoreno - we sort of discussed this today...

@pshriwise
Copy link
Contributor Author

Noting here that it would probably be good to include a rotate_first option on these transformations to indicate the order of rotation/translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants