Don't calculate positioning for interior sounds, clean up unsused data

Author: SteelFill

Source/RunActivity/Viewer3D/ALSoundHelper.cs

@@ -650,9 +650,6 @@ public void InitPosition()
             {
                 OpenAL.alSourcei(SoundSourceID, OpenAL.AL_SOURCE_RELATIVE, OpenAL.AL_FALSE);
                 OpenAL.alSourcef(SoundSourceID, OpenAL.AL_DOPPLER_FACTOR, 1);
-
-                if (Car != null && !Car.SoundSourceIDs.Contains(SoundSourceID))
-                    Car.SoundSourceIDs.Add(SoundSourceID);
             }
         }
 
@@ -676,9 +673,6 @@ public void HardDeactivate()
         {
             if (SoundSourceID != -1)
             {
-                if (Car != null)
-                    Car.SoundSourceIDs.Remove(SoundSourceID);
-
                 Stop();
                 OpenAL.alDeleteSources(1, ref SoundSourceID);
                 SoundSourceID = -1;

Source/RunActivity/Viewer3D/RollingStock/TrainCarViewer.cs

@@ -64,7 +64,7 @@ internal virtual void LoadForPlayer() { }
 
         public void UpdateSoundPosition()
         {
-            if (Car.SoundSourceIDs.Count == 0 || Viewer.Camera == null)
+            if (Viewer.Camera == null)
                 return;
 
             if (Car.Train != null)

Source/RunActivity/Viewer3D/Sound.cs

@@ -1040,8 +1040,8 @@ public override bool Update()
             {
                 foreach (SoundStream stream in SoundStreams)
                 {
-                    // For train cars, calculate the position and velocity of the sound
-                    if (CarViewer != null)
+                    // For train cars, calculate the position and velocity of exterior sounds
+                    if (CarViewer != null && !Ignore3D)
                     {
                         // Convert position offset into train-car space offset
                         Vector3 pos = stream.MSTSStream.Position;
@@ -1060,7 +1060,7 @@ public override bool Update()
 
                         stream.Update(position, CarViewer.Velocity);
                     }
-                    else // Don't try to update position if CarViewer is missing
+                    else // Interior sounds ignore 3D position, do not try to update 3D position
                         stream.Update();
                     needsFrequentUpdate |= stream.NeedsFrequentUpdate;
                 }