fix: Move daylight offset entirely into Viewer

Author: twpol

Source/Orts.Simulation/Simulation/Weather.cs

@@ -108,9 +108,5 @@ public float WindInstantaneousDirectionRad
             get => (float)Math.Atan2(WindInstantaneousDirection.X, -WindInstantaneousDirection.Y);
             set => WindInstantaneousDirection = new Vector2((float)Math.Sin(value), -(float)Math.Cos(value));
         }
-
-        // FIXME: This is not a weather simulation field
-        // Daylight offset (-12h to +12h)
-        public int DaylightOffset = 0;
     }
 }

Source/RunActivity/Viewer3D/SkyInterpolation.cs

@@ -29,7 +29,7 @@ public class SkyInterpolation
         public int Step1;
         public int Step2;
 
-        static float DaylightOffsetS => (float)Program.Simulator.Weather.DaylightOffset * 60 * 60;
+        static float DaylightOffsetS => (float)Program.Viewer.World.WeatherControl.DaylightOffset * 60 * 60;
 
         public void SetSunAndMoonDirection(ref Vector3 solarDirection, ref Vector3 lunarDirection, Vector3[] solarPosArray, Vector3[] lunarPosArray, double clockTime)
         {

Source/RunActivity/Viewer3D/Weather.cs

@@ -60,6 +60,9 @@ public class WeatherControl
         private readonly float[,] DesertZones = { { 30, 45, -120, -105 } }; // minlat, maxlat, minlong, maxlong
         public float Time;
 
+        // Daylight offset (-12h to +12h)
+        public int DaylightOffset = 0;
+
         // Variables used for wind calculations
         const int WindSpeedBeaufort = 6;
         const float WindInstantaneousDirectionLimitRad = (float)(45 * Math.PI / 180);
@@ -537,16 +540,16 @@ public virtual void Update(ElapsedTime elapsedTime)
 
                 // Daylight offset is useful for debugging night running timetables; it ranges from -12h to +12h
                 string FormatDaylightOffsetHour(int h) => h <= 0 ? h.ToString() : $"+{h}";
-                if (UserInput.IsPressed(UserCommand.DebugDaylightOffsetIncrease) && Weather.DaylightOffset < 12)
+                if (UserInput.IsPressed(UserCommand.DebugDaylightOffsetIncrease) && DaylightOffset < 12)
                 {
-                    Weather.DaylightOffset += 1;
-                    Viewer.Simulator.Confirmer.Message(ConfirmLevel.None, Viewer.Catalog.GetStringFmt("Increased daylight offset to {0} h", FormatDaylightOffsetHour(Weather.DaylightOffset)));
+                    DaylightOffset += 1;
+                    Viewer.Simulator.Confirmer.Message(ConfirmLevel.None, Viewer.Catalog.GetStringFmt("Increased daylight offset to {0} h", FormatDaylightOffsetHour(DaylightOffset)));
                 }
 
-                if (UserInput.IsPressed(UserCommand.DebugDaylightOffsetDecrease) && Weather.DaylightOffset > -12)
+                if (UserInput.IsPressed(UserCommand.DebugDaylightOffsetDecrease) && DaylightOffset > -12)
                 {
-                    Weather.DaylightOffset -= 1;
-                    Viewer.Simulator.Confirmer.Message(ConfirmLevel.None, Viewer.Catalog.GetStringFmt("Decreased daylight offset to {0} h", FormatDaylightOffsetHour(Weather.DaylightOffset)));
+                    DaylightOffset -= 1;
+                    Viewer.Simulator.Confirmer.Message(ConfirmLevel.None, Viewer.Catalog.GetStringFmt("Decreased daylight offset to {0} h", FormatDaylightOffsetHour(DaylightOffset)));
                 }
 
                 UpdateWind(elapsedTime);