Fix a NullReferenceException in TCS scripts

pzgulyas · pzgulyas · commit 3a665975e596 · 2025-04-07T20:42:36.000+02:00
diff --git a/Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/TrainControlSystem.cs b/Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/TrainControlSystem.cs
@@ -670,9 +670,10 @@ SignalFeatures NextGenericSignalFeatures(string signalFunctionTypeName, int item
                     }
 
                     var functionHead = default(SignalHead);
-                    foreach (var head in trainSignal.SignalObject.SignalHeads)
-                        if (head.Function == function)
-                            functionHead = head;
+                    if (trainSignal?.SignalObject?.SignalHeads != null)
+                        foreach (var head in trainSignal.SignalObject.SignalHeads)
+                            if (head.Function == function)
+                                functionHead = head;
                     signalTypeName = functionHead.SignalTypeName;
                     foreach (var key in functionHead.signalType.DrawStates.Keys)
                     {

Original file line number	Diff line number	Diff line change
`@@ -670,9 +670,10 @@ SignalFeatures NextGenericSignalFeatures(string signalFunctionTypeName, int item`
`670`	`670`	`}`
`671`	`671`
`672`	`672`	`var functionHead = default(SignalHead);`
`673`		`- foreach (var head in trainSignal.SignalObject.SignalHeads)`
`674`		`- if (head.Function == function)`
`675`		`- functionHead = head;`
	`673`	`+ if (trainSignal?.SignalObject?.SignalHeads != null)`
	`674`	`+ foreach (var head in trainSignal.SignalObject.SignalHeads)`
	`675`	`+ if (head.Function == function)`
	`676`	`+ functionHead = head;`
`676`	`677`	`signalTypeName = functionHead.SignalTypeName;`
`677`	`678`	`foreach (var key in functionHead.signalType.DrawStates.Keys)`
`678`	`679`	`{`