Resolves review points

Author: cjakeman

Source/Menu/Notifications/NotificationManager.cs

@@ -1,4 +1,4 @@
-// COPYRIGHT 2009, 2010, 2011, 2012, 2013, 2014, 2015 by the Open Rails project.
+// COPYRIGHT 2009 - 2024 by the Open Rails project.
 // 
 // This file is part of Open Rails.
 // 
@@ -100,8 +100,8 @@ public void CheckNotifications()
                 CurrentPageIndex = 0;
                 Notifications = GetNotifications();
                 ParameterDictionary = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
-                
-                // To support testing, add any overriding values to the ValueDictionary
+
+                // To support testing, add any overriding values to the ParameterDictionary
                 GetOverrideParameters()?.ParameterValueList.ForEach(i => ParameterDictionary.Add(i.Parameter, i.Value));
                 LogOverrideParameters();
 
@@ -220,7 +220,7 @@ public void PopulatePage()
 
                 Page.NDetailList.Add(new NTitleControl(Panel, CurrentPageIndex + 1, list.Count, n.Date, n.Title));
 
-                // Check constraints foPageNoem
+                // Check criteria for each item and add the successful items to the current page
                 foreach (var item in n.ItemList)
                 {
                     if (AreItemChecksMet(item)) AddItemToPage(Page, item);
@@ -280,6 +280,11 @@ private bool AreNotificationChecksMet(Notification notification)
             return true;
         }
 
+        /// <summary>
+        ///  For the checks in the item, compares parameter values with criteria values
+        /// </summary>
+        /// <param name="item"></param>
+        /// <returns></returns>
         private bool AreItemChecksMet(Item item)
         {
             if (item.IncludeIf != null || item.IncludeIfNot != null)

Source/Menu/Notifications/Notifications.cs

@@ -1,4 +1,4 @@
-// COPYRIGHT 2009, 2010, 2011, 2012, 2013, 2014, 2015 by the Open Rails project.
+// COPYRIGHT 2009 - 2024 by the Open Rails project.
 // 
 // This file is part of Open Rails.
 // 
@@ -73,51 +73,29 @@ public class Item
         public string Color { get; set; } = "black";
         public int Indent { get; set; } = 140;
     }
-    //public class Met
-    //{
-    //    public List<Item> ItemList { get; set; }
-    //    public List<CheckId> CheckIdList { get; set; }
-    //}
-    //public class CheckId
-    //{
-    //    public string Id { get; set; }
-    //}
 
     public class Check
     {
         public string Id { get; set; }
         public List<AnyOf> AnyOfList { get; set; }
-        //public List<Item> UnmetItemList { get; set; }
     }
 
-    //public class CheckAllOf
-    //{
-    //    public List<Criteria> AllOfList { get; set; }
-    //}
     public class AnyOf
     {
         public List<Criteria> AllOfList { get; set; }
     }
 
-    //public class Excludes : CheckAllOf
-    //{
-    //}
-
-    //public class Includes : CheckAllOf
-    //{
-    //}
-
     class Contains : Criteria { }
     class NotContains : Criteria { }
 
-    // Not implemented yet
+    // Not implemented as not needed yet
     // String comparison, not numerical
     class NoLessThan : Criteria { }
     class NoMoreThan : Criteria { }
 
     public class Criteria
     {
-        // System Information "examples"
+                                                // System Information "examples"
         public string Property { get; set; }    // installed_version, direct3d, runtime, system, memory, cpu, gpu
         public string Value { get; set; }       // {{new_version}}, {{10_0}}
     }

Source/ORTS.Common/SystemInfo.cs

@@ -69,7 +69,7 @@ static SystemInfo()
             {
                 // Likely to catch multiple exceptions like:
                 // Exception thrown: 'System.IO.InvalidDataException' in ORTS.Menu.dll
-                //Trace.WriteLine(error);
+                Trace.WriteLine(error);
             }
 
             NativeMethods.GlobalMemoryStatusEx(MemoryStatusExtended);