Force "TrProfile" to be default profile, improve track profile selection

Author: SteelFill

Source/RunActivity/Viewer3D/DynamicTrack.cs

@@ -249,8 +249,8 @@ public class TRPFile
         //public RenderProcess RenderProcess; // TODO: Pass this along in function calls
 
         /// <summary>
-        /// Creates a TRPFile instance from a track profile file (XML or STF) or canned.
-        /// (Precedence is XML [.XML], STF [.DAT], default [canned]).
+        /// Creates a List<TRPFile></TRPFile> instance from a set of track profile file(s)
+        /// (XML or STF) or canned. (Precedence is XML [.XML], STF [.DAT], default [canned]).
         /// </summary>
         /// <param name="viewer">Viewer.</param>
         /// <param name="routePath">Path to route.</param>
@@ -263,14 +263,36 @@ public static void CreateTrackProfile(Viewer viewer, string routePath, out List<
 
             if (Directory.Exists(path))
             {
+                // The file called "TrProfile" should be used as the default track profile, if present
+                string xmlDefault = path + @"\TrProfile.xml";
+                string stfDefault = path + @"\TrProfile.stf";
+
+                if (File.Exists(xmlDefault))
+                {
+                    trpFiles.Add(new TRPFile(viewer, xmlDefault));
+                    profileNames.Add(Path.GetFileNameWithoutExtension(xmlDefault));
+                }
+                else if (File.Exists(stfDefault))
+                {
+                    trpFiles.Add(new TRPFile(viewer, stfDefault));
+                    profileNames.Add(Path.GetFileNameWithoutExtension(stfDefault));
+                }
+                else // Add the canned (Kuju) track profile if no default is given
+                    trpFiles.Add(new TRPFile(viewer, ""));
+
                 // Get all .xml/.stf files that start with "TrProfile"
                 string[] xmlProfiles = Directory.GetFiles(path, "TrProfile*.xml");
                 string[] stfProfiles = Directory.GetFiles(path, "TrProfile*.stf");
 
                 foreach (string xmlProfile in xmlProfiles)
                 {
-                    trpFiles.Add(new TRPFile(viewer, xmlProfile));
-                    profileNames.Add(Path.GetFileNameWithoutExtension(xmlProfile));
+                    string xmlName = Path.GetFileNameWithoutExtension(xmlProfile);
+                    // Don't try to add the default track profile twice
+                    if (!profileNames.Contains(xmlName))
+                    {
+                        trpFiles.Add(new TRPFile(viewer, xmlProfile));
+                        profileNames.Add(xmlName);
+                    }
                 }
                 foreach (string stfProfile in stfProfiles)
                 {
@@ -284,7 +306,7 @@ public static void CreateTrackProfile(Viewer viewer, string routePath, out List<
                 }
             }
 
-            // Add default profile only if no other profiles were added
+            // Add canned profile if no profiles were found
             if (trpFiles.Count <= 0)
                 trpFiles.Add(new TRPFile(viewer, ""));
 

Source/RunActivity/Viewer3D/Scenery.cs

@@ -678,28 +678,30 @@ public static int GetBestTrackProfile(Viewer viewer, SharedShape shape)
                 TRPFile.CreateTrackProfile(viewer, viewer.Simulator.RoutePath, out viewer.TRPs);
             }
 
-            float score = 0;
+            float score = float.NegativeInfinity;
             int bestIndex = -1;
             for (int i = 0; i < viewer.TRPs.Count; i++)
             {
-                
                 float prevScore = score;
+                score = 0;
                 // Default behavior: Attempt to match track shape to track profile using texture names alone
                 foreach (string image in viewer.TRPs[i].TrackProfile.Images)
                 {
                     if (shape.ImageNames.Contains(image, StringComparer.InvariantCultureIgnoreCase))
                         score++;
-                    else // Slight bias to prefer track profiles with more textures defined
-                        score += 0.05f;
+                    else // Slight bias against track profiles with extra textures defined
+                        score -= 0.05f;
                 }
                 foreach (string image in shape.ImageNames)
                 {
-                    // Bias against track profiles that are missing textures
+                    // Strong bias against track profiles that are missing textures
                     if (!viewer.TRPs[i].TrackProfile.Images.Contains(image, StringComparer.InvariantCultureIgnoreCase))
                         score -= 0.25f;
                 }
                 if (score > prevScore)
                     bestIndex = i;
+                else
+                    score = prevScore;
             }
 
             if (bestIndex < 0)