Skip to content

Commit a5e13ed

Browse files
committed
refactor: Separate common value property for notification items
1 parent 25a098f commit a5e13ed

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

Source/Menu/Notifications/Notifications.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,8 @@ public class Notification
3535
public List<string> IncludeIfNot { get; set; }
3636
public List<Item> ItemList { get; set; }
3737
}
38-
class Record : Item
38+
class Record : ValueItem
3939
{
40-
public string Value { get; set; }
4140
}
4241
class Text : Item
4342
{
@@ -46,25 +45,26 @@ class Heading : Item
4645
{
4746
public new string Color { get; set; } = "blue";
4847
}
49-
class Link : Item
48+
class Link : ValueItem
5049
{
51-
public string Value { get; set; }
5250
public string Url { get; set; }
5351
public string StableUrl { get; set; }
5452
public string TestingUrl { get; set; }
5553
public string UnstableUrl { get; set; }
5654
}
57-
class Dialog : Item
55+
class Dialog : ValueItem
5856
{
59-
public string Value { get; set; }
6057
public string Form { get; set; }
6158
}
62-
class Update : Item
59+
class Update : ValueItem
6360
{
64-
public string Value { get; set; }
6561
public string UpdateMode { get; set; }
6662
}
67-
public class Item
63+
abstract class ValueItem : Item
64+
{
65+
public string Value { get; set; }
66+
}
67+
public abstract class Item
6868
{
6969
public List<string> IncludeIf { get; set; }
7070
public List<string> IncludeIfNot { get; set; }
@@ -110,13 +110,13 @@ public abstract class Criteria
110110
public abstract bool IsMatch();
111111
}
112112

113-
public class ParameterValue
113+
class ParameterValue
114114
{
115115
public string Parameter { get; set; } // installed_version, direct3d, runtime, system, memory, cpu, gpu
116116
public string Value { get; set; } // {{new_version}}, {{10_0}}
117117
}
118118

119-
public class OverrideParameterList
119+
class OverrideParameterList
120120
{
121121
public List<ParameterValue> ParameterValueList = new List<ParameterValue>();
122122
}

0 commit comments

Comments
 (0)