fix: Capture all notification errors to avoid broken state

twpol · twpol · commit ab10d1a4ec3d · 2025-01-18T14:19:40.000Z
diff --git a/Source/Menu/Notifications/NotificationManager.cs b/Source/Menu/Notifications/NotificationManager.cs
@@ -1,4 +1,4 @@
-﻿// COPYRIGHT 2009 - 2024 by the Open Rails project.
+// COPYRIGHT 2009 - 2024 by the Open Rails project.
 // 
 // This file is part of Open Rails.
 // 
@@ -126,7 +126,7 @@ public void CheckNotifications()
                 Notifications.NotificationList = IncludeValid(Notifications.NotificationList);
                 Notifications.NotificationList = SortByDate(Notifications.NotificationList);
             }
-            catch (WebException ex)
+            catch (Exception ex)
             {
                 Error = ex;
             }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// COPYRIGHT 2009 - 2024 by the Open Rails project.`
	`1`	`+// COPYRIGHT 2009 - 2024 by the Open Rails project.`
`2`	`2`	`//`
`3`	`3`	`// This file is part of Open Rails.`
`4`	`4`	`//`
`@@ -126,7 +126,7 @@ public void CheckNotifications()`
`126`	`126`	`Notifications.NotificationList = IncludeValid(Notifications.NotificationList);`
`127`	`127`	`Notifications.NotificationList = SortByDate(Notifications.NotificationList);`
`128`	`128`	`}`
`129`		`- catch (WebException ex)`
	`129`	`+ catch (Exception ex)`
`130`	`130`	`{`
`131`	`131`	`Error = ex;`
`132`	`132`	`}`