After tidying

Author: cjakeman

Source/Menu/Notifications/NotificationManager.cs

@@ -51,9 +51,9 @@ class NotificationManager
         private Exception Error;
         private Dictionary<string, string> ParameterDictionary;
 
-        private MainForm MainForm; // Needed so we can add controls to the NotificationPage
-        private UpdateManager UpdateManager;
-        private UserSettings Settings;
+        private readonly MainForm MainForm; // Needed so we can add controls to the NotificationPage
+        private readonly UpdateManager UpdateManager;
+        private readonly UserSettings Settings;
 
         public NotificationManager(MainForm mainForm, UpdateManager updateManager, UserSettings settings) 
         { 
@@ -88,7 +88,7 @@ public void CheckNotifications()
         }
 
         static bool Log = false;
-        static string LogFile = "notifications_trial_log.txt";
+        const string LogFile = "notifications_trial_log.txt";
 
         public Notifications GetNotifications()
         {
@@ -302,7 +302,7 @@ private void AddItemToPage(NotificationPage page, Item item)
             {
                 new NTextControl(page, item.Label, text.Color).Add();
             }
-            else if (item is Item item2)
+            else
             {
                 new NTextControl(page, item.Label).Add();
             }
@@ -386,7 +386,7 @@ private string ReplaceParameter(string field)
             var parameterArray = field.Split('{', '}'); // 5 elements: prefix, "", target, "", suffix
             var target = parameterArray[2];
             var lowerCaseTarget = parameterArray[2].ToLower();
-            var replacement = parameterArray[2]; // Default is original text
+            string replacement;
 
             // If found in dictionary, then use that else extract it from program
             if (ParameterDictionary.ContainsKey(lowerCaseTarget))

Source/Menu/Notifications/Notifications.cs

@@ -48,7 +48,7 @@ class Text : Item
     }
     class Heading : Item
     {
-        new public string Color { get; set; } = "blue";
+        public new string Color { get; set; } = "blue";
     }
     class Link : Item
     {