diff --git a/src/main/java/org/opensearch/security/privileges/UserAttributes.java b/src/main/java/org/opensearch/security/privileges/UserAttributes.java index 14655ea8f5..e5419c600d 100644 --- a/src/main/java/org/opensearch/security/privileges/UserAttributes.java +++ b/src/main/java/org/opensearch/security/privileges/UserAttributes.java @@ -10,12 +10,9 @@ */ package org.opensearch.security.privileges; -import java.util.ArrayList; -import java.util.Collections; import java.util.List; import java.util.Map; import java.util.Set; -import java.util.regex.Matcher; import java.util.regex.Pattern; import com.google.common.base.Joiner; @@ -41,12 +38,7 @@ public static boolean needsAttributeSubstitution(String patternString) { * in {@code s} after substitution has been performed. */ public static List findUnresolvedAttributes(String s) { - List result = new ArrayList<>(); - Matcher matcher = UNRESOLVED_ATTRIBUTE_PATTERN.matcher(s); - while (matcher.find()) { - result.add(matcher.group(1)); - } - return Collections.unmodifiableList(result); + return UNRESOLVED_ATTRIBUTE_PATTERN.matcher(s).results().map(m -> m.group(1)).toList(); } public static String replaceProperties(String orig, PrivilegesEvaluationContext context) {