diff --git a/scripts/src/submission/submission.py b/scripts/src/submission/submission.py index a0aaab77..b7f79f72 100644 --- a/scripts/src/submission/submission.py +++ b/scripts/src/submission/submission.py @@ -307,6 +307,10 @@ def parse_modified_files(self): * The tarball file is named incorrectly """ + if not self.modified_files: + msg = "PR doesn't contain any files" + raise SubmissionError(msg) + for file_path in self.modified_files: file_category, match = get_file_type(file_path) if file_category == "report": diff --git a/scripts/src/submission/submission_test.py b/scripts/src/submission/submission_test.py index 45f32a60..ac6e7250 100644 --- a/scripts/src/submission/submission_test.py +++ b/scripts/src/submission/submission_test.py @@ -237,6 +237,12 @@ class SubmissionInitScenario: ], excepted_exception=pytest.raises(submission.ChartError), ), + # Invalid PR doesn't contain any files + SubmissionInitScenario( + api_url="https://api.github.com/repos/openshift-helm-charts/charts/pulls/103", + modified_files=[], + excepted_exception=pytest.raises(submission.SubmissionError), + ), ]