Skip to content

Fix exception hierarchy #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgoerens merged 1 commit into from
Oct 21, 2025
Merged

Fix exception hierarchy #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/src/submission/submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class ReleaseTagError(SubmissionError):
pass


class ChartError(Exception):
class ChartError(SubmissionError):
pass


Expand Down Expand Up @@ -238,7 +238,7 @@ class Submission:
def __post_init__(self):
"""Complete the initialization of the Submission object.

Only retrieve PR information from the GitHub API if requiered, by checking for the presence
Only retrieve PR information from the GitHub API if required, by checking for the presence
of a value for the modified_files attributes. This check allows to make the distinction
between the two aforementioned cases of initialization of a Submission object:
* If modified_files is not set, we're in the case of initializing a brand new Submission
Expand Down