Merge pull request #862 from tchap/remove-cloud-provider-external

WRKLDS-1556: Remove --cloud-provider=external from KCM

Author: openshift-merge-bot[bot]

bindata/assets/config/defaultconfig.yaml

@@ -29,8 +29,6 @@ extendedArguments:
   # Most upstream clusters don't care about SELinux, therefore this controller is opt-in. OCP cares.
   # Owner: OCP storage team, @jsafrane.
   - "selinux-warning-controller"
-  cloud-provider:
-    - "external"
   cluster-signing-duration:
   - "720h"
   secure-port:

pkg/cmd/render/render_test.go

@@ -181,7 +181,6 @@ func TestRenderCommand(t *testing.T) {
 						"--authentication-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--authorization-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--cert-dir=/var/run/kubernetes",
-						"--cloud-provider=external",
 						"--cluster-signing-cert-file=/etc/kubernetes/secrets/kubelet-signer.crt",
 						"--cluster-signing-duration=720h",
 						"--cluster-signing-key-file=/etc/kubernetes/secrets/kubelet-signer.key",
@@ -261,7 +260,6 @@ func TestRenderCommand(t *testing.T) {
 						"--authentication-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--authorization-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--cert-dir=/var/run/kubernetes",
-						"--cloud-provider=external",
 						"--cluster-signing-cert-file=/etc/kubernetes/secrets/kubelet-signer.crt",
 						"--cluster-signing-duration=720h",
 						"--cluster-signing-key-file=/etc/kubernetes/secrets/kubelet-signer.key",
@@ -327,7 +325,6 @@ func TestRenderCommand(t *testing.T) {
 						"--authentication-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--authorization-kubeconfig=/etc/kubernetes/secrets/kubeconfig",
 						"--cert-dir=/var/run/kubernetes",
-						"--cloud-provider=external",
 						"--cluster-signing-cert-file=/etc/kubernetes/secrets/kubelet-signer.crt",
 						"--cluster-signing-duration=720h",
 						"--cluster-signing-key-file=/etc/kubernetes/secrets/kubelet-signer.key",