OCPBUGS-52853: Do not add iommu.passthrough to ARM by default (#1354)

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>

Author: jmencak

assets/performanceprofile/tuned/openshift-node-performance-arm-aarch64

@@ -5,5 +5,3 @@ summary=Platform specific tuning for aarch64
 # No cstate for ARM
 # No pstate args for ARM
 
-# aarch64 specific tuning options
-cmdline_iommu_arm=iommu.passthrough=1

pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned_test.go

@@ -645,12 +645,6 @@ var _ = Describe("Tuned", func() {
 				Expect(err).ToNot(HaveOccurred())
 				Expect(bootloaderSection.Key("cmdline_pstate").String()).To(Equal(""))
 			})
-			It("should set iommu passthrough", func() {
-				tunedData := getTunedStructuredData(profile, components.ProfileNameArmAarch64)
-				bootloaderSection, err := tunedData.GetSection("bootloader")
-				Expect(err).ToNot(HaveOccurred())
-				Expect(bootloaderSection.Key("cmdline_iommu_arm").String()).To(Equal("iommu.passthrough=1"))
-			})
 		})
 	})
 

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-master_tuned.yaml

@@ -84,16 +84,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-openshift-bootstrap-master
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-openshift-bootstrap-master
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-worker_tuned.yaml

@@ -84,16 +84,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-openshift-bootstrap-worker
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-openshift-bootstrap-worker
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-master_tuned.yaml

@@ -84,16 +84,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-openshift-bootstrap-master
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-openshift-bootstrap-master
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-worker_tuned.yaml

@@ -84,16 +84,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-openshift-bootstrap-worker
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-openshift-bootstrap-worker
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/default/arm/manual_tuned.yaml

@@ -83,16 +83,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-manual
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-manual
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/default/cpuFrequency/manual_tuned.yaml

@@ -84,16 +84,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-manual
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-manual
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/default/manual_tuned.yaml

@@ -85,16 +85,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-manual
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-manual
   - data: |+
       [main]

test/e2e/performanceprofile/testdata/render-expected-output/default/pp-norps/manual_tuned.yaml

@@ -85,16 +85,14 @@ spec:
 
 
     name: openshift-node-performance-amd-x86-manual
-  - data: |
+  - data: |+
       [main]
       summary=Platform specific tuning for aarch64
 
       [bootloader]
       # No cstate for ARM
       # No pstate args for ARM
 
-      # aarch64 specific tuning options
-      cmdline_iommu_arm=iommu.passthrough=1
     name: openshift-node-performance-arm-aarch64-manual
   - data: |+
       [main]