Skip to content

Commit 9b4ad8d

Browse files
committed
Add startup_udev_settle_wait option option to tunedConfig
The new startup_udev_settle_wait TuneD global option has recently been added to /etc/tuned/tuned-main.conf. This option should help in situations where there are a lot of udev events during TuneD startup and TuneD is too slow to handle them. Users may want/need to adjust this period or completely disable this functionality. Other changes: - fix the logic when reapply_sysctl is undefined in /etc/tuned/tuned-main.conf Also see: OCPBUGS-56442, OCPBUGS-57470
1 parent df3b43e commit 9b4ad8d

File tree

29 files changed

+331
-323
lines changed

29 files changed

+331
-323
lines changed

manifests/20-profile.crd.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,12 @@ spec:
7878
type: object
7979
properties:
8080
reapply_sysctl:
81-
description: 'turn reapply_sysctl functionality on/off for the TuneD daemon: true/false'
81+
description: 'turn reapply_sysctl functionality on/off for the TuneD daemon: true/false (default is true)'
8282
type: boolean
83+
startup_udev_settle_wait:
84+
description: 'configure startup_udev_settle_wait timeout functionality for the TuneD daemon: unsigned integer (default is 20)'
85+
type: integer
86+
format: int64
8387
tunedProfile:
8488
description: TuneD profile to apply
8589
type: string

manifests/20-tuned.crd.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,14 @@ spec:
144144
properties:
145145
reapply_sysctl:
146146
description: 'turn reapply_sysctl functionality on/off
147-
for the TuneD daemon: true/false'
147+
for the TuneD daemon: true/false (default is true)'
148148
type: boolean
149+
startup_udev_settle_wait:
150+
description: 'configure startup_udev_settle_wait timeout
151+
functionality for the TuneD daemon: unsigned integer
152+
(default is 20)'
153+
format: int64
154+
type: integer
149155
type: object
150156
verbosity:
151157
description: klog logging verbosity

pkg/apis/tuned/v1/tuned_types.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,12 @@ type OperandConfig struct {
128128

129129
// Global configuration for the TuneD daemon as defined in tuned-main.conf
130130
type TuneDConfig struct {
131-
// turn reapply_sysctl functionality on/off for the TuneD daemon: true/false
131+
// turn reapply_sysctl functionality on/off for the TuneD daemon: true/false (default is true)
132132
// +optional
133133
ReapplySysctl *bool `json:"reapply_sysctl"`
134+
// configure startup_udev_settle_wait timeout functionality for the TuneD daemon: unsigned integer (default is 20)
135+
// +optional
136+
StartupUdevSettleWait *uint64 `json:"startup_udev_settle_wait"`
134137
}
135138

136139
// TunedStatus is the status for a Tuned resource.

pkg/apis/tuned/v1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/clientset.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/typed/tuned/v1/fake/fake_profile.go

Lines changed: 19 additions & 118 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/typed/tuned/v1/fake/fake_tuned.go

Lines changed: 19 additions & 118 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/typed/tuned/v1/fake/fake_tuned_client.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)