Skip to content

Commit a0ccadb

Browse files
committed
Skip llc tests on Virtual Machines
Skipping LLC tests on virtual machines as these dont have uncore cache similar to Baremetal systems Signed-off-by: Niranjan M.R <mniranja@redhat.com>
1 parent 76833c9 commit a0ccadb

File tree

1 file changed

+8
-1
lines changed
  • test/e2e/performanceprofile/functests/13_llc

1 file changed

+8
-1
lines changed

test/e2e/performanceprofile/functests/13_llc/llc.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import (
4141
testclient "github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/client"
4242
"github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/deployments"
4343
"github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/images"
44+
"github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/infrastructure"
4445
"github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/label"
4546
testlog "github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/log"
4647
"github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/mcps"
@@ -116,7 +117,13 @@ var _ = Describe("[rfe_id:77446] LLC-aware cpu pinning", Label(string(label.Open
116117
if len(workerRTNodes) < 1 {
117118
Skip("need at least a worker node")
118119
}
119-
120+
for _, cnfnode := range workerRTNodes {
121+
isVM, err := infrastructure.IsVM(context.TODO(), &cnfnode)
122+
Expect(err).ToNot(HaveOccurred(), "Failed to detect if the node is based on VM")
123+
if isVM {
124+
Skip("System is Virtual Machine - LLC tests are applicable only on Baremetal")
125+
}
126+
}
120127
perfProfile, err = profiles.GetByNodeLabels(testutils.NodeSelectorLabels)
121128
Expect(err).ToNot(HaveOccurred())
122129
initialProfile = perfProfile.DeepCopy()

0 commit comments

Comments
 (0)