Do not cause kubelet failed dependency by ocp-tuned-one-shot.service

Change #1045 introduced systemd ocp-tuned-one-shot.service unit which
runs and blocks kubelet.  This service is important for reducing the
number of Inter-processor interrupts interfering with low-latency
workloads.

In order to minimize the number of reboots, ocp-tuned-one-shot.service
uses an environment file which references NTO image from the release
payload.  This way the unit file does not need to change when the
release payload changes thus lowering the number of reboots due to lower
number of MachineConfig changes.

Unfortunately, this is not a good solution.  Sometimes, the
ocp-tuned-one-shot.service needs to be changed.  When it needs to be
changed and a power cut or a reboot happens between the time the
environment file changes and the MachineConfig of the
ocp-tuned-one-shot.service unit is updated, the
ocp-tuned-one-shot.service may fail thus causing a failed dependency for
the kubelet.

Until we find to merge these machine configs into one or stop MCO treating
these machine configs as separate, make the ocp-tuned-one-shot.service
always succeed.

Resolves: OCPBUGS-62940

Author: jmencak

assets/performanceprofile/configs/ocp-tuned-one-shot.service

@@ -18,7 +18,7 @@ RestartSec=5s
 ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
 ExecStartPre=/bin/bash -c " \
   mkdir -p /run/tuned "
-ExecStart=/usr/bin/podman run \
+ExecStart=-/usr/bin/podman run \
     --rm \
     --name openshift-tuned \
     --privileged \
@@ -40,6 +40,7 @@ ExecStart=/usr/bin/podman run \
     --volume /sys:/sys:rslave \
     --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
     $NTO_IMAGE
+ExecStart=/usr/bin/true
 Environment=PODMAN_SYSTEMD_UNIT=%n
 EnvironmentFile=/etc/mco/proxy.env
 EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-master_machineconfig.yaml

@@ -157,7 +157,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -179,6 +179,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-worker_machineconfig.yaml

@@ -157,7 +157,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -179,6 +179,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-master_machineconfig.yaml

@@ -157,7 +157,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -179,6 +179,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-worker_machineconfig.yaml

@@ -157,7 +157,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -179,6 +179,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/default/arm/manual_machineconfig.yaml

@@ -174,7 +174,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -196,6 +196,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/default/cpuFrequency/manual_machineconfig.yaml

@@ -159,7 +159,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -181,6 +181,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/default/manual_machineconfig.yaml

@@ -175,7 +175,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -197,6 +197,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/default/pp-norps/manual_machineconfig.yaml

@@ -175,7 +175,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -197,6 +197,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env

test/e2e/performanceprofile/testdata/render-expected-output/no-ref/manual_machineconfig.yaml

@@ -174,7 +174,7 @@ spec:
           ExecReload=/bin/pkill --signal HUP --pidfile /run/tuned/tuned.pid
           ExecStartPre=/bin/bash -c " \
             mkdir -p /run/tuned "
-          ExecStart=/usr/bin/podman run \
+          ExecStart=-/usr/bin/podman run \
               --rm \
               --name openshift-tuned \
               --privileged \
@@ -196,6 +196,7 @@ spec:
               --volume /sys:/sys:rslave \
               --entrypoint '["/usr/bin/cluster-node-tuning-operator","ocp-tuned","--in-cluster=false","--one-shot=true","-v=1"]' \
               $NTO_IMAGE
+          ExecStart=/usr/bin/true
           Environment=PODMAN_SYSTEMD_UNIT=%n
           EnvironmentFile=/etc/mco/proxy.env
           EnvironmentFile=-/var/lib/ocp-tuned/image.env