From 247c83f36f6aa4aa2771ad59202ed0979af0fe00 Mon Sep 17 00:00:00 2001 From: stefanonardo Date: Tue, 24 Mar 2026 10:10:58 +0100 Subject: [PATCH] Migrate LogSnippet to PatternFly component --- .../console-shared/src/components/index.ts | 1 - .../src/components/log/LogSnippet.scss | 15 --------------- .../src/components/log/LogSnippet.tsx | 19 ------------------- .../src/components/log/index.ts | 1 - .../src/components/workload/BuildOverview.tsx | 11 +++++++++-- 5 files changed, 9 insertions(+), 38 deletions(-) delete mode 100644 frontend/packages/console-shared/src/components/log/LogSnippet.scss delete mode 100644 frontend/packages/console-shared/src/components/log/LogSnippet.tsx delete mode 100644 frontend/packages/console-shared/src/components/log/index.ts diff --git a/frontend/packages/console-shared/src/components/index.ts b/frontend/packages/console-shared/src/components/index.ts index c1fdd23fe00..4e888460b55 100644 --- a/frontend/packages/console-shared/src/components/index.ts +++ b/frontend/packages/console-shared/src/components/index.ts @@ -5,7 +5,6 @@ export * from './form-utils'; export * from './formik-fields'; export * from './getting-started'; export * from './lists'; -export * from './log'; export * from './status'; export * from './pod'; export * from './popper'; diff --git a/frontend/packages/console-shared/src/components/log/LogSnippet.scss b/frontend/packages/console-shared/src/components/log/LogSnippet.scss deleted file mode 100644 index f4d017718c5..00000000000 --- a/frontend/packages/console-shared/src/components/log/LogSnippet.scss +++ /dev/null @@ -1,15 +0,0 @@ -.ocs-log-snippet { - border-left: 2px solid var(--pf-t--global--border--color--status--danger--default); - display: flex; - flex-direction: column; - margin-left: 6px; - padding: 10px 0 10px 13px; - - &__status-message { - margin-bottom: 10px; - } - - &__log-snippet { - margin: 0; - } -} diff --git a/frontend/packages/console-shared/src/components/log/LogSnippet.tsx b/frontend/packages/console-shared/src/components/log/LogSnippet.tsx deleted file mode 100644 index 2674bdd1f71..00000000000 --- a/frontend/packages/console-shared/src/components/log/LogSnippet.tsx +++ /dev/null @@ -1,19 +0,0 @@ -import type { FC } from 'react'; - -import './LogSnippet.scss'; - -type LogSnippetProps = { - logSnippet?: string; - message: string; -}; - -const LogSnippet: FC = ({ logSnippet, message }) => { - return ( -
-

{message}

- {logSnippet &&
{logSnippet}
} -
- ); -}; - -export default LogSnippet; diff --git a/frontend/packages/console-shared/src/components/log/index.ts b/frontend/packages/console-shared/src/components/log/index.ts deleted file mode 100644 index e2c0af2e4d3..00000000000 --- a/frontend/packages/console-shared/src/components/log/index.ts +++ /dev/null @@ -1 +0,0 @@ -export { default as LogSnippet } from './LogSnippet'; diff --git a/frontend/packages/topology/src/components/workload/BuildOverview.tsx b/frontend/packages/topology/src/components/workload/BuildOverview.tsx index 5726a2adfd9..fc4772cf64e 100644 --- a/frontend/packages/topology/src/components/workload/BuildOverview.tsx +++ b/frontend/packages/topology/src/components/workload/BuildOverview.tsx @@ -1,4 +1,5 @@ import type { FC } from 'react'; +import { LogSnippet } from '@patternfly/react-component-groups'; import { Button, List, ListItem } from '@patternfly/react-core'; import { SyncAltIcon } from '@patternfly/react-icons/dist/esm/icons/sync-alt-icon'; import { Trans, useTranslation } from 'react-i18next'; @@ -19,7 +20,7 @@ import type { K8sResourceKind } from '@console/internal/module/k8s'; import { referenceFor } from '@console/internal/module/k8s'; import { BuildPhase, startBuild } from '@console/internal/module/k8s/builds'; import type { BuildConfigOverviewItem } from '@console/shared'; -import { LogSnippet, Status } from '@console/shared'; +import { Status } from '@console/shared'; import './BuildOverview.scss'; const MAX_VISIBLE = 3; @@ -83,7 +84,13 @@ const BuildStatus = ({ build }: { build: K8sResourceKind }) => { status: { logSnippet, message, phase }, } = build; const unsuccessful = [BuildPhase.Error, BuildPhase.Failed].includes(phase); - return unsuccessful ? : null; + return unsuccessful ? ( + {message}

} + logSnippet={logSnippet} + /> + ) : null; }; const BuildOverviewItem: FC = ({ build }) => {