fix insecure

Author: jcpowermac

pkg/controller/vsphere/session/session.go

@@ -18,6 +18,7 @@ package session
 
 import (
 	"context"
+	"crypto/tls"
 	"errors"
 	"fmt"
 	"io"
@@ -159,7 +160,7 @@ func newClientWithTimeout(ctx context.Context, u *url.URL, insecure bool, timeou
 	*/
 
 	customTransport := &CustomTransport{
-		RoundTripper: http.DefaultTransport,
+		RoundTripper: createTransport(insecure),
 	}
 
 	soapClient := soap.NewClient(u, insecure)
@@ -182,7 +183,6 @@ func newClientWithTimeout(ctx context.Context, u *url.URL, insecure bool, timeou
 	if err != nil {
 		log.Fatalf("Failed to login to vSphere: %v", err)
 	}
-	defer client.Logout(clientCreateCtx)
 
 	// Create SOAP client with custom transport
 	//client.Transport = customTransport
@@ -363,3 +363,18 @@ func (s *Session) WithCachingTagsManager(ctx context.Context, f func(m *CachingT
 
 	return f(m)
 }
+
+// createTransport creates a transport that respects the insecure flag
+func createTransport(insecure bool) http.RoundTripper {
+	if insecure {
+		// Create a transport that skips TLS verification
+		transport := &http.Transport{
+			TLSClientConfig: &tls.Config{
+				InsecureSkipVerify: true,
+			},
+		}
+		return transport
+	}
+	// Use default transport for secure connections
+	return http.DefaultTransport
+}