From c9f065b4bab896310e74772eb70935438aff170b Mon Sep 17 00:00:00 2001 From: Hiroyuki Wada Date: Sat, 14 Jun 2025 23:44:48 +0900 Subject: [PATCH] fix: use lowercase 't' in Content-type header to prevent GitHub API override Change HEADER_CONTENT_TYPE from "Content-Type" to "Content-type" to avoid being overwritten by GitHub API client's default Content-Type handling. --- src/main/java/org/kohsuke/github/SCIMConstants.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/SCIMConstants.java b/src/main/java/org/kohsuke/github/SCIMConstants.java index cfe5816..8ffaaf3 100644 --- a/src/main/java/org/kohsuke/github/SCIMConstants.java +++ b/src/main/java/org/kohsuke/github/SCIMConstants.java @@ -11,7 +11,9 @@ public final class SCIMConstants { public static final String SCIM_ACCEPT = "application/scim+json"; public static final String GITHUB_API_VERSION = "2022-11-28"; - public static final String HEADER_CONTENT_TYPE = "Content-Type"; + // Be careful, as it will be overwritten by the following if we use Content-Type. + // https://github.com/hub4j/github-api/blob/github-api-1.122/src/main/java/org/kohsuke/github/GitHubHttpUrlConnectionClient.java#L141-L142 + public static final String HEADER_CONTENT_TYPE = "Content-type"; public static final String HEADER_ACCEPT = "Accept"; public static final String HEADER_API_VERSION = "X-GitHub-Api-Version";