Skip to content

fix: get close tab shortcut from key-binding-registry #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

fix: get close tab shortcut from key-binding-registry #4606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df6f8d
fix: get close tab shortcut from key-binding-registry
Jul 18, 2025
e0b8a53
:bug: lint err of import order
Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/design/src/browser/override/editor-tab.service.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import cls from 'classnames';
import React, { ReactNode, useCallback, useMemo } from 'react';

import { Autowired, Injectable } from '@opensumi/di';
import { KeybindingRegistry, useInjectable } from '@opensumi/ide-core-browser';
import { Popover, PopoverPosition } from '@opensumi/ide-core-browser/lib/components';
import { LayoutViewSizeConfig } from '@opensumi/ide-core-browser/lib/layout/constants';
import { formatLocalize, isMacintosh, uuid } from '@opensumi/ide-core-common';
Expand All @@ -19,12 +20,16 @@ const EditorTabCloseComponent = (props) => {
setDisplay(false);
}, []);

const title = useMemo(() => formatLocalize('editor.closeTab.title', isMacintosh ? '⌘W' : 'Ctrl+W'), []);
const keybindingRegistry = useInjectable(KeybindingRegistry);
const keyBinds = keybindingRegistry.getKeybindingsForCommand('editor.close');
const keyBinding = keyBinds && keyBinds[0];
const shortCut = keyBinding ? keybindingRegistry.acceleratorFor(keyBinding, ' ') : isMacintosh ? '⌘W' : 'Ctrl+W';
const title = useMemo(() => formatLocalize('editor.closeTab.title', shortCut), []);

return (
<Popover
delay={1000}
position={PopoverPosition.bottom}
position={PopoverPosition.top}
id={uid}
title={title}
onClickAction={handleClick}
Expand Down